Commits · 59c1ac4103f77f93e0c2b4e94589a453dcdba2b0 · abdullh.alsoleman / Front-End

05 May, 2023 7 commits

Roll Flutter Engine from a885ed472eea to e7cd29153aa9 (1 revision) (#126135) · 59c1ac41

engine-flutter-autoroll authored May 05, 2023

https://github.com/flutter/engine/compare/a885ed472eea...e7cd29153aa9

2023-05-05 dkwingsmt@users.noreply.github.com [macOS] Change view ID's type to signed and a typedef (flutter/engine#41653)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

59c1ac41

Roll Flutter Engine from c97a0deccbc1 to a885ed472eea (1 revision) (#126129) · 9b36fda9

engine-flutter-autoroll authored May 05, 2023

https://github.com/flutter/engine/compare/c97a0deccbc1...a885ed472eea

2023-05-05 skia-flutter-autoroll@skia.org Roll Skia from 6577130e14b6 to bf4217c3f0da (1 revision) (flutter/engine#41762)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9b36fda9

[NavigationDrawer] adds padding property in NavigationDrawer Widget (#123961) · 91a84ded

Tirth authored May 05, 2023

Adds `tilePadding` property to `NavigationDrawer` Widget.

Fixes: #121662

| Without adding `tilePadding` in NavigationDrawer | With `tilePadding: EdgeInsets.all(16)` in NavigationDrawer |
| --- | --- |
| ![photo_2023-04-02_15-03-56](https://user-images.githubusercontent.com/13456345/229344718-9070c0c0-9c71-4436-9953-d258367951e9.jpg) | ![photo_2023-04-02_15-04-00](https://user-images.githubusercontent.com/13456345/229344717-0768f9d5-6a55-4c2f-918e-53f2423bb959.jpg) |

91a84ded

Roll Flutter Engine from 269ce2deebeb to c97a0deccbc1 (1 revision) (#126124) · 04e284a4

engine-flutter-autoroll authored May 05, 2023

https://github.com/flutter/engine/compare/269ce2deebeb...c97a0deccbc1

2023-05-05 30322203+ksballetba@users.noreply.github.com Close connection on keyboard close (flutter/engine#41500)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

04e284a4

Roll Flutter Engine from 4d5070672859 to 269ce2deebeb (16 revisions) (#126115) · e9d486cd

engine-flutter-autoroll authored May 05, 2023

https://github.com/flutter/engine/compare/4d5070672859...269ce2deebeb

2023-05-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SD8Q_B7eWZqLgqo0f... to de2Eqw0IsOzTq15m3... (flutter/engine#41755)
2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 00693e987828 to 6577130e14b6 (1 revision) (flutter/engine#41752)
2023-05-04 jacksongardner@google.com Revert "Skwasm Font Loading" (flutter/engine#41750)
2023-05-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 95e133dbd3a6 to afeed9f8701e (1 revision) (flutter/engine#41749)
2023-05-04 magder@google.com Fix flaky FlutterChannelsTests, stop mocking `NSObject` (flutter/engine#41747)
2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from a4828415b4af to 00693e987828 (6 revisions) (flutter/engine#41746)
2023-05-04 godofredoc@google.com Migrate linux unopt to engine_v2. (flutter/engine#41658)
2023-05-04 jonahwilliams@google.com [Impeller] check if path is Rect/RRect/Oval (flutter/engine#41744)
2023-05-04 lhkbob@gmail.com Add temporary staging GN arg for Skia roll (flutter/engine#41743)
2023-05-04 jason-simmons@users.noreply.github.com Roll buildroot to 05ec9f7124191c7ba354521f3ffd34b09af872e7 (flutter/engine#41736)
2023-05-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 7b56aac98a5a to 95e133dbd3a6 (1 revision) (flutter/engine#41741)
2023-05-04 dnfield@google.com Disable flaky tests on arm64 (flutter/engine#41740)
2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 6950f56ad2ec to a4828415b4af (2 revisions) (flutter/engine#41737)
2023-05-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LIacrdFhuTuHnYh0B... to m0-fwGyFnoDVAvxgk... (flutter/engine#41738)
2023-05-04 jacksongardner@google.com Skwasm Font Loading (flutter/engine#41246)
2023-05-04 godofredoc@google.com Migrate linux_host_engine to engine v2. (flutter/engine#41715)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from LIacrdFhuTuH to m0-fwGyFnoDV
fuchsia/sdk/core/mac-amd64 from SD8Q_B7eWZqL to de2Eqw0IsOzT

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e9d486cd

Minor fixes found while working on blankcanvas (#125751) · a11da307

Ian Hickson authored May 05, 2023

This PR contains a series of minor changes to address issues that I happened to run into:

 - Pretty-print errors triggered when handling events that are pending because of having locked event handling. Previously these were just dumped to the console.
 - Add more documentation for `debugPaintPadding`.
 - Add documentation to `Tween` saying how to implement it.
 - Slight formatting changes in the scrollbar code to align some expressions.
 - Since we convert ScrollMetricsNotifications to ScrollNotifications in various places, provide an explicit API to do this. This will make the behaviour consistent throughout, and makes the code easier to understand. Added a test for this.
 - Clarifications to some of the BindingBase and SchedulerBinding documentation.
 - Clarified some documentation in `flutter_test`'s `Finder` class.

a11da307

tool-web: use ProcessUtil.run to invoke child processes (#126109) · f22dd30c
Kevin Moore authored May 05, 2023
```
All invocations are logged on verbose
Better, more detailed exceptions are thrown on errors
A lot less boilerplate
```
f22dd30c

04 May, 2023 19 commits

Cleans up appbar imply leading logic (#125315) · 0b657236
chunhtai authored May 04, 2023
```
fixes https://github.com/flutter/flutter/issues/80256
```
0b657236
Adding vmservice to get iOS app settings (#123156) · b00f1c45
chunhtai authored May 04, 2023
```
fixes https://github.com/flutter/flutter/issues/120405
```
b00f1c45
tool-web-wasm: make wasm-opt an "option" instead of a "flag" (#126035) · 529b919f
Kevin Moore authored May 04, 2023
```
Allows controlling a broader set of variables than just on/off.

Also make wasm-opt "full" the default
```
529b919f
Define testWidgetsWithLeakTracking. (#125063) · 5a80f8d6
Polina Cherkasova authored May 04, 2023

5a80f8d6

Roll Packages from 407b7da0079e to 6bd59cdb8fb5 (5 revisions) (#126078) · fde717da

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/packages/compare/407b7da0079e...6bd59cdb8fb5

2023-05-04 41930132+hellohuanlin@users.noreply.github.com [pigeon][reland]enable treat warnings as errors for swift code in unit test (flutter/packages#3901)
2023-05-04 stuartmorgan@google.com [video_player] Fix Android lints (flutter/packages#3886)
2023-05-04 stuartmorgan@google.com [quick_actions] Fix Android lint issues (flutter/packages#3885)
2023-05-03 andrewjohncoutts@gmail.com [camera_platform_interface] [camera] [camera_android] Add NV21 as an image stream format (flutter/packages#3277)
2023-05-03 stuartmorgan@google.com Revert "[pigeon]enable treat warning as errors for swift code in unit test" (flutter/packages#3898)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fde717da

Provide default constraints for M3 dialogs (#120082) · 8ec5001a

Pierre-Louis authored May 04, 2023

This PR constrains M3 dialogs to 560dp max width and height.

This is not a breaking change per the breaking change policy.

Part of https://github.com/flutter/flutter/issues/118619

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

8ec5001a

Roll Flutter Engine from 31de1c79ad56 to 4d5070672859 (2 revisions) (#126067) · c2022aa5

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/31de1c79ad56...4d5070672859

2023-05-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 47da769ae13a to 7b56aac98a5a (1 revision) (flutter/engine#41731)
2023-05-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from LCajvqTauUudC-7RW... to SD8Q_B7eWZqLgqo0f... (flutter/engine#41730)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from LCajvqTauUud to SD8Q_B7eWZqL

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c2022aa5

Fix typo in README.md (#126053) · ce32282c
Yu authored May 04, 2023

ce32282c

Fix nullability of ClipRRect.borderRadius (#125878) · 4bf297ce

Michael Goderbauer authored May 04, 2023

The property was typed as nullable, but the code assumed its always non-null. This makes the property non-nullable as well.

Also refactors CupertinoListSection, which was flagged by the analyzer when borderRadius became non-nullable (no functional change, just cleaning up existing code to avoid the warning).

4bf297ce

Roll Flutter Engine from ee646f9dd4c0 to 31de1c79ad56 (1 revision) (#126060) · f53335bf

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/ee646f9dd4c0...31de1c79ad56

2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 02e4b3087869 to 6950f56ad2ec (1 revision) (flutter/engine#41729)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f53335bf

Roll Flutter Engine from a344b0df36f1 to ee646f9dd4c0 (3 revisions) (#126057) · accc9432

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/a344b0df36f1...ee646f9dd4c0

2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 5c0f4c9bdc35 to 02e4b3087869 (1 revision) (flutter/engine#41728)
2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 9b19c0a0acf0 to 5c0f4c9bdc35 (1 revision) (flutter/engine#41727)
2023-05-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 59787216f670 to 47da769ae13a (2 revisions) (flutter/engine#41726)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

accc9432

Roll Flutter Engine from b764b9cd2c45 to a344b0df36f1 (1 revision) (#126048) · dbd1d534

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/b764b9cd2c45...a344b0df36f1

2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 93c869da03f5 to 9b19c0a0acf0 (14 revisions) (flutter/engine#41725)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dbd1d534

Switch imports from test_api to focused libaries (#125854) · 2089eacc

Nate Bosch authored May 04, 2023

Move imports of API available in `hooks.dart` or `scaffolding.dart` to use those more narrow libraries.

Move imports of APIs from `package:matcher` to import directly. The next major version of `test_api` will remove the exports of `matcher` APIs.

2089eacc

Roll Flutter Engine from 4152b851e78e to b764b9cd2c45 (1 revision) (#126045) · f309eadf

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/4152b851e78e...b764b9cd2c45

2023-05-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from n1UnzmslAzt04yRv6... to LIacrdFhuTuHnYh0B... (flutter/engine#41724)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from n1UnzmslAzt0 to LIacrdFhuTuH

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f309eadf

Roll Flutter Engine from da45a21708f2 to 4152b851e78e (1 revision) (#126042) · d51c59c7

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/da45a21708f2...4152b851e78e

2023-05-04 jacksongardner@google.com Populate fallback fonts from CIPD in tests (flutter/engine#41656)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d51c59c7

Roll Flutter Engine from ee65be7d8fb1 to da45a21708f2 (3 revisions) (#126037) · ebf3ea17

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/ee65be7d8fb1...da45a21708f2

2023-05-04 dnfield@google.com Make run_tests.py assert that the ios test dylib is at least as new as libFlutter.dylib (flutter/engine#41720)
2023-05-04 bdero@google.com [Impeller] Remove the DrawPaint->Clear optimization (flutter/engine#41711)
2023-05-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 3cfcfb24bc6a to 59787216f670 (2 revisions) (flutter/engine#41718)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ebf3ea17

Roll Flutter Engine from 85516ecc0e4c to ee65be7d8fb1 (2 revisions) (#126032) · 15386d9d

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/85516ecc0e4c...ee65be7d8fb1

2023-05-03 godofredoc@google.com Add relative path support for malioc_diff. (flutter/engine#41703)
2023-05-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from WAfNudyWPOGyWSpZD... to LCajvqTauUudC-7RW... (flutter/engine#41716)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from WAfNudyWPOGy to LCajvqTauUud

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

15386d9d

[tool] consistently use environment (not globals) in targets/web.dart (#125937) · 5816da80
Kevin Moore authored May 04, 2023
```
Also update the order of args to commands so that testing has less repeated "stuff"
```
5816da80

Roll Flutter Engine from a0906bdfc845 to 85516ecc0e4c (1 revision) (#126027) · 8449623e

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/a0906bdfc845...85516ecc0e4c

2023-05-03 dkwingsmt@users.noreply.github.com [macOS] Remove view ID from public (flutter/engine#41712)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8449623e

03 May, 2023 14 commits

Remove `complex_layout_*__compile` benchmarks (#126023) · 4f3c989b
Jenn Magder authored May 03, 2023
```
Fixes https://github.com/flutter/flutter/issues/126020.
```
4f3c989b

Roll Flutter Engine from 7d70dc81cfa5 to a0906bdfc845 (8 revisions) (#126018) · d6ef15ed

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/7d70dc81cfa5...a0906bdfc845

2023-05-03 bdero@google.com [Impeller] Load instead of restore drawing for non-MSAA passes (flutter/engine#41676)
2023-05-03 jonahwilliams@google.com Remove physical model layer (flutter/engine#41593)
2023-05-03 gspencergoog@users.noreply.github.com Reland: "Determine lifecycle by looking at window focus also" (#41094) (flutter/engine#41702)
2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from 887e58fff02f to 93c869da03f5 (12 revisions) (flutter/engine#41705)
2023-05-03 mdebbar@google.com [web] Improve null safety for color->css (flutter/engine#41699)
2023-05-03 mdebbar@google.com [web] Remove unused function parameter (flutter/engine#41700)
2023-05-03 godofredoc@google.com Migrate Android Engine Debug to Engine V2. (flutter/engine#41687)
2023-05-03 kjlubick@users.noreply.github.com Migrate SkSurface::getBackend* methods to static functions (flutter/engine#41693)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d6ef15ed

[tool] Improve help info with build web --wasm flags (#125907) · 2c56a25d
Kevin Moore authored May 03, 2023
```
Also fixed some comments
```
2c56a25d
tool: use switch expressions (#125930) · 0f9d66aa
Kevin Moore authored May 03, 2023

0f9d66aa

[Reland] Add migrator to upgrade gradle version when conflict with Android... · c12488a7

gmackall authored May 03, 2023

[Reland] Add migrator to upgrade gradle version when conflict with Android Studio bundled Java version is detected (#125836)

This is an attempt to reland https://github.com/flutter/flutter/pull/124085.

Differences from this attempt and the last: 
1. Adds a check for null android studio versions and a test for this case.
2. Wraps the migrate code in a try-catch [per the suggestion here](https://github.com/flutter/flutter/pull/125728/files#r1181747899).

Old PR description:
This PR adds an android project migrator that checks the version of android studio and the version of gradle for conflicts, and upgrades to 7.4 if a conflict is detected. For more detail about the particular conflict, see https://github.com/flutter/flutter/issues/122376.

The PR also upgrades older gradle versions being used in integration testing to 7.4.

Fixes/related to: https://github.com/flutter/flutter/issues/122376 and https://github.com/flutter/flutter/issues/123636

c12488a7

tool: DRY up DepfileService (#125922) · 4bd9bcd7
Kevin Moore authored May 03, 2023

4bd9bcd7

Add `InlineSpan.visitDirectChildren` (#125656) · f704c689

LongCatIsLooong authored May 03, 2023

I'd like to find out the `fontSize` of a `PlaceholderSpan`, and currently there doesn't seem to be a way to do `TextStyle` cascading in the framework:

 `InlineSpan.visitChildren` traverses the entire `InlineSpan` tree using a preorder traversal, and nodes that don't have "content" will be skipped (https://master-api.flutter.dev/flutter/painting/InlineSpan/visitChildren.html): 

> Walks this [InlineSpan](https://master-api.flutter.dev/flutter/painting/InlineSpan-class.html) and any descendants in pre-order and calls visitor for each span that has content.

which makes it impossible to do `TextStyle` cascading in the framework: 
- `InlineSpan`s with a non-null `TextStyle` but has no content will be skipped
- `visitChildren` doesn't directly expose the hierarchy, it only gives information about the flattened tree.

This doesn't look like a breaking change, most internal customers are extending `WidgetSpan` which has a concrete implementation of the new method.

Alternatively I could create a fake `ui.ParagraphBuilder` and record the `ui.TextStyle` at the top of the stack when `addPlaceholder` is called. But `ui.TextStyle` properties are not exposed to the framework.

f704c689

add slsa l1 badge (#125932) · 7815699d
godofredoc authored May 03, 2023
```
Adds SLSA L1 badge
```
7815699d

Roll Flutter Engine from b71728bee873 to 7d70dc81cfa5 (3 revisions) (#125989) · affb3436

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/b71728bee873...7d70dc81cfa5

2023-05-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 342dff83c38e to 3cfcfb24bc6a (1 revision) (flutter/engine#41698)
2023-05-03 joshualitt@google.com [web] Add `dart:js_interop_unsafe` to SDK. (flutter/engine#41591)
2023-05-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 9T4mGpfsJZO0KPtfp... to n1UnzmslAzt04yRv6... (flutter/engine#41697)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 9T4mGpfsJZO0 to n1UnzmslAzt0

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

affb3436

Roll Packages from f163786731b8 to 407b7da0079e (13 revisions) (#125988) · fd7efc6f

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/packages/compare/f163786731b8...407b7da0079e

2023-05-03 vashworth@google.com Update Cirrus to Xcode 14.3 (flutter/packages#3890)
2023-05-03 stuartmorgan@google.com [file_selector] Deprecates `macUTIs` (flutter/packages#3888)
2023-05-03 41930132+hellohuanlin@users.noreply.github.com [pigeon]enable treat warning as errors for swift code in unit test (flutter/packages#3889)
2023-05-02 vashworth@google.com Update xcode to 14e222b (flutter/packages#3868)
2023-05-02 41930132+hellohuanlin@users.noreply.github.com [pigeon]fix "as Any" workaround due to nested optional (flutter/packages#3658)
2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Adds support to accept third party cookies (flutter/packages#3834)
2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes an exception caused by the `onUrlChange` callback returning a null url (flutter/packages#3848)
2023-05-02 pateltirth454@gmail.com [google_maps_flutter] [Docs] Note regarding usage within a bounded & an unbound widget (flutter/packages#3691)
2023-05-02 evace93@gmail.com [local_auth_android] Fix Android lint warnings (flutter/packages#3764)
2023-05-02 koji.wakamiya@gmail.com [go_router_builder] Support go_router v7 (flutter/packages#3858)
2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes internal enum type and adds unknown enum values (flutter/packages#3812)
2023-05-02 stuartmorgan@google.com [file_selector] Add MIME type support on macOS (flutter/packages#3862)
2023-05-02 engine-flutter-autoroll@skia.org Roll Flutter from 828a0404 to db6074ad (12 revisions) (flutter/packages#3881)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fd7efc6f

Marks Linux_android slider_perf_android to be unflaky (#125968) · 15bd29c8

Flutter GitHub Bot authored May 03, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android slider_perf_android"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20slider_perf_android%22).
This test can be marked as unflaky.

15bd29c8

Adding printOnFailure for result of process (#125910) · 9160c6e7

Elias Yishak authored May 03, 2023

Adding a `printOnFailure` call into the flakey test to help debug the cause for future failures.

- Reference issue: https://github.com/flutter/flutter/issues/125512

9160c6e7

Roll Flutter Engine from bc8f14001d7a to b71728bee873 (1 revision) (#125972) · c4d6c8c6

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/bc8f14001d7a...b71728bee873

2023-05-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 4d084f5b8f91 to 342dff83c38e (2 revisions) (flutter/engine#41692)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c4d6c8c6

Roll Flutter Engine from 99e5184c7aa8 to bc8f14001d7a (2 revisions) (#125969) · c4ad07dc

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/99e5184c7aa8...bc8f14001d7a

2023-05-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ubfKertFqqUj0WD8I... to WAfNudyWPOGyWSpZD... (flutter/engine#41691)
2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from b58340991480 to 887e58fff02f (2 revisions) (flutter/engine#41690)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from ubfKertFqqUj to WAfNudyWPOGy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c4ad07dc