- 20 Mar, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 06 Feb, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 09 Jan, 2018 1 commit
-
-
Michael Goderbauer authored
`RenderSemanticsGestureHandler` is no longer a semantics boundary, which allows us to correctly mark disabled buttons as disabled without having their semantics size and semantics node id change unexpectedly. Fixes https://github.com/flutter/flutter/issues/12589. Fixes https://github.com/flutter/flutter/issues/11991. See also https://github.com/flutter/flutter/issues/11993. This change also required some refactoring to how we deal with `twoPaneSemantics` scrolling as it previously relied on `RenderSemanticsGestureHandler` being a semantics boundary. This should also make the underlying logic easier to understand. In addition, the following minor changes are included in this PR: * Removal of orphaned and unused `SemanticsConfiguration.isMergingDescendantsIntoOneNode`. * Logic optimizations for `markNeedsSemanticsUpdate` . * Fix for edge case where `MergeSemantics` failed to merge semantics. * Use of emojis to better indicate leaf merging in the printed semantics tree. * Better assert message for adding invisible child semantics nodes. * Make some semantics tests robuster by not relying on creation order of SemanticsNode ids across test boundaries. Fixes https://github.com/flutter/flutter/issues/13943.
-
- 03 Nov, 2017 1 commit
-
-
amirh authored
-
- 18 Oct, 2017 1 commit
-
-
Michael Goderbauer authored
* Oct 12 10:12am * implicit_semantics_test.dart passes * refactoring * works in nice * minor rename * more doc comments * to be explicit check better * fix test * ++ * ++ * semantics_9_test (BlockSemantics) and implicit_semantics_test are passing * doc updates * tiny refactor * fix static errors in tests * fix gesture detector * ++ * ++ * geometry * ++ * remove noGeometry * revert test * + * all tests but scrolling/clipping pass * clipping works * scrolling halfway * sliver tests pass * ALL TESTS PASS * SemanticsNode changed * docs and tiny fixes * card test * more doc comments * remove missed print * more tests * make test pass on Linux * remove changes to intellij proj file * review comments
-
- 27 Sep, 2017 1 commit
-
-
Ian Hickson authored
-
- 21 Sep, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 15 Sep, 2017 1 commit
-
-
Ian Hickson authored
-
- 13 Sep, 2017 2 commits
-
-
Ian Hickson authored
This reverts commit da0602fe.
-
Ian Hickson authored
-
- 05 Sep, 2017 1 commit
-
-
Michael Goderbauer authored
* getOffsetToReveal deals with pinned slivers If a Sliver can potentially be pinned at the edge of a viewport, getOffsetToReveal will take that into account and scroll further up/down to ensure that the object to reveal doesn't end up covered by a pinned sliver. This is important for accessibility scrolling with app bars. Since how much a pinned sliver is covering is dynamic (it can change with scroll offset, etc), getOffsetToReveal deals with the worst case and tries to ensure that the object to uncover is visible when the pinned slivers are at their max pinned extent. * name fixes * review feedback * typos * renaming * fix analyzer * fix test * analyzer fixes
-
- 26 Aug, 2017 1 commit
-
-
Michael Goderbauer authored
* refactor to ensureAction + some related doc fixes * Update docs for markNeedsSemanticsUpdate * rewording * rewording * ensureAction test * ensureAction test * ensureAction test * more tests * refactor to allways reset node * tiny fixes * more test * doc fixes * one more test * review comments
-
- 23 Aug, 2017 1 commit
-
-
Michael Goderbauer authored
* refactor to assembleSemanticNode * ++ * cleanup * fix test * add note * review comments * review feedback * import fix * another import fix * refactor to ensure tag * tests, tests, tests * analyzer fixes * review comments
-
- 03 Aug, 2017 1 commit
-
-
Jacob Richman authored
Add Diagnosticable base class and documentation
-
- 25 Jul, 2017 1 commit
-
-
Jacob Richman authored
Refactor RenderObject.toStringDeep and Widget.toStringDeep code to use DiagnosticsNode.
-
- 21 Jul, 2017 1 commit
-
-
Ian Hickson authored
Mainly, this adds documentation to members that were previously lacking documentation. It also adds a big block of documentation about improving performance of widgets. This also removes some references to package:collection and adds global setEquals and listEquals methods in foundation that we can use. (setEquals in particular should be much faster than the package:collection equivalent, though both should be faster as they avoid allocating new objects.) All remaining references now qualify the import so we know what our remaining dependencies are. Also lots of code reordering in Flutter driver to make the code consistent and apply the style guide more thoroughly.
-
- 27 Jun, 2017 1 commit
-
-
Ian Hickson authored
-
- 06 Jun, 2017 1 commit
-
-
Ian Hickson authored
-
- 05 Jun, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Apr, 2017 1 commit
-
-
Hans Muller authored
-
- 29 Mar, 2017 1 commit
-
-
xster authored
-
- 02 Mar, 2017 1 commit
-
-
Chris Bracken authored
Prevent the app bar header from being overscrolled on iOS by setting paintOrigin to the overlap.
-
- 24 Feb, 2017 1 commit
-
-
Adam Barth authored
With slivers, the app bar is part of the scroll view. Naively, the overscroll appears at the beginning of the scroll view, but that's not the desired behavior. Instead, the app bar should remained pinned to the top of the scroll view and the overscroll should appear below the app bar, which is what this patch does. Fixes #8228
-
- 23 Feb, 2017 2 commits
-
-
Alexandre Ardhuin authored
-
Hans Muller authored
-
- 21 Feb, 2017 1 commit
-
-
Alexandre Ardhuin authored
Fixes #7734
-
- 17 Feb, 2017 1 commit
-
-
Ian Hickson authored
* More better toStrings and more vigorous smoke testing of gallery * Update scroll_controller.dart * Update sliver.dart
-
- 09 Feb, 2017 1 commit
-
-
Ian Hickson authored
Move the back button and drawer opening logic into the app bar. Move the tap-status-bar-to-scroll-to-top logic to using ScrollControllers. Provide a PrimaryScrollController and a `primary` flag on scroll views. Make it possible to track when a route becomes or stops being poppable.
-
- 06 Feb, 2017 1 commit
-
-
Ian Hickson authored
-
- 03 Feb, 2017 1 commit
-
-
Adam Barth authored
There aren't any interdependencies with the rest of sliver.dart, and that file is already quite complex.
-
- 01 Feb, 2017 2 commits
-
-
Adam Barth authored
-
Ian Hickson authored
-
- 31 Jan, 2017 1 commit
-
-
Adam Barth authored
This patch adds grid supports to slivers and introduces a ScrollGrid convenience class for making the common types of scrollable grids. This patch also deploys ScrollGrid in an example in the Flutter Gallery.
-
- 25 Jan, 2017 2 commits
-
-
Adam Barth authored
When you put a box in a Viewport2, it might paint outside its allocated bounds. This patch teaches Viewport2 to clip when that happens.
-
Ian Hickson authored
-