Commits · 596d9b6c1a4eb955552837e74a1550fefc6918cb · abdullh.alsoleman / Front-End

16 Dec, 2023 10 commits

Center Floating Snackbar with custom width when direction is RTL (#140215) · 596d9b6c

Bruno Leroux authored Dec 16, 2023

## Description

This PR fixes the positionning of a floating snackbar when the text direction is RTL.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/140125.

## Tests

Adds 1 test.

596d9b6c

Roll Flutter Engine from 6752398c2f54 to a8d8fbbcef22 (1 revision) (#140274) · c1e207d6

engine-flutter-autoroll authored Dec 16, 2023

https://github.com/flutter/engine/compare/6752398c2f54...a8d8fbbcef22

2023-12-16 skia-flutter-autoroll@skia.org Roll Skia from d231faf34f8a to 35d0d7eb991c (1 revision) (flutter/engine#49137)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c1e207d6

Use `SemanticsUpdateBuilder` again, remove all references to temporary... · 8c02a224

Bartek Pacia authored Dec 16, 2023

Use `SemanticsUpdateBuilder` again, remove all references to temporary `SemanticsUpdateBuilderNew` (#139942)

This PR removes all usages of the temporary `SemanticsUpdateBuilderNew` API in favor of `SemanticsUpdateBuilder`. These two APIs are the same as of now.

This is mainly targeted at https://github.com/flutter/flutter/issues/17988

Steps:
part 1: [engine] add `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/47961
part 2: [flutter] use `SemanticsUpdateBuilderNew` https://github.com/flutter/flutter/pull/138331
part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/48882
**part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again** <-- we are here
part 5: [engine] remove `SemanticsBuilderNew`

8c02a224

Roll Flutter Engine from 7d300e5b9587 to 6752398c2f54 (1 revision) (#140270) · 3958b3d5

engine-flutter-autoroll authored Dec 16, 2023

https://github.com/flutter/engine/compare/7d300e5b9587...6752398c2f54

2023-12-16 skia-flutter-autoroll@skia.org Roll Skia from 01aa69c38af5 to d231faf34f8a (1 revision) (flutter/engine#49134)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3958b3d5

Roll Flutter Engine from 832238a3b493 to 7d300e5b9587 (1 revision) (#140268) · 0c6850dd

engine-flutter-autoroll authored Dec 16, 2023

https://github.com/flutter/engine/compare/832238a3b493...7d300e5b9587

2023-12-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 620976ef6b80 to c8106261c9cd (1 revision) (flutter/engine#49131)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0c6850dd

Roll Flutter Engine from 34d427aa009c to 832238a3b493 (1 revision) (#140265) · 8b4ece26

engine-flutter-autoroll authored Dec 16, 2023

https://github.com/flutter/engine/compare/34d427aa009c...832238a3b493

2023-12-16 skia-flutter-autoroll@skia.org Roll Skia from 191943f9c43e to 01aa69c38af5 (4 revisions) (flutter/engine#49128)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8b4ece26

Roll Flutter Engine from 74e4965a2845 to 34d427aa009c (1 revision) (#140263) · 42eebee8

engine-flutter-autoroll authored Dec 16, 2023

https://github.com/flutter/engine/compare/74e4965a2845...34d427aa009c

2023-12-16 skia-flutter-autoroll@skia.org Roll Dart SDK from d66f9c854db7 to 620976ef6b80 (2 revisions) (flutter/engine#49125)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

42eebee8

Roll Flutter Engine from ca329dd84207 to 74e4965a2845 (4 revisions) (#140262) · 445bd51b

engine-flutter-autoroll authored Dec 16, 2023

https://github.com/flutter/engine/compare/ca329dd84207...74e4965a2845

2023-12-16 dnfield@google.com Statically link swiftshader into flutter_tester (flutter/engine#48708)
2023-12-16 jason-simmons@users.noreply.github.com [Impeller] Do not pass the depfile flag when creating a shader bundle in ImpellerC (flutter/engine#49114)
2023-12-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run tests on macOS 13 exclusively" (flutter/engine#49115)
2023-12-15 dnfield@google.com Roll SwiftShader to 2fa7e9b99ae4e70ea5ae2cc9c8d3afb43391384f (flutter/engine#49112)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

445bd51b

[github actions] minor PR to test latest github actions (#140252) · c1762215

Xilai Zhang authored Dec 16, 2023

Minor fix of a typo.

A merged PR on flutter/flutter with a newer base commit is needed to test the latest version of https://github.com/flutter/flutter/blob/master/.github/workflows/easy-cp.yml. (more details in https://github.com/flutter/flutter/pull/140191#issuecomment-1857169933).

This PR has a base commit that includes the latest updates to easy-cp.yml, and would be a good candidate for testing purposes when merged

c1762215

Roll Flutter Engine from 6e3a04874be5 to ca329dd84207 (3 revisions) (#140255) · 388ba451

engine-flutter-autoroll authored Dec 16, 2023

https://github.com/flutter/engine/compare/6e3a04874be5...ca329dd84207

2023-12-15 bdero@google.com [Impeller] Turn off Aiks bounds tracking for filtered SaveLayers. (flutter/engine#49076)
2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from cf84bab13da3 to 191943f9c43e (1 revision) (flutter/engine#49105)
2023-12-15 skia-flutter-autoroll@skia.org Roll Dart SDK from e6528d1b7997 to d66f9c854db7 (1 revision) (flutter/engine#49104)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

388ba451

15 Dec, 2023 27 commits

Remove usage of testWidgetsWithLeakTracking. (#140239) · baf739c8
Polina Cherkasova authored Dec 15, 2023

baf739c8

Roll Flutter Engine from a8d861b53db1 to 6e3a04874be5 (1 revision) (#140244) · 70145886

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/a8d861b53db1...6e3a04874be5

2023-12-15 15619084+vashworth@users.noreply.github.com Run tests on macOS 13 exclusively (flutter/engine#49099)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

70145886

Roll Flutter Engine from c48b08ac4682 to a8d861b53db1 (1 revision) (#140240) · d57e7ac0

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/c48b08ac4682...a8d861b53db1

2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from 4f0f3f3992e0 to cf84bab13da3 (1 revision) (flutter/engine#49097)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d57e7ac0

Use new `enabledFeature` param for `Analytics` (#139934) · d180c127

Elias Yishak authored Dec 15, 2023

Related to tracker issue:
- https://github.com/flutter/flutter/issues/128251

This updates the `Analytics` constructor to provide it with the enabled features for the flutter-tool. This will be sent with each event for the flutter-tool.

d180c127

Roll Flutter Engine from db98451b063c to c48b08ac4682 (2 revisions) (#140236) · c35c42ac

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/db98451b063c...c48b08ac4682

2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from c10028c9756f to 4f0f3f3992e0 (2 revisions) (flutter/engine#49094)
2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from 7a97b766b14b to c10028c9756f (1 revision) (flutter/engine#49091)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c35c42ac

Reorganize dependencies on leak_tracker. (#140233) · bda158ad

Polina Cherkasova authored Dec 15, 2023

1. Move leak_tracker and leak_tracker_testing out of direct dependencies.
2. Move leak_tracker_flutter_testing from dev to prod dependencies for flutter_test

It is prerequisite for https://github.com/flutter/flutter/issues/135856

bda158ad

[macOS,iOS] CocoaPods recommended version: 1.13.0 (#135447) · d0670f05

Chris Bracken authored Dec 15, 2023

Due to changes in Xcode 15, several variables such as `DT_TOOLCHAIN_DIR`
have been eliminateed in favour of others such as `TOOLCHAIN_DIR`. This
broke CocoaPods support under Xcode 15, as reported in:
https://github.com/CocoaPods/CocoaPods/issues/12012

@vashworth worked around this in Flutter in:
https://github.com/flutter/flutter/pull/132803

The CocoaPods issue was resolved by the following PR to their repo:
https://github.com/CocoaPods/CocoaPods/pull/12009
and was released in CocoaPods 1.13.0.

Also switches from an if-else chain to a switch for CocoaPodsStatus
handling.

Related: https://github.com/flutter/flutter/issues/133584
Related: https://github.com/flutter/flutter/issues/132755

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/ChatCo-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>

d0670f05

Roll Flutter Engine from b36374085c4b to db98451b063c (1 revision) (#140230) · 253a90f7

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/b36374085c4b...db98451b063c

2023-12-15 jason-simmons@users.noreply.github.com Revert "[Impeller] Provide the clear color to an advanced blend if it was optimized out" (flutter/engine#49064)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

253a90f7

Roll Flutter Engine from e89b7ed8812b to b36374085c4b (1 revision) (#140228) · 85523f28

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/e89b7ed8812b...b36374085c4b

2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from 0e0e00e2969b to 7a97b766b14b (1 revision) (flutter/engine#49090)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

85523f28

Roll Flutter Engine from 986a6fe198dc to e89b7ed8812b (1 revision) (#140224) · b2111330

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/986a6fe198dc...e89b7ed8812b

2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from 1537198c5461 to 0e0e00e2969b (1 revision) (flutter/engine#49088)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b2111330

Move package:web dependency to dev dependency (#139696) · 2407f699

Srujan Gaddam authored Dec 15, 2023

Pinning the package:web dependency constrains downstream packages from
using newer versions and making sure they support the version pinned in
Flutter. Since the usage of package:web in Flutter is light, we should
instead have a small shim like the engine and keep package:web as a dev
dependency only.

2407f699

Roll Flutter Engine from 9524a185b055 to 986a6fe198dc (1 revision) (#140221) · 8b8d3959

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/9524a185b055...986a6fe198dc

2023-12-15 103135467+sealesj@users.noreply.github.com Use flutter mirrors for non-google origin deps instead of fuchsia (flutter/engine#48735)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8b8d3959

Roll Packages from 1151191c8c13 to 3f2e16bf2b17 (9 revisions) (#140218) · f9ee379b

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/packages/compare/1151191c8c13...3f2e16bf2b17

2023-12-15 magder@google.com Swap some iOS package CODEOWNERS (flutter/packages#5667)
2023-12-14 ychris@google.com [in_app_purchase_storekit]add storekit configuration to the example app (flutter/packages#5411)
2023-12-14 50643541+Mairramer@users.noreply.github.com [camera_platform_interface] Adds support for setting the image file format (flutter/packages#5593)
2023-12-14 34871572+gmackall@users.noreply.github.com [path_provider_android] Re-enable getExternalStorageDirectories test (flutter/packages#5668)
2023-12-14 ndelanou@users.noreply.github.com [go_router] fix(docs): typo in example extra_codec.dart (flutter/packages#5570)
2023-12-14 stuartmorgan@google.com [ios_platform_images] Adopt code-excerpts (flutter/packages#5682)
2023-12-14 me@nils.re [camera] Fix typo "intialize" in doc comments (flutter/packages#4949)
2023-12-14 engine-flutter-autoroll@skia.org Roll Flutter from 11a9cb70 to a51e33ac (30 revisions) (flutter/packages#5680)
2023-12-14 katelovett@google.com [two_dimensional_scrollables] Post 3.16 stable tech debt clean up (flutter/packages#5671)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f9ee379b

Roll Flutter Engine from 7a50221733c2 to 9524a185b055 (1 revision) (#140217) · 8889a098

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/7a50221733c2...9524a185b055

2023-12-15 kjlubick@users.noreply.github.com Fix text missing in performance overlay (on Android) (flutter/engine#49035)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8889a098

Roll Flutter Engine from 767223f7a4f8 to 7a50221733c2 (1 revision) (#140216) · ba30653f

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/767223f7a4f8...7a50221733c2

2023-12-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 0530162179c6 to e6528d1b7997 (1 revision) (flutter/engine#49083)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ba30653f

Roll Flutter Engine from 91f65eea0c11 to 767223f7a4f8 (1 revision) (#140210) · cc782576

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/91f65eea0c11...767223f7a4f8

2023-12-15 skia-flutter-autoroll@skia.org Roll Dart SDK from bb1b67b78b8d to 0530162179c6 (1 revision) (flutter/engine#49080)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cc782576

Roll Flutter Engine from a47da28c9a62 to 91f65eea0c11 (1 revision) (#140207) · 2c992d9d

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/a47da28c9a62...91f65eea0c11

2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from 9dea4e05ccc2 to 1537198c5461 (1 revision) (flutter/engine#49077)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2c992d9d

Roll Flutter Engine from cde1a596432d to a47da28c9a62 (1 revision) (#140204) · 3b3cd77a

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/cde1a596432d...a47da28c9a62

2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from cd2f06086c96 to 9dea4e05ccc2 (1 revision) (flutter/engine#49072)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3b3cd77a

Roll Flutter Engine from 46ff5c08a905 to cde1a596432d (1 revision) (#140200) · a899e04b

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/46ff5c08a905...cde1a596432d

2023-12-15 skia-flutter-autoroll@skia.org Roll Dart SDK from f1e37ed8917e to bb1b67b78b8d (1 revision) (flutter/engine#49073)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a899e04b

Roll Flutter Engine from a17bb0a63b7e to 46ff5c08a905 (1 revision) (#140198) · ffe780c2

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/a17bb0a63b7e...46ff5c08a905

2023-12-15 matanlurey@users.noreply.github.com Move `third_party/json` to `flutter/third_party/json`. (flutter/engine#48844)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ffe780c2

Roll Flutter Engine from 4cb3ba7a85f6 to a17bb0a63b7e (1 revision) (#140196) · d69653c9

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/4cb3ba7a85f6...a17bb0a63b7e

2023-12-15 matanlurey@users.noreply.github.com Automatically fix header guards in the rest of the `flutter/engine` repo. (flutter/engine#49059)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d69653c9

Roll Flutter Engine from 0e7248d43251 to 4cb3ba7a85f6 (14 revisions) (#140195) · 09dc01fc

engine-flutter-autoroll authored Dec 15, 2023

https://github.com/flutter/engine/compare/0e7248d43251...4cb3ba7a85f6

2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from 79f23e8d8b5d to cd2f06086c96 (1 revision) (flutter/engine#49069)
2023-12-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 0471164827b9 to f1e37ed8917e (1 revision) (flutter/engine#49065)
2023-12-15 dnfield@google.com [Impeller] impellerc: delete unused code (flutter/engine#49061)
2023-12-15 30870216+gaaclarke@users.noreply.github.com [Impeller] split out gradient tests from aiks_unittests (flutter/engine#49050)
2023-12-15 30870216+gaaclarke@users.noreply.github.com Revert "[Impeller] Turned on new blur." (flutter/engine#49062)
2023-12-14 matanlurey@users.noreply.github.com Fix header-guard naming convention in `shell/`. (flutter/engine#49006)
2023-12-14 jason-simmons@users.noreply.github.com Manual roll of Dart SDK from a677378ae254 to 0471164827b9 (flutter/engine#49054)
2023-12-14 matanlurey@users.noreply.github.com Rename `font-subset` to `font_subset`. (flutter/engine#49051)
2023-12-14 skia-flutter-autoroll@skia.org Roll Skia from 92935b91193a to 79f23e8d8b5d (1 revision) (flutter/engine#49056)
2023-12-14 chingjun@google.com Suppress warning for the new Activity library. (flutter/engine#49046)
2023-12-14 jonahwilliams@google.com [Impeller] distinguish between no clear color and transparent black clear color. (flutter/engine#49038)
2023-12-14 15619084+vashworth@users.noreply.github.com Unpin mac_toolchain version (flutter/engine#48994)
2023-12-14 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned on new blur. (flutter/engine#48472)
2023-12-14 103135467+sealesj@users.noreply.github.com Remove unused metadata in DEPS from vuln scanning (flutter/engine#48995)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

09dc01fc

Increase versions of leak tracker libraries. (#140018) · 6a856848
Polina Cherkasova authored Dec 15, 2023
```
Contributes to https://github.com/flutter/flutter/issues/135856
```
6a856848

Set compile test iOS app target version to not embed Swift runtime (#140188) · 0cd2ea96

Jenn Magder authored Dec 15, 2023

ObjC->Swift plugin migration caused a size regression in the gallery app because the Swift runtime was also pulled in.  

The gallery app minimum target version is iOS 11.0, which predates Swift ABI compatibility.  Pre iOS 12.2 apps embedded the Swift runtime since there wasn't one available to use in the OS.  

Add  `FLUTTER_XCODE_IPHONEOS_DEPLOYMENT_TARGET` to the compile perf test environment, which gets translated by the tool to an Xcode build setting:
```
[2023-12-14 15:52:14.797318] [STDOUT] stdout:                IPHONEOS_DEPLOYMENT_TARGET = 12.2
```

On my machine on main
```
    "release_size_bytes": 43717389,
```
becomes
```
    "release_size_bytes": 40679432,
```

Fixes https://github.com/flutter/flutter/issues/139605

0cd2ea96

Cupertino text clear label (#129727) · f0051d8b

Mitchell Goodwin authored Dec 15, 2023

Fixes #123107

Adds a customizable semantic label so that the clear button on the Cupertino text field will be picked up by screen readers.

https://github.com/flutter/flutter/assets/58190796/de31d9dd-923c-402f-a55b-e5cc77ea68bb

f0051d8b

[github actions] use token from real user flutter mirror bot (#140191) · 8c1d723d

Xilai Zhang authored Dec 15, 2023

sir @godofredoc pointed out that we should use a real user to create PRs with, and we already have one account with such credentials -- the mirror bot.

8c1d723d

Reverts "Roll Flutter Engine from 0e7248d43251 to 0b0fab821536 (4 revisions)" (#140194) · 13b81068

auto-submit[bot] authored Dec 15, 2023

Reverts flutter/flutter#140180
Initiated by: zanderso
This change reverts the following previous change:
Original Description:

https://github.com/flutter/engine/compare/0e7248d43251...0b0fab821536

2023-12-14 jonahwilliams@google.com [Impeller] distinguish between no clear color and transparent black clear color. (flutter/engine#49038)
2023-12-14 15619084+vashworth@users.noreply.github.com Unpin mac_toolchain version (flutter/engine#48994)
2023-12-14 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned on new blur. (flutter/engine#48472)
2023-12-14 103135467+sealesj@users.noreply.github.com Remove unused metadata in DEPS from vuln scanning (flutter/engine#48995)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

13b81068

14 Dec, 2023 3 commits

Roll Flutter Engine from 0e7248d43251 to 0b0fab821536 (4 revisions) (#140180) · 0b6da5b4

engine-flutter-autoroll authored Dec 14, 2023

https://github.com/flutter/engine/compare/0e7248d43251...0b0fab821536

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0b6da5b4

feat: Add onTapAlwaysCalled in TextFormField (#140089) · 703ae778

lsaudon authored Dec 14, 2023

Add onTapAlwaysCalled in TextFormField

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

703ae778

Bump actions/upload-artifact from 3.1.3 to 4.0.0 (#140177) · ea1e2dfa

dependabot[bot] authored Dec 14, 2023

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.0.0</h2>
<h2>What's Changed</h2>
<p>The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.</p>
<p>For more information, see the <a href="https://github.com/actions/toolkit/tree/main/packages/artifact"><code>@âactions/artifact</code></a> documentation.</p>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/vmjoseph"><code>@âvmjoseph</code></a> made their first contribution in <a href="https://redirect.github.com/actions/upload-artifact/pull/464">actions/upload-artifact#464</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v3...v4.0.0">https://github.com/actions/upload-artifact/compare/v3...v4.0.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/upload-artifact/commit/c7d193f32edcb7bfad88892161225aeda64e9392"><code>c7d193f</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/466">#466</a> from actions/v4-beta</li>
<li><a href="https://github.com/actions/upload-artifact/commit/13131bb095770b4070a7477c3cd2d96e1c16d9f4"><code>13131bb</code></a> licensed cache</li>
<li><a href="https://github.com/actions/upload-artifact/commit/4a6c273b9834f66a1d05c170dc3f80f9cdb9def1"><code>4a6c273</code></a> Merge branch 'main' into v4-beta</li>
<li><a href="https://github.com/actions/upload-artifact/commit/f391bb91a3d3118aeca171c365bb319ece276b37"><code>f391bb9</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/465">#465</a> from actions/robherley/v4-documentation</li>
<li><a href="https://github.com/actions/upload-artifact/commit/9653d03c4b74c32144e02dae644fea70e079d4b3"><code>9653d03</code></a> Apply suggestions from code review</li>
<li><a href="https://github.com/actions/upload-artifact/commit/875b63076402f25ef9d52c294c86ba4f97810575"><code>875b630</code></a> add limitations section</li>
<li><a href="https://github.com/actions/upload-artifact/commit/ecb21463e93740a6be75c3116242169bfdbcb15a"><code>ecb2146</code></a> add compression example</li>
<li><a href="https://github.com/actions/upload-artifact/commit/5e7604f84a055838f64ed68bb9904751523081ae"><code>5e7604f</code></a> trim some repeated info</li>
<li><a href="https://github.com/actions/upload-artifact/commit/d6437d07581fe318a364512e6cf6b1dca6b4f92c"><code>d6437d0</code></a> naming</li>
<li><a href="https://github.com/actions/upload-artifact/commit/1b561557037b4957d7d184e9aac02bec86c771eb"><code>1b56155</code></a> s/v4-beta/v4/g</li>
<li>Additional commits viewable in <a href="https://github.com/actions/upload-artifact/compare/a8a3f3ad30e3422c9c7b888a15615d19a852ae32...c7d193f32edcb7bfad88892161225aeda64e9392">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=3.1.3&new-version=4.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

ea1e2dfa