1. 23 Aug, 2019 1 commit
    • Greg Spencer's avatar
      Normalize assert checking of clipBehavior (#38568) · 365f577c
      Greg Spencer authored
      I noticed that we were pretty inconsistent with the way that we checked the value of clipBehavior in the framework, so I normalized the usages and updated docs where necessary.
      
      This is a breaking change if you used to pass null explicitly to FlatButton, OutlineButton or RaisedButton constructors, expecting to get Clip.none. It will now assert if you do that. Existing implementations that pass null implicitly by not specifying clipBehavior won't need to change their call sites. It always implicitly defaulted to Clip.none before, and it will continue to do that, it's only places where it was explicitly set to null in order to get the implicit default that it will fail.
      365f577c
  2. 05 Feb, 2019 1 commit
  3. 18 Jan, 2019 1 commit
  4. 10 Jan, 2019 1 commit
    • MH Johnson's avatar
      [Material] Bottom app bar theme (#24156) · 090c3bcd
      MH Johnson authored
      * [WIP] BAB theme
      
      * [WIP] BAB theme
      
      * Update goldens
      
      * Extract helper function in tests
      
      * Update Goldens version
      
      * Add tests
      
      * [WIP] Hans first round comments
      
      * Added test
      
      * Added docs
      
      * Hans second round comments
      
      * Fixed analyzer error
      
      * Hans third round comments
      
      * ambient
      
      * Change [BottomAppBarTheme.of] to static
      
      * Final doc change
      090c3bcd
  5. 18 Dec, 2018 2 commits
  6. 08 Nov, 2018 1 commit
  7. 12 Sep, 2018 1 commit
  8. 07 Sep, 2018 1 commit
  9. 06 Sep, 2018 1 commit
  10. 02 Aug, 2018 1 commit
  11. 27 Jul, 2018 1 commit
  12. 23 Jul, 2018 1 commit
  13. 16 Jul, 2018 2 commits
  14. 21 Jun, 2018 1 commit
    • amirh's avatar
      Move the notch computation from the FAB to the BAB. (#18372) · c39f2f26
      amirh authored
      Move the notch computation from the FAB to the BAB.
      
      The notch in the BAB (bottom action bar) for the FAB (floating action button) was previously kept as part of the FAB's implementation. This was done to keep the shape of the FAB and the shape of the notch coupled.
      That approach resulted in a somewhat complex and 'non Fluttery' mechanism for propagating the notch computation from the FAB to the BAB.
      
      This CL uncouples the FAB and the notch computation.
      With the new API the BAB computes its overall shape including the notch using a NotchedShape delegate.
      
      This includes multiple breaking changes:
        * Scaffold.setFloatingActionButtonNotchFor is deleted.
        * The ComputeNotch type is deleted.
        * The hasNotch property of BottomAppBar is deleted.
        * The notchMargin property of FloatingActionButton is deleted.
      
      Quick migration guide from the previous API:
      
      | Previous API | New API |
      | ------------------|-------------|
      | BottomAppBar(hasNotch: false) | BottomAppBar() |
      | Using a FloatingActionButton with: BottomAppBar() / BottomAppBar(hasNotch: true) | BottomAppBar(shape: CircularNotchedRectangle()) |
      | Scaffold.setFloatingActionButtonNotchFor(..) | No longer supported |
      c39f2f26
  15. 06 Jun, 2018 1 commit
    • amirh's avatar
      _markNeedsClip() when clipper type has changed. (#18248) · 0a26ac09
      amirh authored
      A bug in _RenderCustomClip was compaeing the type of oldClipper to
      itself instead to the type of newClipper.
      
      This was the root cause for the crash #14937 worked around.
      This also reverts the workaround introduced in #14937.
      0a26ac09
  16. 05 Jun, 2018 1 commit
  17. 08 May, 2018 1 commit
  18. 21 Apr, 2018 1 commit
  19. 28 Feb, 2018 1 commit
  20. 26 Feb, 2018 1 commit
  21. 24 Feb, 2018 1 commit
  22. 23 Feb, 2018 1 commit
  23. 22 Feb, 2018 1 commit
  24. 21 Feb, 2018 1 commit
    • amirh's avatar
      Initial implementation of BottomAppBar (#14713) · 7996d7fb
      amirh authored
      * add a FAB NotchMaker to ScaffoldGeometry
      
      * add a notchMaker to FloatingActionButton
      
      * Initial implementation of BottomAppBar
      
      Mainly includes the notch making logic.
      Not yet tested as currently there is no way to make the FAB and the BAB
      overlap, once #14368 to lands we could add unit tests to the
      BottomAppBar as well.
      
      * use a closeable for clearing the FAB notchmaker
      7996d7fb