- 17 Jan, 2024 18 commits
-
-
Andrew Kolos authored
Make test file systems/platforms used in asset_bundle_test.dart less dependent on the host platform (#141657) Part of work on https://github.com/flutter/flutter/pull/141214. See [this discussion](https://github.com/flutter/flutter/pull/141214#discussion_r1446727495) for the inspiration for this PR. ## Issue Many tests in [packages/flutter_tools/test/general.shard/asset_bundle_test.dart](https://github.com/flutter/flutter/blob/4cd0a3252d2b45e243714b3ce93c5b2313bce671/packages/flutter_tools/test/general.shard/asset_bundle_test.dart) aren't hermetic. When setting up fake `FileSystem` and `Platform` objects, the host OS is referenced: https://github.com/flutter/flutter/blob/f2745e97d53c6a29c7d40003dfaa4fc4c688cdd2/packages/flutter_tools/test/general.shard/asset_bundle_test.dart#L35-L40 https://github.com/flutter/flutter/blob/f2745e97d53c6a29c7d40003dfaa4fc4c688cdd2/packages/flutter_tools/test/general.shard/asset_bundle_test.dart#L43 To improve hermeticity here, we could instead run each once _per_ valid combination of file system style and platform. However, it is unclear if these tests even depend on the file system style (integration tests should catch most cases where this might matter). As a result, I think it's sufficient to improve hermeticity by always assuming a Linux environment, which is generally our default (as `MemoryFileSystem` does, and most of our fakes of `Platform` do by default). In general, if a test needs to run other kinds of environments, it should make this clear, ideally through the test name.
-
Daco Harkes authored
Rolls the packages from https://github.com/dart-lang/native in the native assets implementation. Most notable we're refactoring `package:native_assets_cli` for `build.dart` use. Therefore, all imports to that package for Flutter/Dart should be to the implementation internals that are no longer visible for `build.dart` writers. Hence all the import updates. No behavior in Flutter apps should change. This PR also updates the template to use the latests version of `package:native_assets_cli` which no longer exposes all the implementation details.
-
godofredoc authored
Most of the builds for mac_x64 can actually run on any available architecture. This is required to use capacity more efficiently.
-
Victoria Ashworth authored
Framework part of https://github.com/flutter/flutter/issues/132237.
-
https://github.com/flutter/engine/pull/49786Yegor authored
Skip incorrect expectations in preparation for https://github.com/flutter/engine/pull/49786. Bonus: improved error message when text style test fails
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows framework_tests_misc_leak_tracking" } --> The issue https://github.com/flutter/flutter/issues/140414 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20framework_tests_misc_leak_tracking%22). This test can be marked as unflaky. -
Michael Goderbauer authored
Make sure that these PRs don't slip through the cracks and only get caught during the stale PR review in critical triage.
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/141644
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/7dd0fcbcfa79...1a2b780c9108 2024-01-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Run check_podspecs on arm Mac bots" (flutter/packages#5909) 2024-01-17 stuartmorgan@google.com [various] Update minimum iOS versions to 12.0 (flutter/packages#5902) 2024-01-16 magder@google.com [ci] Run check_podspecs on arm Mac bots (flutter/packages#5885) 2024-01-16 alzollin@microsoft.com [pigeon] Fix pigeon test generation missing wrapResponse method. (flutter/packages#5903) 2024-01-16 engine-flutter-autoroll@skia.org Roll Flutter from 1a2c3151 to 8e94423e (2 revisions) (flutter/packages#5897) 2024-01-16 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.3 to 4.1.0 (flutter/packages#5896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Greg Spencer authored
## Description This adds a check to make sure that the `--empty` flag isn't applied to non-app templates. ## Related Issues - Fixes https://github.com/flutter/flutter/issues/141592 ## Tests - Added a test.
-
Jonah Williams authored
Reverts flutter/flutter#141673
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/73a2de5da53f...c7e328518bc0 2024-01-17 skia-flutter-autoroll@skia.org Roll Skia from 02e94b3b4d29 to d8da1ee69767 (1 revision) (flutter/engine#49824) 2024-01-17 bdero@google.com Flutter GPU: Add GpuContext.createHostBuffer (flutter/engine#49822) 2024-01-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Klxww53tA4-TG5pA9... to GuU0e5WxJCi92Scz8... (flutter/engine#49823) 2024-01-17 bdero@google.com [Impeller] Switch from transient stencil-only to depth+stencil buffer. (flutter/engine#47987) 2024-01-17 skia-flutter-autoroll@skia.org Roll Skia from 31309ff09537 to 02e94b3b4d29 (43 revisions) (flutter/engine#49819) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Klxww53tA4-T to GuU0e5WxJCi9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
Manual roll requested by zra@google.com Cannot build log URL because revision "73a2de5da53f" is invalid: Luci builds of "Mac builder_cache" for 73a2de5da53f8ab133e88b43d05189879c370cb3 was INFRA_FAILURE 2024-01-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Encode directly to command buffer for Vulkan." (flutter/engine#49818) 2024-01-17 zanderso@users.noreply.github.com Revert "Add gclient_variables back for linux_license and fix the excluded files" (flutter/engine#49817) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d4b6b7ec8e48...1382ff79dd6d 2024-01-16 magder@google.com Remove iOS 12 availability checks (flutter/engine#49771) 2024-01-16 30870216+gaaclarke@users.noreply.github.com [Impeller] generate mipmaps for imagefilters (flutter/engine#49794) 2024-01-16 ditman@gmail.com [web] Leave blob URLs untouched in TT policy. (flutter/engine#49782) 2024-01-16 jason-simmons@users.noreply.github.com [Impeller] Fix a race between SwapchainImplVK::Present and WaitForFence (flutter/engine#49777) 2024-01-16 737941+loic-sharma@users.noreply.github.com Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49726) 2024-01-16 jason-simmons@users.noreply.github.com [Impeller] Add an API for sampling strictly within the bounds of the source rect in DrawImageRect (flutter/engine#49696) 2024-01-16 jonahwilliams@google.com [Impeller] Encode directly to command buffer for Vulkan. (flutter/engine#49780) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Kostia Sokolovskyi authored
-
auto-submit[bot] authored
Reverts flutter/flutter#141651 Initiated by: jonahwilliams This change reverts the following previous change: Original Description: https://github.com/flutter/engine/compare/d4b6b7ec8e48...021a5ff5eae6 2024-01-16 ditman@gmail.com [web] Leave blob URLs untouched in TT policy. (flutter/engine#49782) 2024-01-16 jason-simmons@users.noreply.github.com [Impeller] Fix a race between SwapchainImplVK::Present and WaitForFence (flutter/engine#49777) 2024-01-16 737941+loic-sharma@users.noreply.github.com Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49726) 2024-01-16 jason-simmons@users.noreply.github.com [Impeller] Add an API for sampling strictly within the bounds of the source rect in DrawImageRect (flutter/engine#49696) 2024-01-16 jonahwilliams@google.com [Impeller] Encode directly to command buffer for Vulkan. (flutter/engine#49780) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d4b6b7ec8e48...021a5ff5eae6 2024-01-16 ditman@gmail.com [web] Leave blob URLs untouched in TT policy. (flutter/engine#49782) 2024-01-16 jason-simmons@users.noreply.github.com [Impeller] Fix a race between SwapchainImplVK::Present and WaitForFence (flutter/engine#49777) 2024-01-16 737941+loic-sharma@users.noreply.github.com Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49726) 2024-01-16 jason-simmons@users.noreply.github.com [Impeller] Add an API for sampling strictly within the bounds of the source rect in DrawImageRect (flutter/engine#49696) 2024-01-16 jonahwilliams@google.com [Impeller] Encode directly to command buffer for Vulkan. (flutter/engine#49780) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 16 Jan, 2024 15 commits
-
-
Dan Field authored
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/68547 for macOS. Needs https://github.com/flutter/engine/pull/49314
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/eab7bd3b0999...d4b6b7ec8e48 2024-01-16 jonahwilliams@google.com [Impeller] remove shared_ptr copy/release in main rendering loop. (flutter/engine#49801) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f20657354d8b...eab7bd3b0999 2024-01-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manually bump Dart to 3.4.0-34.0.dev" (flutter/engine#49802) 2024-01-16 bdero@google.com Use the correct impeller-cmake-example mirror (flutter/engine#49791) 2024-01-16 bdero@google.com [Flutter GPU] Run unittests on CI and fix HostBuffer. (flutter/engine#49789) 2024-01-16 bdero@google.com [Flutter GPU] Fix playground shader paths. (flutter/engine#49790) 2024-01-16 737941+loic-sharma@users.noreply.github.com [Windows] Add README (flutter/engine#49779) 2024-01-16 dnfield@google.com Fix typo (flutter/engine#49725) 2024-01-16 jason-simmons@users.noreply.github.com Truncate thread names on Linux to the maximum allowed length (flutter/engine#49781) 2024-01-16 dnfield@google.com [Impeller] Fix hot reload for shaders on Impeller (flutter/engine#49739) 2024-01-16 jiahaog@users.noreply.github.com Add `flutter` prefix to import (flutter/engine#49793) 2024-01-16 ivan.inozemtsev@gmail.com Support running sound null safe kernels from dart_runner (flutter/engine#49598) 2024-01-16 bdero@google.com Manually bump Dart to 3.4.0-34.0.dev (flutter/engine#49792) 2024-01-16 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.3 to 4.1.0 (flutter/engine#49788) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Anis Alibegić authored
I continued [my mission](https://github.com/flutter/flutter/pull/141431) to find as many typos as I could. This time it's a smaller set than before. There is no need for issues since it's a typo fix.
-
godofredoc authored
This is required to remove explicit contexts from recipes.
-
Reid Baker authored
- handle number format exceptions and strip rc information from version compare - add test that handles rc format part 2/n https://github.com/flutter/flutter/issues/138523 Helpfully pointed out by [asaarnak](https://github.com/asaarnak) https://github.com/flutter/flutter/pull/139325#issuecomment-1892554584
-
Bartek Pacia authored
This line is a leftover. Removing it is a no-op.
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/d21f3b861e32...7dd0fcbcfa79 2024-01-16 stuartmorgan@google.com Bump `release` to use 3.16.6 (flutter/packages#5886) 2024-01-16 ian@hixie.ch [rfw] Add support for tracking source locations of BlobNodes. (flutter/packages#5876) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Bartek Pacia authored
[Source](https://github.com/flutter/flutter/pull/133598#discussion_r1446033128) For future readers.
-
Bartek Pacia authored
Inspired by #137621.
-
Jenn Magder authored
`swift-format` alphabetizes imports. Alphabetize them in swift template files and integration tests. I found this as part of https://github.com/flutter/flutter/issues/41129 running `swift-import` on packages.
-
Polina Cherkasova authored
-
Spt authored
Solve the problem that <Flutter/Flutter.h> cannot be imported when a pod transitive depends on Flutter (#125610)   If a pod transitive depends on a pod containing a framework, cocoapods will add the path of the framework to its FRAMEWORK_SEARCH_PATHS. So I modified the relevant logic in podhelper, hoping to be consistent with the behavior of cocoapods. Fixes https://github.com/flutter/flutter/issues/126251.
-
Sulav Parajuli authored
## Description This PR addresses issue #141061, which requested the addition of a 'color' property to buttons extending _ActionButton. The 'color' property has been introduced to enhance customization options for these buttons. ## Issues Fixed - Fixes #141061
-
- 15 Jan, 2024 2 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/d74d687dc0aa...d21f3b861e32 2024-01-14 engine-flutter-autoroll@skia.org Roll Flutter from 7dc856ab to 1a2c3151 (23 revisions) (flutter/packages#5895) 2024-01-13 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Add test that `onReceivedHttpAuthRequest` is cancelled by default (flutter/packages#5723) 2024-01-13 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 46787ee49c1f to ef1af02aead6 (1 revision) (flutter/packages#5887) 2024-01-12 stuartmorgan@google.com [google_maps_flutter] Drop iOS 11 support (flutter/packages#5873) 2024-01-12 engine-flutter-autoroll@skia.org Roll Flutter from 9f2e681e to 7dc856ab (15 revisions) (flutter/packages#5882) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
auto-submit[bot] authored
Reverts flutter/flutter#141526 Initiated by: CaseyHillers This change reverts the following previous change: Original Description: ### Description - Adds `BoxPainter` creation and disposal events dispatching for memory leak tracking as part of https://github.com/flutter/flutter/issues/141198 ### Tests - Updates `decoration_test.dart` to test `BoxPainter` object creation and disposal events dispatching.
-
- 14 Jan, 2024 3 commits
-
-
Kostia Sokolovskyi authored
-
Kostia Sokolovskyi authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a0ac66ecaa2b...f20657354d8b 2024-01-13 chinmaygarde@google.com Remove pthread based thread local support. (flutter/engine#49297) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 13 Jan, 2024 2 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b06478b70a2f...a0ac66ecaa2b 2024-01-13 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed nested save layer mipmap counts (flutter/engine#49778) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/205ed6882a8f...b06478b70a2f 2024-01-12 dnfield@google.com [Impeller] Properly size struct emplacements for Vulkan Runtime Effects (flutter/engine#49768) 2024-01-12 zanderso@users.noreply.github.com Fix linux_android_emulator_api_33 build config for rbe (flutter/engine#49776) 2024-01-12 dkwingsmt@users.noreply.github.com [Linux] Remove the usage of std::function in FlKeyEmbedderResponder (flutter/engine#49293) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
![auto-submit[bot]'s avatar](https://secure.gravatar.com/avatar/266ceac20512ae5366aafb5e5452ef8b?s=80&d=identicon "auto-submit[bot]")
