1. 28 May, 2019 1 commit
  2. 10 Apr, 2019 1 commit
  3. 08 Apr, 2019 3 commits
    • Todd Volkert's avatar
      Add Form.onSaved (#30643) · 949023b2
      Todd Volkert authored
      When submitting data to a server, callers need a callback that will
      get invoked after all the individual form fields are saved. If they
      have a button that submits the form, they could just do this logic
      in the click handler for the button (save the form, then submit to
      the server), but if they have more ways than one to submit the form
      (i.e. hitting enter while in a text form field), then it becomes
      more convoluted and calls for a unified callback that will get
      notified when the form is submitted.
      949023b2
    • Todd Volkert's avatar
      Make FormField._validate() return void (#30644) · cb78274c
      Todd Volkert authored
      None of its callers were using the return value, so no need to
      invoke the `isValid` getter unnecessarily.
      cb78274c
    • Todd Volkert's avatar
      Add docs to FormFieldValidator (#30645) · 535523db
      Todd Volkert authored
      To describe what its return value represents
      535523db
  4. 27 Mar, 2019 1 commit
  5. 07 Mar, 2019 1 commit
  6. 06 Mar, 2019 1 commit
  7. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  8. 28 Feb, 2019 1 commit
    • Greg Spencer's avatar
      Fix spelling errors. (#28657) · ccdd5057
      Greg Spencer authored
      Fix the spelling errors in the dartdocs for the framework.
      
      There are no functionality changes here, just documentation fixes.
      ccdd5057
  9. 16 Oct, 2018 1 commit
  10. 14 Sep, 2018 1 commit
  11. 12 Sep, 2018 1 commit
  12. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  13. 11 Jun, 2018 1 commit
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  14. 05 Jun, 2018 1 commit
  15. 30 May, 2018 2 commits
  16. 03 May, 2018 1 commit
  17. 22 Mar, 2018 1 commit
  18. 19 Mar, 2018 1 commit
  19. 21 Dec, 2017 1 commit
  20. 29 Sep, 2017 1 commit
    • Chris Bracken's avatar
      Improved behaviour for text-editing widgets (#12273) · 85c425ac
      Chris Bracken authored
      This patch fixes a collection of issues with widgets involved in text
      editing:
      
        * Fire widget.onChanged on EditableText value change:
          The value of an EditableText is composed of the text value as well
          as other editing-related data such as selection-related information.
      
          Previously, widget.onChanged() was only called for updates via
          updateEditingValue(). For pastes via a TextSelectionOverlay, updates
          are signalled via _handleSelectionOverlayChanged(), which only ever
          triggered widget.onSelectionChanged(), but not widget.onChanged().
      
          Both updateEditingValue() and _handleSelectionOverlayChanged()
          perform the value update via _formatAndSetValue(), which is where
          this patch moves the widget.onChanged() call.
      
        * Correctly update TextFormField value on edits via controller:
          The textual value of a TextFormField exists in two locations:
            1. FormField.value, as with all FormFields and subclasses.
            2. TextEditingController.value associated with the TextField
               underlying the TextFormField.
      
          Previously, edits to the TextEditingController associated with a
          TextFormField resulted in updates to the rendered TextField widget,
          but did not update TextFormField.value. FormField.value is updated
          via FormField's onChanged function, which is called from the
          EditableText underlying the TextField underlying the TextFormField.
          EditableText only fires onChanged when it receives changes from the
          engine. It does not fire onChanged for changes made to the
          underlying TextController, since the owner of the TextController is
          the one making these changes and thus, already aware of them.
          FormField, however, *does* need to listen to these changes to update
          its value.
      
        * Adds an initialValue parameter to the TextFormField constructor:
          FormField's constructor already takes an initialValue parameter,
          which specifies the initial value in the field, which is also the
          value to which reset() returns the field.
      
          Previously, TextFormField took its initial value from the controller
          value (if a controller was passed in) or the empty string (if not).
          This had the undesirable effect that calling reset() always resets
          the value to the current value of the controller... i.e., does
          nothing.
      
          We now take an initial value explicitly.
      85c425ac
  21. 21 Aug, 2017 1 commit
  22. 28 Jul, 2017 1 commit
  23. 05 May, 2017 1 commit
  24. 23 Apr, 2017 1 commit
  25. 21 Apr, 2017 1 commit
  26. 14 Apr, 2017 1 commit
  27. 11 Apr, 2017 1 commit
    • xster's avatar
      Rename State.config to widget everywhere (#9273) · 89a7fdfc
      xster authored
      Rename State.config to State.widget
      Rename State.didUpdateConfig to State.didUpdateWidget
      Renamed all State subclasses' local variables named config to something else
      89a7fdfc
  28. 08 Apr, 2017 1 commit
    • Kyle Bradshaw's avatar
      Form.dart doc typo fixes (#9302) · 55e51e79
      Kyle Bradshaw authored
      Came across "can ve" while experimenting with Forms using VSCode and Dart Code. Glanced over the rest of the docs for typos while I was at it.
      55e51e79
  29. 29 Mar, 2017 1 commit
  30. 15 Mar, 2017 1 commit
  31. 04 Mar, 2017 1 commit
  32. 21 Feb, 2017 1 commit
  33. 07 Feb, 2017 1 commit
  34. 19 Jan, 2017 1 commit
  35. 18 Jan, 2017 1 commit
  36. 16 Dec, 2016 1 commit
  37. 12 Dec, 2016 1 commit