Commits · 56cbf3e1d9b373dc70099c96c09e4133f36a332f · abdullh.alsoleman / Front-End

18 Sep, 2023 16 commits

Cover more test/widgets tests with leak tracking #5 (#134869) · 56cbf3e1
Kostia Sokolovskyi authored Sep 18, 2023

56cbf3e1

Don't uninstall before retrying to connect during app launch (#134542) · abf8361a

Victoria Ashworth authored Sep 18, 2023

When retrying to connect to the device during app launch, don't uninstall the app first.

Latest test flake for https://github.com/flutter/flutter/issues/120808:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8770202475999850785/+/u/run_hot_mode_dev_cycle_ios__benchmark/test_stdout

Shows that it uninstalled and then tried debugging and failed, which would make sense since the app wasn't installed anymore.
```
[2023-09-11 18:02:24.555646] [STDOUT] stdout: [   +6 ms] Lost connection to device. Trying to connect again...
[2023-09-11 18:02:24.556949] [STDOUT] stdout: [   +1 ms] executing: /opt/s/w/ir/x/w/recipe_cleanup/tmp53fs1szo/flutter sdk/bin/cache/artifacts/libimobiledevice/idevicesyslog -u 00008030-00144DA10185402E
[2023-09-11 18:02:24.557323] [STDOUT] stdout: [        ] executing: script -t 0 /dev/null /opt/s/w/ir/x/w/recipe_cleanup/tmp53fs1szo/flutter sdk/bin/cache/artifacts/ios-deploy/ios-deploy --id 00008030-00144DA10185402E --bundle build/ios/iphoneos/Flutter Gallery.app --app_deltas build/ios/app-delta --uninstall --noinstall --debug --no-wifi --args --enable-dart-profiling --disable-vm-service-publication --enable-checked-mode --verify-entry-points
[2023-09-11 18:02:24.578010] [STDOUT] stdout: [  +20 ms] [....] Waiting for iOS device to be connected
[2023-09-11 18:02:24.712631] [STDOUT] stdout: [ +134 ms] [....] Using 00008030-00144DA10185402E (N104AP, iPhone 11, iphoneos, arm64e, 16.2, 20C65) a.k.a. 'iPhone 11'.
[2023-09-11 18:02:24.712725] [STDOUT] stdout: [        ] ------ Uninstall phase ------
[2023-09-11 18:02:24.818293] [STDOUT] stdout: [ +105 ms] [ OK ] Uninstalled package with bundle id io.flutter.examples.gallery
[2023-09-11 18:02:24.906833] [STDOUT] stdout: [  +88 ms] ------ Debug phase ------
[2023-09-11 18:02:24.906924] [STDOUT] stdout: [        ] Starting debug of 00008030-00144DA10185402E (N104AP, iPhone 11, iphoneos, arm64e, 16.2, 20C65) a.k.a. 'iPhone 11' connected through USB...
[2023-09-11 18:02:25.285252] [STDOUT] stdout: [ +378 ms] [  0%] Looking up developer disk image
[2023-09-11 18:02:25.529937] [STDOUT] stdout: [ +244 ms] [ 90%] Mounting developer disk image
[2023-09-11 18:02:25.545261] [STDOUT] stdout: [  +15 ms] [ 95%] Developer disk image already mounted
[2023-09-11 18:02:25.587923] [STDOUT] stdout: [  +42 ms] Detected path to iOS debug symbols: "Symbol Path: /Users/swarming/Library/Developer/Xcode/iOS DeviceSupport/16.2 (20C65) arm64e/Symbols"
[2023-09-11 18:02:25.857177] [STDOUT] stdout: [ +269 ms] Script started, output file is /dev/null
[2023-09-11 18:02:25.857259] [STDOUT] stdout: [        ] Script done, output file is /dev/null
[2023-09-11 18:02:25.857511] [STDOUT] stdout: [        ] ios-deploy exited with code 0
[2023-09-11 18:02:25.858066] [STDOUT] stderr: [        ] Could not run build/ios/iphoneos/Flutter Gallery.app on 00008030-00144DA10185402E.
[2023-09-11 18:02:25.858130] [STDOUT] stderr: [        ] Try launching Xcode and selecting "Product > Run" to fix the problem:
[2023-09-11 18:02:25.858214] [STDOUT] stderr: [        ]   open ios/Runner.xcworkspace
[2023-09-11 18:02:25.858537] [STDOUT] stdout: [        ] Installing and launching... (completed in 52.4s)
[2023-09-11 18:02:25.858956] [STDOUT] stderr: [        ] Error launching application on iPhone 11.
```

abf8361a

[flutter roll] Revert "LinkedText (Linkify)" (#134955) · 6425a3b4

Xilai Zhang authored Sep 18, 2023

Reverts flutter/flutter#125927

context: b/300804374

Looks like a g3 fix might involve changing the names of widget on the customer app, and I am not sure if that would be the right approach forward. Putting up a revert to be safe for now.

6425a3b4

Fix memory leak in _DarwinViewState. (#134938) · 9dd3e1e6
Kostia Sokolovskyi authored Sep 18, 2023

9dd3e1e6

Roll Flutter Engine from be7a039c5451 to e1c784e3f841 (3 revisions) (#134956) · bac5e5d5

engine-flutter-autoroll authored Sep 18, 2023

https://github.com/flutter/engine/compare/be7a039c5451...e1c784e3f841

2023-09-18 skia-flutter-autoroll@skia.org Roll Skia from f8065ca00d0c to 0c990ab9e097 (7 revisions) (flutter/engine#45979)
2023-09-18 mdebbar@google.com [web] ScreenOrientation singleton (flutter/engine#45304)
2023-09-18 mdebbar@google.com [web] De-singletonize MouseCursor for multi-view (flutter/engine#45295)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bac5e5d5

Migrate the "Missing frames / speed related performance issues" issue template... · b195c944

huycozy authored Sep 18, 2023

Migrate the "Missing frames / speed related performance issues" issue template to use Github forms (#134033)

Closes #119921

### Demo

- Demo issue template: [Issue: My app is slow or missing frames](https://github.com/huycozy/flutter/issues/new?assignees=&labels=from%3A+performance+template&projects=&template=5_performance_speed.yml)
- Demo a filed issue: https://github.com/huycozy/flutter/issues/5

b195c944

Roll Packages from bc8c2f20910b to d4e245421737 (6 revisions) (#134945) · b7d0e8c9

engine-flutter-autoroll authored Sep 18, 2023

https://github.com/flutter/packages/compare/bc8c2f20910b...d4e245421737

2023-09-18 me@nils.re [camera_android] Removes usage of `_ambiguate` method in example (flutter/packages#4924)
2023-09-17 engine-flutter-autoroll@skia.org Roll Flutter from e5e36ad3 to 1b18b132 (8 revisions) (flutter/packages#4940)
2023-09-16 engine-flutter-autoroll@skia.org Roll Flutter from 72b69f94 to e5e36ad3 (12 revisions) (flutter/packages#4938)
2023-09-15 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.5.0 to 1.7.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#4891)
2023-09-15 engine-flutter-autoroll@skia.org Roll Flutter from 58ba6c29 to 72b69f94 (21 revisions) (flutter/packages#4934)
2023-09-15 stuartmorgan@google.com [image_picker] Add missing entitlements to macOS example (flutter/packages#4931)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b7d0e8c9

Roll Flutter Engine from 4107ee0dc8b1 to be7a039c5451 (1 revision) (#134937) · 06e346a8

engine-flutter-autoroll authored Sep 18, 2023

https://github.com/flutter/engine/compare/4107ee0dc8b1...be7a039c5451

2023-09-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 5c56e0f3fe13 to 5b0e7bda1379 (1 revision) (flutter/engine#45974)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

06e346a8

Native assets support for Linux (#134031) · 2337c64d

Daco Harkes authored Sep 18, 2023

Support for FFI calls with `@Native external` functions through Native assets on Linux. This enables bundling native code without any build-system boilerplate code.

For more info see:

* https://github.com/flutter/flutter/issues/129757

### Implementation details for Linux.

Mainly follows the design of https://github.com/flutter/flutter/pull/130494.

Some differences are:

* Linux does not support cross compiling or compiling for multiple architectures, so this has not been implemented.
* Linux has no add2app.

The assets copying is done in the install-phase of the CMake build of a flutter app.
CMake requires the native assets folder to exist, so we create it also when the feature is disabled or there are no assets.

### Tests

This PR adds new tests to cover the various use cases.

* packages/flutter_tools/test/general.shard/linux/native_assets_test.dart
  * Unit tests the Linux-specific part of building native assets.

It also extends various existing tests:

* packages/flutter_tools/test/integration.shard/native_assets_test.dart
  * Runs (incl hot reload/hot restart), builds, builds frameworks for Linux and flutter-tester.

2337c64d

Roll Flutter Engine from 77965cabbaf9 to 4107ee0dc8b1 (1 revision) (#134927) · d6d90b0f

engine-flutter-autoroll authored Sep 18, 2023

https://github.com/flutter/engine/compare/77965cabbaf9...4107ee0dc8b1

2023-09-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 5eef4301567f to 5c56e0f3fe13 (1 revision) (flutter/engine#45966)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d6d90b0f

Roll Flutter Engine from 75e5ba3c4671 to 77965cabbaf9 (1 revision) (#134925) · cf317b5a

engine-flutter-autoroll authored Sep 18, 2023

https://github.com/flutter/engine/compare/75e5ba3c4671...77965cabbaf9

2023-09-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 2TJNsB32jPioIfFao... to 3_Lh8otTpmVuf-Zwb... (flutter/engine#45963)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 2TJNsB32jPio to 3_Lh8otTpmVu

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cf317b5a

Roll Flutter Engine from 573e44b91887 to 75e5ba3c4671 (1 revision) (#134923) · 6068ff2a

engine-flutter-autoroll authored Sep 18, 2023

https://github.com/flutter/engine/compare/573e44b91887...75e5ba3c4671

2023-09-18 skia-flutter-autoroll@skia.org Roll Skia from eac827d9eed3 to f8065ca00d0c (2 revisions) (flutter/engine#45962)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6068ff2a

Improve DropdownMenu sample code for requestFocusOnTap on mobile platforms (#134867) · c2b1e483

huycozy authored Sep 18, 2023

### Description

This PR is to improve `DropdownMenu` sample code. By default, `requestFocusOnTap` is false on mobile platforms. When users run API sample code on mobile platforms, they can not edit the text field and think it is a bug. Although it is detailed at https://api.flutter.dev/flutter/material/DropdownMenu/requestFocusOnTap.html, users often do not pay attention to it.

### Related issue

Fixes https://github.com/flutter/flutter/issues/127672

c2b1e483

Roll Flutter Engine from 51a402860f5b to 573e44b91887 (1 revision) (#134920) · b03f5337

engine-flutter-autoroll authored Sep 18, 2023

https://github.com/flutter/engine/compare/51a402860f5b...573e44b91887

2023-09-18 skia-flutter-autoroll@skia.org Roll Skia from 0d02aa8cb640 to eac827d9eed3 (1 revision) (flutter/engine#45957)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b03f5337

Roll Flutter Engine from f53681fb2220 to 51a402860f5b (1 revision) (#134918) · 466fa608

engine-flutter-autoroll authored Sep 18, 2023

https://github.com/flutter/engine/compare/f53681fb2220...51a402860f5b

2023-09-18 skia-flutter-autoroll@skia.org Roll Dart SDK from a0ca39c63c16 to 5eef4301567f (1 revision) (flutter/engine#45956)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

466fa608

Roll Flutter Engine from 9f3e46a21e51 to f53681fb2220 (1 revision) (#134916) · 2e67d8c0

engine-flutter-autoroll authored Sep 18, 2023

https://github.com/flutter/engine/compare/9f3e46a21e51...f53681fb2220

2023-09-18 skia-flutter-autoroll@skia.org Roll Skia from a160e7fb80db to 0d02aa8cb640 (1 revision) (flutter/engine#45952)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2e67d8c0

17 Sep, 2023 3 commits

Roll Flutter Engine from 57a4ff3c7ff8 to 9f3e46a21e51 (1 revision) (#134909) · e599dae4

engine-flutter-autoroll authored Sep 17, 2023

https://github.com/flutter/engine/compare/57a4ff3c7ff8...9f3e46a21e51

2023-09-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from AjL85L6CVMEuMWPVZ... to 2TJNsB32jPioIfFao... (flutter/engine#45945)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from AjL85L6CVMEu to 2TJNsB32jPio

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e599dae4

Roll Flutter Engine from e07bb975ee85 to 57a4ff3c7ff8 (1 revision) (#134895) · 1b18b132

engine-flutter-autoroll authored Sep 17, 2023

https://github.com/flutter/engine/compare/e07bb975ee85...57a4ff3c7ff8

2023-09-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from IJXVQbD3CpkL2_ihZ... to AjL85L6CVMEuMWPVZ... (flutter/engine#45937)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from IJXVQbD3CpkL to AjL85L6CVMEu

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1b18b132

Roll Flutter Engine from 444689fd4060 to e07bb975ee85 (1 revision) (#134889) · 13a03cef

engine-flutter-autoroll authored Sep 17, 2023

https://github.com/flutter/engine/compare/444689fd4060...e07bb975ee85

2023-09-17 skia-flutter-autoroll@skia.org Roll Skia from 2eaaa5bf7dae to a160e7fb80db (1 revision) (flutter/engine#45933)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

13a03cef

16 Sep, 2023 13 commits

Roll Flutter Engine from 8c2203bb6c3b to 444689fd4060 (1 revision) (#134886) · 1bad8c4f

engine-flutter-autoroll authored Sep 16, 2023

https://github.com/flutter/engine/compare/8c2203bb6c3b...444689fd4060

2023-09-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 3Tb9CQTTiBv1lb673... to IJXVQbD3CpkL2_ihZ... (flutter/engine#45928)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 3Tb9CQTTiBv1 to IJXVQbD3CpkL

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1bad8c4f

Fix memory leak in CupertinoActionSheet (#134885) · 854bbb90
Kostia Sokolovskyi authored Sep 16, 2023

854bbb90
Add disposal mechanism for created Layers to TestRecordingPaintingContext. (#134768) · 60fae58a
Polina Cherkasova authored Sep 16, 2023
```
Contributes to https://github.com/flutter/flutter/issues/134575
```
60fae58a

Manual roll Flutter Engine from 490925676b91 to 8c2203bb6c3b (6 revisions) (#134882) · c66ca4f1

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/490925676b91...8c2203bb6c3b

2023-09-16 skia-flutter-autoroll@skia.org Roll Skia from b33e0e6706b0 to 2eaaa5bf7dae (1 revision) (flutter/engine#45926)
2023-09-16 skia-flutter-autoroll@skia.org Roll Skia from a1f8fb54299a to b33e0e6706b0 (1 revision) (flutter/engine#45923)
2023-09-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from -_edKGA5GTkDFxVgl... to 3Tb9CQTTiBv1lb673... (flutter/engine#45922)
2023-09-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 029d6d73c860 to a0ca39c63c16 (1 revision) (flutter/engine#45921)
2023-09-16 matanlurey@users.noreply.github.com [Impeller] `vk::CommandPool` resets via `ResourceManager` (flutter/engine#45654)
2023-09-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from wWzXsy6kx1sp8Km34... to ZhY53WD7bFJSA3xoO... (flutter/engine#45919)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from wWzXsy6kx1sp to ZhY53WD7bFJS
fuchsia/sdk/core/mac-amd64 from -_edKGA5GTkD to 3Tb9CQTTiBv1

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c66ca4f1

Manual roll Flutter Engine from cdcbdcc7ccba to 490925676b91 (5 revisions) (#134879) · d9cffa05

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/cdcbdcc7ccba...490925676b91

2023-09-16 matanlurey@users.noreply.github.com Add a single MacOS+Vulkan+SwiftShader CI test (flutter/engine#45918)
2023-09-16 skia-flutter-autoroll@skia.org Roll Skia from 696ac041ea82 to a1f8fb54299a (1 revision) (flutter/engine#45917)
2023-09-16 skia-flutter-autoroll@skia.org Roll Skia from 4851cd29e1dd to 696ac041ea82 (1 revision) (flutter/engine#45915)
2023-09-16 skia-flutter-autoroll@skia.org Roll Skia from c19cc483c619 to 4851cd29e1dd (1 revision) (flutter/engine#45913)
2023-09-16 skia-flutter-autoroll@skia.org Roll Dart SDK from e9452310189b to 029d6d73c860 (1 revision) (flutter/engine#45912)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d9cffa05

Manual roll Flutter Engine from 30b7e9ded7a0 to cdcbdcc7ccba (5 revisions) (#134877) · 042c0757

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/30b7e9ded7a0...cdcbdcc7ccba

2023-09-16 jonahwilliams@google.com Revert "[Impeller] construct text
frames on UI thread." (flutter/engine#45910)
2023-09-16 skia-flutter-autoroll@skia.org Roll Skia from 7c179932cc06 to
c19cc483c619 (1 revision) (flutter/engine#45911)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 917fd16e6f26 to
7c179932cc06 (1 revision) (flutter/engine#45907)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 0057898979a1 to
917fd16e6f26 (1 revision) (flutter/engine#45906)
2023-09-15 matanlurey@users.noreply.github.com Do not convert an open
path to a closed rect. (flutter/engine#45903)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

042c0757

Manual roll Flutter Engine from 326faf1762d6 to 30b7e9ded7a0 (5 revisions) (#134876) · e5e36ad3

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/326faf1762d6...30b7e9ded7a0

2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 7f88bda24f7f to 0057898979a1 (1 revision) (flutter/engine#45904)
2023-09-15 matanlurey@users.noreply.github.com [Impeller] Test `FenceWaiterVK` and fix termination bugs (flutter/engine#45870)
2023-09-15 skia-flutter-autoroll@skia.org Roll Dart SDK from a5ee0055cf20 to e9452310189b (1 revision) (flutter/engine#45902)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 4f26f22daa4b to 7f88bda24f7f (5 revisions) (flutter/engine#45901)
2023-09-15 jonahwilliams@google.com [Impeller] dont cache failed render target allocations. (flutter/engine#45895)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e5e36ad3

Manual roll Flutter Engine from 51e643de62aa to 326faf1762d6 (6 revisions) (#134875) · e1428bff

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/51e643de62aa...326faf1762d6

2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from c79441fc8016 to 4f26f22daa4b (1 revision) (flutter/engine#45893)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 58c509b1a24a to c79441fc8016 (1 revision) (flutter/engine#45892)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from fffef1047640 to 58c509b1a24a (2 revisions) (flutter/engine#45888)
2023-09-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 65117290c3b0 to a5ee0055cf20 (1 revision) (flutter/engine#45887)
2023-09-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from --OUw__L3ekVTG-5c... to -_edKGA5GTkDFxVgl... (flutter/engine#45886)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from de56f293eb41 to fffef1047640 (2 revisions) (flutter/engine#45885)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from --OUw__L3ekV to -_edKGA5GTkD

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e1428bff

Manual roll Flutter Engine from d623ecf43c66 to 51e643de62aa (5 revisions) (#134865) · b8dc118b

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/d623ecf43c66...51e643de62aa

2023-09-15 zanderso@users.noreply.github.com Adds a --quiet flag to run_tests.py (flutter/engine#45880)
2023-09-15 reidbaker@google.com Update AGP and Kotlin for scenario app (flutter/engine#45549)
2023-09-15 kjlubick@users.noreply.github.com Migrate GrMipmapped->skgpu::Mipmapped (flutter/engine#45881)
2023-09-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Introduce mock vulkan context builder (flutter/engine#45834)
2023-09-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ES0r-mYplPOBYHvUQ... to wWzXsy6kx1sp8Km34... (flutter/engine#45879)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ES0r-mYplPOB to wWzXsy6kx1sp

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b8dc118b

Manual roll Flutter Engine from c0eaf2633686 to d623ecf43c66 (5 revisions) (#134861) · 0032d9bb

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/c0eaf2633686...d623ecf43c66

2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 3492fc567816 to
de56f293eb41 (1 revision) (flutter/engine#45878)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 6e286034109e to
3492fc567816 (1 revision) (flutter/engine#45876)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 824b1973703d to
6e286034109e (1 revision) (flutter/engine#45875)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 4f7aafd0c853 to
824b1973703d (1 revision) (flutter/engine#45871)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from c0cabb0f93c9 to
4f7aafd0c853 (1 revision) (flutter/engine#45868)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0032d9bb

Manual roll Flutter Engine from 5aa9db365ed6 to c0eaf2633686 (5 revisions) (#134860) · ae743699

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/5aa9db365ed6...c0eaf2633686

2023-09-15 skia-flutter-autoroll@skia.org Roll Dart SDK from
c0a505f9d1dd to 65117290c3b0 (1 revision) (flutter/engine#45867)
2023-09-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
FF4r9-tqhioBbRG9f... to --OUw__L3ekVTG-5c... (flutter/engine#45866)
2023-09-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
MzLcTzBiWJ7o3Q2_Z... to ES0r-mYplPOBYHvUQ... (flutter/engine#45865)
2023-09-15 skia-flutter-autoroll@skia.org Roll Dart SDK from
7e4d9f4d8e52 to c0a505f9d1dd (1 revision) (flutter/engine#45864)
2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 7aa8bfaa63fc to
c0cabb0f93c9 (1 revision) (flutter/engine#45863)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from MzLcTzBiWJ7o to ES0r-mYplPOB
  fuchsia/sdk/core/mac-amd64 from FF4r9-tqhioB to --OUw__L3ekV

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ae743699

Manual roll Flutter Engine from 67dd12f8dfca to 5aa9db365ed6 (5 revisions) (#134856) · 30cd285c

engine-flutter-autoroll authored Sep 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/67dd12f8dfca...5aa9db365ed6

2023-09-15 skia-flutter-autoroll@skia.org Roll Skia from 37ea783440ea to
7aa8bfaa63fc (1 revision) (flutter/engine#45861)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 8c9e378c4902 to
37ea783440ea (1 revision) (flutter/engine#45859)
2023-09-14 findyou795@gmail.com Reduce unnecessary
Dart_TimelineGetMicros call (flutter/engine#45637)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 9b7c116ed6c2 to
8c9e378c4902 (3 revisions) (flutter/engine#45858)
2023-09-14 15619084+vashworth@users.noreply.github.com Set tests to run
on macOS 12 (flutter/engine#45855)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

30cd285c

Roll Flutter Engine from 45bc4307cda3 to 67dd12f8dfca (6 revisions) (#134791) · 18ad09ef

engine-flutter-autoroll authored Sep 16, 2023

https://github.com/flutter/engine/compare/45bc4307cda3...67dd12f8dfca

2023-09-14 skia-flutter-autoroll@skia.org Roll Dart SDK from
d25e8d682c8f to 7e4d9f4d8e52 (3 revisions) (flutter/engine#45854)
2023-09-14 kustermann@google.com Remove @pragma('vm:entry-point')
annotations on members that aren't accessed from C++
(flutter/engine#45697)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 6bc9f5886ddf to
9b7c116ed6c2 (1 revision) (flutter/engine#45853)
2023-09-14 54558023+keyonghan@users.noreply.github.com Switch
linux_android_debug_engine from goma to reclient (flutter/engine#45345)
2023-09-14 54558023+keyonghan@users.noreply.github.com Switch goma to
reclient fro standalone targets (flutter/engine#45804)
2023-09-14 109111084+yaakovschectman@users.noreply.github.com Handle
external window's `WM_CLOSE` in lifecycle manager (flutter/engine#45840)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

18ad09ef

15 Sep, 2023 8 commits

Makes scheme and target optional parameter when getting universal lin… (#134571) · 367203b3

chunhtai authored Sep 15, 2023

â¦k settings

the show build settings xcode command can only accept one of the target or scheme flag. Therefore I make them optional.

367203b3

Dispose layers in test. (#134802) · f629dc87
Polina Cherkasova authored Sep 15, 2023

f629dc87

[Windows_android channels_integration_test] Column -> ListView (#134836) · ec471480

LongCatIsLooong authored Sep 15, 2023

This should fix https://github.com/flutter/flutter/issues/134636. 

The column can get really tall, especially when there's line wrapping. This is the layout on a tablet, so on a motor g4 this column is likely going to overflow.

```
     RenderParagraph#66251 relayoutBoundary=up3
â creator: RichText â Text-[<'status'>] â Column â
â   FutureBuilder<TestStepResult> â Padding â
â   KeyedSubtree-[GlobalKey#0f29e] â _BodyBuilder â MediaQuery â
â   LayoutId-[<_ScaffoldSlot.body>] â CustomMultiChildLayout â
â   _ActionsScope â Actions â â¯
|  parentData: offset=Offset(0.0, 600.0); flex=null; fit=null
```

![flutter_01](https://github.com/flutter/flutter/assets/31859944/5e700d21-3c5e-4990-bfb5-153f44f1c517)

ec471480

moved hello_world_impeller to a 7pro (#134830) · 43260cce

gaaclarke authored Sep 15, 2023

arm64 is necessary for this test

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

43260cce

Speed up native assets target (#134523) · 8ebb8d4f

Daco Harkes authored Sep 15, 2023

Speeds up the native assets target in the backend by

1. changing other targets `gen_dart_plugin_registrant` and
`release_unpack_ios` to do async I/O,
2. not reparsing the package config, and
3. not calling `dart pub deps --json` for 0 or 1 packages (fixed
package:native_assets_builder).

* https://github.com/flutter/flutter/issues/134427

```
           [   +2 ms] native_assets: Starting due to {}
           [   +2 ms] Skipping target: gen_localizations
           [   +1 ms] gen_dart_plugin_registrant: Starting due to {InvalidatedReasonKind.inputChanged: The following inputs have updated contents: /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/package_config_subset}
           [  +33 ms] gen_dart_plugin_registrant: Complete
           [ +107 ms] release_unpack_ios: Complete
           [  +60 ms] Writing native_assets.yaml.
           [   +7 ms] Writing /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/flutter_build/be2692bbfbc0b9a27fcd2422d52354c6/native_assets.yaml done.
           [        ] native_assets: Complete
```

->

```
           [   +4 ms] native_assets: Starting due to {}
           [        ] Skipping target: gen_localizations
           [   +1 ms] gen_dart_plugin_registrant: Starting due to {InvalidatedReasonKind.inputChanged: The following inputs have updated contents: /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/package_config_subset}
           [  +31 ms] Writing native_assets.yaml.
           [   +8 ms] Writing /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/flutter_build/f9451a65a465bfab70d004e21d6cc1d6/native_assets.yaml done.
           [   +1 ms] native_assets: Complete
```

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.


<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

8ebb8d4f

Date picker dialog state should dispose members. (#134804) · 72b69f94
Polina Cherkasova authored Sep 15, 2023

72b69f94

Roll Packages from 275b76ccffa5 to bc8c2f20910b (7 revisions) (#134823) · 0b9551e6

engine-flutter-autoroll authored Sep 15, 2023

https://github.com/flutter/packages/compare/275b76ccffa5...bc8c2f20910b

2023-09-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.6 to 2.21.7 (flutter/packages#4930)
2023-09-14 stuartmorgan@google.com [ios_platform_images] Add extension tests (flutter/packages#4925)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2524052335ec to 367f9ea16bfa (3 revisions) (flutter/packages#4929)
2023-09-14 stuartmorgan@google.com [ci] Enable ios_platform_images tests (flutter/packages#4920)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.5 to 2.21.6 (flutter/packages#4922)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter from 61b890bf to 58ba6c29 (16 revisions) (flutter/packages#4928)
2023-09-14 43054281+camsim99@users.noreply.github.com Manual Roll of Flutter from 4e7a07af to 61b890bf (flutter/packages#4919)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0b9551e6

Fix navigation rail hover misplaced when direction is RTL and extended is true (#134815) · 2a7ad01e

Bruno Leroux authored Sep 15, 2023

## Description

This PR fixes `NavigationRail` hover position when text direction is set to RTL and `NavigationRail.extended` is true.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/134361.

## Tests

Adds 1 test.

2a7ad01e