- 11 Mar, 2024 2 commits
-
-
auto-submit[bot] authored
Reverts: flutter/flutter#144752 Initiated by: andrewkolos Reason for reverting: compilation issue has turned the tree red Original PR Author: andrewkolos Reviewed By: {christopherfujino} This change reverts the following previous change: In service of https://github.com/flutter/flutter/issues/143348 When invoking a package to transform an asset, we set `FLUTTER_BUILD_MODE` to the CLI name of the build mode being used. Inspired by https://github.com/flutter/flutter/issues/101077#issuecomment-1890379501: > Do transformers know whether they get executed in debug or release mode? I kinda imagine that being useful. Ex: There's a transformer that optimizes the file size of images. Depending on the amount and size of the images, that could take a significant amount of time. Therefore, I might want to only execute it in release builds. Note for the reviewer: the interesting part of this change can be found in the commit [set environment variable to build mode when running asset transformer…](https://github.com/flutter/flutter/pull/144752/commits/579912d470b6f6eb036fd6b23a128fa3942f6282). The rest of the change is updating call sites with a new argument.
-
Andrew Kolos authored
In service of https://github.com/flutter/flutter/issues/143348 When invoking a package to transform an asset, we set `FLUTTER_BUILD_MODE` to the CLI name of the build mode being used. Inspired by https://github.com/flutter/flutter/issues/101077#issuecomment-1890379501: > Do transformers know whether they get executed in debug or release mode? I kinda imagine that being useful. Ex: There's a transformer that optimizes the file size of images. Depending on the amount and size of the images, that could take a significant amount of time. Therefore, I might want to only execute it in release builds. Note for the reviewer: the interesting part of this change can be found in the commit [set environment variable to build mode when running asset transformerâ¦](https://github.com/flutter/flutter/pull/144752/commits/579912d470b6f6eb036fd6b23a128fa3942f6282). The rest of the change is updating call sites with a new argument.
-
- 06 Mar, 2024 1 commit
-
-
Andrew Kolos authored
`DevFSBytesContent` (and it's descendant `DevFSStringContent`) have setters that change the underlying content. These are unused outside of tests, so this PR removes them. Amongst other things, this could help me refactor https://github.com/flutter/flutter/pull/144660 into something that has fewer pitfalls. This is purely a refactoring.
-
- 05 Mar, 2024 2 commits
-
-
Andrew Kolos authored
Partial implementation of https://github.com/flutter/flutter/issues/143348 This enables asset transformation during hot reload (except for web, because that has its own implementation of `DevFS` ð). Asset transformers will be reapplied after changing any asset and performing a hot reload during `flutter run`.
-
Andrew Kolos authored
The title says it all. This parameter is unused and serves no apparent purpose.
-
- 23 Feb, 2024 1 commit
-
-
Andrew Kolos authored
In service of https://github.com/flutter/flutter/issues/143348 This will make testing of asset transformation hot reload behavior easier (specifically in that we can avoid having to write a test that looks like this: https://github.com/flutter/flutter/blob/5d02c27248d9ebb0db79547f3ed0fce8060ff041/packages/flutter_tools/test/general.shard/build_system/targets/assets_test.dart#L167-L249
-
- 07 Feb, 2024 1 commit
-
-
Andrew Kolos authored
Resolves #143041
-
- 02 Feb, 2024 1 commit
-
-
Lau Ching Jun authored
Avoid depending on files from build_system/targets other than from top level entrypoints in flutter_tools. (#142760) Add a new `BuildTargets` class that provides commonly used build targets. And avoid importing files from `build_system/targets` except from the top level entrypoints or from top level commands. Also move `scene_importer.dart` and `shader_compiler.dart` into `build_system/tools` because they are not `Target` classes, but wrapper for certain tools. With this change, we can ignore all files in `build_system/targets` internally and make PR #142709 easier to land internally. See cl/603434066 for the corresponding internal change. Related to: https://github.com/flutter/flutter/pull/142709 https://github.com/flutter/flutter/issues/142041 Also note that I have opted to add a new variable in `globals.dart` for `BuildTargets` in this PR, but I know that we are trying to get rid of globals. Several alternatives that I was considering: 1. Add a new field in `BuildSystem` that returns a `BuildTargets` instance. Since `BuildSystem` is already in `globals`, we can access build targets using `globals.buildSystem.buildTargets` without adding a new global variable. 2. Properly inject the `BuildTargetsImpl` instance from the top level `executable.dart` and top level commands. Let me know if you want me to do one of the above instead. Thanks!
-
- 23 Jan, 2024 1 commit
-
-
Andrew Kolos authored
consolidate AssetBundle::entries and AssetBundle::entryKinds into a new type, `AssetBundleEntry` (#142029) Part of work on https://github.com/flutter/flutter/pull/141194 The [`AssetBundle`](https://github.com/flutter/flutter/blob/0833929c997c8a9db11c1e0df9a731ab17b77606/packages/flutter_tools/lib/src/asset.dart#L80) class contains two members, `entries` and `entryKinds`. `entries` contains asset data indexed by asset key. `entryKinds` contains the "kinds" of these assets, again indexed by asset key. **Change.** Rather than have two separate maps, this PR proposes combining these maps into one by wrapping the asset data and kind into a single data type `AssetBundleEntry`. **Purpose.** In https://github.com/flutter/flutter/pull/141194, I am considering associating more information with an asset. In particular, what transformers are meant to be applied to it when copying it to the build output. Rather than adding another map member onto `AssetBundle` (e.g. `entryTransformers`), I decided to make things neater by introducing the `AssetBundleEntry` type.
-
- 10 Aug, 2023 1 commit
-
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/132157
-
- 15 May, 2023 1 commit
-
-
Tomasz Gucio authored
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 23 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes * fix after merge conflicts * review
-
- 10 Jan, 2023 1 commit
-
-
Brandon DeRosier authored
-
- 08 Aug, 2022 1 commit
-
-
Jonah Williams authored
-
- 27 Jul, 2022 1 commit
-
-
Jonah Williams authored
-
- 20 Jul, 2022 1 commit
-
-
Lau Ching Jun authored
-
- 18 Jul, 2022 1 commit
-
-
Christopher Fujino authored
Revert "Read dart_plugin_registrant path from FlutterProject to support non-standard path." (#107850)
-
- 15 Jul, 2022 1 commit
-
-
Lau Ching Jun authored
-
- 15 Jun, 2022 1 commit
-
-
Jonah Williams authored
-
- 22 Feb, 2022 1 commit
-
-
Tomasz Gucio authored
-
- 02 Nov, 2021 1 commit
-
-
jensjoha authored
-
- 08 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 5fd259be.
-
Ian Hickson authored
-
- 02 Oct, 2021 1 commit
-
-
Christopher Fujino authored
-
- 01 Oct, 2021 1 commit
-
-
stuartmorgan authored
Building an application for a desktop platform that transitively included any Dart-based plugins (such as path_provider) broke `flutter test`, because its compilation was overriding the provided main (in this case, the test main) with `generated_main.dart` if it was present. This PR: - Changes the `flutter test` compilation path to update `generated_main.dart`, so that the tests will work, and will include any registered Dart plugins. - Makes using `generated_main.dart` during recompile opt-in, to try to reduce the chance of a similar bug happening with other codepaths in the future. Fixes https://github.com/flutter/flutter/issues/88794
-
- 08 Sep, 2021 1 commit
-
-
Jenn Magder authored
-
- 28 Jun, 2021 1 commit
-
-
Lau Ching Jun authored
-
- 25 Jun, 2021 2 commits
-
-
Lau Ching Jun authored
-
Lau Ching Jun authored
-
- 08 Jun, 2021 1 commit
-
-
Lau Ching Jun authored
-
- 01 Jun, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Apr, 2021 1 commit
-
-
xster authored
-
- 23 Apr, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 23 Mar, 2021 1 commit
-
-
Zachary Anderson authored
* Revert "Enable dart_plugin_registry_test (#76645)" This reverts commit 109e0bb9. * Revert "Apply changes caused by https://github.com/flutter/flutter/pull/76662 (#77093)" This reverts commit cdca6485. * Revert "Disable clang format in the plugin registrants (#76662)" This reverts commit dadbd47d. * Revert "Disable warnings for the dart plugin registrant (#76561)" This reverts commit 098ece52. * Revert "Remove dart_plugin_registry_test timeouts (#76838)" This reverts commit 1610a274. * Revert "Implement dartPluginClass support for plugins (#74469)" This reverts commit b7d48062. Kick.
-
- 24 Feb, 2021 1 commit
-
-
Jonah Williams authored
-
- 19 Feb, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 27 Jan, 2021 1 commit
-
-
Jonah Williams authored
* opt out the flutter tool * oops EOF * fix import * Update tool_backend.dart * Update daemon_client.dart * fix more
-
- 25 Jan, 2021 1 commit
-
-
Jenn Magder authored
-