Commits · 55c988fb453eddd97cb2e4d6df9ec28d72e2e899 · abdullh.alsoleman / Front-End

28 Apr, 2023 1 commit

Roll Flutter Engine from 3d61e293cb96 to 1d25906b4cf0 (1 revision) (#125658) · 55c988fb

engine-flutter-autoroll authored Apr 28, 2023

https://github.com/flutter/engine/compare/3d61e293cb96...1d25906b4cf0

2023-04-27 skia-flutter-autoroll@skia.org Roll Skia from f7c8a58c2127 to 05d09f28250a (4 revisions) (flutter/engine#41557)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

55c988fb

27 Apr, 2023 22 commits

Increase Xcode minimum version to 14 (#125639) · 6b73885e

Jenn Magder authored Apr 27, 2023

Looks like CocoaPods 1.12.1 is incompatible with < Xcode 14 due to https://github.com/CocoaPods/CocoaPods/pull/11828 (see https://github.com/flutter/flutter/issues/123890 for context).

Bump the minimum Xcode version allowed by tooling to 14, released September 2022.

```
[!] Xcode - develop for iOS and macOS (Xcode 13.4)
    â Flutter requires Xcode 14 or higher.
      Download the latest version or update via the Mac App Store.
```

Fixes https://github.com/flutter/flutter/issues/125286.
Previous bump at #97746.

6b73885e

Add migrator to upgrade gradle version when conflict with Android Studio... · eba2a520

gmackall authored Apr 27, 2023

Add migrator to upgrade gradle version when conflict with Android Studio bundled Java version is detected (#124085)

This PR adds an android project migrator that checks the version of android studio and the version of gradle for conflicts, and upgrades to 7.4 if a conflict is detected. For more detail about the particular conflict, see https://github.com/flutter/flutter/issues/122376.

The PR also upgrades older gradle versions being used in integration testing to 7.4.

Fixes/related to: https://github.com/flutter/flutter/issues/122376 and https://github.com/flutter/flutter/issues/123636

eba2a520

Update dartdoc to v6.2.2. (#125650) · fb36bba3

Janice Collins authored Apr 27, 2023

This PR updates the dartdoc version to v6.2.2.

Release notes:  https://github.com/dart-lang/dartdoc/releases/tag/v6.2.2

The main impact for Flutter is to update dartdoc to add chips to class and/or mixin pages for class modifiers.  See dart-lang/dartdoc#3391, dart-lang/dartdoc#3402.   This will also be a cherry-pick candidate for 3.1 if it can land in time.

- [ test-exempt ] I added new tests to check the change I am making, or this PR is [test-exempt].

fb36bba3

Add `slider_perf_android` task to `ci.yaml` (#125540) · 746cacc5

Taha Tesser authored Apr 27, 2023

This adds `devicelab` task `slider_perf_android` to `.ci.yaml`, which was added in https://github.com/flutter/flutter/pull/125296

746cacc5

Roll Flutter Engine from 883bb7d5cb28 to 3d61e293cb96 (1 revision) (#125645) · 215fa355

engine-flutter-autoroll authored Apr 27, 2023

https://github.com/flutter/engine/compare/883bb7d5cb28...3d61e293cb96

2023-04-27 skia-flutter-autoroll@skia.org Roll Skia from 8441d7a93942 to f7c8a58c2127 (10 revisions) (flutter/engine#41556)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

215fa355

[flutter_tools] more debugging for timeouts in break_on_framework_exceptions test (#125584) · 4ff505c8

Christopher Fujino authored Apr 27, 2023

Better debugging to investigate: https://github.com/flutter/flutter/issues/125241

When the `test/integration.shard/break_on_framework_exceptions_test.dart` test times out, log out verbose logging to give clues as to why it did not complete.

From one local run it looks like the test runner is failing to load a test file (when I checked the path locally, the file was there, and re-running the `flutter test ...` invocation succeeded--in that the app threw an exception):

```
14:12 +26 -1: breaks when StatefulWidget.build throws [E]
  Timed out launching `flutter test`
  package:matcher                                                        fail
  test/integration.shard/break_on_framework_exceptions_test.dart 623:11  _timeoutAfter.<fn>

250s            Spawning flutter [test, --disable-service-auth-codes, --machine, --start-paused, test/test.dart] in /tmp/flutter_break_on_framework_exceptions.GUJDAZ

251s <=stdout=  {"protocolVersion":"0.1.1","runnerVersion":null,"pid":25763,"type":"start","time":0}

<=stdout=  {"suite":{"id":0,"platform":"vm","path":"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart"},"type":"suite","time":0}

<=stdout=  {"test":{"id":1,"name":"loading /tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","suiteID":0,"groupIDs":[],"metadata":{"skip":false,"skipReason":null},"line":null,"column":null,"url":null},"type":"testStart","time":0}

258s <=stdout=  {"testID":1,"error":"Exception: the Dart compiler exited unexpectedly.","stackTrace":"package:flutter_tools/src/base/common.dart 10:3  throwToolExit\npackage:flutter_tools/src/compile.dart 813:13    DefaultResidentCompiler._compile.<fn>\ndart:async/zone.dart 1391:47                     _rootRun\ndart:async/zone.dart 1301:19                     _CustomZone.run\ndart:async/zone.dart 1209:7                      _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13               _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7                _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7                _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11        _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11        _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11       _StringAdapterSink.close\ndart:convert/line_splitter.dart 141:11           _LineSplitterSink.close\ndart:async/stream_transformers.dart 132:24       _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47                     _rootRun\ndart:async/zone.dart 1301:19                     _CustomZone.run\ndart:async/zone.dart 1209:7                      _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13               _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7                _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7                _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11        _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11        _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11       _StringAdapterSink.close\ndart:convert/string_conversion.dart 295:20       _Utf8ConversionSink.close\ndart:convert/chunked_conversion.dart 78:18       _ConverterStreamEventSink.close\ndart:async/stream_transformers.dart 132:24       _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47                     _rootRun\ndart:async/zone.dart 1301:19                     _CustomZone.run\ndart:async/zone.dart 1209:7                      _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13               _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7                _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart...

<=stdout=  {"testID":1,"error":"Failed to load \"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart\": Compilation failed for testPath=/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","stackTrace":"","isFailure":false,"type":"error","time":7518}

<=stdout=  {"testID":1,"result":"error","skipped":false,"hidden":false,"type":"testDone","time":7521}

<=stdout=  {"count":1,"time":7526,"type":"allSuites"}

<=stdout=  {"success":false,"type":"done","time":7529}

259s            Process exited (1)

371s            Expecting test.startedProcess event
[+    95] <=stdout=  {"suite":{"id":0,"platform":"vm","path":"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart"},"type":"suite","time":0}
[+    95] <=stdout=  {"test":{"id":1,"name":"loading /tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","suiteID":0,"groupIDs":[],"metadata":{"skip":false,"skipReason":null},"line":null,"column":null,"url":null},"type":"testStart","time":0}
[+  7600] <=stdout=  {"testID":1,"error":"Exception: the Dart compiler exited unexpectedly.","stackTrace":"package:flutter_tools/src/base/common.dart 10:3  throwToolExit\npackage:flutter_tools/src/compile.dart 813:13    DefaultResidentCompiler._compile.<fn>\ndart:async/zone.dart 1391:47                     _rootRun\ndart:async/zone.dart 1301:19                     _CustomZone.run\ndart:async/zone.dart 1209:7                      _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13               _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7                _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7                _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11        _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11        _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11       _StringAdapterSink.close\ndart:convert/line_splitter.dart 141:11           _LineSplitterSink.close\ndart:async/stream_transformers.dart 132:24       _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47                     _rootRun\ndart:async/zone.dart 1301:19                     _CustomZone.run\ndart:async/zone.dart 1209:7                      _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13               _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7                _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7                _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11        _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11        _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11       _StringAdapterSink.close\ndart:convert/string_conversion.dart 295:20       _Utf8ConversionSink.close\ndart:convert/chunked_conversion.dart 78:18       _ConverterStreamEventSink.close\ndart:async/stream_transformers.dart 132:24...

Expecting test.startedProcess event is taking longer than usual...
```

4ff505c8

Roll Flutter Engine from 3d6d915cb74a to 883bb7d5cb28 (1 revision) (#125641) · 84e8d498

engine-flutter-autoroll authored Apr 27, 2023

https://github.com/flutter/engine/compare/3d6d915cb74a...883bb7d5cb28

2023-04-27 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.2.11 to 2.3.1 (flutter/engine#41553)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

84e8d498

Mark module_test_ios tests unflaky (#125498) · 28e17177

Jenn Magder authored Apr 27, 2023

[Dart workaround](https://dart-review.googlesource.com/c/sdk/+/297821 ) to prevent the flake has rolled into the framework.  Mark the tests unflaky so we can detect if it happens again when a fix for the underlying issue lands.

https://github.com/flutter/flutter/issues/125425#issuecomment-1522142360

Reverts https://github.com/flutter/flutter/pull/125426

28e17177

Roll Flutter Engine from 381f714972d8 to 3d6d915cb74a (1 revision) (#125637) · ea179fe0

engine-flutter-autoroll authored Apr 27, 2023

https://github.com/flutter/engine/compare/381f714972d8...3d6d915cb74a

2023-04-27 103135467+sealesj@users.noreply.github.com Refactor vuln scan into separate yaml (flutter/engine#41528)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ea179fe0

Bump the default minSdkVersion to 19 (#125515) · fc209836

Dan Field authored Apr 27, 2023

See https://docs.flutter.dev/reference/supported-platforms

I don't expect this to break anything, but if it does we can revert and figure out what else needs to happen first.

Without this change, engine changes upstream will get flagged in default flutter created apps.

fc209836

Fix `SnackBar` material clip (#125622) · 18e36dcb

Taha Tesser authored Apr 27, 2023

fixes https://github.com/flutter/flutter/issues/125619

### Before

![Screenshot 2023-04-27 at 14 08 05](https://user-images.githubusercontent.com/48603081/234853490-0a9c4e18-20aa-40f7-a6b0-efb278f515eb.png)

### After

![Screenshot 2023-04-27 at 14 00 44](https://user-images.githubusercontent.com/48603081/234853470-c69c20d3-124d-438a-9312-2d17492c5606.png)

18e36dcb

Roll Flutter Engine from 968413585768 to 381f714972d8 (1 revision) (#125634) · 4dbeb3fb

engine-flutter-autoroll authored Apr 27, 2023

https://github.com/flutter/engine/compare/968413585768...381f714972d8

2023-04-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 497a81b1af4f to c7160d4ea0b7 (1 revision) (flutter/engine#41550)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4dbeb3fb

fix: `moreOrLessEquals` does not allow `actual` to be integers (#125599) · 37c95a28
fzyzcjy authored Apr 27, 2023
```
Close https://github.com/flutter/flutter/issues/125600
```
37c95a28

Roll Flutter Engine from 79237ad14354 to 968413585768 (1 revision) (#125631) · b359f110

engine-flutter-autoroll authored Apr 27, 2023

https://github.com/flutter/engine/compare/79237ad14354...968413585768

2023-04-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Du6g64Nirs3tZVK6i... to Rk2iPE0_H1vjuGV4e... (flutter/engine#41551)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Du6g64Nirs3t to Rk2iPE0_H1vj

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b359f110

Provide default constraints for M3 bottom sheets (#120065) · 1f602cb6

Pierre-Louis authored Apr 27, 2023

This PR constrains M3 bottom sheets to 640dp max width by default.
`constraints` can be used to provide different `minWidth` and
`maxWidth`.

This is not a breaking change per the breaking change policy.

Part of https://github.com/flutter/flutter/issues/118619
Part of https://github.com/flutter/flutter/issues/111448

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

1f602cb6

Roll Flutter Engine from 99b7fc1aa5b0 to 79237ad14354 (1 revision) (#125606) · 9a68bffb

engine-flutter-autoroll authored Apr 27, 2023

https://github.com/flutter/engine/compare/99b7fc1aa5b0...79237ad14354

2023-04-27 jonahwilliams@google.com Reland: [Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend. (flutter/engine#41538)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9a68bffb

Roll Flutter Engine from d9f91aadffd4 to 99b7fc1aa5b0 (1 revision) (#125604) · 14596334

engine-flutter-autoroll authored Apr 27, 2023

https://github.com/flutter/engine/compare/d9f91aadffd4...99b7fc1aa5b0

2023-04-27 jonahwilliams@google.com [Impeller] allow shader read for root resolve texture (flutter/engine#41543)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

14596334

Roll Flutter Engine from 689eb6ee9047 to d9f91aadffd4 (1 revision) (#125602) · fdd6b876

engine-flutter-autoroll authored Apr 27, 2023

https://github.com/flutter/engine/compare/689eb6ee9047...d9f91aadffd4

2023-04-27 skia-flutter-autoroll@skia.org Roll Skia from 3b14dcad64ef to 8441d7a93942 (1 revision) (flutter/engine#41542)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fdd6b876

tools: Drop unused function (#125590) · 9565892a
Kevin Moore authored Apr 27, 2023
```
Internal usage dropped in http://cl/527348621
```
9565892a

Roll Flutter Engine from 19045bb99c7a to 689eb6ee9047 (2 revisions) (#125598) · 3d250495

engine-flutter-autoroll authored Apr 27, 2023

https://github.com/flutter/engine/compare/19045bb99c7a...689eb6ee9047

2023-04-27 godofredoc@google.com reland "Migrate mac_host_engine to
engine v2 builds." (flutter/engine#41531)
2023-04-27 zanderso@users.noreply.github.com Roll buildroot to
5708f2051772fd02c949e5dc9397e54f8c7a4478 (flutter/engine#41540)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3d250495

Roll Flutter Engine from d4ca5240da52 to 19045bb99c7a (3 revisions) (#125595) · 4fb146e6

engine-flutter-autoroll authored Apr 27, 2023

https://github.com/flutter/engine/compare/d4ca5240da52...19045bb99c7a

2023-04-27 skia-flutter-autoroll@skia.org Roll Skia from d315ab065af3 to 3b14dcad64ef (1 revision) (flutter/engine#41539)
2023-04-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 3d444bc30fc4 to 497a81b1af4f (1 revision) (flutter/engine#41537)
2023-04-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from rM9DAwmAeMc8pV11x... to Du6g64Nirs3tZVK6i... (flutter/engine#41536)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from rM9DAwmAeMc8 to Du6g64Nirs3t

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4fb146e6

Roll Flutter Engine from cf975417ce40 to d4ca5240da52 (11 revisions) (#125593) · e454644d

engine-flutter-autoroll authored Apr 27, 2023

https://github.com/flutter/engine/compare/cf975417ce40...d4ca5240da52

2023-04-27 skia-flutter-autoroll@skia.org Roll Skia from 20a1c61c5597 to
d315ab065af3 (5 revisions) (flutter/engine#41535)
2023-04-26 jonahwilliams@google.com Revert "[Impeller] Use a device
buffer for SkBitmap allocation, use Linear texture on Metal backend."
(flutter/engine#41533)
2023-04-26 xilaizhang@google.com [codesign] Add pinned xcode version as
property to mac android aot engine (flutter/engine#41518)
2023-04-26 bdero@google.com [Impeller] Coerce opaque ColorSourceContents
to Source (flutter/engine#41525)
2023-04-26 skia-flutter-autoroll@skia.org Roll Skia from 3fea88565a83 to
20a1c61c5597 (3 revisions) (flutter/engine#41530)
2023-04-26 jonahwilliams@google.com [Impeller] partial repaint for
Impeller/iOS. (flutter/engine#40959)
2023-04-26 30870216+gaaclarke@users.noreply.github.com Updated todo with
github issue link (flutter/engine#41517)
2023-04-26 skia-flutter-autoroll@skia.org Roll Clang from 20d06c833d83
to 5344d8e10bb7 (flutter/engine#41524)
2023-04-26 jonahwilliams@google.com [Impeller] Use a device buffer for
SkBitmap allocation, use Linear texture on Metal backend.
(flutter/engine#41374)
2023-04-26 zanderso@users.noreply.github.com Manual clang roll to
5344d8e10bb7d8672d4bfae8adb010465470d51b (flutter/engine#41520)
2023-04-26 zanderso@users.noreply.github.com Download and use the goma
client from cipd (flutter/engine#41488)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e454644d

26 Apr, 2023 17 commits

Revert "Roll Flutter Engine from cf975417ce40 to fddd5add8b62 (3 revisions)" (#125588) · b3f3a032
Jonah Williams authored Apr 26, 2023
```
Reverts flutter/flutter#125583

Reverting to fix tree breakage caused by https://github.com/flutter/engine/pull/41533/files
```
b3f3a032

Roll Flutter Engine from cf975417ce40 to fddd5add8b62 (3 revisions) (#125583) · 2dda1297

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/cf975417ce40...fddd5add8b62

2023-04-26 jonahwilliams@google.com [Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend. (flutter/engine#41374)
2023-04-26 zanderso@users.noreply.github.com Manual clang roll to 5344d8e10bb7d8672d4bfae8adb010465470d51b (flutter/engine#41520)
2023-04-26 zanderso@users.noreply.github.com Download and use the goma client from cipd (flutter/engine#41488)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2dda1297

Remove flavors_test_macos (#125581) · 1d30a1fc

Zachary Anderson authored Apr 26, 2023

This test has been failing for the past >1000 runs, and is wedging a bot
for 30 minutes as the failure mode is a timeout.

Fixes https://github.com/flutter/flutter/issues/119782

1d30a1fc

Roll Flutter Engine from f2882afe0ec3 to cf975417ce40 (4 revisions) (#125578) · 06a6ba96

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/f2882afe0ec3...cf975417ce40

2023-04-26 godofredoc@google.com Migrate Windows AOT Engine to Engine
V2. (flutter/engine#41515)
2023-04-26 bdero@google.com [Impeller] Store the root stencil on iOS
(flutter/engine#41509)
2023-04-26 bdero@google.com [Impeller] iOS/macOS: Only wait for command
scheduling prior to present (redux) (flutter/engine#41501)
2023-04-26 30870216+gaaclarke@users.noreply.github.com [Impeller]
removed collisions of dead command pools between tests.
(flutter/engine#41490)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

06a6ba96

Roll Flutter Engine from 40187bb9afac to f2882afe0ec3 (1 revision) (#125576) · b03d6d65

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/40187bb9afac...f2882afe0ec3

2023-04-26 skia-flutter-autoroll@skia.org Roll Skia from a0e3fa5aa947 to 3fea88565a83 (3 revisions) (flutter/engine#41516)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b03d6d65

Refactor "gen-l10n" command to use same code path when "l10n.yaml" is present... · 5c44b1df

Tae Hyung Kim authored Apr 26, 2023

Refactor "gen-l10n" command to use same code path when "l10n.yaml" is present or not present (#125429)

I think this is a long needed change to the `gen-l10n` command.
Essentially, the arguments to `flutter gen-l10n` can be provided by two
different methods: via command line arguments or via the `l10n.yaml`
file. The existence of a `l10n.yaml` file causes the latter approach to
take precedence.

However, currently, there's several differences in how the two
approaches are handled, and most of the default arguments are all over
the place, causing unexpected issues such as #120457 or #120023.

This PR refactors the command so that
* `LocalizationOptions` are more consistent with the actual argument
names/yaml options.
* All default values are determined in `LocalizationOptions`'s
constructor (or in `argParser.addOption(...)` in the case a boolean
value needs to be explicitly true).
* New `parseLocalizationsOptionsFromCommand` function to parse
arguments.
* Parse `LocalizationOptions` at the beginning of `runCommand()` and
pass it to `generateLocalizations`.

Fixes #120023.

5c44b1df

Roll Flutter Engine from f125a54f5a57 to 40187bb9afac (1 revision) (#125566) · 89c76989

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/f125a54f5a57...40187bb9afac

2023-04-26 skia-flutter-autoroll@skia.org Roll Skia from 47cfc5a2f0a0 to a0e3fa5aa947 (1 revision) (flutter/engine#41514)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

89c76989

Remove web compile benchmarks that specify an attached device (#125559) · 66fa4c5d
Zachary Anderson authored Apr 26, 2023
```
Fixes https://github.com/flutter/flutter/issues/125492
```
66fa4c5d

Roll Flutter Engine from f75908135e10 to f125a54f5a57 (1 revision) (#125560) · c9d7bed4

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/f75908135e10...f125a54f5a57

2023-04-26 skia-flutter-autoroll@skia.org Roll Dart SDK from b0dacad08d62 to 3d444bc30fc4 (1 revision) (flutter/engine#41513)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c9d7bed4

Roll Flutter Engine from c9db1587f207 to f75908135e10 (1 revision) (#125558) · b0ae2e81

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/c9db1587f207...f75908135e10

2023-04-26 skia-flutter-autoroll@skia.org Roll Skia from 5085ba92075b to 47cfc5a2f0a0 (4 revisions) (flutter/engine#41512)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b0ae2e81

Roll Flutter Engine from 58a5a1e3f2c1 to c9db1587f207 (1 revision) (#125555) · 00d231c0

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/58a5a1e3f2c1...c9db1587f207

2023-04-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JKHSUjf-qEr0ZMdEi... to rM9DAwmAeMc8pV11x... (flutter/engine#41511)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from JKHSUjf-qEr0 to rM9DAwmAeMc8

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

00d231c0

Roll Flutter Engine from 321f8015b9c2 to 58a5a1e3f2c1 (1 revision) (#125552) · 709d431f

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/321f8015b9c2...58a5a1e3f2c1

2023-04-26 skia-flutter-autoroll@skia.org Roll Dart SDK from f9d4d255c6e7 to b0dacad08d62 (4 revisions) (flutter/engine#41510)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

709d431f

Roll Flutter Engine from 87f5f4e939cf to 321f8015b9c2 (1 revision) (#125549) · 11734dd9

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/87f5f4e939cf...321f8015b9c2

2023-04-26 jiahaog@users.noreply.github.com Log dlopen errors in opt builds (flutter/engine#41477)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

11734dd9

Update prefer_final_parameters comment (#125465) · f6b9c4da
Michael Goderbauer authored Apr 26, 2023
```
Per discusion in https://github.com/flutter/flutter/pull/125061.
```
f6b9c4da

Roll Flutter Engine from 706c023df44b to 87f5f4e939cf (1 revision) (#125539) · 14be1af7

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/706c023df44b...87f5f4e939cf

2023-04-26 skia-flutter-autoroll@skia.org Roll Skia from 0f3c8eaf60b2 to 5085ba92075b (1 revision) (flutter/engine#41504)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

14be1af7

Roll Flutter Engine from 7b385abd18a2 to 706c023df44b (1 revision) (#125536) · 75dd5da9

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/7b385abd18a2...706c023df44b

2023-04-26 dnfield@google.com Roll vulkan-deps and vs_toolchain (flutter/engine#41455)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

75dd5da9

Roll Flutter Engine from 610c57781b47 to 7b385abd18a2 (1 revision) (#125533) · b379af8b

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/610c57781b47...7b385abd18a2

2023-04-26 skia-flutter-autoroll@skia.org Roll Skia from 22132575fceb to 0f3c8eaf60b2 (1 revision) (flutter/engine#41499)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b379af8b