Commits · 55528ba1b77e0c531c3ceefad995dcccc33f2a5a · abdullh.alsoleman / Front-End

26 Mar, 2024 2 commits

Roll Flutter Engine from 3c881b75cc28 to b2d93a64cbc7 (1 revision) (#145759) · 55528ba1

engine-flutter-autoroll authored Mar 26, 2024

https://github.com/flutter/engine/compare/3c881b75cc28...b2d93a64cbc7

2024-03-26 58529443+srujzs@users.noreply.github.com Change JSBoxedDartObject to JSAny (flutter/engine#51634)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

55528ba1

Roll Flutter Engine from b2001fa6d773 to 3c881b75cc28 (1 revision) (#145733) · a8345d53

engine-flutter-autoroll authored Mar 26, 2024

https://github.com/flutter/engine/compare/b2001fa6d773...3c881b75cc28

2024-03-25 zanderso@users.noreply.github.com Revert "Disable cleaning up ImageReaders in memory pressure callback" (flutter/engine#51665)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a8345d53

25 Mar, 2024 22 commits

Roll Flutter Engine from 5fc95a3277ea to b2001fa6d773 (1 revision) (#145730) · bc9e789e

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/engine/compare/5fc95a3277ea...b2001fa6d773

2024-03-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ySBsQPn-0UgTQaXIw... to uu8lffXkeJQ9PC96I... (flutter/engine#51660)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ySBsQPn-0UgT to uu8lffXkeJQ9

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bc9e789e

Fix `SearchAnchor` triggers unnecessary suggestions builder calls (#143443) · 8363e782

Taha Tesser authored Mar 25, 2024

fixes [`SearchAnchor` triggers extra search operations](https://github.com/flutter/flutter/issues/139880)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

Future<List<String>> createFuture() async {
  return List.generate(1000, (index) => "Hello World!");
}

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      title: 'Flutter Demo',
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  final SearchController controller = SearchController();

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            SearchAnchor(
              searchController: controller,
              suggestionsBuilder: (suggestionsContext, controller) {
                final resultFuture = createFuture();
                return [
                  FutureBuilder(
                    future: resultFuture,
                    builder: ((context, snapshot) {
                      if (snapshot.connectionState != ConnectionState.done) {
                        return const LinearProgressIndicator();
                      }
                      final result = snapshot.data;
                      if (result == null) {
                        return const LinearProgressIndicator();
                      }
                      return ListView.builder(
                        shrinkWrap: true,
                        physics: const NeverScrollableScrollPhysics(),
                        itemCount: result.length,
                        itemBuilder: (BuildContext context, int index) {
                          final root = result[index];
                          return ListTile(
                            leading: const Icon(Icons.article),
                            title: Text(root),
                            subtitle: Text(
                              root,
                              overflow: TextOverflow.ellipsis,
                              style: TextStyle(
                                color: Theme.of(suggestionsContext)
                                    .colorScheme
                                    .onSurfaceVariant,
                              ),
                            ),
                            onTap: () {},
                          );
                        },
                      );
                    }),
                  ),
                ];
              },
              builder: (BuildContext context, SearchController controller) {
                return IconButton(
                  onPressed: () {
                    controller.openView();
                  },
                  icon: const Icon(Icons.search),
                );
              },
            ),
          ],
        ),
      ),
    );
  }
}

```

</details>

### Before

https://github.com/flutter/flutter/assets/48603081/69f6dfdc-9f92-4d2e-8a3e-984fce25f9e4

### After

https://github.com/flutter/flutter/assets/48603081/be105e2c-51d8-4cb0-a75b-f5f41d948e5e

8363e782

Refactor add_to_app_life_cycle_tests (#145546) · 2832611d

Jesse authored Mar 25, 2024

Refactor add_to_app_life_cycle_tests in order to reduce testing logic in test.dart, create a suite_runners directory and allow for later implementing package:test onto add_to_app_life_cycle_tests

Part of https://github.com/flutter/flutter/issues/145482

2832611d

Roll Flutter Engine from 04191a122e9a to 5fc95a3277ea (3 revisions) (#145722) · b05937d3

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/engine/compare/04191a122e9a...5fc95a3277ea

2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from 625d04f3a7c5 to 7ffd936a66df (7 revisions) (flutter/engine#51657)
2024-03-25 lauren@selfisekai.rocks font_subset tests: name correct variant in exception (flutter/engine#51492)
2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from 8a587a10323f to 625d04f3a7c5 (5 revisions) (flutter/engine#51655)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b05937d3

Fix vertical `Stepper` draws connector on the last step (#145703) · 5e19b335

Taha Tesser authored Mar 25, 2024

fixes [Vertical stepper shows line after last step](https://github.com/flutter/flutter/issues/144376)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: Center(
          child: Stepper(
            currentStep: 1,
            steps: const <Step>[
              Step(
                title: Text("Step 1"),
                content: Text("Content 1"),
              ),
              Step(
                title: Text("Step 2"),
                content: Text("Content 2"),
              ),
            ],
          ),
        ),
      ),
    );
  }
}
```

</details>

### Before

![Screenshot 2024-03-25 at 18 36 32](https://github.com/flutter/flutter/assets/48603081/af859a88-7ec8-4432-8eec-f8eb72706b57)

### After
![Screenshot 2024-03-25 at 18 36 24](https://github.com/flutter/flutter/assets/48603081/994325b2-4bd4-44ef-9473-245d3492faf7)

5e19b335

Update links in analysis_options.yaml (#145706) · 330a2ca2

Michael Goderbauer authored Mar 25, 2024

According to the [readme](https://github.com/dart-lang/linter?tab=readme-ov-file#repository-has-moved) of the linter repository, the source of truth for the linter has moved to the SDK repository. This updates the link to `all.yaml` in our file.

While I am in here, I also updated two other links that were outdated.

330a2ca2

Add a `--print-dtd` flag to print the DTD address served by DevTools server (#144272) · 31f4f2b6
Kenzie Davisson authored Mar 25, 2024

31f4f2b6

Roll Flutter Engine from ef896e942f44 to 04191a122e9a (1 revision) (#145709) · dbdcead9

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/engine/compare/ef896e942f44...04191a122e9a

2024-03-25 jonahwilliams@google.com [Impeller] fix unbalanced restores. (flutter/engine#51648)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dbdcead9

Update semantics.dart (#145683) · 9fa731dd
Ikko Eltociear Ashimine authored Mar 25, 2024
```
loosing -> losing
```
9fa731dd
TwoDimensionalChildDelegate should dispatch creation and disposal events (#145684) · 453a04d9
Kostia Sokolovskyi authored Mar 25, 2024

453a04d9
Memory leaks clean up 1 (#145691) · 47bfa827
Kostia Sokolovskyi authored Mar 25, 2024

47bfa827

Roll Flutter Engine from 2e8d77dbb0f0 to ef896e942f44 (1 revision) (#145705) · 2dd27648

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/engine/compare/2e8d77dbb0f0...ef896e942f44

2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from e7ae039f5b1b to 8a587a10323f (1 revision) (flutter/engine#51654)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2dd27648

[Fix]: Searchbar doesn't lose focus when tapped outside (#145232) · a9f18b80

Sahil Kachhap authored Mar 25, 2024

Added a Fix to search bar that allows it be unfocused when tapped anywhere outside the search bar.

I have attached below the app flow after implementing the fix.

https://github.com/flutter/flutter/assets/54017876/70915c47-9b77-4a43-a128-8706107f921f

Issue that gets resolved by this fix: #145096

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

a9f18b80

Fix typo in hitTest docs (#145677) · 2851ed32
Kostia Sokolovskyi authored Mar 25, 2024
```
This PR fixes the typo in the `hitTest` method documentation.
```
2851ed32

Roll Packages from 611aea1657fb to 28d126c54c63 (1 revision) (#145690) · b39660df

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/packages/compare/611aea1657fb...28d126c54c63

2024-03-25 engine-flutter-autoroll@skia.org Roll Flutter from 18340ea1 to 14774b95 (20 revisions) (flutter/packages#6376)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b39660df

[deps] Bump native assets dependencies (#145612) · baa54fdd

Daco Harkes authored Mar 25, 2024

Roll of a bunch of breaking changes from the native_assets_builder and
native_assets_cli upstream. Most notably:

* https://github.com/dart-lang/native/pull/946
* https://github.com/dart-lang/native/pull/1018
* https://github.com/dart-lang/native/pull/1019

This PR also updates the template in `flutter create
--template=package_ffi` to use the rewritten API.

This PR does not change any functionality in Flutter.

For reference, the same roll in the Dart SDK:

* https://dart-review.googlesource.com/c/sdk/+/357605
* https://dart-review.googlesource.com/c/sdk/+/357623

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

baa54fdd

Roll Flutter Engine from 857584c458ff to 2e8d77dbb0f0 (1 revision) (#145678) · 280037f6

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/engine/compare/857584c458ff...2e8d77dbb0f0

2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from e6dc16a6d82d to e7ae039f5b1b (1 revision) (flutter/engine#51653)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

280037f6

Add `AnimationStyle` to `showBottomSheet` and `showModalBottomSheet` (#145536) · 23687c52

Taha Tesser authored Mar 25, 2024

fixes [Introduce animation customizable with `AnimationStyle` to `BottomSheet`](https://github.com/flutter/flutter/issues/145532)

### Default bottom sheet animation
![00-ezgif com-video-to-gif-converter](https://github.com/flutter/flutter/assets/48603081/a295b002-b310-4dea-8bc4-23b1d299748c)

### Custom bottom sheet animation
![01-ezgif com-video-to-gif-converter](https://github.com/flutter/flutter/assets/48603081/8c5c3d5f-e67d-4ed5-880d-f17d262087e1)

### No bottom sheet animation
![02-ezgif com-video-to-gif-converter](https://github.com/flutter/flutter/assets/48603081/872409d8-8a8d-4db9-b95b-7f96a62cdffc)

23687c52

Roll Flutter Engine from ae758d54630d to 857584c458ff (2 revisions) (#145673) · 62adaff8

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/engine/compare/ae758d54630d...857584c458ff

2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from 7f2e8320bbfe to e6dc16a6d82d (1 revision) (flutter/engine#51652)
2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from df5d7a960d34 to 7f2e8320bbfe (1 revision) (flutter/engine#51651)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

62adaff8

Roll Flutter Engine from efdde39a2a57 to ae758d54630d (1 revision) (#145669) · 7f06c263

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/engine/compare/efdde39a2a57...ae758d54630d

2024-03-25 skia-flutter-autoroll@skia.org Roll Skia from fa486cd8b2d0 to df5d7a960d34 (1 revision) (flutter/engine#51650)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7f06c263

make hot reload reflect changes to asset transformer configurations (#144660) · cd785544

Andrew Kolos authored Mar 25, 2024

In service of https://github.com/flutter/flutter/issues/143348

This PR makes hot reloads reflect changes to transformer configurations under the `assets` section in pubspec.yaml.
This PR is optimized for ease of implementation, and should not be merged as-is. If it is merged as-is, seriously consider creating a tech debt issue and assigning it to someone to make sure it gets resolved.

cd785544

Roll Flutter Engine from 0734f47f2a3d to efdde39a2a57 (2 revisions) (#145668) · a5cf4191

engine-flutter-autoroll authored Mar 25, 2024

https://github.com/flutter/engine/compare/0734f47f2a3d...efdde39a2a57

2024-03-25 robert.ancell@canonical.com Add fl_standard_method_codec_new_with_message_codec() (flutter/engine#51599)
2024-03-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from IPZvFWIGJFJnJ409e... to ySBsQPn-0UgTQaXIw... (flutter/engine#51649)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from IPZvFWIGJFJn to ySBsQPn-0UgT

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a5cf4191

24 Mar, 2024 5 commits

Roll Flutter Engine from 7c139e0a4897 to 0734f47f2a3d (1 revision) (#145662) · 52dc43f3

engine-flutter-autoroll authored Mar 24, 2024

https://github.com/flutter/engine/compare/7c139e0a4897...0734f47f2a3d

2024-03-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 88f531b19ed5 to a783a4a043ec (1 revision) (flutter/engine#51647)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

52dc43f3

Leak clean up. (#144803) · 9fee27b2

Polina Cherkasova authored Mar 24, 2024

Fix some leaks and mark others.

[Known leaks](https://github.com/issues?q=is%3Aopen+is%3Aissue+label%3A%22a%3A+leak+tracking%22+-label%3A%22c%3A+new+feature%22+)

9fee27b2

Turn off randomization for leak detection bots. (#145624) · e10049b2
Polina Cherkasova authored Mar 24, 2024

e10049b2

Roll Flutter Engine from 2f5afdf62365 to 7c139e0a4897 (1 revision) (#145655) · 33739617

engine-flutter-autoroll authored Mar 24, 2024

https://github.com/flutter/engine/compare/2f5afdf62365...7c139e0a4897

2024-03-24 skia-flutter-autoroll@skia.org Roll Skia from 755ca0094a77 to fa486cd8b2d0 (2 revisions) (flutter/engine#51646)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

33739617

Roll Flutter Engine from 7aa8521e640e to 2f5afdf62365 (2 revisions) (#145651) · d8854fd8

engine-flutter-autoroll authored Mar 24, 2024

https://github.com/flutter/engine/compare/7aa8521e640e...2f5afdf62365

2024-03-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 567a19adbe9a to 88f531b19ed5 (1 revision) (flutter/engine#51644)
2024-03-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from _uuBNUJ6KbprCDWmC... to IPZvFWIGJFJnJ409e... (flutter/engine#51643)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from _uuBNUJ6Kbpr to IPZvFWIGJFJn

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d8854fd8

23 Mar, 2024 11 commits

Roll Flutter Engine from 689ea4b10b17 to 7aa8521e640e (1 revision) (#145643) · 638e4714

engine-flutter-autoroll authored Mar 23, 2024

https://github.com/flutter/engine/compare/689ea4b10b17...7aa8521e640e

2024-03-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 4ed5b58c2cf7 to 567a19adbe9a (1 revision) (flutter/engine#51642)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

638e4714

Roll Flutter Engine from 42d4262b4b20 to 689ea4b10b17 (1 revision) (#145636) · 73e78fd9

engine-flutter-autoroll authored Mar 23, 2024

https://github.com/flutter/engine/compare/42d4262b4b20...689ea4b10b17

2024-03-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 45169152b424 to 4ed5b58c2cf7 (1 revision) (flutter/engine#51641)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

73e78fd9

Reland #128236 "Improve build output for all platforms" (#145495) · 9ae8a6b7

Pierre-Louis authored Mar 23, 2024

Reland #128236, reverted in https://github.com/flutter/flutter/pull/143125, https://github.com/flutter/flutter/pull/145261, and https://github.com/flutter/flutter/pull/145487.

The errors were raised in post-submit tests on Windows. I have finally obtained a Windows machine to reproduce the errors locally and adjust the test (remove size expectation and rename output `.exe`).

## Original description

Improves the build output:

1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained) 

### `apk`, `appbundle` 

<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d">

<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436">

### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.

<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257">

<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50">

<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698">

### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).

<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b">

<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2">

<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5">

### Size reporting
When applicable, the printed size matches the OS reported size.

- macOS
    <img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce">
- Windows
    <img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7">
- Linux   
    <img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b">

## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401

9ae8a6b7

Roll Flutter Engine from 7690eb12ded5 to 42d4262b4b20 (1 revision) (#145635) · 09b1afbd

engine-flutter-autoroll authored Mar 23, 2024

https://github.com/flutter/engine/compare/7690eb12ded5...42d4262b4b20

2024-03-23 skia-flutter-autoroll@skia.org Roll Skia from 2e99e3a5445c to 755ca0094a77 (1 revision) (flutter/engine#51639)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

09b1afbd

Roll Flutter Engine from 8a51e124fbf1 to 7690eb12ded5 (1 revision) (#145634) · c7dc2ce6

engine-flutter-autoroll authored Mar 23, 2024

https://github.com/flutter/engine/compare/8a51e124fbf1...7690eb12ded5

2024-03-23 skia-flutter-autoroll@skia.org Roll Dart SDK from ad26f4885bf4 to 45169152b424 (2 revisions) (flutter/engine#51638)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c7dc2ce6

Roll Flutter Engine from bc4fa4367edb to 8a51e124fbf1 (4 revisions) (#145630) · 085dbd85

engine-flutter-autoroll authored Mar 23, 2024

https://github.com/flutter/engine/compare/bc4fa4367edb...8a51e124fbf1

2024-03-22 skia-flutter-autoroll@skia.org Roll Skia from 10a460af3308 to 2e99e3a5445c (1 revision) (flutter/engine#51632)
2024-03-22 skia-flutter-autoroll@skia.org Roll Dart SDK from a959c7def805 to ad26f4885bf4 (1 revision) (flutter/engine#51631)
2024-03-22 1961493+harryterkelsen@users.noreply.github.com [web] Add ability to customize font fallback download URL (flutter/engine#51569)
2024-03-22 jacksongardner@google.com [skwasm] Use test fonts while in debugEmulateFlutterTesterEnvironment mode (flutter/engine#51630)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

085dbd85

Bump github/codeql-action from 3.24.8 to 3.24.9 (#145627) · 5b6a121d

dependabot[bot] authored Mar 23, 2024

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.8 to 3.24.9.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.24.9 - 22 Mar 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.5. <a href="https://redirect.github.com/github/codeql-action/pull/2203">#2203</a></li>
</ul>
<h2>3.24.8 - 18 Mar 2024</h2>
<ul>
<li>Improve the ease of debugging extraction issues by increasing the verbosity of the extractor logs when running in debug mode. <a href="https://redirect.github.com/github/codeql-action/pull/2195">#2195</a></li>
</ul>
<h2>3.24.7 - 12 Mar 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.4. <a href="https://redirect.github.com/github/codeql-action/pull/2185">#2185</a></li>
</ul>
<h2>3.24.6 - 29 Feb 2024</h2>
<p>No user facing changes.</p>
<h2>3.24.5 - 23 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.3. <a href="https://redirect.github.com/github/codeql-action/pull/2156">#2156</a></li>
</ul>
<h2>3.24.4 - 21 Feb 2024</h2>
<ul>
<li>Fix an issue where an existing, but empty, <code>/sys/fs/cgroup/cpuset.cpus</code> file always resulted in a single-threaded run. <a href="https://redirect.github.com/github/codeql-action/pull/2151">#2151</a></li>
</ul>
<h2>3.24.3 - 15 Feb 2024</h2>
<ul>
<li>Fix an issue where the CodeQL Action would fail to load a configuration specified by the <code>config</code> input to the <code>init</code> Action. <a href="https://redirect.github.com/github/codeql-action/pull/2147">#2147</a></li>
</ul>
<h2>3.24.2 - 15 Feb 2024</h2>
<ul>
<li>Enable improved multi-threaded performance on larger runners for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/2141">#2141</a></li>
</ul>
<h2>3.24.1 - 13 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.2. <a href="https://redirect.github.com/github/codeql-action/pull/2124">#2124</a></li>
<li>The CodeQL action no longer fails if it can't write to the telemetry api endpoint. <a href="https://redirect.github.com/github/codeql-action/pull/2121">#2121</a></li>
</ul>
<h2>3.24.0 - 02 Feb 2024</h2>
<ul>
<li>CodeQL Python analysis will no longer install dependencies on GitHub Enterprise Server, as is already the case for GitHub.com. See <a href="https://github.com/github/codeql-action/blob/main/#3230---08-jan-2024">release notes for 3.23.0</a> for more details. <a href="https://redirect.github.com/github/codeql-action/pull/2106">#2106</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/1b1aada464948af03b950897e5eb522f92603cc2"><code>1b1aada</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2208">#2208</a> from github/update-v3.24.9-09d4101d2</li>
<li><a href="https://github.com/github/codeql-action/commit/6505708f955e212b674980b47a03f34f6d1d9776"><code>6505708</code></a> Update changelog for v3.24.9</li>
<li><a href="https://github.com/github/codeql-action/commit/09d4101d2b9ab56005e4d4b429fcd66b33f86488"><code>09d4101</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2203">#2203</a> from github/update-bundle/codeql-bundle-v2.16.5</li>
<li><a href="https://github.com/github/codeql-action/commit/a3ab02e6453e6d2d2f6bd77317c51c10ea973420"><code>a3ab02e</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.16.5</li>
<li><a href="https://github.com/github/codeql-action/commit/9cf4574790094ee1d65a5c79713238216ad8b8db"><code>9cf4574</code></a> Add changelog note</li>
<li><a href="https://github.com/github/codeql-action/commit/964f5e781137c77436cb7c1230cdab297670d8d8"><code>964f5e7</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2207">#2207</a> from github/henrymercer/more-processing-error-catego...</li>
<li><a href="https://github.com/github/codeql-action/commit/9c0c35b370686be5728dec35cd1c3282773a0778"><code>9c0c35b</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2206">#2206</a> from github/henrymercer/improved-autobuild-error-wit...</li>
<li><a href="https://github.com/github/codeql-action/commit/c84e4c8e7b99e8c51d759338dfcffa926d58fa6f"><code>c84e4c8</code></a> Mark some more processing errors as invalid SARIF upload requests</li>
<li><a href="https://github.com/github/codeql-action/commit/4aca720110e11498c0c68f71b4078b27b782534d"><code>4aca720</code></a> Improve error message when using build modes and autobuild fails</li>
<li><a href="https://github.com/github/codeql-action/commit/7f375aeb76b6f1b81401407aeb7de808dd5f814c"><code>7f375ae</code></a> Wrap configuration errors for all CLI commands</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/05963f47d870e2cb19a537396c1f668a348c7d8f...1b1aada464948af03b950897e5eb522f92603cc2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.24.8&new-version=3.24.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

5b6a121d

Add workaround for bug adding unicode strings to test reports. (#145607) · 716f8276

godofredoc authored Mar 23, 2024

When print is used inside tests its content is added to the test report as a string of unicode \u0000 making the test reporting parser fail. This PR cleans removes non json content every line of the report.

Bug: https://github.com/flutter/flutter/issues/145553

716f8276

Roll Flutter Engine from 52142e428760 to bc4fa4367edb (1 revision) (#145626) · 42d6f719

engine-flutter-autoroll authored Mar 23, 2024

https://github.com/flutter/engine/compare/52142e428760...bc4fa4367edb

2024-03-22 skia-flutter-autoroll@skia.org Roll Skia from eb6976fc57cc to 10a460af3308 (3 revisions) (flutter/engine#51629)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

42d6f719

[web][docs] Improve HtmlElementView widget docs. (#145192) · df75d249

David Iglesias authored Mar 23, 2024

This PR expands the `HtmlElementView` widget DartDocs, with the following sections:

* Usage: How to use the widget, two ways:
  * The `HtmlElementView.fromTagName` constructor
  * The `PlatformViewRegistry` way
* Lifecycle: There's an `onCreated` callback on the widget. When does it get called?
* HTML Lifecycle: How to listen to events coming from the DOM.
* Visibility: what is the `isVisible` property for?

Small additional tweaks here and there to mention common pitfalls of using HtmlElementView on the web, and mentions to workarounds, like `package:pointer_interceptor`.

## Issues

* Fixes: https://github.com/flutter/flutter/issues/143922
* Fixes: https://github.com/flutter/flutter/issues/49634
* Related: https://github.com/flutter/website/issues/5063

df75d249

Disable flaky text_editing_integration tests temporarily. (#145629) · 6836b044

Jackson Gardner authored Mar 23, 2024

I did some local debugging but couldn't get an exact root cause on the flakiness of these tests. Running them locally, there are a lot of assertions and exceptions being thrown in console, so I think we need to figure out what's going on there, but we should disable these for now to unblock the tree.

6836b044