Commits · 55502fc36a16f25deebd9539f5288e12525f350f · abdullh.alsoleman / Front-End

18 Apr, 2023 15 commits

Add vmservice for android build options (#123034) · 55502fc3
chunhtai authored Apr 18, 2023
```
https://github.com/flutter/flutter/issues/120408
```
55502fc3

Fix text theme dart fix cases (#125052) · 42fb0b23

Kate Lovett authored Apr 18, 2023

Fixes https://github.com/flutter/flutter/issues/125049

This is blocking the dart roll, dart fix will now fix some invalid code that was in these test cases. These test case files are un-analyzed intentionally because they are by nature samples of broken code.

42fb0b23

Update the copy icon in snippets and samples to use the standard one (#123651) · d4e1209c

Greg Spencer authored Apr 18, 2023

## Description

This updates the copy icon for copying sample code to use `content_copy` instead of `assignment`.
Before:
<img width="369" alt="223876418-2470c4c5-abfc-4511-9762-1fd0b6e05903" src="https://user-images.githubusercontent.com/8867023/228396142-450125ee-d8cf-4ede-8545-5920eb0da99d.png">

After:
<img width="408" alt="image" src="https://user-images.githubusercontent.com/8867023/228395959-8531704a-77aa-43af-9dcf-7456bb2ed090.png">

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/122246

## Tests
 - No tests needed.

d4e1209c

Remove unused context parameter (#124254) · 9d688313
Justin McCandless authored Apr 18, 2023
```
Tidying up the spell check API.
```
9d688313
iOS spell check cursor placement (#124875) · 39becb77
Justin McCandless authored Apr 18, 2023
```
Fixes the cursor location after selecting a spell check result on iOS.
```
39becb77

Roll Flutter Engine from d2973619074e to 55bb065c607b (1 revision) (#125047) · f7245b64

engine-flutter-autoroll authored Apr 18, 2023

https://github.com/flutter/engine/compare/d2973619074e...55bb065c607b

2023-04-18 10456171+caroqliu@users.noreply.github.com [fuchsia] migrate touch-input integration tests to gfx scene manager test ui stack (flutter/engine#41118)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f7245b64

Stop running "_impeller_" benchmark variants (#125044) · c31467f1

Zachary Anderson authored Apr 18, 2023

Impeller is now the default on iOS, so these are redundant.

In a subsequent change, I'll clean up the source files for these.

c31467f1

Roll Packages from 0277f2ad9d92 to faf53fb3998c (7 revisions) (#125040) · a9ffc166

engine-flutter-autoroll authored Apr 18, 2023

https://github.com/flutter/packages/compare/0277f2ad9d92...faf53fb3998c

2023-04-18 engine-flutter-autoroll@skia.org Manual roll Flutter from 50171bba to 15cb1f84 (9 revisions) (flutter/packages#3749)
2023-04-17 reidbaker@google.com [palette_generator] run agp update for example (flutter/packages#3747)
2023-04-17 47866232+chunhtai@users.noreply.github.com [go_router] Fixes a bug that go_router would crash if pageBuilder depends on InheritedWidgets.s. (flutter/packages#3714)
2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump com.android.tools.build:gradle from 7.3.1 to 8.0.0 in /packages/pigeon/platform_tests/alternate_language_test_plugin/android (flutter/packages#3727)
2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump com.android.tools.build:gradle from 7.3.1 to 8.0.0 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3726)
2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.4 to 1.13.5 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3725)
2023-04-17 stuartmorgan@google.com [tool] Add initial gradle validation command (flutter/packages#3715)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a9ffc166

Roll Flutter Engine from c4396f9f602f to d2973619074e (6 revisions) (#125039) · ec02eb35

engine-flutter-autoroll authored Apr 18, 2023

https://github.com/flutter/engine/compare/c4396f9f602f...d2973619074e

2023-04-18 leroux_bruno@yahoo.fr [macOS] Fix Ctrl+Tab is broken
(flutter/engine#40706)
2023-04-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
K1LGtKXyxRlW3Q9O1... to qZHSvkpAU1-YYGvYc... (flutter/engine#41293)
2023-04-18 aam@google.com Roll buildroot to
059d155b4d452efd9c4427c45cddfd9445144869 (flutter/engine#41288)
2023-04-18 bdero@google.com [Impeller] Remove glyph pixel rounding
during text frame conversion (flutter/engine#41285)
2023-04-18 godofredoc@google.com Revert "Reland "Migrate mac_host_engine
to engine v2 builds."" (flutter/engine#41284)
2023-04-17 flar@google.com focus SkiaGPUObject wrappers on only those
objects that need the protection (flutter/engine#41237)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from K1LGtKXyxRlW to qZHSvkpAU1-Y

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ec02eb35

Roll pub packages (#125005) · b0346b29
Flutter GitHub Bot authored Apr 18, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
b0346b29

[InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget (#124143) · 5de716f7

Tirth authored Apr 18, 2023

Adds `acceptEmptyDate` property to `InputDatePickerFormField`.

Fixes: #117511

| `acceptEmptyDate` is **false** | `acceptEmptyDate` is **true** |
| --- | ---|
| ![acceptemptydate_false](https://user-images.githubusercontent.com/13456345/229893658-280ecdee-d509-4579-b53c-9d8d485c61b4.gif) | ![acceptemptydate__true](https://user-images.githubusercontent.com/13456345/229895144-115e71bd-e5bb-4653-8db2-9f57dd8262aa.gif) |

5de716f7

relayout active ListWheelScrollView children every performLayout (#124476) · 3ba249a6

Viren Khatri authored Apr 18, 2023

during performLayout, active children's constraints were updated, but they weren't laid out again w.r.t their parent (ListWheelScrollView).

Fixes #123497

3ba249a6

Roll Flutter Engine from 4a603aaff32e to c4396f9f602f (2 revisions) (#125007) · 40755034

engine-flutter-autoroll authored Apr 18, 2023

https://github.com/flutter/engine/compare/4a603aaff32e...c4396f9f602f

2023-04-17 zanderso@users.noreply.github.com Roll impeller-cmake-example to 58042bb24833a3cbd615ad082b1d17daef42d097 (flutter/engine#41280)
2023-04-17 jacksongardner@google.com Reland ui_web files in sky_engine (flutter/engine#41169)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

40755034

Roll Flutter Engine from 20034a8d62c4 to 4a603aaff32e (2 revisions) (#125004) · 9cc5f555

engine-flutter-autoroll authored Apr 18, 2023

https://github.com/flutter/engine/compare/20034a8d62c4...4a603aaff32e

2023-04-17 magder@google.com Remove 'Mac mac_unopt' in favor of Linux (flutter/engine#41226)
2023-04-17 chinmaygarde@google.com [Impeller] Add debug ToString methods to render targets. (flutter/engine#41221)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9cc5f555

Add optional axis specifier to static scrollable methods (#124894) · e867d1c6

Kate Lovett authored Apr 18, 2023

This is motivated by part of the 2D scrolling proposal: [flutter.dev/go/2D-Foundation](https://flutter.dev/go/2D-Foundation)

This is one of the last little PRs to prep for the 2D scrolling foundation.
This adds an optional `axis` parameter to the static Scrollable methods `[of, maybeOf, recommendDeferredLoadingForContext]`. This allows developers that are nesting scrollables (or one day using 2D scrolling) to look them up instead by a particular axis.

In general, even outside the context of 2D, I think this is helpful. I am often asked how to get the outer scrollable when nesting. Now it can be done.

There is also a small semantic refactor here in ScrollableState.build, this just creates a private method (_buildChrome) that will be overridden in 2D later. It is easier to add now than in the really big PR that will be.

e867d1c6

17 Apr, 2023 14 commits

Update usage of standalone`pub` executable in flutter_tools testing docs (#124898) · e99eb402
Bartek Pacia authored Apr 17, 2023
```
Just found this while trying to run the integration test shard of `flutter_tools` locally :)
```
e99eb402
Add Harish Anbalagan to AUTHORS (#124684) · 0ac1813b
Harish Anbalagan authored Apr 17, 2023
```
Adding my name (Harish Anbalagan) to Authors.
```
0ac1813b

Roll Flutter Engine from b2d07388ceb6 to 20034a8d62c4 (7 revisions) (#125001) · 67a84e6c

engine-flutter-autoroll authored Apr 17, 2023

https://github.com/flutter/engine/compare/b2d07388ceb6...20034a8d62c4

2023-04-17 godofredoc@google.com Reland "Migrate mac_host_engine to engine v2 builds." (flutter/engine#41279)
2023-04-17 41930132+hellohuanlin@users.noreply.github.com [rotation_distortion] Use "delayed swap" solution to reduce rotation distortion (flutter/engine#40730)
2023-04-17 akash.mercer@gmail.com null check added to avoid NPE while calling FlutterView.detachFromFlutterEngine() (flutter/engine#41082)
2023-04-17 5236035+fzyzcjy@users.noreply.github.com [Impeller] Make `DoMakeRasterSnapshot` output timeline event. (flutter/engine#41197)
2023-04-17 bdero@google.com [Impeller] Remove ContentContextOptions declarations from AnonymousContents (flutter/engine#41256)
2023-04-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 786a70d8ef6b to a335e6724332 (1 revision) (flutter/engine#41278)
2023-04-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from atix5Ek_OOxH-uoPA... to Cy5LG4U2InaFLkJGz... (flutter/engine#41275)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from atix5Ek_OOxH to Cy5LG4U2InaF

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

67a84e6c

Add an example for SearchBar (#124992) · 6e851134

Qun Cheng authored Apr 17, 2023

This PR is to: 
* Update API doc for `SearchBar`.
* Add an example to show how to use a `SearchBar` as the builder of the `SearchAnchor`.

6e851134

SelectionContainer's listeners can remove itself during listener call… (#124624) · cc9ffd3f

chunhtai authored Apr 17, 2023

When swapping out delegate of  selectioncontainer, if the newly passed in delegate doesn't have any selectable content(which is usually the case), the selectioncontainerstate will notify all of the listeners. One of the listener would be SelectionRegistrant._updateSelectionRegistrarSubscription, and since it doesn't have content, it would remove itself from the listener which causes concurrent modification

cc9ffd3f

Fix Chip highlight color isn't drawn on top of the background color (#124673) · 15cb1f84
Taha Tesser authored Apr 17, 2023

15cb1f84

Deprecates string for reorderable list in material_localizations (#124711) · 7424f344

chunhtai authored Apr 17, 2023

deprecates the these strings since they are now moved into widgetslocalizations

migration guide https://github.com/flutter/website/pull/8543/files

7424f344

Fix a null crash in SelectableRegion Widget (#124736) · 2f45458e
hangyu authored Apr 17, 2023
```
issue #123378
```
2f45458e
Customize color and thickness of connected lines in Stepper.dart (#122485) · df8d8194
Mubarak Bakarman authored Apr 17, 2023

df8d8194

Roll Flutter Engine from 30e1c4308213 to b2d07388ceb6 (7 revisions) (#124987) · 53f31c7c

engine-flutter-autoroll authored Apr 17, 2023

https://github.com/flutter/engine/compare/30e1c4308213...b2d07388ceb6

2023-04-17 30870216+gaaclarke@users.noreply.github.com Adds AndroidSurfaceGLImpeller unit tests (flutter/engine#40979)
2023-04-17 yjbanov@google.com [web:canvaskit] migrate Paint API to UniqueRef (flutter/engine#41230)
2023-04-17 kjlubick@users.noreply.github.com Migrate uses of deprecated SkImage->encodeToData (flutter/engine#41204)
2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 962800967591 to d9e216e62223 (1 revision) (flutter/engine#41270)
2023-04-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from xPacy_rLieLS05d_g... to K1LGtKXyxRlW3Q9O1... (flutter/engine#41271)
2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 82665485077b to 962800967591 (1 revision) (flutter/engine#41267)
2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 5c4d2a518736 to 82665485077b (2 revisions) (flutter/engine#41266)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from xPacy_rLieLS to K1LGtKXyxRlW

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

53f31c7c

Remove token permissions for coverage. (#124909) · 8bbe7178
godofredoc authored Apr 17, 2023
```
The coverage build does not require write access to checks.
```
8bbe7178

Roll Packages from e4ec15590935 to 0277f2ad9d92 (9 revisions) (#124972) · c368d64d

engine-flutter-autoroll authored Apr 17, 2023

https://github.com/flutter/packages/compare/e4ec15590935...0277f2ad9d92

2023-04-16 engine-flutter-autoroll@skia.org Roll Flutter from 00171b07 to 50171bba (7 revisions) (flutter/packages#3723)
2023-04-15 engine-flutter-autoroll@skia.org Roll Flutter from f7405446 to 00171b07 (17 revisions) (flutter/packages#3717)
2023-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.2.9 to 2.2.12 (flutter/packages#3711)
2023-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.0 to 3.5.2 (flutter/packages#3710)
2023-04-14 stuartmorgan@google.com [path_provider] Fix Android lint warnings (flutter/packages#3706)
2023-04-14 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] [camera_android_camerax] Updates internal Java InstanceManager to only stop finalization callbacks when stopped (flutter/packages#3571)
2023-04-14 stuartmorgan@google.com [shared_preferences] Fix Android Java version issue (flutter/packages#3712)
2023-04-14 48185017+andreisas06@users.noreply.github.com [image_picker][android] Non-bitmap images now return path instead of null (flutter/packages#3590)
2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter from be45eb24 to f7405446 (24 revisions) (flutter/packages#3713)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c368d64d

Roll Flutter Engine from 360ca05311c8 to 30e1c4308213 (3 revisions) (#124963) · bfd92a86

engine-flutter-autoroll authored Apr 17, 2023

https://github.com/flutter/engine/compare/360ca05311c8...30e1c4308213

2023-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.0 to 3.5.2 (flutter/engine#41264)
2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from a64c248e62e0 to 5c4d2a518736 (1 revision) (flutter/engine#41262)
2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 03c8e529196d to a64c248e62e0 (1 revision) (flutter/engine#41261)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bfd92a86

Roll Flutter Engine from 4a998b73a2df to 360ca05311c8 (2 revisions) (#124952) · 858d4ff6

engine-flutter-autoroll authored Apr 17, 2023

https://github.com/flutter/engine/compare/4a998b73a2df...360ca05311c8

2023-04-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from AAx6fLy6ykWVhXvNh... to xPacy_rLieLS05d_g... (flutter/engine#41260)
2023-04-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 46T4ZTAt48yPRDEn5... to atix5Ek_OOxH-uoPA... (flutter/engine#41258)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 46T4ZTAt48yP to atix5Ek_OOxH
fuchsia/sdk/core/mac-amd64 from AAx6fLy6ykWV to xPacy_rLieLS

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

858d4ff6

16 Apr, 2023 2 commits

Roll Flutter Engine from da0805a9cf03 to 4a998b73a2df (5 revisions) (#124944) · 50171bba

engine-flutter-autoroll authored Apr 16, 2023

https://github.com/flutter/engine/compare/da0805a9cf03...4a998b73a2df

2023-04-16 skia-flutter-autoroll@skia.org Roll Skia from cc3404330d3b to 03c8e529196d (1 revision) (flutter/engine#41255)
2023-04-16 skia-flutter-autoroll@skia.org Roll Skia from 2d0b05335104 to cc3404330d3b (1 revision) (flutter/engine#41254)
2023-04-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hacWN-gQSoWudziIS... to 46T4ZTAt48yPRDEn5... (flutter/engine#41253)
2023-04-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gI2knJ4Rh0yoK4Syd... to AAx6fLy6ykWVhXvNh... (flutter/engine#41252)
2023-04-16 bdero@google.com [Impeller] Add offscreen texture checkerboarding (flutter/engine#41199)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from hacWN-gQSoWu to 46T4ZTAt48yP
fuchsia/sdk/core/mac-amd64 from gI2knJ4Rh0yo to AAx6fLy6ykWV

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

50171bba

Roll Flutter Engine from feb476b7b991 to da0805a9cf03 (4 revisions) (#124933) · 2d572610

engine-flutter-autoroll authored Apr 16, 2023

https://github.com/flutter/engine/compare/feb476b7b991...da0805a9cf03

2023-04-15 skia-flutter-autoroll@skia.org Roll Skia from 2a4d95762651 to 2d0b05335104 (1 revision) (flutter/engine#41250)
2023-04-15 jonahwilliams@google.com [Impeller] add a generic porter duff blend foreground shader. (flutter/engine#41098)
2023-04-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Y_tD90hDX_jiubGbC... to hacWN-gQSoWudziIS... (flutter/engine#41248)
2023-04-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from RFyPoDrXzIiy-E3wn... to gI2knJ4Rh0yoK4Syd... (flutter/engine#41249)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Y_tD90hDX_ji to hacWN-gQSoWu
fuchsia/sdk/core/mac-amd64 from RFyPoDrXzIiy to gI2knJ4Rh0yo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2d572610

15 Apr, 2023 9 commits

Roll Flutter Engine from ee66f0d6f2c9 to feb476b7b991 (2 revisions) (#124929) · d8a916f2

engine-flutter-autoroll authored Apr 15, 2023

https://github.com/flutter/engine/compare/ee66f0d6f2c9...feb476b7b991

2023-04-15 skia-flutter-autoroll@skia.org Roll Skia from cf580fd68a21 to 2a4d95762651 (2 revisions) (flutter/engine#41247)
2023-04-15 skia-flutter-autoroll@skia.org Roll Dart SDK from eb26d88d7f58 to 786a70d8ef6b (1 revision) (flutter/engine#41245)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d8a916f2

Revert "[framework] use shader tiling instead of repeated calls to drawImage" (#124640) · 00495da0

Jonah Williams authored Apr 15, 2023

Reverts flutter/flutter#119495

We'll managed to optimize almost all of the cases that made this slow. Actually, it will soon be harder to optimize shader tiling...

00495da0

[cupertino] improve cupertino picker performance by using at most one opacity layer (#124719) · d1d426e5

Jonah Williams authored Apr 15, 2023

Fixes https://github.com/flutter/flutter/issues/124703

Rather than applying an opacity layer per picker item, apply them to all partially opaque picker items at once. This dramatically improves performance for impeller, by reducing the number of required subpasses and texture allocations signficantly.

Before:
Doesn't finish, 100s of passes

After:

![image](https://user-images.githubusercontent.com/8975114/231569280-91f55c9a-53a5-4b75-8728-59a4dceebe81.png)

![image](https://user-images.githubusercontent.com/8975114/231569309-7c82e5ff-46c7-4f00-80f0-9b4096aa4b14.png)

See also:

https://github.com/flutter/flutter/issues/124658

d1d426e5

[flutter_tools] Remove `Version.unknown` (#124771) · 68ec71f4

Andrew Kolos authored Apr 15, 2023

Fixes #124756 by removing the concept of `Version.unknown`.

`Version` fields that needed the ability to represent an unknown version have been made nullable. Assigning `null` to them represents an unknown version.

68ec71f4

Roll Flutter Engine from 41c1ea9a8283 to ee66f0d6f2c9 (2 revisions) (#124923) · 4543766a

engine-flutter-autoroll authored Apr 15, 2023

https://github.com/flutter/engine/compare/41c1ea9a8283...ee66f0d6f2c9

2023-04-15 skia-flutter-autoroll@skia.org Roll Skia from f489b4a06e19 to cf580fd68a21 (3 revisions) (flutter/engine#41244)
2023-04-15 skia-flutter-autoroll@skia.org Roll Dart SDK from afb0adeca5b6 to eb26d88d7f58 (1 revision) (flutter/engine#41241)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4543766a

Roll Flutter Engine from f24e37bb4d9e to 41c1ea9a8283 (1 revision) (#124916) · 00171b07

engine-flutter-autoroll authored Apr 15, 2023

https://github.com/flutter/engine/compare/f24e37bb4d9e...41c1ea9a8283

2023-04-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from wL-3zhH7VC1ugMJUN... to RFyPoDrXzIiy-E3wn... (flutter/engine#41240)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from wL-3zhH7VC1u to RFyPoDrXzIiy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

00171b07

Roll Flutter Engine from f6e64a87407f to f24e37bb4d9e (2 revisions) (#124914) · d0d02cbd

engine-flutter-autoroll authored Apr 15, 2023

https://github.com/flutter/engine/compare/f6e64a87407f...f24e37bb4d9e

2023-04-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Z0of2S9pf3Zn1nsJP... to Y_tD90hDX_jiubGbC... (flutter/engine#41238)
2023-04-15 magder@google.com Remove jazzy and Xcode properties from impeller-cmake-example builder (flutter/engine#41222)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Z0of2S9pf3Zn to Y_tD90hDX_ji

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d0d02cbd

Roll Flutter Engine from c8d84cf3b761 to f6e64a87407f (2 revisions) (#124913) · 7975257c

engine-flutter-autoroll authored Apr 15, 2023

https://github.com/flutter/engine/compare/c8d84cf3b761...f6e64a87407f

2023-04-15 godofredoc@google.com Revert "Migrate mac_host_engine to engine v2 builds." (flutter/engine#41233)
2023-04-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 5687f08b854d to afb0adeca5b6 (2 revisions) (flutter/engine#41232)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7975257c

Roll Flutter Engine from 4552a6e105f1 to c8d84cf3b761 (1 revision) (#124907) · e1642baf

engine-flutter-autoroll authored Apr 15, 2023

https://github.com/flutter/engine/compare/4552a6e105f1...c8d84cf3b761

2023-04-15 chris@bracken.jp [macOS] Fix arm64 floating-point test failure (flutter/engine#41228)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e1642baf