Commits · 55061e4652c8fa5e0f3c2279c32b1dd95f7b2630 · abdullh.alsoleman / Front-End

02 May, 2023 6 commits

Roll Flutter Engine from a9e38dd0510d to c0d68c36c376 (1 revision) (#125868) · 55061e46

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/a9e38dd0510d...c0d68c36c376

2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from e18b7415188c to d2c85cb8aa2f (2 revisions) (flutter/engine#41660)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

55061e46

Roll Flutter Engine from 024bf946232d to a9e38dd0510d (2 revisions) (#125866) · 59653136

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/024bf946232d...a9e38dd0510d

2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from c9e0992be00b to e18b7415188c (1 revision) (flutter/engine#41659)
2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 25c29435f73e to 0c4f93a82e0b (2 revisions) (flutter/engine#41657)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

59653136

Make `future` and `stream` required arguments in their respective builder widgets (#125838) · 4d86f5d0

Casey Rogers authored May 02, 2023

cc'ing existing conversation participants: @domesticmouse @srawlins
cc'ing to request review: @goderbauer

This PR makes the following constructor arguments required:
1. `FutureBuilder.future`
2. `StreamBuilderBase.stream`
3. `StreamBuilder.stream`

This fixes:
https://github.com/flutter/flutter/issues/83081
https://github.com/flutter/flutter/issues/125188 (dupe of 83081)

This obviates:
https://github.com/dart-lang/linter/issues/4309
(I suggest we skip straight to merging this PR as this should be a low impact breaking change-assuming few to no devs are intentionally using the builders without their relevant arguments, however we could always merge 4309 first and then this)
https://github.com/flutter/flutter/pull/83101
(The above PR required that at least one of future and initial data be non-null, this is undesirable as there are plenty of valid reasons to have both arguments be null)

See above issues for a deeper dive, but here is a summary:
It is very easy for a developer to forget to specify `future` or `stream` when using the respective `*Builder` widgets. This produces a non-obvious failure where the UI sits in a "no data yet received" state. It is easy for a dev to misinterpret this as the async work backing the future/stream hanging and they thus waste a lot of time trying to debug the async work.
As such, we should require these two constructor arguments to make it impossible/much harder for devs to make this time-wasting mistake.

This is a breaking change. However, it should break only a small number of active projects given that using a builder without specifying `future` or `stream` seems highly niche.
The only place I've found non-accidental examples of this is in widget tests where you're calling `pumpWidget` with and without these arguments to test `*Builder.didUpdateWidget`'s behavior. In this and similar cases, it is a trivial fix to add `future: null`/`stream: null`.

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

4d86f5d0

Roll Flutter Engine from 7d87410a51d5 to 024bf946232d (6 revisions) (#125858) · 7907f931

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/7d87410a51d5...024bf946232d

2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from 38e56b6da8f9 to c9e0992be00b (3 revisions) (flutter/engine#41655)
2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from dc4a048e3cf7 to 25c29435f73e (1 revision) (flutter/engine#41654)
2023-05-01 flar@google.com [Impeller] take advantage of DisplayList culling (flutter/engine#41606)
2023-05-01 godofredoc@google.com Use os_dimension in framework tests. (flutter/engine#41649)
2023-05-01 58529443+srujzs@users.noreply.github.com Turn @staticInterop tear-off into closure (flutter/engine#41643)
2023-05-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SJOgKviZ-kwWd1Z1u... to ur2ymZJCZSj64s6Q2... (flutter/engine#41648)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from SJOgKviZ-kwW to ur2ymZJCZSj6

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7907f931

Roll Flutter Engine from 3fa6084dfb36 to 7d87410a51d5 (4 revisions) (#125845) · d304545d

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/3fa6084dfb36...7d87410a51d5

2023-05-01 ychris@google.com Update xcode to 14e222b (flutter/engine#41640)
2023-05-01 aam@google.com Run flutter license script with dart `--intrepret_irregexp` runtime option (flutter/engine#41646)
2023-05-01 skia-flutter-autoroll@skia.org Roll Skia from 82d1ef7a833e to 38e56b6da8f9 (8 revisions) (flutter/engine#41645)
2023-05-01 ychris@google.com Move scenario app to use iPhone Se 3rd gen iOS 16.2, un-skip test `TwoPlatformViewsWithOtherBackDropFilterTests` (flutter/engine#41532)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d304545d

Migrate Xcode projects last version checks to Xcode 14.3 (#125827) · 1861ac47

Jenn Magder authored May 02, 2023

1. Add iOS and macOS migration to mark "last upgraded" Xcode version to 14.3 to prevent `Update to recommended settings` warning.
2. Update iOS and macOS templates to same.
3. Update iOS template to set `BuildIndependentTargetsInParallel` to YES as suggested. I didn't add a migration for this since it seems like a minor optimization and I don't think it's worth a potentially botched/corrupted migration.
4. Run all example/integration test project to see migrator work.
5. Add some missing test projects to the build shard since I noticed they were missing and I had to build those manually outside `SHARD=build_tests`.

Fixes https://github.com/flutter/flutter/issues/125817
See https://github.com/flutter/flutter/pull/90304 for Xcode 13 example.

1861ac47

01 May, 2023 17 commits

Roll Flutter Engine from 58cc54197a54 to 3fa6084dfb36 (1 revision) (#125839) · 635337ca

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/58cc54197a54...3fa6084dfb36

2023-05-01 timmaffett@gmail.com Fixes font-subset to not drop GSUB/GPOS/GDEF tables for variable fonts where they are needed Fixes #125704 (flutter/engine#41592)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

635337ca

Roll Flutter Engine from 687f4c761db1 to 58cc54197a54 (6 revisions) (#125833) · 050e4ade

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/687f4c761db1...58cc54197a54

2023-05-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from NBgD7NzOpwnAULR_g... to u7iIoiSX4y8WV6Of1... (flutter/engine#41641)
2023-05-01 godofredoc@google.com Add the verify exported symbols to linux builds. (flutter/engine#41635)
2023-05-01 30870216+gaaclarke@users.noreply.github.com [Impeller] Turns on the Metal validator for impeller_unittests. (flutter/engine#40998)
2023-05-01 dnfield@google.com [Impeller] Remove duplicate component in path.h (flutter/engine#41639)
2023-05-01 whesse@google.com Forward fix for roll of Dart SDK to version with new checked-in SDK (flutter/engine#41634)
2023-05-01 skia-flutter-autoroll@skia.org Roll Skia from 1a6a1e905518 to 82d1ef7a833e (5 revisions) (flutter/engine#41637)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from NBgD7NzOpwnA to u7iIoiSX4y8W

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

050e4ade

Roll Flutter Engine from 666bc34c61aa to 687f4c761db1 (2 revisions) (#125818) · 828a0404

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/666bc34c61aa...687f4c761db1

2023-05-01 skia-flutter-autoroll@skia.org Roll Dart SDK from a433ca08e7e2 to dc4a048e3cf7 (1 revision) (flutter/engine#41636)
2023-05-01 xilaizhang@google.com [flutter roll] Revert "Determine lifecycle by looking at window focus also" (flutter/engine#41626)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

828a0404

Revert "Add migrator to upgrade gradle version when conflict with And… (#125813) · db7196c5
gmackall authored May 01, 2023
```
â¦roid Studio bundled Java version is detected (#124085)"

This reverts commit eba2a520.
```
db7196c5
Roll pub packages (#125801) · b2f22321
Flutter GitHub Bot authored May 01, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
b2f22321
[tools] fix `expect` calls in `FakeCommand` (#125783) · a27cb145
Andrew Kolos authored May 01, 2023
```
Fixes #125782.

Would be nice to figure out a way to put this under test.
```
a27cb145

Roll Packages from 7e3f5da42e81 to de6131dbe4f7 (41 revisions) (#125811) · ff248d23

engine-flutter-autoroll authored May 01, 2023

Roll Packages from 7e3f5da42e81 to de6131dbe4f7 (41 revisions)

https://github.com/flutter/packages/compare/7e3f5da42e81...de6131dbe4f7

2023-05-01 reidbaker@google.com I122213 update non examples (flutter/packages#3846)
2023-04-29 47866232+chunhtai@users.noreply.github.com [go_router] Cleans up route match API and introduces dart fix (flutter/packages#3819)
2023-04-29 43054281+camsim99@users.noreply.github.com [camerax] Add `LifecycleOwner` Proxy (flutter/packages#3837)
2023-04-29 stuartmorgan@google.com [file_selector] Add getDirectoryPaths implementation for Windows (flutter/packages#3704)
2023-04-29 stuartmorgan@google.com [various] Update Android example min SDKs (flutter/packages#3847)
2023-04-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.2.12 to 2.3.2 (flutter/packages#3838)
2023-04-28 43054281+camsim99@users.noreply.github.com [camerax] Implement Image Streaming (flutter/packages#3454)
2023-04-28 reidbaker@google.com [various] update agp and gradle for all examples in packages (flutter/packages#3822)
2023-04-28 54558023+keyonghan@users.noreply.github.com Update xcode to 14c18 (flutter/packages#3774)
2023-04-28 andrewjohncoutts@gmail.com [camera_android] Add NV21 as an image stream format #3277 (flutter/packages#3639)
2023-04-28 gautier.bayzelon@gmail.com [go_router] Remove unused navigator keys (flutter/packages#3708)
2023-04-28 JeroenWeener@users.noreply.github.com [image_picker] Move I/O operations to a separate thread (flutter/packages#3506)
2023-04-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.20 to 1.8.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3824)
2023-04-28 stuartmorgan@google.com [pigeon] Reland: Add an initial example app (flutter/packages#3832)
2023-04-28 engine-flutter-autoroll@skia.org Roll Flutter from c9004ff8 to 66fa4c5d (68 revisions) (flutter/packages#3830)
2023-04-28 stuartmorgan@google.com [various] Conditionalize the namespace in all Android plugins (flutter/packages#3836)
2023-04-27 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.billingclient:billing from 5.1.0 to 5.2.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3672)
2023-04-27 ychris@google.com [auick_action_ios] Retries multiple times to not fail ci when there is a flake (flutter/packages#3823)
2023-04-26 magder@google.com Swap some iOS package CODEOWNERS (flutter/packages#3793)
2023-04-26 stuartmorgan@google.com [various] Add `targetCompatibility` to build.gradle (flutter/packages#3825)
2023-04-26 stuartmorgan@google.com [various] Set cmake_policy versions (flutter/packages#3828)
2023-04-26 stuartmorgan@google.com [path_provider] Allow `win32` up to version 4.x (flutter/packages#3820)
2023-04-26 stuartmorgan@google.com [tool] Move Android lint checks (flutter/packages#3816)
2023-04-25 evace93@gmail.com [google_maps_flutter_android] Fix Android lint warnings (flutter/packages#3751)
2023-04-25 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.5.0 to 1.6.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3381)
2023-04-25 jason-simmons@users.noreply.github.com Update test golden images for the latest Skia roll (flutter/packages#3787)
2023-04-25 stuartmorgan@google.com [various] Adds Android namespace (flutter/packages#3791)
2023-04-25 reidbaker@google.com [shared_preferences] Update gradle/agp in example apps (flutter/packages#3809)
2023-04-24 43640732+dancamdev@users.noreply.github.com [go_router] Adds name to TypedGoRoute (flutter/packages#3702)
2023-04-22 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds support to receive permission requests (flutter/packages#3543)
2023-04-21 stuartmorgan@google.com [google_sign_in] Fix Android Java warnings (flutter/packages#3762)
2023-04-21 stuartmorgan@google.com [local_auth] Fix enum return on Android (flutter/packages#3780)
2023-04-21 stuartmorgan@google.com [pigeon] Warn when trying to use enums in collections (flutter/packages#3782)
2023-04-21 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] [webview_flutter_wkwebview] Platform implementations for supporting permission requests (flutter/packages#3792)
2023-04-21 scheglov@google.com [pigeon] Update for compatibility with a future change to the analyzer. (flutter/packages#3789)
2023-04-21 10687576+bparrishMines@users.noreply.github.com [camera_android] Fix Android lint warnings (flutter/packages#3716)
2023-04-21 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds method to receive permission requests (flutter/packages#3767)
2023-04-21 magder@google.com [image_picker_ios] In unit test write and read kCGImagePropertyExifUserComment property (flutter/packages#3783)
2023-04-21 widrans@gmail.com [go_router_builder] Fixed the return value of the generated push method (flutter/packages#3650)
2023-04-21 JeroenWeener@users.noreply.github.com [image_picker] Mention `launchMode: singleInstance` in README (flutter/packages#3759)
2023-04-21 stuartmorgan@google.com Revert "[pigeon] Add an initial example app" (flutter/packages#3785)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
...

ff248d23

Introduce `TabBar.tabAlignment` (#125036) · a732a748

Taha Tesser authored May 01, 2023

fixes https://github.com/flutter/flutter/issues/124195

This introduces `TabBar.tabAlignment` while keeping the default alignment for both M2 and M3.

a732a748

Roll Flutter Engine from b0da68e7e024 to 666bc34c61aa (1 revision) (#125805) · e2ddf563

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/b0da68e7e024...666bc34c61aa

2023-05-01 skia-flutter-autoroll@skia.org Roll Skia from a7f887f344c6 to 1a6a1e905518 (1 revision) (flutter/engine#41633)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e2ddf563

add support to customize Slider interacivity (#121483) · 293715a6

Viren Khatri authored May 01, 2023

design doc: https://docs.flutter.dev/go/permissible-slider-interaction

closes #113370

open questions:
  - No, as `SliderInteraction.none` doesn't exist anymore.
  - Yes (done)
  - Yes.
    - SliderInteraction
    - SliderAction
    - Slider.allowedInteraction
    - Slider.permissibleInteraction
    - Slider.interaction
    - Slider.allowedAction
    - Slider.permittedAction

293715a6

Roll Flutter Engine from b4551c72487c to b0da68e7e024 (1 revision) (#125800) · d9ea36cc

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/b4551c72487c...b0da68e7e024

2023-05-01 kjlubick@users.noreply.github.com Reland image encoder (flutter/engine#41632)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d9ea36cc

Roll Flutter Engine from 605528f293d0 to b4551c72487c (1 revision) (#125795) · 3380c398

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/605528f293d0...b4551c72487c

2023-05-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 823a69e2a34d to a433ca08e7e2 (3 revisions) (flutter/engine#41631)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3380c398

Roll Flutter Engine from bba66b658cee to 605528f293d0 (2 revisions) (#125793) · fed8cc4a

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/bba66b658cee...605528f293d0

2023-05-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from FV1Uu3faXL2llmvaU... to SJOgKviZ-kwWd1Z1u... (flutter/engine#41630)
2023-05-01 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.1 to 2.3.2 (flutter/engine#41629)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from FV1Uu3faXL2l to SJOgKviZ-kwW

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fed8cc4a

Roll Flutter Engine from 2fa61b91d7c2 to bba66b658cee (1 revision) (#125791) · bf6f0af2

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/2fa61b91d7c2...bba66b658cee

2023-05-01 skia-flutter-autoroll@skia.org Roll Skia from fe0977a822a4 to a7f887f344c6 (1 revision) (flutter/engine#41628)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bf6f0af2

Roll Flutter Engine from 30c91b8180e7 to 2fa61b91d7c2 (1 revision) (#125789) · 8ecc3d92

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/30c91b8180e7...2fa61b91d7c2

2023-05-01 skia-flutter-autoroll@skia.org Roll Skia from 5a7d7da47c10 to fe0977a822a4 (5 revisions) (flutter/engine#41627)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8ecc3d92

Roll Flutter Engine from d76a22e67eea to 30c91b8180e7 (1 revision) (#125787) · cbdeec91

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/d76a22e67eea...30c91b8180e7

2023-05-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from uU98Ene2OeSVt21X_... to NBgD7NzOpwnAULR_g... (flutter/engine#41625)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from uU98Ene2OeSV to NBgD7NzOpwnA

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cbdeec91

[tools] Apply Android Studio version detection logic to explicitly configured... · 9dbd6e61

Andrew Kolos authored May 01, 2023

[tools] Apply Android Studio version detection logic to explicitly configured installation directory (`flutter config --android-studio-dir`) (#125596)

Fixes #121468 (when considered along with https://github.com/flutter/flutter/pull/125247).

This applies the pre-existing Android Studio version detection logic to the install configured with `flutter config android-studio-dir`.

9dbd6e61

30 Apr, 2023 5 commits

Roll Flutter Engine from f234d5e1dd26 to d76a22e67eea (1 revision) (#125776) · 4b74232a

engine-flutter-autoroll authored Apr 30, 2023

https://github.com/flutter/engine/compare/f234d5e1dd26...d76a22e67eea

2023-04-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RzN-C9ZpB2ZsMq9Sn... to FV1Uu3faXL2llmvaU... (flutter/engine#41624)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from RzN-C9ZpB2Zs to FV1Uu3faXL2l

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4b74232a

Roll Flutter Engine from c796390d14cb to f234d5e1dd26 (1 revision) (#125773) · e9b9d0fb

engine-flutter-autoroll authored Apr 30, 2023

https://github.com/flutter/engine/compare/c796390d14cb...f234d5e1dd26

2023-04-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from R1rpDA1v0caZl5BFC... to uU98Ene2OeSVt21X_... (flutter/engine#41623)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from R1rpDA1v0caZ to uU98Ene2OeSV

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e9b9d0fb

Roll Flutter Engine from e99f31f4437d to c796390d14cb (1 revision) (#125762) · 9241329b

engine-flutter-autoroll authored Apr 30, 2023

https://github.com/flutter/engine/compare/e99f31f4437d...c796390d14cb

2023-04-30 skia-flutter-autoroll@skia.org Roll Skia from e98b3f40fbf2 to 5a7d7da47c10 (1 revision) (flutter/engine#41622)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9241329b

Roll Flutter Engine from 1942b0c2cd9a to e99f31f4437d (1 revision) (#125758) · 3ed5f512

engine-flutter-autoroll authored Apr 30, 2023

https://github.com/flutter/engine/compare/1942b0c2cd9a...e99f31f4437d

2023-04-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uapMevjPUC6e5zepp... to RzN-C9ZpB2ZsMq9Sn... (flutter/engine#41621)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from uapMevjPUC6e to RzN-C9ZpB2Zs

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3ed5f512

Roll Flutter Engine from 7806f8a4fb4c to 1942b0c2cd9a (1 revision) (#125757) · 9fa34e82

engine-flutter-autoroll authored Apr 30, 2023

https://github.com/flutter/engine/compare/7806f8a4fb4c...1942b0c2cd9a

2023-04-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from tz8A3SWVI56hqwnzp... to R1rpDA1v0caZl5BFC... (flutter/engine#41620)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from tz8A3SWVI56h to R1rpDA1v0caZ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9fa34e82

29 Apr, 2023 12 commits

Roll Flutter Engine from 8167f909bc8d to 7806f8a4fb4c (2 revisions) (#125750) · 845c12fb

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/8167f909bc8d...7806f8a4fb4c

2023-04-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from FUOS_QWwsi0RMumuZ... to uapMevjPUC6e5zepp... (flutter/engine#41618)
2023-04-29 skia-flutter-autoroll@skia.org Roll Skia from 3a037528ab83 to e98b3f40fbf2 (2 revisions) (flutter/engine#41619)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from FUOS_QWwsi0R to uapMevjPUC6e

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

845c12fb

Roll Flutter Engine from 900b8a89b73b to 8167f909bc8d (1 revision) (#125748) · b319b141

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/900b8a89b73b...8167f909bc8d

2023-04-29 jason-simmons@users.noreply.github.com Exclude Skia's Vello directory from the license crawl (flutter/engine#41617)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b319b141

Roll Flutter Engine from c56ea398b0dc to 900b8a89b73b (1 revision) (#125747) · 29b3e66e

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/c56ea398b0dc...900b8a89b73b

2023-04-29 jason-simmons@users.noreply.github.com Manual roll of Dart SDK from e8b86b073413 to 823a69e2a34d (flutter/engine#41614)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

29b3e66e

Roll Flutter Engine from 0834c886f06a to c56ea398b0dc (1 revision) (#125746) · 807c55c6

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/0834c886f06a...c56ea398b0dc

2023-04-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from XeUTCh70VOPbIFXdz... to tz8A3SWVI56hqwnzp... (flutter/engine#41615)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from XeUTCh70VOPb to tz8A3SWVI56h

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

807c55c6

Roll Flutter Engine from 68f2ed0a1db5 to 0834c886f06a (1 revision) (#125736) · 14981ffc

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/68f2ed0a1db5...0834c886f06a

2023-04-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from xfKYQ2vkoLvxhBHIf... to FUOS_QWwsi0RMumuZ... (flutter/engine#41611)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from xfKYQ2vkoLvx to FUOS_QWwsi0R

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

14981ffc

Roll Flutter Engine from 0079bb4a20d0 to 68f2ed0a1db5 (1 revision) (#125735) · b5a1d9c5

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/0079bb4a20d0...68f2ed0a1db5

2023-04-29 skia-flutter-autoroll@skia.org Roll Skia from c7b3371bcd48 to 3a037528ab83 (2 revisions) (flutter/engine#41609)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b5a1d9c5

Fix crasher in DragableScrollableSheet when controller is animating and switching widgets (#125721) · e1e8ad80

Dan Field authored Apr 29, 2023

We were failing to dispose of animation controllers created by `animateTo` when `didUpdateWidget` happens and we null out the `_attachedController`. This would cause the listener added here to fail on a null assertion:

https://github.com/flutter/flutter/blob/fef41cfce0e3582907f6846cf2385470bb17ecd1/packages/flutter/lib/src/widgets/draggable_scrollable_sheet.dart#L135

Without the code change, the test ends up throwing exceptions related to that line. I don't have a great way to verify what this does visually though, hoping for help on that from internal customer.

b/279930163

See cl/527868355 as well.

Fixes https://github.com/flutter/flutter/issues/125709

e1e8ad80

Roll Flutter Engine from 8f04b29c1b98 to 0079bb4a20d0 (2 revisions) (#125734) · 9417b2a4

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/8f04b29c1b98...0079bb4a20d0

2023-04-29 737941+loic-sharma@users.noreply.github.com Remove single view assumption from pointer events (flutter/engine#41602)
2023-04-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kNDuhglIFq_xEt5n3... to XeUTCh70VOPbIFXdz... (flutter/engine#41608)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from kNDuhglIFq_x to XeUTCh70VOPb

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9417b2a4

Roll Flutter Engine from 788d0ed5ed06 to 8f04b29c1b98 (1 revision) (#125731) · bd85177d

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/788d0ed5ed06...8f04b29c1b98

2023-04-29 bdero@google.com [Impeller] Remove destructive blend mode check from Contents::ShouldRender (flutter/engine#41600)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bd85177d

Roll Flutter Engine from 89a8affdced0 to 788d0ed5ed06 (1 revision) (#125729) · 0ff36a1e

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/89a8affdced0...788d0ed5ed06

2023-04-29 skia-flutter-autoroll@skia.org Roll Skia from 49412cbee072 to c7b3371bcd48 (7 revisions) (flutter/engine#41603)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0ff36a1e

Roll Flutter Engine from 3835d975c8b0 to 89a8affdced0 (2 revisions) (#125725) · 47f4d1a9

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/3835d975c8b0...89a8affdced0

2023-04-28 skia-flutter-autoroll@skia.org Roll Skia from 9867fa253064 to 49412cbee072 (13 revisions) (flutter/engine#41597)
2023-04-28 godofredoc@google.com Migrate desktop artifacts to engine v2. (flutter/engine#41599)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

47f4d1a9

Roll Flutter Engine from 1ae848ce6b55 to 3835d975c8b0 (1 revision) (#125722) · 6f85ff6b

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/1ae848ce6b55...3835d975c8b0

2023-04-28 jason-simmons@users.noreply.github.com [Impeller] Ensure that embedded blobs are placed at aligned addresses. (flutter/engine#41526)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6f85ff6b