1. 28 Sep, 2015 2 commits
    • Hixie's avatar
      Require giving a GlobalKey to UniqueComponent · 5487b954
      Hixie authored
      Having UniqueComponent automatically generate its own key is a trap. If
      anyone ever creates a UniqueComponent in a build function (rather than
      ahead of time) and forgets to pass a key, then that entire subtree is
      going to be rebuilt, including layout, every time it's updated. Since
      there's basically no way for us to catch this, we should at least force
      the author to see the explicit "new GlobalKey()" call in their code.
      5487b954
    • Adam Barth's avatar
      Actually notify GlobalKey listeners in fn3 · 64dfb849
      Adam Barth authored
      This patch makes a number of changes:
      
      1) buildDirtyComponents now prevents all calls to setState, not just those
         higher in the tree. This change is necessary for consistency with
         MixedViewport and HomogeneousViewport because those widgets already build
         subwidgets with that restriction. If the "normal" build didn't enforce that
         rule, then some widgets would break when put inside a mixed or homogeneous
         viewport.
      
      2) We now notify global key listeners in a microtask after beginFrame. That
         means setState is legal in these callbacks and that we'll produce another
         frame if someone calls setState in such a callback.
      64dfb849
  2. 27 Sep, 2015 2 commits
  3. 26 Sep, 2015 9 commits
  4. 25 Sep, 2015 27 commits