- 11 Aug, 2020 32 commits
-
-
Greg Spencer authored
This makes the processing of RawKeyboardEventData.getModifierSide consistent among the platforms. Before this change, some platforms (Android) didn't handle the case where the "either" flag was set, but no side flag was set (e.g. "shift" was set, but not "shift left"), and instead said that no keys were down by returning null (which was wrong). Some platforms (Linux, Windows) also returned KeyboardSide.any from getModifierSide, when the contract says that it will never return KeyboardSide.any. Those methods now return KeyboardSide.all in the case where no side is specified, as macOS and Fuchsia already did. Now, all platforms will return KeyboardSide.all from getModifierSide when it's not clear which side the key was on.
-
Jonah Williams authored
-
Hans Muller authored
Updated old button references in dev/integration_tests/flutter_gallery ... full_screen_dialog_demo (#63491)
-
Jonah Williams authored
-
guolinaileen authored
-
Pragya authored
-
Hans Muller authored
Updated old button references in dev/integration_tests/flutter_gallery ... transformation_demo (#63432)
-
Michael Goderbauer authored
-
Hans Muller authored
-
Greg Spencer authored
This adds an assert in RawKeyboard that catches the case where it tries to send a key down event, but (after synchronizing modifiers) there are no keys in keysPressed. This state can occur if the modifier flags are not set properly for the platform. Also prevents shortcuts attempting to handle a key down when no keys are pressed at the moment (which was causing a crash in release mode).
-
Ian Hickson authored
It now uses the scroll metrics as they stood at the end of the last frame. It previously used a weird combination of the old extents and the newish position, which led to some weird effects when the position had been changed in expectation of a viewport or content dimension change.
-
engine-flutter-autoroll authored
-
godofredoc authored
Framework tests got replaced with a new version using shards. This pr is enabling the new builders in presubmit and removing the old ones. Bug: https://github.com/flutter/flutter/issues/63258 https://github.com/flutter/flutter/issues/63242 https://github.com/flutter/flutter/issues/63241
-
Hans Muller authored
-
Hans Muller authored
-
Hans Muller authored
-
engine-flutter-autoroll authored
-
Rami authored
-
Alexandre Ardhuin authored
-
engine-flutter-autoroll authored
-
Jenn Magder authored
-
Ming Lyu (CareF) authored
-
Paul Berry authored
* Ignore dead_code hints for weak-only null checks. When https://github.com/dart-lang/sdk/issues/41985 is fixed, the analyzer will begin detecting dead code due to "unnecessary" null checks. Since we want to retain null checks in Flutter even when they appear unnecessary (in order to preserve runtime behavior in weak mode), we need to suppress these dead code hints. * Add comments explaining why we're ignoring dead_code hints
-
Ian Hickson authored
-
engine-flutter-autoroll authored
-
Ming Lyu (CareF) authored
-
Rustom Ichhaporia authored
-
Panmari authored
-
James D. Lin authored
-
Michael Goderbauer authored
-
Francesco Iapicca authored
-
Jenn Magder authored
-
- 10 Aug, 2020 8 commits
-
-
Jonah Williams authored
This reverts commit 74b5051c.
-
LI DONGZE authored
* Add native stacktrace field for PlatformException * Mute the readValue check for stacktrace. * polish * Add unit test and further polish * Added more comments * remove unnecessary import * fill in stacktrace to JSONMethodCodec and fix tests Co-authored-by: Ben Li <libe@google.com>
-
Ian Hickson authored
-
Ming Lyu (CareF) authored
-
Ming Lyu (CareF) authored
-
Michael Klimushyn authored
-
xubaolin authored
-
Hans Muller authored
-