Commits · 51f7fdbc169740564239a2e749ce1ada4302a1b7 · abdullh.alsoleman / Front-End

25 May, 2023 24 commits

Roll Flutter Engine from 6a4e675ab0b4 to ff04d2fdd12b (3 revisions) (#127630) · 51f7fdbc

engine-flutter-autoroll authored May 25, 2023

https://github.com/flutter/engine/compare/6a4e675ab0b4...ff04d2fdd12b

2023-05-25 flar@google.com Move checkerboard unit tests onto DisplayList mechanism (flutter/engine#41951)
2023-05-25 jacksongardner@google.com [Skwasm] Implement miscellaneous drawing APIs (flutter/engine#42324)
2023-05-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from X4uS4T6_J-VUh9M4A... to AgIKKqtBtb6RJnyI9... (flutter/engine#42326)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from X4uS4T6_J-VU to AgIKKqtBtb6R

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

51f7fdbc

Roll Flutter Engine from 99f2653cbb79 to 6a4e675ab0b4 (2 revisions) (#127625) · 2460e63f

engine-flutter-autoroll authored May 25, 2023

https://github.com/flutter/engine/compare/99f2653cbb79...6a4e675ab0b4

2023-05-25 skia-flutter-autoroll@skia.org Roll Skia from e648bf802cd2 to bd677c195886 (2 revisions) (flutter/engine#42325)
2023-05-25 dkwingsmt@users.noreply.github.com [Rasterizer] Make resubmit information temporary (flutter/engine#42001)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2460e63f

Append $flutter/osx sdk property to existing platforms/targets relying on xcode (#127537) · 3eecc217
keyonghan authored May 25, 2023
```
Part of https://github.com/flutter/flutter/issues/127534
```
3eecc217
Indent markdown value on CP issue template (#127623) · ce894e84
Casey Hillers authored May 25, 2023
```
Fixes https://github.com/flutter/flutter/issues/127592
```
ce894e84

Roll Flutter Engine from 6ff02c17268f to 99f2653cbb79 (6 revisions) (#127619) · 08266bdf

engine-flutter-autoroll authored May 25, 2023

https://github.com/flutter/engine/compare/6ff02c17268f...99f2653cbb79

2023-05-25 jacksongardner@google.com Implement Web Codecs for Skwasm (flutter/engine#42184)
2023-05-25 godofredoc@google.com Move linux clang tidy to engine_v2. (flutter/engine#42112)
2023-05-25 skia-flutter-autoroll@skia.org Roll Skia from 69d0aa065992 to e648bf802cd2 (11 revisions) (flutter/engine#42323)
2023-05-25 jacksongardner@google.com Only use 8 cores for web test compilation. (flutter/engine#42321)
2023-05-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from nLnQzTesaABpgroOl... to DNwJQMQZladAsKTjv... (flutter/engine#42322)
2023-05-25 valentin.haloiu@gmail.com Dynamically link against system fontconfig (flutter/engine#40725)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from nLnQzTesaABp to DNwJQMQZladA

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

08266bdf

`ProcessResultMatcher` created and used in test (#127414) · cb3b1f8c

Elias Yishak authored May 25, 2023

Addresses issues:
- https://github.com/flutter/flutter/issues/127135
- https://github.com/flutter/flutter/issues/99767

Creates a matcher class that we can use for `ProcessResult` to check for the exit code.

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

cb3b1f8c

Fix yaml lint issue (#127600) · 8576da53

Casey Hillers authored May 25, 2023

Fixes https://github.com/flutter/flutter/issues/127592

Tested by pasting this file into a yaml formatter.

8576da53

Roll Flutter Engine from 515a4bfc4b6e to 6ff02c17268f (1 revision) (#127609) · 93103743

engine-flutter-autoroll authored May 25, 2023

https://github.com/flutter/engine/compare/515a4bfc4b6e...6ff02c17268f

2023-05-25 matej.knopp@gmail.com [macOS] Fix FlutterViewController retain cycle (flutter/engine#42317)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

93103743

`SearchBar` should not be impacted by overall `InputDecorationTheme` (#127465) · 9fa35180
Qun Cheng authored May 25, 2023

9fa35180

Roll Flutter Engine from 195009b91abd to 515a4bfc4b6e (4 revisions) (#127601) · f71075db

engine-flutter-autoroll authored May 25, 2023

https://github.com/flutter/engine/compare/195009b91abd...515a4bfc4b6e

2023-05-25 dnfield@google.com Implement PlatformDispatcher.displays on web (flutter/engine#42297)
2023-05-25 skia-flutter-autoroll@skia.org Roll Skia from b80e74dc4cda to 69d0aa065992 (3 revisions) (flutter/engine#42319)
2023-05-25 bdero@google.com [Impeller] Safely access snapshot in the pipeline blend filter (flutter/engine#42314)
2023-05-25 bdero@google.com [Impeller] Add generic path for mask blurring (flutter/engine#42308)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f71075db

Roll Flutter Engine from fb463217d1f3 to 195009b91abd (1 revision) (#127591) · e583ba4c

engine-flutter-autoroll authored May 25, 2023

https://github.com/flutter/engine/compare/fb463217d1f3...195009b91abd

2023-05-25 skia-flutter-autoroll@skia.org Roll Skia from fbba25f66405 to b80e74dc4cda (2 revisions) (flutter/engine#42316)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e583ba4c

avoid incorrect usage of TimelineTask (#127527) · a21f33e7
Dan Field authored May 25, 2023
```
This code was added based on a misunderstanding of the API surface.
```
a21f33e7

Add `ScrollNotificationObserver` sample (#127023) · c05a05e6

Taha Tesser authored May 25, 2023

fixes https://github.com/flutter/flutter/issues/126702

### Preview

https://github.com/flutter/flutter/assets/48603081/4c529a0d-b8a5-4950-9095-429f1c5eccbb

c05a05e6

Roll Packages from fba97fa4cc86 to 995bfc5f9857 (3 revisions) (#127590) · 3e610f73

engine-flutter-autoroll authored May 25, 2023

https://github.com/flutter/packages/compare/fba97fa4cc86...995bfc5f9857

2023-05-24 engine-flutter-autoroll@skia.org Roll Flutter from f86c529b to 216605b6 (18 revisions) (flutter/packages#4071)
2023-05-24 stuartmorgan@google.com [various] Fixes `unawaited_futures` violations (flutter/packages#4067)
2023-05-24 48731731+phcs971@users.noreply.github.com [quick_actions] Fix iOS home screen quick actions documentation hyperlink (flutter/packages#4059)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3e610f73

Roll Flutter Engine from a74d9d1f4776 to fb463217d1f3 (1 revision) (#127577) · 60a64a5a

engine-flutter-autoroll authored May 25, 2023

https://github.com/flutter/engine/compare/a74d9d1f4776...fb463217d1f3

2023-05-25 skia-flutter-autoroll@skia.org Roll Dart SDK from be01f9fdac37 to 0e78305875a4 (1 revision) (flutter/engine#42313)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

60a64a5a

Roll Flutter Engine from a7f026b03e35 to a74d9d1f4776 (1 revision) (#127565) · 20e164e6

engine-flutter-autoroll authored May 25, 2023

https://github.com/flutter/engine/compare/a7f026b03e35...a74d9d1f4776

2023-05-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from RSSC61ubl9JXmn4JO... to X4uS4T6_J-VUh9M4A... (flutter/engine#42311)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from RSSC61ubl9JX to X4uS4T6_J-VU

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

20e164e6

Roll Flutter Engine from fb38bb6b1bc1 to a7f026b03e35 (1 revision) (#127563) · 1a17ba0e

engine-flutter-autoroll authored May 25, 2023

https://github.com/flutter/engine/compare/fb38bb6b1bc1...a7f026b03e35

2023-05-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 96e29af6e0c6 to be01f9fdac37 (2 revisions) (flutter/engine#42310)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1a17ba0e

Roll Flutter Engine from 2be736c390ee to fb38bb6b1bc1 (1 revision) (#127560) · 54d001d4

engine-flutter-autoroll authored May 25, 2023

https://github.com/flutter/engine/compare/2be736c390ee...fb38bb6b1bc1

2023-05-25 skia-flutter-autoroll@skia.org Roll Skia from 7ec172b433f1 to fbba25f66405 (2 revisions) (flutter/engine#42309)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

54d001d4

Remove Tooltip mouse tracker listener & update hovering/MouseRegion logic & animation (#119199) · 1b800fd4

LongCatIsLooong authored May 25, 2023

Fixes https://github.com/flutter/flutter/issues/117627

### Behavior changes:
1. If fade in/fade out animation is already in progress, hiding/showing the tooltip will immediately take effect without waiting for `waitDuration`.
2. A PointerDownEvent that doesn't become a part of a "trigger" gesture dismisses the tooltip, even for hovered ones.
3. The OverlayEntry is now updated only when the previous tooltip was completely dismissed. This can be fixed by OverlayPortal but I'm not sure what the correct behavior is.

1b800fd4

Roll Flutter Engine from 37ebad2d5c27 to 2be736c390ee (2 revisions) (#127554) · 9da1d98a

engine-flutter-autoroll authored May 25, 2023

https://github.com/flutter/engine/compare/37ebad2d5c27...2be736c390ee

2023-05-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UYN_Tk7M6_5d2aGIj... to nLnQzTesaABpgroOl... (flutter/engine#42307)
2023-05-25 bdero@google.com [Impeller] Simplify CreateContentsForGeometry overloads (flutter/engine#42306)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from UYN_Tk7M6_5d to nLnQzTesaABp

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9da1d98a

Roll Flutter Engine from 62a83490ee60 to 37ebad2d5c27 (1 revision) (#127551) · b49830b3

engine-flutter-autoroll authored May 25, 2023

https://github.com/flutter/engine/compare/62a83490ee60...37ebad2d5c27

2023-05-25 skia-flutter-autoroll@skia.org Roll Skia from 150d534341a4 to 7ec172b433f1 (1 revision) (flutter/engine#42305)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b49830b3

Roll Flutter Engine from 1bed04a4375a to 62a83490ee60 (3 revisions) (#127546) · 9e4104b0

engine-flutter-autoroll authored May 25, 2023

https://github.com/flutter/engine/compare/1bed04a4375a...62a83490ee60

2023-05-25 54558023+keyonghan@users.noreply.github.com Append $flutter/osx sdk property to existing platforms/targets relying on xcode (flutter/engine#42299)
2023-05-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 9bea16a7dcbd to 96e29af6e0c6 (1 revision) (flutter/engine#42303)
2023-05-25 skia-flutter-autoroll@skia.org Roll Skia from 76bae143aded to 150d534341a4 (2 revisions) (flutter/engine#42301)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9e4104b0

Roll Flutter Engine from 6a361090a367 to 1bed04a4375a (2 revisions) (#127544) · 5eacfe62

engine-flutter-autoroll authored May 25, 2023

https://github.com/flutter/engine/compare/6a361090a367...1bed04a4375a

2023-05-24 30870216+gaaclarke@users.noreply.github.com [Impeller] Turn on vulkan tests for mac CI. (flutter/engine#42225)
2023-05-24 jonahwilliams@google.com [Impeller] fix UV and color blending. (flutter/engine#42293)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5eacfe62

Roll Flutter Engine from 9ba461efd3fe to 6a361090a367 (3 revisions) (#127542) · 9516368e

engine-flutter-autoroll authored May 25, 2023

https://github.com/flutter/engine/compare/9ba461efd3fe...6a361090a367

2023-05-24 godofredoc@google.com Use engine_v2 builds on recipe testing. (flutter/engine#42298)
2023-05-24 jason-simmons@users.noreply.github.com [Impeller] Golden test for text with a shader and a transform (flutter/engine#42291)
2023-05-24 skia-flutter-autoroll@skia.org Roll Skia from 593ece8f74c7 to 76bae143aded (13 revisions) (flutter/engine#42295)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9516368e

24 May, 2023 16 commits

Revert "Update labeler action wildcards" (#127541) · 20eb5adf
Casey Hillers authored May 24, 2023
```
Reverts flutter/flutter#127524

Bad YAML format is blocking presubmit PRs.
```
20eb5adf

[web] ui.platformViewRegistry => ui_web.platformViewRegistry (#127493) · 2d142c5b

Mouad Debbar authored May 24, 2023

Now that `platformViewRegistry` is [exposed](https://github.com/flutter/engine/pull/41877) through `dart:ui_web`, we can do some cleanup here.

Part of https://github.com/flutter/flutter/issues/126831

2d142c5b

Roll Flutter Engine from c641f6307f08 to 9ba461efd3fe (6 revisions) (#127536) · ef54879b

engine-flutter-autoroll authored May 24, 2023

https://github.com/flutter/engine/compare/c641f6307f08...9ba461efd3fe

2023-05-24 mdebbar@google.com [web] Remove comment about dart:html migration (flutter/engine#42290)
2023-05-24 mdebbar@google.com [web] Hide JS types from dart:ui_web (flutter/engine#42252)
2023-05-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qoLy9E5PjnAlICjUb... to RSSC61ubl9JXmn4JO... (flutter/engine#42287)
2023-05-24 marcianx@gmail.com [web] Update a11y announcements to append divs instead of setting content. (flutter/engine#42258)
2023-05-24 jonahwilliams@google.com [Impeller] fix Xcode frame capture. (flutter/engine#42289)
2023-05-24 jason-simmons@users.noreply.github.com [Impeller] Create an autorelease pool for Impeller tests running on macOS. (flutter/engine#42265)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from qoLy9E5PjnAl to RSSC61ubl9JX

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ef54879b

Add missing parameters in `TextFormField` (#127020) · 7827a242

lsaudon authored May 24, 2023

`TextFormField` does not have all the parameters of `TextField`.

Added:
```dart
    UndoHistoryController? undoController,
    AppPrivateCommandCallback? onAppPrivateCommand,
    bool? cursorOpacityAnimates,
    ui.BoxHeightStyle selectionHeightStyle = ui.BoxHeightStyle.tight,
    ui.BoxWidthStyle selectionWidthStyle = ui.BoxWidthStyle.tight,
    DragStartBehavior dragStartBehavior = DragStartBehavior.start,
    ContentInsertionConfiguration? contentInsertionConfiguration,
    Clip clipBehavior = Clip.hardEdge,
    bool scribbleEnabled = true,
    bool canRequestFocus = true,
```

7827a242

Update labeler action wildcards (#127524) · 99f792e0
Casey Hillers authored May 24, 2023
```
https://github.com/flutter/flutter/issues/126002
```
99f792e0

Improve `TextPainter.layout` caching (#118128) · 62e78bf1

LongCatIsLooong authored May 24, 2023

Improves `TextPainter.layout` caching when only the input constraints change: 
- removes the double layout calls in `TextPainter._layoutParagraph`: now double layout is only needed when `TextAlign` is not left, and the input `maxWidth == double.infinity`.  
- skip calls to `ui.Paragraph.layout` when it's guaranteed that there's no soft line breaks before/after the layout call.

This doesn't introduce new APIs but may slightly shift text rendered on screen.
This reduces the number of `layout` calls but since shaping results are already cached so it only skips the relatively cheap line-breaking process when possible.

528 scuba failures but all of them seem reasonable.

62e78bf1

Bump actions/labeler from 2713f7303c96cb1e69627957ec16eea0fd7f94a4 to... · 4d1c6a43

dependabot[bot] authored May 24, 2023

Bump actions/labeler from 2713f7303c96cb1e69627957ec16eea0fd7f94a4 to 0776a679364a9a16110aac8d0f40f5e11009e327 (#127533)

Bumps [actions/labeler](https://github.com/actions/labeler) from 2713f7303c96cb1e69627957ec16eea0fd7f94a4 to 0776a679364a9a16110aac8d0f40f5e11009e327.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/labeler/commit/0776a679364a9a16110aac8d0f40f5e11009e327"><code>0776a67</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/571">#571</a> from akv-platform/remove-implicit-dependencies</li>
<li><a href="https://github.com/actions/labeler/commit/08382d15cbe3356793d4187dcd9792a2d10cb03c"><code>08382d1</code></a> Move eslint-plugin-node to dev dependencies</li>
<li><a href="https://github.com/actions/labeler/commit/d1dd326cccf2f7c059720fe6ad43b76abd786264"><code>d1dd326</code></a> Install eslint-plugin-node</li>
<li><a href="https://github.com/actions/labeler/commit/91076827ed0d4506993bae4f3cf7aacc578c9a3f"><code>9107682</code></a> Update configuration files</li>
<li>See full diff in <a href="https://github.com/actions/labeler/compare/2713f7303c96cb1e69627957ec16eea0fd7f94a4...0776a679364a9a16110aac8d0f40f5e11009e327">compare view</a></li>
</ul>
</details>
<br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

4d1c6a43

Fix ScrollPosition overscroll precision error (#127321) · 2b105ac6

Bruno Leroux authored May 24, 2023

## Description

This PR fixes a precision error in ~~`ClampingScrollPhysics`~~ `ScrollPosition` that leads to `StretchingOverscrollIndicator` stretching its content unexpectedly in some devices (see  https://github.com/flutter/flutter/issues/126561 where this is visible in `TabBarView` and the test added in this PR where it reproduces with a `PageView`).

~~This PR also contains a change to `nested_scroll_view.dart` because the first change (the one in `ClampingScrollPhysics`)  breaks the precision error test added by https://github.com/flutter/flutter/pull/87801.~~

## Related Issue

Fixes https://github.com/flutter/flutter/issues/126561

## Tests

Adds 1 test.

2b105ac6

`Slider.onChangeStart` & `Slider.onChangeEnd` are not called on keyboard shortcuts (#126896) · 5451ea6e

Devin authored May 24, 2023

fixes https://github.com/flutter/flutter/issues/123315
--------

This PR makes changes to the _actionHandler function used on the Slider.Dart Widget for Key Events. It ensures onChangeStart is called at the beginning of a Key Event and onChangeEnd at the end of one. This PR includes a test for the changes made.
I ran all existing tests after my changes were made and they passed.

5451ea6e

Manually roll Flutter Engine from 0c41b02cd5a6 to c641f6307f08 (#127514) · 982e0052

Brandon DeRosier authored May 24, 2023

Rolls engine to head with
[fixes](https://github.com/flutter/flutter/pull/127505) corresponding to
the [latest Dart roll](https://github.com/flutter/engine/pull/42286).

982e0052

Update CP template to include timeline and changelog (#127507) · eea12df3
Casey Hillers authored May 24, 2023
```
Based on recent feedback. Give more information in the CP template.
```
eea12df3
make `suggestionsBuilder` in `SearchAnchor` asyncable (#127019) · 7b67aa58
Sun Jiao authored May 24, 2023

7b67aa58

Log all lines from ios-deploy (#127502) · a19b3436

Victoria Ashworth authored May 24, 2023

Reland https://github.com/flutter/flutter/pull/127222 that was reverted in https://github.com/flutter/flutter/pull/127405.

Fixed `Mac_ios microbenchmarks_ios` test failure by not echoing logs twice.

a19b3436

Revert "Replace rsync when unzipping artifacts on a Mac (#126703)" (#127430) · 555326b2
Victoria Ashworth authored May 24, 2023
```
This reverts commit 2b3cd7f4.

Fixes https://github.com/flutter/flutter/issues/127281.
```
555326b2
test owners: cyanglaz -> vashworth (#127391) · 9232834e
Chris Yang authored May 24, 2023
```
Changes the test owners to @vashworth while I'm OOO.
```
9232834e

[Linux] Ignore deprecation of libupower call in example (#127503) · edf4a91f

Chris Bracken authored May 24, 2023

The Linux platform channels sample makes a call to the libupower
function `up_client_get_devices`, which was deprecated in libupower
0.99.8 in favour of `up_client_get_devices2`.

The prod bots have been migrated to focal, which ships libupower 0.99.11
in which the old function is deprecated and the new one is available.

The try bots have not yet been migrated and remain on bionic, which
ships libupower 0.99.7 in which the old function is not deprecated and
the new one is not available.

This marks the line in question to ignore deprecation warnings. Once all
bots have migrated to focal, we'll migrate to the new function. See
tracking issue below.

See:
https://upower.freedesktop.org/docs/UpClient.html#up-client-get-devices

Issue: https://github.com/flutter/flutter/issues/127506

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

edf4a91f