- 31 Aug, 2023 1 commit
-
-
Pierrick Bouvier authored
To implement windows-arm64 support, it is needed to add architecture as a subdirectory (https://github.com/flutter/flutter/issues/129805). In short, when performing a flutter windows build, we have: - Before: build/windows/runner/Release/gallery.exe - After: build/windows/x64/runner/Release/gallery.exe This convention follows what flutter linux build does. Addresses: https://github.com/flutter/flutter/issues/129805 Addresses: https://github.com/flutter/flutter/issues/116196 Design doc: [flutter.dev/go/windows-arm64](https://flutter.dev/go/windows-arm64)
-
- 29 Jun, 2023 1 commit
-
-
lsaudon authored
Some files are supposed to ignore, but don't. - **/windows/flutter/generated_plugins.cmake - **/linux/flutter/generated_plugin_registrant.cc - **/linux/flutter/generated_plugin_registrant.h - **/linux/flutter/generated_plugins.cmake - **/windows/flutter/generated_plugin_registrant.cc - **/windows/flutter/generated_plugin_registrant.h - **/ios/Runner/GeneratedPluginRegistrant.h - **/ios/Runner/GeneratedPluginRegistrant.m *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
- 31 May, 2023 1 commit
-
-
Loïc Sharma authored
Address Tong's feedback here: https://github.com/flutter/flutter/issues/127695#issuecomment-1564884872 Follow-up to: https://github.com/flutter/flutter/pull/127046
-
- 19 May, 2023 1 commit
-
-
Loïc Sharma authored
## Background The Windows runner has a race at startup: 1. **Platform thread**: creates a hidden window 2. **Platform thread**: launches the Flutter engine 3. **UI/Raster threads**: renders the first frame 4. **Platform thread**: Registers a callback to show the window once the next frame has been rendered. Steps 3 and 4 happen in parallel and it is possible for step 3 to complete before step 4 starts. In this scenario, the next frame callback is never called and the window is never shown. As a result the `windows_startup_test`'s test, which [verifies that the "show window" callback is called](https://github.com/flutter/flutter/blob/1f09a8662dad3bb1959b24e9124e05e2b9dbff1d/dev/integration_tests/windows_startup_test/windows/runner/flutter_window.cpp#L60-L64), can flake if the first frame is rendered before the show window callback has been registered. ## Solution This change makes the runner schedule a frame after it registers the next frame callback. If step 3 hasn't completed yet, this no-ops as a frame is already scheduled. If step 3 has already completed, a new frame will be rendered, which will call the next frame callback and show the window. Part of https://github.com/flutter/flutter/issues/119415 See this thread for alternatives that were considered: https://github.com/flutter/engine/pull/42061#issuecomment-1550080722
-
- 28 Apr, 2023 1 commit
-
-
yaakovschectman authored
~Update the windows app template and migration to use `CMP0135` when cmake version is >= 3.24.~ Update app templates' and examples' CMakeLists.txt to use `cmake_policy(VERSION`. https://github.com/flutter/packages/pull/3828 should obviate the need for a migration. Addresses https://github.com/flutter/flutter/issues/116866 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
- 23 Feb, 2023 1 commit
-
-
Lioness100 authored
* Fix typos * lowercase animated & opacity * Undo typo fix --------- Co-authored-by: Michael Goderbauer <goderbauer@google.com>
-
- 13 Feb, 2023 1 commit
-
-
Tomasz Gucio authored
--------- Co-authored-by: schectman <schectman@google.com>
-
- 09 Sep, 2022 1 commit
-
-
Loïc Sharma authored
-
- 03 Sep, 2022 1 commit
-
-
Jenn Magder authored
-
- 02 Sep, 2022 1 commit
-
-
Loïc Sharma authored
-
- 30 Aug, 2022 1 commit
-
-
Loïc Sharma authored
-
- 11 Aug, 2022 1 commit
-
-
Peter Eliasson authored
-
- 30 Jun, 2022 1 commit
-
-
stuartmorgan authored
-
- 27 Jun, 2022 1 commit
-
-
Loïc Sharma authored
Previously developers had to edit their `Runner.rc` file to update their executable's version information. Now, version information will automatically be set from `flutter build`'s arguments or the `pubspec.yaml` file for new projects. Addresses https://github.com/flutter/flutter/issues/73652
-
- 27 May, 2022 1 commit
-
-
Tim Sneath authored
-
- 08 Mar, 2022 1 commit
-
-
Chris Bracken authored
This patch adds an additional check to ensure the target length of a string is within the supported maximum string length prior to calling WideCharToMultiByte/MultiByteToWideChar in the Windows runner template. This is to prevent resize() from failing if called with a count > std::string::max_size(). According to Win32 API docs (WideCharToMultiByte, MultiByteToWideChar) it's the caller responsibility to make sure the buffers are correctly allocated. Authored by: Tomasz Gucio <tgucio@gmail.com>
-
- 09 Feb, 2022 1 commit
-
-
Pierre-Louis authored
-
- 07 Jan, 2022 1 commit
-
-
Greg Spencer authored
Updates the platform shims in dev/manual_tests so that Windows and Linux can be built. I had to update the Windows shims, because I was unable to build a Windows app there. Also updates the analyze.dart script to report all license issues simultaneously instead of just dying after the first failure. The only substantive code changes are in dev/bots/analyze.dart and dev/bots/test/analyze_test.dart
-
- 04 Sep, 2021 1 commit
-
-
Chris Bracken authored
When we landed the CMake minimum requirement constraint for Visual Studio 2019, we landed it with minimum version 3.15, since that's what was shipping with the current version of VS 2019 at the time. Looking at the release notes of earlier versions, it's clear that earlier versions of Visual Studio 2019 shipped with version 3.14. See: https://devblogs.microsoft.com/cppblog/visual-studio-cmake-support-clang-llvm-cmake-3-14-vcpkg-and-performance-improvements/ Looking at release notes for CMake 3.15, there are no features/fixes introduced in that version that we are dependent on. https://cmake.org/cmake/help/latest/release/3.15.html Issue: https://github.com/flutter/flutter/issues/88589
-
- 16 Jul, 2021 1 commit
-
-
Kaushik Iska authored
-
- 21 May, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 05 Mar, 2021 2 commits
-
-
Andre authored
-
Chris Bracken authored
This adds support for building and running manual tests, such as the raw keyboard test on Windows desktop.
-