- 26 Apr, 2023 1 commit
-
-
Tae Hyung Kim authored
Refactor "gen-l10n" command to use same code path when "l10n.yaml" is present or not present (#125429) I think this is a long needed change to the `gen-l10n` command. Essentially, the arguments to `flutter gen-l10n` can be provided by two different methods: via command line arguments or via the `l10n.yaml` file. The existence of a `l10n.yaml` file causes the latter approach to take precedence. However, currently, there's several differences in how the two approaches are handled, and most of the default arguments are all over the place, causing unexpected issues such as #120457 or #120023. This PR refactors the command so that * `LocalizationOptions` are more consistent with the actual argument names/yaml options. * All default values are determined in `LocalizationOptions`'s constructor (or in `argParser.addOption(...)` in the case a boolean value needs to be explicitly true). * New `parseLocalizationsOptionsFromCommand` function to parse arguments. * Parse `LocalizationOptions` at the beginning of `runCommand()` and pass it to `generateLocalizations`. Fixes #120023.
-
- 25 Apr, 2023 1 commit
-
-
Tae Hyung Kim authored
Currently, the code doesn't properly handle strings which contain dollar signs. The return expression for the generated localization function is computed by `generateReturnExpr` which concatenates several strings, which are either interpolated placeholders, interpolated function calls, or normal strings, but we didn't properly escape dollar signs before sending normal strings to `generateReturnExpr`. Fixes #125461.
-
- 06 Apr, 2023 1 commit
-
-
Albert Wolszon authored
`intl` [0.18.0 added](https://pub.dev/packages/intl/changelog#0180) a [`NumberFormat.decimalPatternDigits`](https://pub.dev/documentation/intl/latest/intl/NumberFormat/NumberFormat.decimalPatternDigits.html) pattern that allows `decimalDigits` param. Fixes #122785 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] ~I updated/added relevant documentation (doc comments with `///`).~ - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
- 22 Mar, 2023 2 commits
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
Christopher Fujino authored
[flutter_tools] toolexit on malformed yaml during gen-l10n
-
- 17 Feb, 2023 1 commit
-
-
Ian Hickson authored
* lerp documentation * Remove Note, Note That from repo * Improve BorderSide documentation. * apply review comments
-
- 13 Feb, 2023 1 commit
-
-
Tae Hyung Kim authored
* init * fix error handling * fix issue * lint? * error handling tests * lint
-
- 01 Feb, 2023 1 commit
-
-
Alex Li authored
*
Do not format the messages file * Add test * Add the link to the test * Respect the path separator from the file system * Add the untranslated messages file existence test
-
- 31 Jan, 2023 1 commit
-
-
Tae Hyung Kim authored
* init * lint * lint again
-
- 25 Jan, 2023 2 commits
-
-
Tae Hyung Kim authored
-
Ahmed Ashour authored
* Remove superfluous words from comments. * Revert `win32_window.h` Which seems to come from `gallery`
-
- 23 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes * fix after merge conflicts * review
-
- 10 Jan, 2023 1 commit
-
-
Tae Hyung Kim authored
-
- 11 Dec, 2022 1 commit
-
-
Ian Hickson authored
-
- 08 Dec, 2022 1 commit
-
-
Tae Hyung Kim authored
* init * add comment * make error more actionable
-
- 06 Dec, 2022 1 commit
-
-
Tae Hyung Kim authored
* init * empty commit to start google testing
-
- 01 Dec, 2022 1 commit
-
-
Ahmed Ashour authored
* [gen_l10n] keys can contain dollar sign Fixes #112250 * Update packages/flutter_tools/lib/src/localizations/gen_l10n.dart Co-authored-by:
Christopher Fujino <fujino@google.com>
-
- 30 Nov, 2022 1 commit
-
-
Tae Hyung Kim authored
* init * fix tests * fix lint * extra changes * oops missed some merge conflicts * fix lexer add tests * consistent warnings and errors * throw error at the end * improve efficiency, improve code generation * fix * nit * fix test * remove helper method class * two d's * oops * empty commit as google testing won't pass :(
-
- 29 Nov, 2022 1 commit
-
-
Tae Hyung Kim authored
* init * make more descriptive * fix lint
-
- 28 Nov, 2022 1 commit
-
-
Tae Hyung Kim authored
* init * more fixing * finish * fix lint * address pr comments * redo checks
-
- 05 Nov, 2022 1 commit
-
-
Tae Hyung Kim authored
* init * code generation * improve syntax error, add tests * add tests and fix bugs * code generation fix * fix all tests :) * fix bug * init * fix all code gen issues * FIXED ALL TESTS :D * add license * remove trailing spaces * remove print * tests fix * specify type annotation * fix test * lint * fix todos * fix subclass issues * final fix; flutter gallery runs * escaping for later pr * fix comment * address PR comments * more * more descriptive errors * last fixes
-
- 16 Sep, 2022 1 commit
-
-
Liam Appelbe authored
This reverts commit f8f69575.
-
- 13 Sep, 2022 1 commit
-
-
Zachary Anderson authored
-
- 12 Sep, 2022 1 commit
-
-
Liam Appelbe authored
* Migrate packages/flutter_tools/bin * Fix NPE * Fix test * Fix test * Fix l10n optionalParameters * Fix ChromeTab nullability * Fix another type cast error * Fix another cast error * Fix another cast error (copied from #110711) * Fix NPE * Fix another NPE * Assert that testDirectory is not null
-
- 19 Aug, 2022 1 commit
-
-
Tae Hyung Kim authored
* init * fix * fix 2 * fix 3 * tests * fix tests * clarify help text * fix all tests * fix formatting? * add second test * unused import * remove print * trailing spaces * artifacts is never null * fix
-
- 26 Jul, 2022 1 commit
-
-
Tae Hyung Kim authored
[gen_l10n] Warn users when placeholder types are converted to 'num' when using pluralization (#108036) * init * asdf * fix tests * change warning slightly * fix test again * fix spacing and comment * fix lint
-
- 15 Jul, 2022 2 commits
-
-
Christopher Fujino authored
-
Tae Hyung Kim authored
-
- 12 May, 2022 1 commit
-
-
Alex Li authored
-
- 06 May, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Apr, 2022 1 commit
-
-
Phil Quitslund authored
-
- 24 Apr, 2022 1 commit
-
-
Alex Li authored
-
- 02 Feb, 2022 1 commit
-
-
Lau Ching Jun authored
-
- 23 Nov, 2021 1 commit
-
-
Tarekk Mohamed Abdalla authored
-
- 17 Nov, 2021 3 commits
-
-
Danny Tuppeny authored
-
Hans Muller authored
This reverts commit 16f44118.
-
Taha Tesser authored
-
- 10 Nov, 2021 1 commit
-
-
Shueh Chou Lu authored
-
- 08 Nov, 2021 1 commit
-
-
J-P Nurmi authored
-
- 08 Oct, 2021 1 commit
-
-
Ian Hickson authored
-