1. 06 Oct, 2017 2 commits
  2. 03 Oct, 2017 1 commit
  3. 02 Oct, 2017 2 commits
    • gspencergoog's avatar
      Add framework support for system text scale factor. (#12180) · 18f0d3ae
      gspencergoog authored
      * Add framework-side support for system text scale factor.
      
      * Rolling engine to e3404b81a53ba3180c7623a6f2190ebb28518f30
        Additional changes rolled in with engine change:
          libtxt: implementation of GetRectsForRange that processes a line at a time - e3404b8
          Provide an entropy source to the Dart engine (#4161) - e1aa867
          libtxt: search for fallback fonts that can match emoji and CJK characters - 8061df1
          Roll skia to e4679fa06a. (#4157) - 267e7a8
          Update buildroot to 53fea9aebbcc39c6522731471a1a45960ee0685e (#4160) - 02ea7ae
          Revert engine Dart roll. (#4158) - 14aab33
          Add support for system text scale factor. (#4124) - b2a7f4b
          Include _http into sky_engine libraries for analyzer (#4154) - b930f10
          libtxt: Remove postprocess_line and improve tracking of X offsets - 86f95f0
          libtxt: remove redundant line_widths (#4152) - 14bf515
          Roll dart to ade37f931e90b0fdb8fe16d6bf6f089545da55b6 (#4151) - 6f1264f
      18f0d3ae
    • Adam Barth's avatar
      Replace usage of FractionalOffset with Alignment (#12348) · 0044ea2d
      Adam Barth authored
      Alignment will eventually replace FractionalOffset.
      0044ea2d
  4. 27 Sep, 2017 1 commit
  5. 26 Sep, 2017 1 commit
  6. 25 Sep, 2017 1 commit
  7. 22 Sep, 2017 3 commits
  8. 21 Sep, 2017 1 commit
  9. 11 Sep, 2017 1 commit
  10. 08 Sep, 2017 1 commit
    • Adam Barth's avatar
      Rename BannerLocation enum values (#11960) · 1792766a
      Adam Barth authored
      * Rename BannerLocation enum values
      
       * topLeft -> topStart
       * topRight -> topEnd
       * bottomLeft -> bottomStart
       * bottomRight -> bottomEnd
      
      These names will make it easier for us to adjust the location of the
      banner in right-to-left mode.
      
      See the discussion on flutter-dev.
      
      * Add RTL support for Banner
      
      Fixes #11905
      1792766a
  11. 24 Aug, 2017 1 commit
  12. 15 Aug, 2017 1 commit
  13. 09 Aug, 2017 1 commit
  14. 08 Aug, 2017 1 commit
    • Michael Goderbauer's avatar
      Don't trigger an assert when markNeedsSemanticsUpdate is called multiple times... · b551f534
      Michael Goderbauer authored
      Don't trigger an assert when markNeedsSemanticsUpdate is called multiple times in edge cases (#11544)
      
      * Don't trigger assert if a render object ceases to be a semantic boundary
      
      This bug was exposed by https://github.com/flutter/flutter/pull/11309, which caused the following assertion to trigger when scrolling in the Animation demo:
      
      ```
      The following assertion was thrown during _updateSemantics():
      'package:flutter/src/rendering/object.dart': Failed assertion: line 2626 pos 16: 'fragment is
      _InterestingSemanticsFragment': is not true.
      ```
      
      A minimal reproduction of the bug can be found in `semantics_10_test.dart`, which has been added as a regression test for the bug by this PR.
      
      Looking at that test, here is a description of the faulty behaviour:
      1. During the second `pumpWidget` call `RenderExcludeSemantics` marks itself as needing a semantics update (due to excluding going from `false` -> `true`).
      2. This causes the nearest ancestor with semantics information (here: `RenderSemanticsAnnotations` representing the "container" Semantics widget) to be added to the `_nodesNeedingSemantics` list.
      3. `RenderSliverList` (implementation behind ListView) marks itself as needing a semantics update (due to its changing children).
      4. This causes the `RenderSemanticsGestureHandler` to be added to the `_nodesNeedingSemantics` list.
      5. Next, canDrag is updated from `true` -> `false`. This means, `RenderSemanticsGestureHandler` is no longer a semantics boundary, it marks itself as needing a semantics update.
      6. The nearest ancestor with semantics (`RenderSemanticsAnnotations`, the "container") is added to the `_nodesNeedingSemantics` list (this is a no-op because it is already in the list).
      7. During `flushSemantics`, the `_nodesNeedingSemantics` list is walked. The first entry (`RenderSemanticsAnnotations`) updates the semantics tree to only contain the container widget and drop everything else (= no children of the ExcludeSemantics widget are walked).
      8. The second entry (`RenderSemanticsGestureHandler`) is updated. It does not add any semantics of its own and is no longer a semantics boundary. Therefore, it wants to merge its descendent semantics into its parents. Here is where the assert throws because the algorithm assumes that every entry in the `_nodesNeedingSemantics` list will produce and own an `_InterestingSemanticsFragment` (passing your semantics on to your parents is not interesting).
      
      The problem here seems to be step 4 in combination with step 5. In step 4 we rely on the fact that `RenderSemanticsGestureHandler` is an (explicit or implicit) semantics boundary and that it will be able to absorb the semantics change of `RenderSliverList`. This is true
      at this time. However, in step 4 `RenderSemanticsGestureHandler` decides to no longer be an (explicit or implicit) semantics boundary and our assumption from step 5 becomes incorrect. We did nothing to correct this assumption.
      
      This PR removes a node, that could potentially cease to be a (explicit or implicit) semantics boundary from the `_nodesNeedingSemantics` list to fix that problem. Please node that this does not mean that the node's semantics will not be updated: The node's closest ances
      tor with semantics is added to that list during the `markNeedsSemanticsUpdate` call. During `flushSemantics` we will walk from this node to update the semantics of it's children (if changed), which will include the node in question.
      
      * tiny fix
      
      * simplify test
      
      * analyzer fixes
      
      * review comments
      b551f534
  15. 07 Aug, 2017 2 commits
  16. 03 Aug, 2017 1 commit
  17. 25 Jul, 2017 1 commit
  18. 14 Jul, 2017 1 commit
  19. 13 Jul, 2017 1 commit
  20. 12 Jul, 2017 1 commit
  21. 11 Jul, 2017 2 commits
  22. 29 Jun, 2017 1 commit
  23. 20 Jun, 2017 3 commits
  24. 15 Jun, 2017 1 commit
  25. 14 Jun, 2017 2 commits
  26. 12 Jun, 2017 2 commits
  27. 08 Jun, 2017 1 commit
  28. 07 Jun, 2017 1 commit
  29. 31 May, 2017 1 commit
    • Ian Hickson's avatar
      Docs for menus (#10396) · ccad2849
      Ian Hickson authored
      Also, clean up the menus code a bit.
      
      Also, make it easier to write a PopupMenuEntry that has itself many
      items (for example, the way Chrome's menu has icons in a row).
      ccad2849
  30. 27 May, 2017 1 commit
    • Ian Hickson's avatar
      Much work on the documentation (#10331) · f50caddf
      Ian Hickson authored
      Minor fixes throughout, e.g. removing trailing commas from the end of sample code expressions, changing headings to "sample code" more consistently, removing stale todos, fix typos in a private method name, minor grammar fixes, added some clarifications to CircularProgressIndicator, LinearProgressIndicator, CrossAxisAlignment, added some cross-references to various members, made it slightly clearer that layout algorithms are implementation details.
      
      Clarified "elevation" throughout.
      
      Added docs to InkResponse and InkWell.
      
      Added sample code for: SliverAppBar, Card, ListTile, EdgeInsets, Row, Column, CustomScrollView, ListView, SliverFixedExtentList, and SliverGrid.
      
      Fixes #10317.
      Fixes #10316.
      Fixes #10267. (sort of, see comment therein)
      Fixes #9331. (sort of, see comment therein)
      Fixes #9407. (sort of, see comment therein)
      f50caddf