1. 15 Feb, 2023 1 commit
    • Ian Hickson's avatar
      Improve network resources doctor check (#120417) · d29668dd
      Ian Hickson authored
      ...and various other minor cleanup:
      
      * Moved "FLUTTER_STORAGE_BASE_URL" into a constant throughout the code. There are other strings that we should do that to but this one was relevant to the code I was changing.
      
      * Fixed the logger's handling of slow warnings. Previously it deleted too much text. Fixed the test for that to actually verify it entirely, too.
      
      * Made the logger delete the slow warning when it's finished.
      
      * Fixed 'Please choose one (To quit, press "q/Q")' message to be the cleaner 'Please choose one (or "q" to quit)'.
      
      * Added a debug toString to ValidationResult for debugging purposes (not used).
      
      * In http_host_validator:
      
        - Shortened constant names to be clearer (e.g. kPubDevHttpHost -> kPubDev).
        - Added GitHub as a tested host since when you run `flutter` we hit that immediately.
        - Renamed the check "Network resources".
        - Updated the `slowWarning` of the check to say which hosts are pending.
        - Removed all timeout logic. Timeouts violate our style guide.
        - Removed `int.parse(... ?? '10')`; passing a constant to `int.parse` is inefficient.
        - Replaced the `_HostValidationResult` class with `String?` for simplicity.
        - Improved the error messages to be more detailed.
        - Removed all checks that dependened on the stringification of exceptions. That's very brittle.
        - Added a warning specifically for HandshakeException that talks about the implications (MITM attacks).
        - Replaced exception-message-parsing logic with just calling `Uri.tryParse` and validating the result.
        - Replaced a lot of list-filtering logic with just a single for loop to check the results.
        - Replaced code that added a constant to a known-empty list with just returning a constant list.
        - Revamped the logic for deciding which hosts to check to just use a single chain of if/else blocks instead of getters, lists literals with `if` expressions, `??`, functions, etc spread over multiple places in the code.
      Unverified
      d29668dd
  2. 13 Feb, 2023 1 commit
  3. 09 Feb, 2023 1 commit
  4. 07 Feb, 2023 1 commit
  5. 05 Feb, 2023 1 commit
  6. 04 Feb, 2023 2 commits
  7. 24 Jan, 2023 2 commits
  8. 23 Jan, 2023 1 commit
  9. 20 Dec, 2022 1 commit
  10. 15 Dec, 2022 2 commits
  11. 02 Dec, 2022 1 commit
    • Jackson Gardner's avatar
      Platform binaries reland (#115502) · db1c3e20
      Jackson Gardner authored
      You can now specify a --local-web-sdk flag to point to a wasm_release folder. This will make it so that only artifacts that pertain to the web sdk are overridden to point to the wasm_release folder. Other artifacts (such as impellerc) will pull from the cache, or from the --local-engine path if that is specified.
      
      This also uses precompiled platform kernel files for both ddc and dart2js
      Unverified
      db1c3e20
  12. 22 Nov, 2022 1 commit
  13. 21 Nov, 2022 1 commit
  14. 13 Nov, 2022 1 commit
  15. 12 Nov, 2022 1 commit
  16. 10 Nov, 2022 1 commit
  17. 19 Oct, 2022 1 commit
  18. 18 Oct, 2022 2 commits
  19. 13 Oct, 2022 1 commit
  20. 12 Oct, 2022 1 commit
  21. 08 Oct, 2022 1 commit
  22. 04 Oct, 2022 1 commit
  23. 16 Sep, 2022 1 commit
  24. 02 Sep, 2022 1 commit
  25. 15 Aug, 2022 1 commit
  26. 29 Jul, 2022 1 commit
  27. 27 Jul, 2022 3 commits
  28. 26 Jul, 2022 2 commits
  29. 25 Jul, 2022 1 commit
  30. 13 Jul, 2022 1 commit
  31. 15 Jun, 2022 1 commit
  32. 03 Jun, 2022 1 commit
  33. 01 Jun, 2022 1 commit