1. 18 Sep, 2019 1 commit
    • Greg Spencer's avatar
      Fix a problem with disposing of focus nodes in tab scaffold (#40100) · 110db03f
      Greg Spencer authored
      Previously, focus nodes created in the tab scaffold were not being disposed of properly, causing possible memory leaks. Also, the builder wasn't being passed the right context so that the FocusScope.of operator inside of a builder would find the focus scope for the given tab (it was being passed the context of the overall tab scaffold).
      110db03f
  2. 17 Sep, 2019 1 commit
  3. 16 Aug, 2019 1 commit
  4. 11 Jun, 2019 1 commit
  5. 17 May, 2019 1 commit
  6. 25 Apr, 2019 1 commit
    • Greg Spencer's avatar
      [Re-Land] Implement focus traversal for desktop platforms. (#31614) · 7775c237
      Greg Spencer authored
      This re-lands the Focus changes in #30040. Correctness changes in routes.dart, and removes the automatic requesting of focus on reparent when there is no current focus, which caused undesirable selections.
      
      Addresses #11344, #1608, #13264, and #1678
      Fixes #30084
      Fixes #26704
      7775c237
  7. 23 Apr, 2019 1 commit
  8. 22 Apr, 2019 1 commit
    • Greg Spencer's avatar
      Implement focus traversal for desktop platforms, shoehorn edition. (#30040) · 4218c0bc
      Greg Spencer authored
      Implements focus traversal for desktop platforms, including re-implementing the existing focus manager and focus tree.
      
      This implements a Focus widget that can be put into a widget tree to allow input focus to be given to a particular part of a widget tree.
      
      It incorporates with the existing FocusScope and FocusNode infrastructure, and has minimal breakage to the API, although FocusScope.reparentIfNeeded is removed, replaced by a call to FocusAttachment.reparent(), so this is a breaking change:
      
      FocusScopeNodes must now be attached to the focus tree using FocusScopeNode.attach, which takes a context and an optional onKey callback, and returns a FocusAttachment that should be kept by the widget that hosts the FocusScopeNode. This is necessary because of the need to make sure that the focus tree reflects the widget hierarchy.
      
      Callers that used to call FocusScope(context).reparentIfNeeded in their build method will call reparent  on a FocusAttachment instead, which they will obtain by calling FocusScopeNode.attach in their initState method. Widgets that own FocusNodes will need to call dispose on the focus node in their dispose method.
      
      Addresses #11344, #1608, #13264, and #1678
      Fixes #30084
      Fixes #26704
      4218c0bc
  9. 17 Apr, 2019 1 commit
  10. 09 Mar, 2019 1 commit
  11. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  12. 08 Feb, 2019 1 commit
  13. 18 Jan, 2019 1 commit
  14. 20 Dec, 2018 1 commit
  15. 19 Dec, 2018 1 commit
  16. 08 Nov, 2018 1 commit
  17. 17 Oct, 2018 1 commit
  18. 12 Sep, 2018 1 commit
  19. 07 Sep, 2018 1 commit
  20. 09 Jul, 2018 1 commit
  21. 03 May, 2018 1 commit
  22. 02 Apr, 2018 1 commit
  23. 21 Feb, 2018 1 commit
  24. 08 Dec, 2017 1 commit
    • xster's avatar
      Let translucent Cupertino bars have its scaffold children automatically pad... · ecf50418
      xster authored
      Let translucent Cupertino bars have its scaffold children automatically pad their heights - second try (#13440)
      
      * Let translucent Cupertino bars have its scaffold children automatically pad their heights (#13194)
      
      * Let lists automatically add sliver padding from media query. Translucent nav and tab bars leave behind media query paddings in scaffolds.
      
      * tests
      
      * const lint
      
      * Rename base abstract class to generalized ObstructingPreferredSizeWidget
      
      * review
      
      * More docs and comments from #13317
      ecf50418
  25. 02 Dec, 2017 1 commit
  26. 30 Nov, 2017 1 commit
  27. 25 Oct, 2017 1 commit
  28. 02 Oct, 2017 1 commit
    • Adam Barth's avatar
      Add Alignment, which will replace FractionalOffset (#12342) · 2b126bcd
      Adam Barth authored
      Unlike FractionalOffset, Alignment uses the center as the zero of the
      coordinate system, which makes the RTL math work out much cleaner.
      
      Also, make FractionalOffset into a subclass of Alignment so that clients
      can continue to use FractionalOffset.
      2b126bcd
  29. 28 Sep, 2017 1 commit
  30. 21 Sep, 2017 2 commits
    • xster's avatar
      Create a CupertinoTab to support parallel navigation trees in iOS (#12130) · f9e8da6d
      xster authored
      * Refactor CupertinoScaffold
      
      * Rename rootTabPageBuilder to tabBuilder
      
      * fix tab transparency padding
      
      * add a CupertinoTab
      
      * Add default background color
      
      * Add a bunch of examples
      
      * A bunch of tests
      
      * Refactor CupertinoScaffold
      
      * Rename rootTabPageBuilder to tabBuilder
      
      * fix tab transparency padding
      
      * Add default background color
      
      * review notes
      
      * fix test
      
      * review
      
      * Rename CupertinoTab to CupertinoTabView
      
      * remove final ; in sample code for analyzer
      f9e8da6d
    • xster's avatar
      Split CupertinoScaffold into CupertinoTabScaffold and CupertinoPageScaffold (#12106) · 6d470927
      xster authored
      * Refactor CupertinoScaffold
      
      * Rename rootTabPageBuilder to tabBuilder
      
      * fix tab transparency padding
      
      * Add default background color
      
      * review notes
      
      * fix test
      6d470927