Commits · 46ba49832028cc23df08994e065fbefb23ba206a · abdullh.alsoleman / Front-End

29 Sep, 2023 16 commits

Roll Flutter Engine from c52251a8b2d0 to d5fcd78a879b (2 revisions) (#135755) · 46ba4983

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/engine/compare/c52251a8b2d0...d5fcd78a879b

2023-09-29 skia-flutter-autoroll@skia.org Roll Skia from a80c164ffb8a to 9f8242377455 (1 revision) (flutter/engine#46406)
2023-09-29 30870216+gaaclarke@users.noreply.github.com [Impeller] Implements canvas recorder with trace serializer (flutter/engine#46376)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

46ba4983

Update `Drawer` tests for M2/M3 (#135752) · ebaf1603
Taha Tesser authored Sep 29, 2023
```
Updated unit tests for `Drawer` to have M2 and M3 versions.

More info in #127064
```
ebaf1603

Expose onAttach and onDetach in ScrollController subclasses (#135721) · 7c9feea8

Kate Lovett authored Sep 29, 2023

Fixes https://github.com/flutter/flutter/issues/135574
This exposes the onAttach and onDetach callbacks of ScrollController in all of its subclasses.

7c9feea8

Update the wasm bootstrap to allow access to the emscripten wrapper to skwasm. (#135723) · 0f947a09

Jackson Gardner authored Sep 29, 2023

Some upcoming engine changes will bind to a function provided by the emscripten JS wrapper around skwasm, rather than just the wasm module itself. This will make sure not to break the benchmarks when those engine changes land. See https://github.com/flutter/engine/pull/46388

0f947a09

Update logic for getting `Analytics` instance from package:unified_analytics (#134756) · ba141695

Elias Yishak authored Sep 29, 2023

Part of:
- https://github.com/flutter/flutter/issues/128251

Currently, when we want to use the analytics instance from `package:unified_analytics`, we are just grabbing it from globals. However, with the legacy analytics instance, there are some things we check to return a no-op version of the instance.. for example, if we are running on bots or a non standard branch, we use a no-op instance

This PR uses the same previous checks for the new analytics instance

ba141695

Roll Packages from c070b0a7a80a to d0e9a0e1b3ac (5 revisions) (#135753) · 57b5c3cd

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/packages/compare/c070b0a7a80a...d0e9a0e1b3ac

2023-09-28 stuartmorgan@google.com [video_player] Endorse macOS (flutter/packages#5021)
2023-09-28 engine-flutter-autoroll@skia.org Manual roll Flutter from f92884c7 to ff4a0f67 (107 revisions) (flutter/packages#5011)
2023-09-28 stuartmorgan@google.com [camera] Fix Android autofocus state reading (flutter/packages#5025)
2023-09-28 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 12fccda59847 to ead455963c12 (1 revision) (flutter/packages#5022)
2023-09-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.8 to 2.21.9 (flutter/packages#5020)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

57b5c3cd

Roll Flutter Engine from db4d3b5b3f59 to c52251a8b2d0 (1 revision) (#135748) · cfdaf1e5

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/engine/compare/db4d3b5b3f59...c52251a8b2d0

2023-09-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Ta8wiQnzbBc7fAGeR... to mR_mhiacGiD-ObsoG... (flutter/engine#46403)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Ta8wiQnzbBc7 to mR_mhiacGiD-

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cfdaf1e5

Roll Flutter Engine from 8b4e633c65eb to db4d3b5b3f59 (2 revisions) (#135745) · 3d003f9f

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/engine/compare/8b4e633c65eb...db4d3b5b3f59

2023-09-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from l2RxJKPfYn7QzGOoL... to vbw3Gwj-6eN7rSqb4... (flutter/engine#46401)
2023-09-29 49699333+dependabot[bot]@users.noreply.github.com Bump webdriver from 3.0.2 to 3.0.3 in /lib/web_ui (flutter/engine#46400)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from l2RxJKPfYn7Q to vbw3Gwj-6eN7

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3d003f9f

Roll Flutter Engine from 09130bf5be97 to 8b4e633c65eb (1 revision) (#135744) · e4fbb6d3

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/engine/compare/09130bf5be97...8b4e633c65eb

2023-09-29 matej.knopp@gmail.com [macOS] Ensure first responder is consistent during and after text input (flutter/engine#46032)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e4fbb6d3

Roll Flutter Engine from ccb30585d3f3 to 09130bf5be97 (1 revision) (#135741) · e8915160

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/engine/compare/ccb30585d3f3...09130bf5be97

2023-09-29 skia-flutter-autoroll@skia.org Roll Skia from 75033613a49f to a80c164ffb8a (3 revisions) (flutter/engine#46399)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e8915160

Roll Flutter Engine from 2052515c44f3 to ccb30585d3f3 (1 revision) (#135737) · fc9fef29

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/engine/compare/2052515c44f3...ccb30585d3f3

2023-09-29 skia-flutter-autoroll@skia.org Roll Skia from 08485e753e3a to 75033613a49f (2 revisions) (flutter/engine#46396)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fc9fef29

Update localizations. (#135691) · 938bb217
godofredoc authored Sep 29, 2023
```
Updates the localization files.
```
938bb217

Roll Flutter Engine from 485543c6765a to 2052515c44f3 (4 revisions) (#135732) · 96e6f18c

engine-flutter-autoroll authored Sep 29, 2023

https://github.com/flutter/engine/compare/485543c6765a...2052515c44f3

2023-09-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 4WW3KRrAbuY7VeGT0... to Ta8wiQnzbBc7fAGeR... (flutter/engine#46387)
2023-09-28 jonahwilliams@google.com [Impeller] revert stencil config changes. (flutter/engine#46386)
2023-09-28 bdero@google.com Bump impeller-cmake to head (flutter/engine#46385)
2023-09-28 skia-flutter-autoroll@skia.org Roll Skia from 33502f9b0c7d to 08485e753e3a (1 revision) (flutter/engine#46384)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 4WW3KRrAbuY7 to Ta8wiQnzbBc7

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

96e6f18c

Add arch property for windows_arm64 platform (#135725) · 951653a1

keyonghan authored Sep 29, 2023

Window arm64 bots are using x64 built python, which gave incorrect arch info. This PR adds the arch info explicitly so that recipes can get this value and populate to benchmark tags.

Part of https://github.com/flutter/flutter/issues/135722

951653a1

[flutter_tools] remove VmService screenshot for native devices. (#135462) · d13cd884

Jonah Williams authored Sep 29, 2023

* This is completely broken on the Impeller renderer, see: https://github.com/flutter/flutter/issues/135052
* Even on the Skia renderer, this gives a software rasterized screenshot which will absolutely look different from a native rendering screenshot.

I plan to remove this functionality from the engine.

d13cd884

Pin leak_tracker before publishing breaking change. (#135720) · e5d3b704
Polina Cherkasova authored Sep 29, 2023

e5d3b704

28 Sep, 2023 24 commits

Roll Flutter Engine from cc7c3c1f0f41 to 485543c6765a (8 revisions) (#135717) · de20e74a

engine-flutter-autoroll authored Sep 28, 2023

https://github.com/flutter/engine/compare/cc7c3c1f0f41...485543c6765a

2023-09-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from cu6apvEZ2P6zhishc... to l2RxJKPfYn7QzGOoL... (flutter/engine#46382)
2023-09-28 30870216+gaaclarke@users.noreply.github.com Remove opacity layer dcheck. (flutter/engine#46160)
2023-09-28 matanlurey@users.noreply.github.com Add initial support for 4x MSAA in OpenGLES backend. (flutter/engine#46381)
2023-09-28 matej.knopp@gmail.com Reland: [macOS] performKeyEquivalent cleanup (flutter/engine#46377)
2023-09-28 matej.knopp@gmail.com [macOS] TextInputPlugin should mark navigation events in IME popover as handled (flutter/engine#46141)
2023-09-28 30870216+gaaclarke@users.noreply.github.com Removed unnecessary dynamic dispatch (flutter/engine#46369)
2023-09-28 joel.winarske@gmail.com [Impeller] Fix OpenGLES EGL_BAD_ACCESS due to context being current on multiple threads. (flutter/engine#46287)
2023-09-28 ajihyf@gmail.com Fix damage calculation when not providing populate_existing_damage for gl embedder (flutter/engine#45611)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from cu6apvEZ2P6z to l2RxJKPfYn7Q

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

de20e74a

Remove assertions on getOffsetToReveal (#135634) · 3509a1df
Kate Lovett authored Sep 28, 2023

3509a1df

Marks Linux_android flutter_gallery__start_up_delayed to be unflaky (#135565) · 55c7a2ef

Flutter GitHub Bot authored Sep 28, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android flutter_gallery__start_up_delayed"
}
-->
The issue https://github.com/flutter/flutter/issues/134631 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20flutter_gallery__start_up_delayed%22).
This test can be marked as unflaky.

55c7a2ef

Roll Flutter Engine from dbb60932a6ab to cc7c3c1f0f41 (2 revisions) (#135701) · 49689632

engine-flutter-autoroll authored Sep 28, 2023

https://github.com/flutter/engine/compare/dbb60932a6ab...cc7c3c1f0f41

2023-09-28 matej.knopp@gmail.com [macOS] FlutterTextInputPlugin should clip to bounds (flutter/engine#46142)
2023-09-28 skia-flutter-autoroll@skia.org Roll Skia from d8a71d549262 to 33502f9b0c7d (2 revisions) (flutter/engine#46375)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

49689632

[tool] fallback to sigkill when closing Chromium (#135521) · 371aadd8

Yegor authored Sep 28, 2023

This implements https://github.com/flutter/flutter/issues/132654#issuecomment-1738221257, namely:

Make `Chromium.close` more robust:

* Send `SIGTERM` and wait up to 5 seconds, if the process exited, great! Return from the function.
* If the process has not exited, then send a `SIGKILL`, which is a much firmer way to exit a process. Same as before, wait up to 5 seconds, if the process exited, great! Return from the function.
* If it still hasn't exited then give up trying to exit Chromium, just print a warning to the console and return from the function.

Bonus: a few nullability fixes and extra `-v` logging.

Fixes https://github.com/flutter/flutter/issues/132654

371aadd8

Roll pub packages (#135455) · b5c8fd11
flutter-pub-roller-bot authored Sep 28, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
b5c8fd11

Roll Flutter Engine from 9789dbc2ec3f to dbb60932a6ab (2 revisions) (#135694) · 97847e09

engine-flutter-autoroll authored Sep 28, 2023

https://github.com/flutter/engine/compare/9789dbc2ec3f...dbb60932a6ab

2023-09-28 chris@bracken.jp Revert "[macOS] performKeyEquivalent cleanup (#45946)" (flutter/engine#46374)
2023-09-28 matej.knopp@gmail.com [macOS] performKeyEquivalent cleanup (flutter/engine#45946)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

97847e09

Fix TabBarView.viewportFraction change is ignored (#135590) · e61f9e0c

Bruno Leroux authored Sep 28, 2023

## Description

This PR updates `_TabBarViewState.didUpdateWidget` in order to react to `TabBarView.viewportFraction`change.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/135557.

## Tests

Adds 1 test.

e61f9e0c

Roll Flutter Engine from d9eaebd05851 to 9789dbc2ec3f (2 revisions) (#135688) · 8860dd21

engine-flutter-autoroll authored Sep 28, 2023

https://github.com/flutter/engine/compare/d9eaebd05851...9789dbc2ec3f

2023-09-28 skia-flutter-autoroll@skia.org Roll Skia from bcbcb109bad6 to d8a71d549262 (1 revision) (flutter/engine#46367)
2023-09-28 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 7c3588c05f87 to 077d768accfa (11 revisions) (flutter/engine#46366)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8860dd21

Added option to disable [NavigationDestination]s ([NavigationBar] destination widget) (#132361) · 9fdb1671

Matheus Kirchesch authored Sep 28, 2023

This PR adds a new option in the NavigationDestination api (the destination widget for the NavigationBar) allowing it to be disabled.

As the issue states this PR is the NavigationBar's version of these two PRs (https://github.com/flutter/flutter/pull/132349 and https://github.com/flutter/flutter/pull/127113)

* https://github.com/flutter/flutter/issues/132359

9fdb1671

Reverts "Marks Windows module_custom_host_app_name_test to be unflaky" (#135692) · f76c150c

auto-submit[bot] authored Sep 28, 2023

Reverts flutter/flutter#135567
Initiated by: ricardoamador
This change reverts the following previous change:
Original Description:
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows module_custom_host_app_name_test"
}
-->
The issue https://github.com/flutter/flutter/issues/134644 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20module_custom_host_app_name_test%22).
This test can be marked as unflaky.

f76c150c

🚀 Add more fields to `RefreshProgressIndicator` (#135207) · 4ed9ab8b
Alex Li authored Sep 28, 2023
```
Resolves #134494
```
4ed9ab8b

Roll Flutter Engine from 82b69dadc07a to d9eaebd05851 (1 revision) (#135679) · 6cde5da5

engine-flutter-autoroll authored Sep 28, 2023

https://github.com/flutter/engine/compare/82b69dadc07a...d9eaebd05851

2023-09-28 skia-flutter-autoroll@skia.org Roll Skia from 267bb43e822d to bcbcb109bad6 (1 revision) (flutter/engine#46365)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6cde5da5

Add API to read flavor from framework at run time (#134179) · aa498cd5

Andrew Kolos authored Sep 28, 2023

Resolves #128046.

Adds a services API that allows flutter app developers to write app code that determines `--flavor` the app was built with.

This is implemented by having the tool adding the value of `--flavor` to its list of dart environment declarations, which will be available to the app at run time. Specifically,`FLUTTER_APP_FLAVOR` is set. I chose this implementation for its simplicity. There is some precedent for this, but only for web ([example](https://github.com/flutter/flutter/blob/cd2f3f5e78409027d3c9014172708e4dec7f2185/packages/flutter_tools/lib/src/runner/flutter_command.dart#L1231)).

aa498cd5

Marks Windows module_custom_host_app_name_test to be unflaky (#135567) · c35515a0

Flutter GitHub Bot authored Sep 28, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows module_custom_host_app_name_test"
}
-->
The issue https://github.com/flutter/flutter/issues/134644 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20module_custom_host_app_name_test%22).
This test can be marked as unflaky.

c35515a0

[web] fix: do not call onSubmitted of TextField when switching browser tabs on mobile web (#134870) · 3b19c2e5

tauu authored Sep 28, 2023

This PR fixes #134846. As discussed in the issue, the onSubmitted callback of a TextField is called when the browser switches tabs or is sent to the background if the flutter app is running in any mobile browser (desktop browsers are not affected). Furthermore there is no straight forward way to distinguish between onSubmitted being called because the user pressed the enter key and it being called because the user switched tabs. For example in a chat app this would cause a message to be sent when the user submits the text by pressing "send" on the virtual keyboard as well as when the user switches to another tab. The later action is likely not so much intended.

The next section explains what causes the bug and explains the proposed fix.

## Bug Analysis
The root cause for this behaviour is line 3494 in editable_text.dart: https://github.com/flutter/flutter/blob/0b540a87f1be9a5bb7e550c777dfe5221c53a112/packages/flutter/lib/src/widgets/editable_text.dart#L3487-L3499
Only if the app is running on the web `_finalizeEditing` is called and this will then trigger the onSubmitted callback. If flutter is running on the web, there are only exactly 3 cases, in which the function is called. The following call trace analysis will describe why.
  - `connectionClosed()` is only called by in one location, `_handleTextInputInvocation` of the TextInput service.
https://github.com/flutter/flutter/blob/367203b3011fc1752cfa1f51adf9751d090c94e6/packages/flutter/lib/src/services/text_input.dart#L1896C12-L1899
  - In particular it is only called if the TextInput service receives a 'TextInputClient.onConnectionClosed' message from the engine.
  - The only location where the web part of the engine send this message is the `onConnectionClosed` function of the TextEditingChannel.
https://github.com/flutter/engine/blob/cbda68a720904137ee9dfdf840db323afcf52705/lib/web_ui/lib/src/engine/text_editing/text_editing.dart#L2242-L2254
  - `onConnectionClosed` in turn is only called by the `sendTextConnectionClosedToFrameworkIfAny` function of `HybridTextEditing`.
https://github.com/flutter/engine/blob/cbda68a720904137ee9dfdf840db323afcf52705/lib/web_ui/lib/src/engine/text_editing/text_editing.dart#L2340-L2345

The function `sendTextConnectionClosedToFrameworkIfAny` is only called at 3 distinct locations of the web engine.

### 1. IOSTextEditingStrategy 
As described in the comment `sendTextConnectionClosedToFrameworkIfAny` is called if the browser is sent to the background or the tab is changed.
https://github.com/flutter/engine/blob/cbda68a720904137ee9dfdf840db323afcf52705/lib/web_ui/lib/src/engine/text_editing/text_editing.dart#L1632-L1656

### 2. AndroidTextEditingStrategy
Same situation as for iOS. `sendTextConnectionClosedToFrameworkIfAny` is also called if `windowHasFocus` is false, which is the case if the browser is sent to background or the tab is changed.
https://github.com/flutter/engine/blob/cbda68a720904137ee9dfdf840db323afcf52705/lib/web_ui/lib/src/engine/text_editing/text_editing.dart#L1773-L1785

### 3. TextInputFinishAutofillContext
This call seems to always happen when `finishAutofillContext` is triggered by the framework.
https://github.com/flutter/engine/blob/cbda68a720904137ee9dfdf840db323afcf52705/lib/web_ui/lib/src/engine/text_editing/text_editing.dart#L2075-L2083

## Proposed Fix
The fixed proposed and implemented by this PR is to simply delete the call to`_finalizeEditing` in the `connectionClosed` function of editable_text.dart.
https://github.com/flutter/flutter/blob/0b540a87f1be9a5bb7e550c777dfe5221c53a112/packages/flutter/lib/src/widgets/editable_text.dart#L3487-L3499

The reasoning for this being:
   * `_finalizeEditing` is only called in `connectionClosed` for the web engine.
   * As explained by the trace analysis above, the web engine only triggers this `_finalizeEditing` call in 3 cases.
   * In the 2 cases for IOSTextEditingStrategy and AndroidTextEditingStrategy the web engine triggering the call only causes the undesired behaviour reported in the issue.
   * In the third case for TextInputFinishAutofillContext, I can't see a good reason why this would require calling `_finalizeEditing` as it only instructs the platform to save the current values. Other platforms also don't have anything that would trigger onSubmitted being called, so it seems safe to remove it.
   * For other platforms the onConnectionClosed function was recently incorporated to only unfocus the TextField. So removing the call `_finalizeEditing` unifies the platform behaviour. See also
     https://github.com/flutter/flutter/pull/123929
     https://github.com/flutter/engine/pull/41500

*List which issues are fixed by this PR. You must list at least one issue.*
#134846

To simplify the evaluation, here are two versions of the minimal example given in the issue, build with the current master and with this PR applied:
current master: https://tauu.github.io/flutter-onsubmit-test/build/web-master/
current master + PR applied: https://tauu.github.io/flutter-onsubmit-test/build/web/

3b19c2e5

Roll Packages from 21c2ebb39c07 to c070b0a7a80a (3 revisions) (#135676) · 880a0a19

engine-flutter-autoroll authored Sep 28, 2023

https://github.com/flutter/packages/compare/21c2ebb39c07...c070b0a7a80a

2023-09-28 stuartmorgan@google.com [video_player] Add macOS support (flutter/packages#4982)
2023-09-28 32538273+ValentinVignal@users.noreply.github.com [go_router] Avoid logging when `debugLogDiagnostics` is `false` (flutter/packages#4875)
2023-09-28 stuartmorgan@google.com [tool] Don't lint Flutter shim podspecs (flutter/packages#5007)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

880a0a19

Fix `RangeSlider` throws an exception in a `ListView` (#135667) · d134345f

Taha Tesser authored Sep 28, 2023

fixes [[RangeSlider] [Flutter 3.10] LateInitializationError: Field '_startThumbCenter@280317193' has not been initialized.](https://github.com/flutter/flutter/issues/126648)

### Code sample (Run it on iOS)

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: ListView(
        children: <Widget>[
          const SizedBox(
            height: 1000,
            child: Placeholder(),
          ),
          RangeSlider(
            values: const RangeValues(0.25, 0.75),
            onChanged: (value) {},
          ),
        ],
      ),
    );
  }
}
```

</details>

d134345f

Roll Flutter Engine from d09c2dbe2292 to 82b69dadc07a (2 revisions) (#135675) · 449c9279

engine-flutter-autoroll authored Sep 28, 2023

https://github.com/flutter/engine/compare/d09c2dbe2292...82b69dadc07a

2023-09-28 leroux_bruno@yahoo.fr [Android] Rename `allowChannelBufferOverflow` to `setWarnsOnChannelOvâ¦ (flutter/engine#46361)
2023-09-28 skia-flutter-autoroll@skia.org Roll Skia from cfac8410d773 to 267bb43e822d (1 revision) (flutter/engine#46363)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

449c9279

Roll Flutter Engine from 495955a3b5de to d09c2dbe2292 (1 revision) (#135669) · 8d01d55b

engine-flutter-autoroll authored Sep 28, 2023

https://github.com/flutter/engine/compare/495955a3b5de...d09c2dbe2292

2023-09-28 skia-flutter-autoroll@skia.org Roll Skia from d410e03a6b9b to cfac8410d773 (1 revision) (flutter/engine#46362)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8d01d55b

Revert "Upload generated frame-request-pending stats" (#135672) · 63b98d55
Zachary Anderson authored Sep 28, 2023
```
Reverts flutter/flutter#135645
```
63b98d55

Upload generated frame-request-pending stats (#135645) · dd341d42

Callum Moffat authored Sep 28, 2023

These values are generated since https://github.com/flutter/flutter/pull/135279, but I didn't know to add the new keys to this list to get them to upload.

Part of https://github.com/flutter/flutter/issues/129150

dd341d42

Roll Flutter Engine from 937bf0432214 to 495955a3b5de (1 revision) (#135665) · 666d8f80

engine-flutter-autoroll authored Sep 28, 2023

https://github.com/flutter/engine/compare/937bf0432214...495955a3b5de

2023-09-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from U334SygIkffMJVmdu... to 4WW3KRrAbuY7VeGT0... (flutter/engine#46357)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from U334SygIkffM to 4WW3KRrAbuY7

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

666d8f80

Roll Flutter Engine from d2540d87fd96 to 937bf0432214 (1 revision) (#135660) · 09b89f41

engine-flutter-autoroll authored Sep 28, 2023

https://github.com/flutter/engine/compare/d2540d87fd96...937bf0432214

2023-09-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 6Y22MutFhgL7ua18F... to cu6apvEZ2P6zhishc... (flutter/engine#46355)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 6Y22MutFhgL7 to cu6apvEZ2P6z

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

09b89f41