- 09 Jan, 2018 2 commits
-
-
Michael Goderbauer authored
`RenderSemanticsGestureHandler` is no longer a semantics boundary, which allows us to correctly mark disabled buttons as disabled without having their semantics size and semantics node id change unexpectedly. Fixes https://github.com/flutter/flutter/issues/12589. Fixes https://github.com/flutter/flutter/issues/11991. See also https://github.com/flutter/flutter/issues/11993. This change also required some refactoring to how we deal with `twoPaneSemantics` scrolling as it previously relied on `RenderSemanticsGestureHandler` being a semantics boundary. This should also make the underlying logic easier to understand. In addition, the following minor changes are included in this PR: * Removal of orphaned and unused `SemanticsConfiguration.isMergingDescendantsIntoOneNode`. * Logic optimizations for `markNeedsSemanticsUpdate` . * Fix for edge case where `MergeSemantics` failed to merge semantics. * Use of emojis to better indicate leaf merging in the printed semantics tree. * Better assert message for adding invisible child semantics nodes. * Make some semantics tests robuster by not relying on creation order of SemanticsNode ids across test boundaries. Fixes https://github.com/flutter/flutter/issues/13943.
-
Michael Goderbauer authored
to align with `SemanticsAction` and other enum-like types.
-
- 21 Dec, 2017 1 commit
-
-
Yegor authored
* localize a11y tab labels in the TabBar * break import cycle * test boilerplate * fix German translation * more test boilerplate fixes
-
- 23 Nov, 2017 1 commit
-
-
Ian Hickson authored
-
- 24 Oct, 2017 1 commit
-
-
Michael Goderbauer authored
* Without checking compatibility * ++ * ++ * ++ * more docs
-
- 19 Oct, 2017 1 commit
-
-
Michael Goderbauer authored
Merge confliuct between #12605 and #12613
-
- 18 Oct, 2017 2 commits
-
-
Michael Goderbauer authored
* Oct 12 10:12am * implicit_semantics_test.dart passes * refactoring * works in nice * minor rename * more doc comments * to be explicit check better * fix test * ++ * ++ * semantics_9_test (BlockSemantics) and implicit_semantics_test are passing * doc updates * tiny refactor * fix static errors in tests * fix gesture detector * ++ * ++ * geometry * ++ * remove noGeometry * revert test * + * all tests but scrolling/clipping pass * clipping works * scrolling halfway * sliver tests pass * ALL TESTS PASS * SemanticsNode changed * docs and tiny fixes * card test * more doc comments * remove missed print * more tests * make test pass on Linux * remove changes to intellij proj file * review comments
-
Michael Goderbauer authored
* Make Tab take a widget as child This way you can override the semantics information of a Tab (see test). Fixes https://github.com/flutter/flutter/issues/12432 * more tests * review comments * review comment * doc nits * style fix
-
- 11 Oct, 2017 1 commit
-
-
Michael Goderbauer authored
* Update Semantics for SingleChildScrollViews * refactor * review feedback * added assert and comments * doc
-
- 02 Oct, 2017 1 commit
-
-
Adam Barth authored
Unlike FractionalOffset, Alignment uses the center as the zero of the coordinate system, which makes the RTL math work out much cleaner. Also, make FractionalOffset into a subclass of Alignment so that clients can continue to use FractionalOffset.
-
- 31 Aug, 2017 1 commit
-
-
Adam Barth authored
This patch includes: * SliverPadding * ScrollView * PageView Fixes #11764 Fixes #11836
-
- 28 Aug, 2017 1 commit
-
-
Ian Hickson authored
* Introduce a Directionality inherited widget which sets the ambient LTR vs RTL mode (defaulting to null, which means you cannot use directionality-influenced values). * Make it possible to configure Padding (including Container.padding and Container.margin) using a directionality-agnostic EdgeInsets variant. * Provide textDirection and verticalDirection controls on Row and Column to make them RTL-aware. * Introduce a variant of FractionalOffset based on the EdgeInsets variant. Not yet actually used. * Fix all the tests that depended on Row defaulting to LTR.
-
- 23 Aug, 2017 1 commit
-
-
Brenton Simpson authored
`stiffness` is the name of a spring's `k` input on [iOS](https://developer.apple.com/documentation/quartzcore/caspringanimation), [Android](https://developer.android.com/topic/libraries/support-library/preview/spring-animation.html), and the [Web](https://github.com/skevy/wobble/blob/bbc0f831e234f2d24fb905f2ec278c134d69ed68/src/index.js#L11-L22). To ensure the API is familiar to and easily understood by developers coming from other platforms, Flutter should follow this convention as well. This is a minimally-breaking change. Across [all of GitHub](https://github.com/search?l=Dart&q=springConstant&type=Code&utf8=%E2%9C%93), there are only 2 uses of the `springConstant` API (in Mondrian). Those can be easily changed to use this name. Closes #11684
-
- 08 Aug, 2017 1 commit
-
-
Michael Goderbauer authored
* Allow tapping on TabBar indicator to switch tabs * fix semantics * review comments
-
- 17 Jul, 2017 1 commit
-
-
najeira authored
-
- 14 Jun, 2017 1 commit
-
-
Michael Goderbauer authored
* [accessibility] Announce index if tab in tab bar * added TODO
-
- 13 Jun, 2017 1 commit
-
-
Michael Goderbauer authored
* Add SemanticsNode.isSelected flag * Adds example usage to TabBar See also https://github.com/flutter/engine/pull/3764 * Review comments * whitespace fixes * Fix doc ref and update engine roll
-
- 12 Jun, 2017 1 commit
-
-
Hans Muller authored
-
- 09 Jun, 2017 1 commit
-
-
Hans Muller authored
-
- 21 Apr, 2017 1 commit
-
-
Alexandre Ardhuin authored
* make @immutable const * fix build
-
- 18 Apr, 2017 1 commit
-
-
Hans Muller authored
-
- 14 Apr, 2017 1 commit
-
-
Hans Muller authored
-
- 12 Apr, 2017 1 commit
-
-
Ian Hickson authored
* Manually fix every use of Point.x and Point.y Some of these were moved to dx/dy, but not all. * Manually convert uses of the old gradient API * Remove old reference to Point. * Mechanical changes I applied the following at the root of the Flutter repository: git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g' git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g' git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g' git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g' git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g' git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g' git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g' git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g' git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g' git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g' git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g' git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g' git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g' git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g' git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g' git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g' * Mechanical changes - dartdocs I applied the following at the root of the Flutter repository: git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g' git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g' * Further improvements and a test * Fix minor errors from rebasing... * Roll engine
-
- 11 Apr, 2017 1 commit
-
-
xster authored
Rename State.config to State.widget Rename State.didUpdateConfig to State.didUpdateWidget Renamed all State subclasses' local variables named config to something else
-
- 07 Apr, 2017 1 commit
-
-
Ian Hickson authored
Aggressively apply the const lint.
-
- 27 Mar, 2017 1 commit
-
-
Hans Muller authored
-
- 22 Mar, 2017 1 commit
-
-
Hans Muller authored
-
- 13 Mar, 2017 2 commits
-
-
Ian Hickson authored
-
Hans Muller authored
-
- 04 Mar, 2017 1 commit
-
-
Chris Bracken authored
-
- 01 Mar, 2017 1 commit
-
-
Chris Bracken authored
This ensures that both timer/microtask queues are cleared out rather than assuming that all work is completed in a specified amount of time.
-
- 21 Feb, 2017 1 commit
-
-
Adam Barth authored
Previously we called onPageChanged when the scroll ended, but that is too late. Now we call onPageChanged when we cross the halfway mark, which, for example, makes the tab indicator update earlier. Fixes #8265
-
- 14 Feb, 2017 1 commit
-
-
Ian Hickson authored
-
- 09 Feb, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 08 Feb, 2017 1 commit
-
-
Adam Barth authored
Tabs are now fully driven by slivers.
-
- 31 Jan, 2017 1 commit
-
-
Adam Barth authored
Our previous behavior of hard-coding the unselected label color to 70% of the selected color was too restrictive. Fixes #7738
-
- 28 Jan, 2017 1 commit
-
-
Ian Hickson authored
-
- 09 Jan, 2017 1 commit
-
-
Hans Muller authored
-
- 09 Dec, 2016 1 commit
-
-
Alexandre Ardhuin authored
-
- 06 Dec, 2016 1 commit
-
-
Hans Muller authored
-