- 03 Sep, 2019 1 commit
-
-
Greg Spencer authored
This changes the behavior of text fields, Material buttons, and Chips so that if they are disabled they lose focus. Before this change, it was possible to disable a control and then use focus traversal to reach it anyhow, and in the case of text fields, enter text into a disabled field. Fixes #33985
-
- 23 Aug, 2019 1 commit
-
-
Greg Spencer authored
I noticed that we were pretty inconsistent with the way that we checked the value of clipBehavior in the framework, so I normalized the usages and updated docs where necessary. This is a breaking change if you used to pass null explicitly to FlatButton, OutlineButton or RaisedButton constructors, expecting to get Clip.none. It will now assert if you do that. Existing implementations that pass null implicitly by not specifying clipBehavior won't need to change their call sites. It always implicitly defaulted to Clip.none before, and it will continue to do that, it's only places where it was explicitly set to null in order to get the implicit default that it will fail.
-
- 15 Aug, 2019 1 commit
-
-
Greg Spencer authored
Add an autofocus parameter to widgets which use Focus widget internally, and update related docs. This will allow developers to request that a particular widget be automatically focused when shown.
-
- 28 Jun, 2019 3 commits
-
-
MH Johnson authored
Re-land "[Material] Support for hovered, focused, and pressed border color on `OutlineButton`s" (#35278) * outline border implements material state property
-
Todd Volkert authored
Revert "[Material] Support for hovered, focused, and pressed border color on `OutlineButton`s (#34872)" (#35276) This reverts commit 3f941599.
-
MH Johnson authored
* outline border implements material state property
-
- 05 Jun, 2019 1 commit
-
-
MH Johnson authored
* Support for stateful text colors in buttons * Add color and a11y tests for buttons
-
- 15 May, 2019 1 commit
-
-
Greg Spencer authored
This implements focus and hover handling for Material buttons. It inserts Focus widgets into the tree in order to allow buttons to be focusable via keyboard traversal (a.k.a. TAB traversal), and Listener widgets into the InkWell to allow the detection of hover states for widgets. Addresses #11344, #1608, and #13264.
-
- 09 May, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 21 Feb, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 15 Jan, 2019 1 commit
-
-
Ian Hickson authored
Previously, a disabled floating action button always had zero elevation, which looks dumb. This also fixes the issue whereby highlightElevation was not honoured on floating action buttons. This also fixes an issue I found during testing whereby setState was being called during build when onHighlightChanged fired due to onPressed becoming null while a gesture is ongoing (which triggers an onTapCancel synchronously during build).
-
- 18 Dec, 2018 2 commits
-
-
Alexandre Ardhuin authored
-
Michael Goderbauer authored
-
- 12 Oct, 2018 2 commits
-
-
matthew-carroll authored
This reverts commit 80f80ab0.
-
matthew-carroll authored
For G3 Roll: * Revert "MaterialButton must honor its minWidth and height parameters (#22919)" This reverts commit a0233233. * Revert "Update uses of ButtonTheme.bar: pass along the current Theme's colorScheme (#22827)" This reverts commit 655bf6a2. * Revert "ButtonTheme.of().colorScheme defers to Theme (#22880)" This reverts commit a590940e. * Revert "Bring TextTheme into alignment with the current Material spec (#22330)" This reverts commit 8bfb4b3e. * Revert "Added ColorScheme, updated ThemeData, ButtonTheme, material buttons (#22013)" This reverts commit eea3465a. * Manual adjustments to fix reversion issues.
-
- 02 Oct, 2018 2 commits
-
-
Hans Muller authored
Introduce an overall material "color scheme" and to make it possible to redefine how a component's visual properties bind to the color scheme and to the existing material Theme.
-
Alexandre Ardhuin authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 07 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* lint unnecessary_new on samples * fix tests
-
- 04 Sep, 2018 1 commit
-
-
Will Larche authored
Closes #3188
-
- 24 Aug, 2018 1 commit
-
-
liyuqian authored
This reverts commit 8de0e15e and updates the goldens versoin. This requires https://github.com/flutter/flutter/pull/20751 to land first.
-
- 22 Aug, 2018 1 commit
-
-
liyuqian authored
This fixes #20483 by letting InkWell do its own clipping. PathOp.intersect is not used because we have too many unit tests that rely on clipping (e.g., paints..clipXXX()..drawCircle()) The goldens are updated due to small AA changes of the additional clipPath.
-
- 21 Aug, 2018 1 commit
-
-
Ian Hickson authored
- remove an //ignore that is no longer needed - fix some intrinsic methods that used the API incorrectly (shouldn't affect correctness but should make things a tiny bit more efficient) - add some asserts to help track down bugs quicker - update a TODO to point to the currently relevant bug - fix some indenting - improve the naming of some privates to improve readability
-
- 15 Aug, 2018 1 commit
-
-
Jonah Williams authored
-
- 09 Aug, 2018 1 commit
-
-
liyuqian authored
This fixes https://github.com/flutter/flutter/issues/18057
-
- 23 Jul, 2018 1 commit
-
-
Alexandre Ardhuin authored
* re-enable lint unnecessary_const * remove trailling whitespaces * remove unnecessary const (after merge)
-
- 19 Jul, 2018 1 commit
-
-
Jonah Williams authored
-
- 09 Jul, 2018 1 commit
-
-
Jonah Williams authored
-
- 03 Jul, 2018 2 commits
-
-
Jonah Williams authored
This reverts commit 989f5741.
-
Jonah Williams authored
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 30 May, 2018 1 commit
-
-
Jonah Williams authored
-
- 20 Mar, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 02 Mar, 2018 1 commit
-
-
Hans Muller authored
-
- 28 Feb, 2018 1 commit
-
-
najeira authored
-
- 05 Feb, 2018 1 commit
-
-
Hans Muller authored
-
- 09 Jan, 2018 1 commit
-
-
Michael Goderbauer authored
`RenderSemanticsGestureHandler` is no longer a semantics boundary, which allows us to correctly mark disabled buttons as disabled without having their semantics size and semantics node id change unexpectedly. Fixes https://github.com/flutter/flutter/issues/12589. Fixes https://github.com/flutter/flutter/issues/11991. See also https://github.com/flutter/flutter/issues/11993. This change also required some refactoring to how we deal with `twoPaneSemantics` scrolling as it previously relied on `RenderSemanticsGestureHandler` being a semantics boundary. This should also make the underlying logic easier to understand. In addition, the following minor changes are included in this PR: * Removal of orphaned and unused `SemanticsConfiguration.isMergingDescendantsIntoOneNode`. * Logic optimizations for `markNeedsSemanticsUpdate` . * Fix for edge case where `MergeSemantics` failed to merge semantics. * Use of emojis to better indicate leaf merging in the printed semantics tree. * Better assert message for adding invisible child semantics nodes. * Make some semantics tests robuster by not relying on creation order of SemanticsNode ids across test boundaries. Fixes https://github.com/flutter/flutter/issues/13943.
-
- 21 Dec, 2017 1 commit
-
-
Ian Hickson authored
This attempts to apply some of what we learnt from UX studies, namely that people wonder how to add multiple children to widget that take one child.
-
- 23 Oct, 2017 1 commit
-
-
- 13 Oct, 2017 1 commit
-
-
Greg Spencer authored
This modifies the MaterialButton to expand vertically to fit the size of the contained child, no matter what the child widget is. It tries to be as close as possible to the minHeight constraint. Also updated some doc comments to have headers (extra blank line after first sentence), and to wrap at 80 cols. Addresses #12311
-