1. 03 Sep, 2019 1 commit
    • Greg Spencer's avatar
      Make disabled buttons/chips/text fields not be focusable. (#38726) · 8daa165d
      Greg Spencer authored
      This changes the behavior of text fields, Material buttons, and Chips so that if they are disabled they lose focus. Before this change, it was possible to disable a control and then use focus traversal to reach it anyhow, and in the case of text fields, enter text into a disabled field.
      
      Fixes #33985
      8daa165d
  2. 23 Aug, 2019 1 commit
    • Greg Spencer's avatar
      Normalize assert checking of clipBehavior (#38568) · 365f577c
      Greg Spencer authored
      I noticed that we were pretty inconsistent with the way that we checked the value of clipBehavior in the framework, so I normalized the usages and updated docs where necessary.
      
      This is a breaking change if you used to pass null explicitly to FlatButton, OutlineButton or RaisedButton constructors, expecting to get Clip.none. It will now assert if you do that. Existing implementations that pass null implicitly by not specifying clipBehavior won't need to change their call sites. It always implicitly defaulted to Clip.none before, and it will continue to do that, it's only places where it was explicitly set to null in order to get the implicit default that it will fail.
      365f577c
  3. 15 Aug, 2019 1 commit
  4. 28 Jun, 2019 3 commits
  5. 05 Jun, 2019 1 commit
  6. 15 May, 2019 1 commit
    • Greg Spencer's avatar
      Implements focus handling and hover for Material buttons. (#31438) · bb3c6605
      Greg Spencer authored
      This implements focus and hover handling for Material buttons. It inserts Focus widgets into the tree in order to allow buttons to be focusable via keyboard traversal (a.k.a. TAB traversal), and Listener widgets into the InkWell to allow the detection of hover states for widgets.
      
      Addresses #11344, #1608, and #13264.
      bb3c6605
  7. 09 May, 2019 1 commit
  8. 21 Feb, 2019 1 commit
  9. 15 Jan, 2019 1 commit
    • Ian Hickson's avatar
      Support setting the elevation of disabled floating action buttons (#24728) · 29928a46
      Ian Hickson authored
      Previously, a disabled floating action button always had zero
      elevation, which looks dumb.
      
      This also fixes the issue whereby highlightElevation was not honoured
      on floating action buttons.
      
      This also fixes an issue I found during testing whereby setState was
      being called during build when onHighlightChanged fired due to
      onPressed becoming null while a gesture is ongoing (which triggers an
      onTapCancel synchronously during build).
      29928a46
  10. 18 Dec, 2018 2 commits
  11. 12 Oct, 2018 2 commits
    • matthew-carroll's avatar
      Revert "Reversion for roll (#22984)" (#23029) · 04a26778
      matthew-carroll authored
      This reverts commit 80f80ab0.
      04a26778
    • matthew-carroll's avatar
      Reversion for roll (#22984) · 80f80ab0
      matthew-carroll authored
      For G3 Roll:
      
      * Revert "MaterialButton must honor its minWidth and height parameters (#22919)"
      
      This reverts commit a0233233.
      
      * Revert "Update uses of ButtonTheme.bar: pass along the current Theme's colorScheme (#22827)"
      
      This reverts commit 655bf6a2.
      
      * Revert "ButtonTheme.of().colorScheme defers to Theme (#22880)"
      
      This reverts commit a590940e.
      
      * Revert "Bring TextTheme into alignment with the current Material spec (#22330)"
      
      This reverts commit 8bfb4b3e.
      
      * Revert "Added ColorScheme, updated ThemeData, ButtonTheme, material buttons (#22013)"
      
      This reverts commit eea3465a.
      
      * Manual adjustments to fix reversion issues.
      80f80ab0
  12. 02 Oct, 2018 2 commits
  13. 12 Sep, 2018 1 commit
  14. 07 Sep, 2018 1 commit
  15. 04 Sep, 2018 1 commit
  16. 24 Aug, 2018 1 commit
  17. 22 Aug, 2018 1 commit
    • liyuqian's avatar
      Add customBorder to InkWell so it can clip ShapeBorder (#20751) · ee8754df
      liyuqian authored
      This fixes #20483 by letting InkWell do its own clipping.
      
      PathOp.intersect is not used because we have too many unit tests that rely on clipping (e.g., paints..clipXXX()..drawCircle())
      
      The goldens are updated due to small AA changes of the additional clipPath.
      ee8754df
  18. 21 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Cleanup (#20754) · 94f9604a
      Ian Hickson authored
      - remove an //ignore that is no longer needed
      - fix some intrinsic methods that used the API incorrectly (shouldn't affect correctness but should make things a tiny bit more efficient)
      - add some asserts to help track down bugs quicker
      - update a TODO to point to the currently relevant bug
      - fix some indenting
      - improve the naming of some privates to improve readability
      94f9604a
  19. 15 Aug, 2018 1 commit
  20. 09 Aug, 2018 1 commit
  21. 23 Jul, 2018 1 commit
  22. 19 Jul, 2018 1 commit
  23. 09 Jul, 2018 1 commit
  24. 03 Jul, 2018 2 commits
  25. 05 Jun, 2018 1 commit
  26. 30 May, 2018 1 commit
  27. 20 Mar, 2018 1 commit
  28. 02 Mar, 2018 1 commit
  29. 28 Feb, 2018 1 commit
  30. 05 Feb, 2018 1 commit
  31. 09 Jan, 2018 1 commit
  32. 21 Dec, 2017 1 commit
  33. 23 Oct, 2017 1 commit
  34. 13 Oct, 2017 1 commit
    • Greg Spencer's avatar
      Modify the MaterialButton to expand when text is scaled. (#12431) · 25ac924e
      Greg Spencer authored
      This modifies the MaterialButton to expand vertically to fit the size of the contained child, no matter what the child widget is. It tries to be as close as possible to the minHeight constraint.
      
      Also updated some doc comments to have headers (extra blank line after first sentence), and to wrap at 80 cols.
      
      Addresses #12311
      25ac924e