1. 20 Oct, 2023 1 commit
  2. 19 Oct, 2023 1 commit
    • auto-submit[bot]'s avatar
      Reverts "Use Layer.toImage for golden tests on CanvasKit" (#136860) · c881808e
      auto-submit[bot] authored
      Reverts flutter/flutter#135249
      Initiated by: zanderso
      This change reverts the following previous change:
      Original Description:
      Changes golden tests on CanvasKit to use Layer.toImage instead of browser APIs for screenshots. This brings it more in line with other platforms and should also fix some async timing bugs with tests.
      c881808e
  3. 18 Oct, 2023 1 commit
  4. 17 Oct, 2023 1 commit
  5. 20 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must not be null' comments from various libraries. (#134984) · 8cda3bea
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries.  Each of them only had a few, so I lumped them together.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134991
      - https://github.com/flutter/flutter/pull/134992
      - https://github.com/flutter/flutter/pull/134993
      - https://github.com/flutter/flutter/pull/134994
      
      ## Tests
       - Documentation only change.
      8cda3bea
  6. 04 May, 2023 1 commit
    • Nate Bosch's avatar
      Switch imports from test_api to focused libaries (#125854) · 2089eacc
      Nate Bosch authored
      Move imports of API available in `hooks.dart` or `scaffolding.dart` to use those more narrow libraries.
      
      Move imports of APIs from `package:matcher` to import directly. The next major version of `test_api` will remove the exports of `matcher` APIs.
      2089eacc
  7. 08 Nov, 2022 2 commits
  8. 25 May, 2022 1 commit
    • Pierre-Louis's avatar
      Use `curly_braces_in_flow_control_structures` for non-`flutter` packages (#104629) · 74cfc3db
      Pierre-Louis authored
      * Use `curly_braces_in_flow_control_structures` for `packages/flutter_driver`
      
      * Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens`
      
      * Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens_client`
      
      * Use `curly_braces_in_flow_control_structures` for `packages/flutter_localizations`
      
      * Use `curly_braces_in_flow_control_structures` for `packages/flutter_test`
      
      * Use `curly_braces_in_flow_control_structures` for `packages/flutter_web_plugins`
      
      * fix comments
      
      * Use `curly_braces_in_flow_control_structures` for `packages/integration_test`
      
      * fix indentation
      74cfc3db
  9. 20 Jan, 2022 1 commit
  10. 12 Jan, 2022 1 commit
  11. 07 Oct, 2021 3 commits
  12. 17 Aug, 2021 1 commit
  13. 01 Jul, 2021 1 commit
  14. 02 Jun, 2021 1 commit
  15. 01 Jun, 2021 1 commit
  16. 02 Mar, 2021 1 commit
  17. 01 Oct, 2020 1 commit
  18. 16 Sep, 2020 1 commit
  19. 24 Aug, 2020 1 commit
  20. 28 Jul, 2020 1 commit
  21. 09 Apr, 2020 1 commit
  22. 07 Feb, 2020 1 commit
  23. 04 Feb, 2020 1 commit
  24. 31 Jan, 2020 3 commits
  25. 06 Dec, 2019 1 commit
  26. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  27. 13 Sep, 2019 1 commit
  28. 11 Sep, 2019 1 commit
  29. 03 Sep, 2019 1 commit
  30. 19 Aug, 2019 1 commit
  31. 28 Jul, 2019 1 commit
  32. 12 Jul, 2019 2 commits
    • Kate Lovett's avatar
      Revert "Part 1: Skia Gold Testing (#33688)" (#36094) · 8809f698
      Kate Lovett authored
      This reverts commit eb0b1790.
      Skia Gold post-submit test were failing due to the service account not being found on Cirrus.
      8809f698
    • Kate Lovett's avatar
      Part 1: Skia Gold Testing (#33688) · eb0b1790
      Kate Lovett authored
      * Fresh PR for Gold integration.
      
      * Nits
      
      * WIP
      
      * Artifacts from merge
      
      * Changed some platform dependencies for web, added library prefix notation for Skia Gold test names.
      
      * Updating for CI implementation
      
      * Write out service account
      
      * Writing to skip out
      
      * WIP
      
      * ++
      
      * Fixing depot tools deps
      
      * Windows depot_tools
      
      * Fixing setup scripts
      
      * ++
      
      * depot tools
      
      * ++
      
      * WIP
      
      * Tracing depot_tools clone
      
      * WIP
      
      * ++
      
      * analyzer
      
      * WIP
      
      * chrome typo
      
      * copy artifact
      
      * Working on tests
      
      * Code cleanup
      
      * ++
      
      * Code cleanup, updated tests
      
      * ++ review feedback
      
      * Review
      
      * Analyzer
      
      * Review feedback
      
      * Nits from review
      
      * PRogress
      
      * ++
      
      * Fixing tests
      
      * ++
      
      * Testing repo route
      
      * Just needing documention around new structures.
      
      * cleanup
      
      * Analyzer
      
      * Documentation updates
      
      * Documentation updates
      
      * Cirrus updates
      
      * cirrus nit
      
      * Review feedback
      
      * Review feedback
      
      * Fixing skip comparator
      
      * Fix base directory for Skia Gold case
      
      * ++
      
      * Feedback
      
      * ++
      
      * Fixed uri assertion
      
      * Made GoldensClient abstract, altered SkiaGoldClient constructor
      
      * Analyzer
      eb0b1790
  33. 25 Apr, 2019 1 commit
  34. 29 Jan, 2019 1 commit