- 20 Oct, 2023 1 commit
-
-
Harry Terkelsen authored
Relands https://github.com/flutter/flutter/pull/135249 A golden test was failing in post submit in the previous PR
-
- 19 Oct, 2023 1 commit
-
-
auto-submit[bot] authored
Reverts flutter/flutter#135249 Initiated by: zanderso This change reverts the following previous change: Original Description: Changes golden tests on CanvasKit to use Layer.toImage instead of browser APIs for screenshots. This brings it more in line with other platforms and should also fix some async timing bugs with tests.
-
- 18 Oct, 2023 1 commit
-
-
Harry Terkelsen authored
Changes golden tests on CanvasKit to use Layer.toImage instead of browser APIs for screenshots. This brings it more in line with other platforms and should also fix some async timing bugs with tests. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
- 17 Oct, 2023 1 commit
-
-
Kostia Sokolovskyi authored
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries. Each of them only had a few, so I lumped them together. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 04 May, 2023 1 commit
-
-
Nate Bosch authored
Move imports of API available in `hooks.dart` or `scaffolding.dart` to use those more narrow libraries. Move imports of APIs from `package:matcher` to import directly. The next major version of `test_api` will remove the exports of `matcher` APIs.
-
- 08 Nov, 2022 2 commits
-
-
Zachary Anderson authored
This reverts commit 53e68762.
-
Kate Lovett authored
* allow marking a golden check as flaky * add matchesFlutterGolden to analyze.dart; no tags for flutter_goldens/lib * Pause * ++ * ++ * Analyzer therapy * Once more with feeling * Nits * Review feedback * Silly oops * Test progress * More tests * Finish * Nits * Analyzer * Review feedback Co-authored-by:
Yegor Jbanov <yjbanov@google.com>
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_driver` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens_client` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_localizations` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_test` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_web_plugins` * fix comments * Use `curly_braces_in_flow_control_structures` for `packages/integration_test` * fix indentation
-
- 20 Jan, 2022 1 commit
-
-
Alberto authored
-
- 12 Jan, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 07 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Mouad Debbar authored
This reverts commit cb378edc.
-
Ian Hickson authored
-
- 17 Aug, 2021 1 commit
-
-
Jonah Williams authored
-
- 01 Jul, 2021 1 commit
-
-
Janice Collins authored
-
- 02 Jun, 2021 1 commit
-
-
Anis Alibegić authored
-
- 01 Jun, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 02 Mar, 2021 1 commit
-
-
Kate Lovett authored
-
- 01 Oct, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 16 Sep, 2020 1 commit
-
-
Michael R Fairhurst authored
-
- 24 Aug, 2020 1 commit
-
-
Jonah Williams authored
-
- 28 Jul, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 09 Apr, 2020 1 commit
-
-
Jacob MacDonald authored
-
- 07 Feb, 2020 1 commit
-
-
Emmanuel Garcia authored
-
- 04 Feb, 2020 1 commit
-
-
Emmanuel Garcia authored
This reverts commit e03f4391.
-
- 31 Jan, 2020 3 commits
-
-
Emmanuel Garcia authored
-
Emmanuel Garcia authored
-
Emmanuel Garcia authored
-
- 06 Dec, 2019 1 commit
-
-
Lau Ching Jun authored
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 13 Sep, 2019 1 commit
-
-
Jonah Williams authored
-
- 11 Sep, 2019 1 commit
-
-
Jonah Williams authored
-
- 03 Sep, 2019 1 commit
-
-
Kate Lovett authored
-
- 19 Aug, 2019 1 commit
-
-
Kate Lovett authored
-
- 28 Jul, 2019 1 commit
-
-
Kate Lovett authored
-
- 12 Jul, 2019 2 commits
-
-
Kate Lovett authored
This reverts commit eb0b1790. Skia Gold post-submit test were failing due to the service account not being found on Cirrus.
-
Kate Lovett authored
* Fresh PR for Gold integration. * Nits * WIP * Artifacts from merge * Changed some platform dependencies for web, added library prefix notation for Skia Gold test names. * Updating for CI implementation * Write out service account * Writing to skip out * WIP * ++ * Fixing depot tools deps * Windows depot_tools * Fixing setup scripts * ++ * depot tools * ++ * WIP * Tracing depot_tools clone * WIP * ++ * analyzer * WIP * chrome typo * copy artifact * Working on tests * Code cleanup * ++ * Code cleanup, updated tests * ++ review feedback * Review * Analyzer * Review feedback * Nits from review * PRogress * ++ * Fixing tests * ++ * Testing repo route * Just needing documention around new structures. * cleanup * Analyzer * Documentation updates * Documentation updates * Cirrus updates * cirrus nit * Review feedback * Review feedback * Fixing skip comparator * Fix base directory for Skia Gold case * ++ * Feedback * ++ * Fixed uri assertion * Made GoldensClient abstract, altered SkiaGoldClient constructor * Analyzer
-
- 25 Apr, 2019 1 commit
-
-
sjindel-google authored
Previously benchmark_test.dart would break if run with --update-goldens. Now the entire test suite can be run with --update-goldens.
-
- 29 Jan, 2019 1 commit
-
-
Alexandre Ardhuin authored
-