- 17 May, 2023 21 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/331c5769e291...d97037077963 2023-05-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from YrEDYUB9NKhirgo5s... to SDKw1RvH0dWiJXERo... (flutter/engine#42100) 2023-05-17 jonahwilliams@google.com [Impelller] fix flickering due to synchronization issues in compute tessellator. (flutter/engine#42076) 2023-05-17 rmolivares@renzo-olivares.dev [Android] Do not collapse text selection on shift key up (flutter/engine#42075) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from YrEDYUB9NKhi to SDKw1RvH0dWi If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Christopher Fujino authored
Time outs are currently making the tree red. Fixes https://github.com/flutter/flutter/issues/127004
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0ae3719d7043...331c5769e291 2023-05-17 mdebbar@google.com [web] Simplify handling of custom url strategy (flutter/engine#42043) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Sam Rawlins authored
When the analyzer detects an unused parameter, it reports `unused_element` which can be ignored with an inline ignore like `// ignore: unused_element`. The analyzer will start reporting instead, `unused_element_parameter`. There are ignores in flutter/flutter that need to be updated to the new code. In order to incrementally migrate, they can be changed to `// ignore: unused_element, unused_element_parameter`. After flutter/flutter is using a new enough analyzer, we can then change those to `// ignore: unused_element_parameter`. Work towards https://github.com/flutter/flutter/issues/126924
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/47fd496c6f8d...0ae3719d7043 2023-05-17 dnfield@google.com Report displays for macOS (flutter/engine#41998) 2023-05-17 dnfield@google.com Fix bounds when painting style is stroke width for image shaders (flutter/engine#42052) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/400a26ad8343...47fd496c6f8d 2023-05-17 103135467+sealesj@users.noreply.github.com Re-Enable Vulnerability 3p Scanning Workflow (flutter/engine#42049) 2023-05-17 skia-flutter-autoroll@skia.org Roll Skia from c3473c32bb35 to ffa425bacfc4 (14 revisions) (flutter/engine#42095) 2023-05-17 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned on wide gamut support by default. (#39801) (flutter/engine#41965) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Christopher Fujino authored
camera_android was pinned because of https://github.com/flutter/flutter/issues/126710, which was fixed upstream in release 0.10.8+1.
-
Michael Goderbauer authored
Partial revert of https://github.com/flutter/flutter/pull/126647 to work around issue in google3. See b/283046390
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/6048360c1837...400a26ad8343 2023-05-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from dIATtSiPf8KE25MMF... to wNfsef5we4l8hxEII... (flutter/engine#42094) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from dIATtSiPf8KE to wNfsef5we4l8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Michael Goderbauer authored
Follow-up to https://github.com/flutter/flutter/pull/126926.
-
Justin McCandless authored
Added examples clarifying how to fetch Autocomplete options asynchronously.
-
JellyO1 authored
This PR exposes a requestFocusCallback on `FocusTraversalPolicy` and it's inheritors. Fixes #83175.
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/b9718302b30f...5c6991400e91 2023-05-17 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 2.18.5 to 2.18.6 in /packages/video_player/video_player_android/android (flutter/packages#3770) 2023-05-17 JeroenWeener@users.noreply.github.com [in_app_purchase] Fully migrate to BillingClient V5 (flutter/packages#3752) 2023-05-17 stuartmorgan@google.com [ci] Re-enable Windows repo tool tests (flutter/packages#4007) 2023-05-16 stuartmorgan@google.com [ci] Allow simctl shutdown to fail (flutter/packages#4024) 2023-05-16 stuartmorgan@google.com [ci] Move Linux repo tool tests to LUCI (flutter/packages#4006) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ea3f27383acc...6048360c1837 2023-05-17 skia-flutter-autoroll@skia.org Roll Skia from 88d7a68694d9 to c3473c32bb35 (2 revisions) (flutter/engine#42093) 2023-05-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 2fc9f4dd9623 to 7f6fabbe9fba (1 revision) (flutter/engine#42090) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Taha Tesser authored
-
joshualitt authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/4b7c37532ea4...ea3f27383acc 2023-05-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from D_EOM3rJ8AMk3-Wex... to YrEDYUB9NKhirgo5s... (flutter/engine#42086) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from D_EOM3rJ8AMk to YrEDYUB9NKhi If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/170b45bae571...4b7c37532ea4 2023-05-17 skia-flutter-autoroll@skia.org Roll Dart SDK from dbbb8a6d79a3 to 2fc9f4dd9623 (1 revision) (flutter/engine#42085) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/28b9dc993c30...170b45bae571 2023-05-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from N4LwCRxg0oIevhQ_O... to dIATtSiPf8KE25MMF... (flutter/engine#42084) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from N4LwCRxg0oIe to dIATtSiPf8KE If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/87a03e107df7...28b9dc993c30 2023-05-16 skia-flutter-autoroll@skia.org Roll Dart SDK from d2b2ac829842 to dbbb8a6d79a3 (3 revisions) (flutter/engine#42082) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/1c775e34e2d5...87a03e107df7 2023-05-16 bdero@google.com [Impeller] Use 32 bit Gaussian function in the 2-pass blur (flutter/engine#42069) 2023-05-16 skia-flutter-autoroll@skia.org Roll Skia from 9b0e912a1cb9 to 88d7a68694d9 (13 revisions) (flutter/engine#42081) 2023-05-16 jacksongardner@google.com Use client ICU data with skwasm. (flutter/engine#42018) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 16 May, 2023 19 commits
-
-
Sigurd Meldgaard authored
Follow-up to https://github.com/flutter/flutter/pull/121802 resolving some style issues.
-
engine-flutter-autoroll authored
Manual roll requested by zra@google.com https://github.com/flutter/engine/compare/fe2476743b59...1c775e34e2d5 2023-05-16 zanderso@users.noreply.github.com Revert "[ios_platform_view] only recycle maskView when the view is applying mutators" (flutter/engine#42080) 2023-05-16 gspencergoog@users.noreply.github.com [macOS] Wait for binding to be ready before requesting exits from framework (flutter/engine#41753) 2023-05-16 gspencergoog@users.noreply.github.com [linux] Wait for binding to be ready before requesting exits from framework (flutter/engine#41782) 2023-05-16 jacksongardner@google.com Initial support for images in Skwasm (flutter/engine#42019) 2023-05-16 jacksongardner@google.com Use new `unresolvedCodePoints` API from skia. (flutter/engine#41991) 2023-05-16 jason-simmons@users.noreply.github.com Convert public API NativeFieldWrapper classes to abstract interfaces (flutter/engine#41945) 2023-05-16 737941+loic-sharma@users.noreply.github.com [Windows] Add force redraw to the C++ client wrapper (flutter/engine#42061) 2023-05-16 godofredoc@google.com Fix drone_dimension host_engine_builder. (flutter/engine#42068) 2023-05-16 godofredoc@google.com Add linux_clang_tidy builder. (flutter/engine#41990) 2023-05-16 ychris@google.com [ios_platform_view] only recycle maskView when the view is applying mutators (flutter/engine#41573) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Ian Hickson authored
This is a proof of concept for renaming SlottedMultiChildRenderObjectWidgetMixin to SlottedMultiChildRenderObjectWidget and making it a concrete class. I also made SlottedContainerRenderObjectMixin generic instead of being specialized to RenderBox. I don't think this is something we can easily automigrate, but we may not need to, I don't know how common this is...
-
Ian Hickson authored
When implementing scrollbars, I found that it would be useful and idiomatic to be able to do `m.extentInside / m.extentTotal` to get the scrollbar thumb size.
-
godofredoc authored
Use drone_dimensions instead of dimensions for builds running on dart-internal. This is required for those builders to select the correct drone type.
-
Mitchell Goodwin authored
Fixes: #102813 Adds a checkmark style to the Cupertino Radio. Also allows the Radio.adaptive and RadioListTile.adaptive widgets to control whether they use the checkmark style for their Cupertino widgets or not. This is how it looks in action: https://github.com/flutter/flutter/assets/58190796/b409b270-42dd-404a-9350-d2c3e1d7fa4e
-
keyonghan authored
Target `Mac_build_test flutter_gallery__transition_perf_e2e_ios` was enabled in staging: https://github.com/flutter/flutter/pull/111164, and it has passed more than 50 runs: https://ci.chromium.org/p/flutter/builders/staging/Mac_build_test%20flutter_gallery__transition_perf_e2e_ios?limit=50. Manually enabling it in prod and removing the old `Mac_ios flutter_gallery__transition_perf_e2e_ios`. The `Mac_build_test` one does the same thing as `Mac_ios` one, but separating build and test steps in separate targets. Context: https://github.com/flutter/flutter/issues/103542
-
Jason Simmons authored
Fixes https://github.com/flutter/flutter/issues/126676
-
Mushaheed Syed authored
Fixes copyWith method of ActionIconThemeData, now using blank copyWith on [ActionIconThemeData] object that isn't `const ActionIconThemeData()` returns object with same values. *List which issues are fixed by this PR.* Fixes https://github.com/flutter/flutter/issues/126762
-
Zachary Anderson authored
Reverts flutter/flutter#126934 Bad Engine roll.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/fe2476743b59...5cf141f7c03c 2023-05-16 godofredoc@google.com Add linux_clang_tidy builder. (flutter/engine#41990) 2023-05-16 ychris@google.com [ios_platform_view] only recycle maskView when the view is applying mutators (flutter/engine#41573) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Michael Goderbauer authored
Follow-up to https://github.com/flutter/flutter/pull/126647#discussion_r1195417860.
-
yaakovschectman authored
Send a platform message to the engine when the `ServiceBinding` is registered. Framework side of https://github.com/flutter/engine/pull/41733 Addresses https://github.com/flutter/flutter/issues/126033 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --------- Co-authored-by:
Greg Spencer <gspencergoog@users.noreply.github.com>
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/525a53eb58ed...fe2476743b59 2023-05-16 skia-flutter-autoroll@skia.org Roll Skia from 24bebce2d9a1 to 9b0e912a1cb9 (12 revisions) (flutter/engine#42072) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Victoria Ashworth authored
Instead of using rsync, which has caused errors in the past (https://github.com/flutter/flutter/issues/99785), delete the file/directory/link prior to moving it. Hopefully should let us stop double zipping the FlutterMacOS.framework in the engine: https://github.com/flutter/engine/pull/41306/files Part of https://github.com/flutter/flutter/issues/126016.
-
Jason Simmons authored
Update SemanticsUpdateBuilderSpy for the conversion of SemanticsUpdateBuilder into a base class (#126570) See https://github.com/flutter/flutter/issues/123756
-
st merlhin authored
â¦property This PR expose `CupertinoDatePicker` and `CupertinoTimerPicker` `itemExtent` property to allow setting custom one depending on `tMediaQuery.of(context).textScaleFactor`. Fixes: #125127
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d7a5de672d1e...525a53eb58ed 2023-05-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 38Oyy28qgYCdt7fEV... to D_EOM3rJ8AMk3-Wex... (flutter/engine#42071) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 38Oyy28qgYCd to D_EOM3rJ8AMk If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Michael Goderbauer authored
-
