1. 16 Feb, 2024 1 commit
  2. 13 Feb, 2024 2 commits
  3. 08 Feb, 2024 3 commits
    • Jackson Gardner's avatar
      Revert Dual Web Compile changes (#143175) · 2efeeb47
      Jackson Gardner authored
      Dual Web Compile has had some issues where `flutter test` is not respecting the `--web-renderer` flag for some reason. I haven't gotten entirely to the bottom of the issue, but for now we need to rever these changes while I investigate. This reverts the following PRs:
      
      https://github.com/flutter/flutter/pull/143128
      https://github.com/flutter/flutter/pull/141396
      
      While doing this revert, I had a few merge conflicts with https://github.com/flutter/flutter/pull/142760, and I tried to resolve the merge conflicts within the spirit of that PR's change, but @chingjun I might need your input on whether the imports I have modified are okay with regards to the change you were making.
      2efeeb47
    • Daco Harkes's avatar
      Reland "Move native assets to `isolated/` directory" (#143055) · 4e70bfae
      Daco Harkes authored
      Reland of https://github.com/flutter/flutter/pull/142709.
      
      The revert of the revert is in the first commit, the fix in the commit on top.
      
      The move of the fakes for packages/flutter_tools/test/general.shard/resident_runner_test.dart was erroneous before, as it was trying to use setters instead of a private field. This PR changes the private `_devFS` field in the fake to be a public `fakeDevFS` in line with other fakes.
      
      ## Original PR description
      
      Native assets in other build systems are not built with `package:native_assets_builder` invoking `build.dart` scripts. Instead all packages have their own blaze rules. Therefore we'd like to not depend on `package:native_assets_builder` from flutter tools in g3 at all.
      
      This PR aims to move the imports of `native_assets_builder` and `native_assets_cli` into the `isolated/` directory and into the files with a `main` function that are not used in with other build systems.
      
      In order to be able to remove all imports in files used by other build systems, two new interfaces are added `HotRunnerNativeAssetsBuilder` and `TestCompilerNativeAssetsBuilder`. New parameters are then piped all the way through from the entry points:
      
      * bin/fuchsia_tester.dart
      * lib/executable.dart
      
      The build_system/targets dir is already excluded in other build systems.
      
      So, after this PR only the two above files and build_system/targets import from `isolated/native_assets/` and only `isolated/native_assets/` import `package:native_assets_cli` and `package:native_assets_builder`.
      
      Context:
      
      * https://github.com/flutter/flutter/issues/142041
      4e70bfae
    • Jackson Gardner's avatar
      Pass along web renderer into debugging options in the test command. (#143128) · 71c6cd0c
      Jackson Gardner authored
      We need to pass along the web renderer in the debugging options to make sure that the resident web runner sets up the targets correctly.
      71c6cd0c
  4. 07 Feb, 2024 1 commit
    • auto-submit[bot]'s avatar
      Reverts "Move native assets to `isolated/` directory" (#143027) · ceca6066
      auto-submit[bot] authored
      Reverts flutter/flutter#142709
      
      Initiated by: vashworth
      
      Reason for reverting: `Mac tool_tests_general` started failing on this commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20tool_tests_general/15552/overview
      
      Original PR Author: dcharkes
      
      Reviewed By: {christopherfujino, chingjun, reidbaker}
      
      This change reverts the following previous change:
      Original Description:
      Native assets in other build systems are not built with `package:native_assets_builder` invoking `build.dart` scripts. Instead all packages have their own blaze rules. Therefore we'd like to not depend on `package:native_assets_builder` from flutter tools in g3 at all.
      
      This PR aims to move the imports of `native_assets_builder` and `native_assets_cli` into the `isolated/` directory and into the files with a `main` function that are not used in with other build systems.
      
      In order to be able to remove all imports in files used by other build systems, two new interfaces are added `HotRunnerNativeAssetsBuilder` and `TestCompilerNativeAssetsBuilder`. New parameters are then piped all the way through from the entry points:
      
      * bin/fuchsia_tester.dart
      * lib/executable.dart
      
      The build_system/targets dir is already excluded in other build systems.
      
      So, after this PR only the two above files and build_system/targets import from `isolated/native_assets/` and only `isolated/native_assets/` import `package:native_assets_cli` and `package:native_assets_builder`.
      
      Context:
      
      * https://github.com/flutter/flutter/issues/142041
      ceca6066
  5. 06 Feb, 2024 1 commit
    • Daco Harkes's avatar
      Move native assets to `isolated/` directory (#142709) · a069e62e
      Daco Harkes authored
      Native assets in other build systems are not built with `package:native_assets_builder` invoking `build.dart` scripts. Instead all packages have their own blaze rules. Therefore we'd like to not depend on `package:native_assets_builder` from flutter tools in g3 at all.
      
      This PR aims to move the imports of `native_assets_builder` and `native_assets_cli` into the `isolated/` directory and into the files with a `main` function that are not used in with other build systems.
      
      In order to be able to remove all imports in files used by other build systems, two new interfaces are added `HotRunnerNativeAssetsBuilder` and `TestCompilerNativeAssetsBuilder`. New parameters are then piped all the way through from the entry points:
      
      * bin/fuchsia_tester.dart
      * lib/executable.dart
      
      The build_system/targets dir is already excluded in other build systems.
      
      So, after this PR only the two above files and build_system/targets import from `isolated/native_assets/` and only `isolated/native_assets/` import `package:native_assets_cli` and `package:native_assets_builder`.
      
      Context:
      
      * https://github.com/flutter/flutter/issues/142041
      a069e62e
  6. 01 Feb, 2024 1 commit
  7. 23 Jan, 2024 1 commit
  8. 12 Jan, 2024 1 commit
  9. 05 Jan, 2024 2 commits
  10. 03 Jan, 2024 1 commit
  11. 21 Sep, 2023 1 commit
  12. 17 Jul, 2023 1 commit
  13. 09 Jun, 2023 1 commit
  14. 02 Jun, 2023 1 commit
  15. 08 May, 2023 2 commits
  16. 22 Mar, 2023 1 commit
  17. 20 Mar, 2023 1 commit
  18. 17 Mar, 2023 2 commits
  19. 13 Mar, 2023 1 commit
  20. 28 Feb, 2023 1 commit
  21. 27 Feb, 2023 3 commits
  22. 21 Feb, 2023 1 commit
  23. 17 Feb, 2023 1 commit
  24. 13 Feb, 2023 1 commit
  25. 06 Feb, 2023 1 commit
  26. 01 Feb, 2023 1 commit
  27. 30 Jan, 2023 1 commit
  28. 27 Jan, 2023 1 commit
  29. 25 Jan, 2023 1 commit
  30. 23 Jan, 2023 1 commit
  31. 16 Nov, 2022 1 commit
    • Elias Yishak's avatar
      removing default values for [reporter] and [timeout] in flutter test (#115160) · d7454d55
      Elias Yishak authored
      * removing default values for [reporter] and [timeout]]
      
      * passing reporter arg to see tests pass
      
      * added test to confirm TestCommand is not passing defaults
      
      * add'l helper message for [reporter] arg
      
      * default behavior for github actions + fixed tests
      
      * removing github conditional for reporter + related test
      
      * removing unused import
      d7454d55
  32. 11 Nov, 2022 1 commit