- 16 Feb, 2024 1 commit
-
-
Andrew Kolos authored
Fixes https://github.com/flutter/flutter/issues/143513 Should be cherry-picked to beta.
-
- 13 Feb, 2024 2 commits
-
-
Jackson Gardner authored
This is an attempt at a reland of https://github.com/flutter/flutter/pull/141396 The main changes here that are different than the original PR is fixes to wire up the `flutter test` command properly with the web renderer.
-
Andrew Kolos authored
This is in service of https://github.com/flutter/flutter/pull/141194 This will make it easier to get the `flutter run -d <browser>` and `flutter build fuschia` cases easier to get under test.
-
- 08 Feb, 2024 3 commits
-
-
Jackson Gardner authored
Dual Web Compile has had some issues where `flutter test` is not respecting the `--web-renderer` flag for some reason. I haven't gotten entirely to the bottom of the issue, but for now we need to rever these changes while I investigate. This reverts the following PRs: https://github.com/flutter/flutter/pull/143128 https://github.com/flutter/flutter/pull/141396 While doing this revert, I had a few merge conflicts with https://github.com/flutter/flutter/pull/142760, and I tried to resolve the merge conflicts within the spirit of that PR's change, but @chingjun I might need your input on whether the imports I have modified are okay with regards to the change you were making.
-
Daco Harkes authored
Reland of https://github.com/flutter/flutter/pull/142709. The revert of the revert is in the first commit, the fix in the commit on top. The move of the fakes for packages/flutter_tools/test/general.shard/resident_runner_test.dart was erroneous before, as it was trying to use setters instead of a private field. This PR changes the private `_devFS` field in the fake to be a public `fakeDevFS` in line with other fakes. ## Original PR description Native assets in other build systems are not built with `package:native_assets_builder` invoking `build.dart` scripts. Instead all packages have their own blaze rules. Therefore we'd like to not depend on `package:native_assets_builder` from flutter tools in g3 at all. This PR aims to move the imports of `native_assets_builder` and `native_assets_cli` into the `isolated/` directory and into the files with a `main` function that are not used in with other build systems. In order to be able to remove all imports in files used by other build systems, two new interfaces are added `HotRunnerNativeAssetsBuilder` and `TestCompilerNativeAssetsBuilder`. New parameters are then piped all the way through from the entry points: * bin/fuchsia_tester.dart * lib/executable.dart The build_system/targets dir is already excluded in other build systems. So, after this PR only the two above files and build_system/targets import from `isolated/native_assets/` and only `isolated/native_assets/` import `package:native_assets_cli` and `package:native_assets_builder`. Context: * https://github.com/flutter/flutter/issues/142041
-
Jackson Gardner authored
We need to pass along the web renderer in the debugging options to make sure that the resident web runner sets up the targets correctly.
-
- 07 Feb, 2024 1 commit
-
-
auto-submit[bot] authored
Reverts flutter/flutter#142709 Initiated by: vashworth Reason for reverting: `Mac tool_tests_general` started failing on this commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20tool_tests_general/15552/overview Original PR Author: dcharkes Reviewed By: {christopherfujino, chingjun, reidbaker} This change reverts the following previous change: Original Description: Native assets in other build systems are not built with `package:native_assets_builder` invoking `build.dart` scripts. Instead all packages have their own blaze rules. Therefore we'd like to not depend on `package:native_assets_builder` from flutter tools in g3 at all. This PR aims to move the imports of `native_assets_builder` and `native_assets_cli` into the `isolated/` directory and into the files with a `main` function that are not used in with other build systems. In order to be able to remove all imports in files used by other build systems, two new interfaces are added `HotRunnerNativeAssetsBuilder` and `TestCompilerNativeAssetsBuilder`. New parameters are then piped all the way through from the entry points: * bin/fuchsia_tester.dart * lib/executable.dart The build_system/targets dir is already excluded in other build systems. So, after this PR only the two above files and build_system/targets import from `isolated/native_assets/` and only `isolated/native_assets/` import `package:native_assets_cli` and `package:native_assets_builder`. Context: * https://github.com/flutter/flutter/issues/142041
-
- 06 Feb, 2024 1 commit
-
-
Daco Harkes authored
Native assets in other build systems are not built with `package:native_assets_builder` invoking `build.dart` scripts. Instead all packages have their own blaze rules. Therefore we'd like to not depend on `package:native_assets_builder` from flutter tools in g3 at all. This PR aims to move the imports of `native_assets_builder` and `native_assets_cli` into the `isolated/` directory and into the files with a `main` function that are not used in with other build systems. In order to be able to remove all imports in files used by other build systems, two new interfaces are added `HotRunnerNativeAssetsBuilder` and `TestCompilerNativeAssetsBuilder`. New parameters are then piped all the way through from the entry points: * bin/fuchsia_tester.dart * lib/executable.dart The build_system/targets dir is already excluded in other build systems. So, after this PR only the two above files and build_system/targets import from `isolated/native_assets/` and only `isolated/native_assets/` import `package:native_assets_cli` and `package:native_assets_builder`. Context: * https://github.com/flutter/flutter/issues/142041
-
- 01 Feb, 2024 1 commit
-
-
Victoria Ashworth authored
When the Dart VM is not found within 10 minutes in CI on CoreDevices (iOS 17+), stop the app and upload the logs from DerivedData. The app has to be stopped first since the logs are not put in DerivedData until it's stopped. Also, rearranged some logic to have CoreDevice have its own function for Dart VM url discovery. Debugging for https://github.com/flutter/flutter/issues/142448.
-
- 23 Jan, 2024 1 commit
-
-
Andrew Kolos authored
consolidate AssetBundle::entries and AssetBundle::entryKinds into a new type, `AssetBundleEntry` (#142029) Part of work on https://github.com/flutter/flutter/pull/141194 The [`AssetBundle`](https://github.com/flutter/flutter/blob/0833929c997c8a9db11c1e0df9a731ab17b77606/packages/flutter_tools/lib/src/asset.dart#L80) class contains two members, `entries` and `entryKinds`. `entries` contains asset data indexed by asset key. `entryKinds` contains the "kinds" of these assets, again indexed by asset key. **Change.** Rather than have two separate maps, this PR proposes combining these maps into one by wrapping the asset data and kind into a single data type `AssetBundleEntry`. **Purpose.** In https://github.com/flutter/flutter/pull/141194, I am considering associating more information with an asset. In particular, what transformers are meant to be applied to it when copying it to the build output. Rather than adding another map member onto `AssetBundle` (e.g. `entryTransformers`), I decided to make things neater by introducing the `AssetBundleEntry` type.
-
- 12 Jan, 2024 1 commit
-
-
Jonah Williams authored
When compiling shaders for flutter tester, include Vulkan shaders when targeting Impeller.
-
- 05 Jan, 2024 2 commits
-
-
Andrew Kolos authored
in `flutter run`, throw tool exit when `--flavor` is provided but is not supported on the target device (#139045) Fixes https://github.com/flutter/flutter/issues/134197
-
Andrew Kolos authored
Fixes https://github.com/flutter/flutter/issues/140932
-
- 03 Jan, 2024 1 commit
-
-
Jonah Williams authored
This allows unit tests to use the impeller backend, which can be useful for Scubas/golden tests.
-
- 21 Sep, 2023 1 commit
-
-
Derek Xu authored
-
- 17 Jul, 2023 1 commit
-
-
Pavel Mazhnik authored
PR provides a new option to the `test` command to include coverage info of specified packages. It helps collecting coverage info in test setups where test code lives in separate packages or for multi-package projects. At present, only current package is included to the final report. Usage: Consider an app with two packages: `app`, `common`. Some of the tests in `app` use (indirectly) code that is located in `common`. When running with `--coverage` flag, that code is not included in the coverage report by default. To include `common` package in report, we can run: ```sh flutter test --coverage --coverage-package app --coverage-package common ``` Note that `--coverage-package` accepts regular expression. Fixes https://github.com/flutter/flutter/issues/79661 Fixes https://github.com/flutter/flutter/issues/101486 Fixes https://github.com/flutter/flutter/issues/93619
-
- 09 Jun, 2023 1 commit
-
-
Andrew Kolos authored
rename generated asset manifest file back to `AssetManifest.bin` (from `AssetManifest.smcbin`) (#128529) Closes https://github.com/flutter/flutter/issues/128456, which is now linked to in a code comment in this change. Reopens https://github.com/flutter/flutter/issues/124883. This effectively reverts https://github.com/flutter/flutter/pull/126077 and is intended to be cherry-picked into stable.
-
- 02 Jun, 2023 1 commit
-
-
Victoria Ashworth authored
Workaround solution for: https://github.com/flutter/flutter/issues/121231 See https://github.com/flutter/flutter/issues/120808#issuecomment-1551826299 Error Case 2 for more information. Sometimes the `ios-deploy` process does not return the logs from the application. We've been unable to figure out why. This is a solution to workaround that by using `idevicesyslog` alongside `ios-deploy` as a backup in getting the log for the Dart VM url. As explained in https://github.com/flutter/flutter/issues/120808#issuecomment-1551826299, when error case 2 happens, the `idevicesyslog` does successfully find the Dart VM. Also, in the comments of the code it mentions `syslog` is not written on iOS 13+, this was added in response to this issue: https://github.com/flutter/flutter/issues/41133. However, `idevicesyslog` does in fact work (at least for iOS 16), we use it to collect device logs for our CI tests already: https://github.com/flutter/flutter/blob/1dc26f80f04c1c1091a83c5fead9b3aa83483292/dev/devicelab/lib/framework/devices.dart#L998-L1006
-
- 08 May, 2023 2 commits
-
-
fzyzcjy authored
Close https://github.com/flutter/flutter/issues/125940 I will add tests if this PR looks roughly OK :) The fix mainly mimics https://github.com/flutter/flutter/pull/115160 - just remove the default argument. p.s. I ran into this bug when wanting to set concurrency in my dart_test.yaml for one set of my tests which I need to be executed without parallalization.
-
Jackson Gardner authored
This should fix https://github.com/flutter/flutter/issues/126178 When we don't pass a `--concurrency` flag to the test package, it uses a default based on the number of cores that are on the machine. However, the web test platform itself serializes all these requests anyway, which can lead to the test package timing out. This is because from the test package's perspective, it has already started the loading process on a number of suites which are simply waiting for other test suites to compile and run. The ones that wait the longest can run up against the test packages 12 minute timeout for loading a given suite, even though they haven't actually started to try to load. Instead, we should always pass `--concurrency=1` to the test package so that it doesn't attempt to start loads concurrently in the first place.
-
- 22 Mar, 2023 1 commit
-
-
Christopher Fujino authored
Revert "[flutter_tools] Remove sound null safety flag (#123031)"
-
- 20 Mar, 2023 1 commit
-
-
Christopher Fujino authored
[flutter_tools] Remove sound null safety flag #2
-
- 17 Mar, 2023 2 commits
-
-
Christopher Fujino authored
This reverts commit 7c3088cf.
-
Christopher Fujino authored
[flutter_tools] Remove sound null safety flag
-
- 13 Mar, 2023 1 commit
-
-
Bartek Pacia authored
[flutter_tools] Clean up `boolArgDeprecated` and `stringArgDeprecated`
-
- 28 Feb, 2023 1 commit
-
- 27 Feb, 2023 3 commits
-
-
Michael Goderbauer authored
Revert "Reland "Remove references to Observatory (#118577)""
-
Danny Tuppeny authored
* [flutter_tools] Add support for URI formats like ?line=x for "flutter test" * Remove unnecessary function * Handle parsing absolute paths on Windows * Use Windows-style paths when running on Windows * Fix paths in isFile * Remove unnecessary clear
-
- 21 Feb, 2023 1 commit
-
-
Mateus Felipe C. C. Pinto authored
* allow passing --file-reporter option to test running refs #69425 * Add trailing comma to help to meet style requirements * Add space between tests for clarity --------- Co-authored-by:
daniel-v <dvarga@skawa.hu>
-
- 17 Feb, 2023 1 commit
-
-
Casey Hillers authored
This reverts commit 2df140f4.
-
- 13 Feb, 2023 1 commit
-
-
Ben Konyi authored
Observatory is being deprecated for Dart 3.0 so it should no longer be referenced in tooling messaging / flags. See https://github.com/dart-lang/sdk/issues/50233
-
- 06 Feb, 2023 1 commit
-
- 01 Feb, 2023 1 commit
-
-
Zachary Anderson authored
Revert "Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119529)" (#119729) This reverts commit 7477d7ac.
-
- 30 Jan, 2023 1 commit
-
- 27 Jan, 2023 1 commit
-
-
Zachary Anderson authored
This reverts commit 6cd4fa45.
-
- 25 Jan, 2023 1 commit
-
-
Ben Konyi authored
This flag will allow for Observatory to be served by the VM service once it is disabled by default in the Dart SDK.
-
- 23 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes * fix after merge conflicts * review
-
- 16 Nov, 2022 1 commit
-
-
Elias Yishak authored
* removing default values for [reporter] and [timeout]] * passing reporter arg to see tests pass * added test to confirm TestCommand is not passing defaults * add'l helper message for [reporter] arg * default behavior for github actions + fixed tests * removing github conditional for reporter + related test * removing unused import
-
- 11 Nov, 2022 1 commit
-
-
Jonah Williams authored
* [flutter_tools] support github reporter * Update packages/flutter_tools/lib/src/commands/test.dart Co-authored-by:
Christopher Fujino <fujino@google.com> Co-authored-by:
Christopher Fujino <fujino@google.com>
-