- 26 Jan, 2024 1 commit
-
-
Andrew Kolos authored
Fixes https://github.com/flutter/flutter/issues/142286 This is a refactor. No code behavior changes should be observed.
-
- 21 Nov, 2023 1 commit
-
-
Andrew Kolos authored
In `flutter doctor -v`, when JRE is too out-of-date to run `sdkmanager`, print a helpful error message (#138762) Closes https://github.com/flutter/flutter/issues/138132. See this issue for more information.
-
- 31 Aug, 2023 1 commit
-
-
Loïc Sharma authored
Flutter doctor warns if the user is updating Visual Studio or has paused a Visual Studio update. The current output recommends reinstalling Visual Studio. This is unnecessary as the user should be able to use the Visual Studio Installer app to complete the installation:  This message is covered by this existing test: https://github.com/flutter/flutter/blob/229b74d987720a0437039b6e44e13f20fb94ad51/packages/flutter_tools/test/general.shard/windows/visual_studio_validator_test.dart#L68-L81 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
- 22 Aug, 2023 1 commit
-
-
Matan Lurey authored
Closes #132245.
-
- 18 Aug, 2023 1 commit
-
-
Jason Simmons authored
-
- 17 Aug, 2023 1 commit
-
-
Matan Lurey authored
Partial work towards https://github.com/flutter/flutter/issues/132245. The goal here is to "sniff" out any missing pieces that would block engine builds, rolls, benchmarks and so on before requiring humans to provide the parameter. The implementation is based on a [short discussion with @christopherfujino](https://discord.com/channels/608014603317936148/608022056616853515/1141503921546875110): @matanlurey: > Not sure whether to post here or â hackers-infra-ð¡ , but is there a way to (and is it advisable to) detect whether the tool is running in a CI environment? I'd like to "soft enforce" --local-engine-host being provided strictly on CI, make sure that lands well, and then "upgrade" it to being non-CI invocations as well (re: https://github.com/flutter/flutter/issues/132245). > > Also happy to get talked out of this idea ð @christopherfujino: > we have a check, lemme find it > whether or not it is advisable, idk > https://github.com/flutter/flutter/blob/flutter-3.14-candidate.0/packages/flutter_tools/lib/src/base/bot_detector.dart#L30 > > (...) > > is your desire to get early signal before enforcing t his for humans to prevent functionality churn of landing and reverting and re-landing? > > (yes) > > uhh, sure, that's advisable ð
-
- 10 Aug, 2023 1 commit
-
-
Matan Lurey authored
Closes https://github.com/flutter/flutter/issues/132162. I did a tiny bit of minor cleanup but didn't want to go
beyond the scope of this change. After it lands I'll update the Wiki. ## Before ```bash $ fl run \ --local-engine-src-path=$ENGINE \ --local-engine=android_debug_unopt_arm64 ``` ... would try to use `host_debug_unopt` (i.e. Rosetta). ## After ```bash $ fl run \ --local-engine-src-path=$ENGINE \ --local-engine=android_debug_unopt_arm64 \ --local-engine-host=host_debug_unopt_arm64 ``` ... uses `host_debug_unopt_arm64`, as specified. --- /cc @jonahwilliams @gaaclarke @zanderso
-
- 07 Jul, 2023 1 commit
-
-
Caique Ribeiro de Oliveira authored
<img width="919" alt="image" src="https://github.com/flutter/flutter/assets/42003129/4bc8c3b8-29af-4b98-9232-47a583523e3c"> I was installing Flutter and noticed that the download link for Xcode is incorrect. They might have changed it, but the current link doesn't exist.
-
- 23 May, 2023 1 commit
-
-
Ian Hickson authored
Give channel descriptions in `flutter channel`, use branch instead of upstream for channel name (#126936) ## How we determine the channel name Historically, we used the current branch's upstream to figure out the current channel name. I have no idea why. I traced it back to https://github.com/flutter/flutter/pull/446/files where @abarth implement this and I reviewed that PR and left no comment on it at the time. I think this is confusing. You can be on a branch and it tells you that your channel is different. That seems weird. This PR changes the logic to uses the current branch as the channel name. ## How we display channels The main reason this PR exists is to add channel descriptions to the `flutter channel` list: ``` ianh@burmese:~/dev/flutter/packages/flutter_tools$ flutter channel Flutter channels: master (tip of tree, for contributors) main (tip of tree, follows master channel) beta (updated monthly, recommended for experienced users) stable (updated quarterly, for new users and for production app releases) * foo_bar Currently not on an official channel. ianh@burmese:~/dev/flutter/packages/flutter_tools$ ``` ## Other changes I made a few other changes while I was at it: * If you're not on an official channel, we used to imply `--show-all`, but now we don't, we just show the official channels plus yours. This avoids flooding the screen in the case the user is on a weird channel and just wants to know what channel they're on. * I made the tool more consistent about how it handles unofficial branches. Now it's always `[user branch]`. * I slightly adjusted how unknown versions are rendered so it's clearer the version is unknown rather than just having the word "Unknown" floating in the output without context. * Simplified some of the code. * Made some of the tests more strict (checking all output rather than just some aspects of it). * Changed the MockFlutterVersion to implement the FlutterVersion API more strictly. * I made sure we escape the output to `.metadata` to avoid potential injection bugs (previously we just inlined the version and channel name verbatim with no escaping, which is super sketchy). * Tweaked the help text for the `downgrade` command to be clearer. * Removed some misleading text in some error messages. * Made the `.metadata` generator consistent with the template file. * Removed some obsolete code to do with the `dev` branch. ## Reviewer notes I'm worried that there are implications to some of these changes that I am not aware of, so please don't assume I know what I'm doing when reviewing this code. :-)
-
- 02 May, 2023 1 commit
-
-
Loïc Sharma authored
Update `flutter doctor` to clarify that Visual Studio is needed only if creating Windows apps. Windows users targeting Android do not need to install Visual Studio.
-
- 19 Apr, 2023 2 commits
-
-
Andrew Kolos authored
Adds `todo` link in code for #125155.
-
Victoria Ashworth authored
Rename variables, update comments, etc from `network` to `wireless` to keep it more uniform. Also, move non-overriden messages related to device selection into the file they're used. Part 7 in breakdown of https://github.com/flutter/flutter/pull/121262.
-
- 29 Mar, 2023 1 commit
-
-
Victoria Ashworth authored
Update device selection to wait for wireless devices to load
-
- 15 Mar, 2023 1 commit
-
-
Victoria Ashworth authored
Separate attached and wireless devices
-
- 15 Feb, 2023 1 commit
-
-
Ian Hickson authored
...and various other minor cleanup: * Moved "FLUTTER_STORAGE_BASE_URL" into a constant throughout the code. There are other strings that we should do that to but this one was relevant to the code I was changing. * Fixed the logger's handling of slow warnings. Previously it deleted too much text. Fixed the test for that to actually verify it entirely, too. * Made the logger delete the slow warning when it's finished. * Fixed 'Please choose one (To quit, press "q/Q")' message to be the cleaner 'Please choose one (or "q" to quit)'. * Added a debug toString to ValidationResult for debugging purposes (not used). * In http_host_validator: - Shortened constant names to be clearer (e.g. kPubDevHttpHost -> kPubDev). - Added GitHub as a tested host since when you run `flutter` we hit that immediately. - Renamed the check "Network resources". - Updated the `slowWarning` of the check to say which hosts are pending. - Removed all timeout logic. Timeouts violate our style guide. - Removed `int.parse(... ?? '10')`; passing a constant to `int.parse` is inefficient. - Replaced the `_HostValidationResult` class with `String?` for simplicity. - Improved the error messages to be more detailed. - Removed all checks that dependened on the stringification of exceptions. That's very brittle. - Added a warning specifically for HandshakeException that talks about the implications (MITM attacks). - Replaced exception-message-parsing logic with just calling `Uri.tryParse` and validating the result. - Replaced a lot of list-filtering logic with just a single for loop to check the results. - Replaced code that added a constant to a known-empty list with just returning a constant list. - Revamped the logic for deciding which hosts to check to just use a single chain of if/else blocks instead of getters, lists literals with `if` expressions, `??`, functions, etc spread over multiple places in the code.
-
- 04 Jan, 2023 1 commit
-
-
Peixin Li authored
* Add macOS to xcodeMissing and xcodeIncomplete * And unit test
-
- 02 Dec, 2022 1 commit
-
-
Jackson Gardner authored
You can now specify a --local-web-sdk flag to point to a wasm_release folder. This will make it so that only artifacts that pertain to the web sdk are overridden to point to the wasm_release folder. Other artifacts (such as impellerc) will pull from the cache, or from the --local-engine path if that is specified. This also uses precompiled platform kernel files for both ddc and dart2js
-
- 01 Dec, 2022 1 commit
-
-
Jenn Magder authored
* Suggest Rosetta when x64 binary cannot be run * validator * Adjust error message
-
- 13 Nov, 2022 1 commit
-
-
Jonah Williams authored
Revert "[web] Add `--local-web-sdk` flag and use precompiled platform kernels for dart2js and ddc (#114639)" (#115242) This reverts commit 0e9ee367.
-
- 12 Nov, 2022 1 commit
-
-
Jackson Gardner authored
* Dart2JS build step looks for compiled platform binaries. * Use new locations of platform binaries. * Added --local-web-sdk command line flag. * Need to use the matching frontend server when doing ddc stuff. * Update packages/flutter_tools/lib/src/test/web_test_compiler.dart Co-authored-by:
Mouad Debbar <mouad.debbar@gmail.com> * Update packages/flutter_tools/lib/src/runner/flutter_command_runner.dart Co-authored-by:
Mouad Debbar <mouad.debbar@gmail.com> * Formatting issues. * Need to use URI format for platform dill. * Fix resident runner tests. * Fix analysis issue. * Fix and add unit tests. * Add some useful comments. * Refine doc comments for flags. Co-authored-by:
Mouad Debbar <mouad.debbar@gmail.com>
-
- 02 Sep, 2022 1 commit
-
-
Pierre-Louis authored
-
- 26 Jul, 2022 1 commit
-
-
Anurag Roy authored
-
- 20 Jun, 2022 1 commit
-
-
Anurag Roy authored
-
- 02 Mar, 2022 1 commit
-
-
Jenn Magder authored
-
- 02 Feb, 2022 1 commit
-
-
Jenn Magder authored
-
- 10 Jan, 2022 1 commit
-
-
Zachary Anderson authored
-
- 06 Jan, 2022 1 commit
-
-
crisboarna authored
-
- 11 Nov, 2021 1 commit
-
-
Kenzie (Schmoll) Davisson authored
* Add DevTools version to `flutter --version` output. * review comments * fix test * add explanatory comment * dummy commit to kick bots Co-authored-by:
Christopher Fujino <christopherfujino@gmail.com>
-
- 25 Sep, 2021 1 commit
-
-
Christopher Fujino authored
-
- 14 Aug, 2021 1 commit
-
-
Jenn Magder authored
-
- 26 May, 2021 1 commit
-
-
Taha Tesser authored
[flutter_tools] Add documentation to "cmdline-tools component is missing" doctor validation error (#83356)
-
- 14 May, 2021 1 commit
-
-
Taha Tesser authored
-
- 13 Apr, 2021 1 commit
-
-
Anurag Roy authored
-
- 31 Mar, 2021 1 commit
-
-
Jenn Magder authored
-
- 23 Mar, 2021 1 commit
-
-
Jenn Magder authored
-
- 18 Mar, 2021 1 commit
-
-
Marcus Tomlinson authored
* Revert "Add libgcrypt as an explicit dependancy on Linux" This reverts commit bf65b3d03ccdc1dd21c09f34d600d72b0636a784. * libblkid & liblzma not explicitly required either
-
- 12 Mar, 2021 1 commit
-
-
Marcus Tomlinson authored
-
- 27 Jan, 2021 1 commit
-
-
Jonah Williams authored
* opt out the flutter tool * oops EOF * fix import * Update tool_backend.dart * Update daemon_client.dart * fix more
-
- 13 Jan, 2021 1 commit
-
-
Jenn Magder authored
-
- 17 Dec, 2020 1 commit
-
-
Jenn Magder authored
-