1. 26 Jan, 2024 1 commit
  2. 21 Nov, 2023 1 commit
  3. 31 Aug, 2023 1 commit
  4. 22 Aug, 2023 1 commit
  5. 18 Aug, 2023 1 commit
  6. 17 Aug, 2023 1 commit
  7. 10 Aug, 2023 1 commit
  8. 07 Jul, 2023 1 commit
  9. 23 May, 2023 1 commit
    • Ian Hickson's avatar
      Give channel descriptions in `flutter channel`, use branch instead of upstream... · 9c7a9e77
      Ian Hickson authored
      Give channel descriptions in `flutter channel`, use branch instead of upstream for channel name (#126936)
      
      ## How we determine the channel name
      
      Historically, we used the current branch's upstream to figure out the current channel name. I have no idea why. I traced it back to https://github.com/flutter/flutter/pull/446/files where @abarth implement this and I reviewed that PR and left no comment on it at the time.
      
      I think this is confusing. You can be on a branch and it tells you that your channel is different. That seems weird.
      
      This PR changes the logic to uses the current branch as the channel name.
      
      ## How we display channels
      
      The main reason this PR exists is to add channel descriptions to the `flutter channel` list:
      
      ```
      ianh@burmese:~/dev/flutter/packages/flutter_tools$ flutter channel
      Flutter channels:
        master (tip of tree, for contributors)
        main (tip of tree, follows master channel)
        beta (updated monthly, recommended for experienced users)
        stable (updated quarterly, for new users and for production app releases)
      * foo_bar
      
      Currently not on an official channel.
      ianh@burmese:~/dev/flutter/packages/flutter_tools$
      ```
      
      ## Other changes
      
      I made a few other changes while I was at it:
      
      * If you're not on an official channel, we used to imply `--show-all`, but now we don't, we just show the official channels plus yours. This avoids flooding the screen in the case the user is on a weird channel and just wants to know what channel they're on.
      * I made the tool more consistent about how it handles unofficial branches. Now it's always `[user branch]`.
      * I slightly adjusted how unknown versions are rendered so it's clearer the version is unknown rather than just having the word "Unknown" floating in the output without context.
      * Simplified some of the code.
      * Made some of the tests more strict (checking all output rather than just some aspects of it).
      * Changed the MockFlutterVersion to implement the FlutterVersion API more strictly.
      * I made sure we escape the output to `.metadata` to avoid potential injection bugs (previously we just inlined the version and channel name verbatim with no escaping, which is super sketchy).
      * Tweaked the help text for the `downgrade` command to be clearer.
      * Removed some misleading text in some error messages.
      * Made the `.metadata` generator consistent with the template file.
      * Removed some obsolete code to do with the `dev` branch.
      
      ## Reviewer notes
      
      I'm worried that there are implications to some of these changes that I am not aware of, so please don't assume I know what I'm doing when reviewing this code. :-)
      9c7a9e77
  10. 02 May, 2023 1 commit
  11. 19 Apr, 2023 2 commits
  12. 29 Mar, 2023 1 commit
  13. 15 Mar, 2023 1 commit
  14. 15 Feb, 2023 1 commit
    • Ian Hickson's avatar
      Improve network resources doctor check (#120417) · d29668dd
      Ian Hickson authored
      ...and various other minor cleanup:
      
      * Moved "FLUTTER_STORAGE_BASE_URL" into a constant throughout the code. There are other strings that we should do that to but this one was relevant to the code I was changing.
      
      * Fixed the logger's handling of slow warnings. Previously it deleted too much text. Fixed the test for that to actually verify it entirely, too.
      
      * Made the logger delete the slow warning when it's finished.
      
      * Fixed 'Please choose one (To quit, press "q/Q")' message to be the cleaner 'Please choose one (or "q" to quit)'.
      
      * Added a debug toString to ValidationResult for debugging purposes (not used).
      
      * In http_host_validator:
      
        - Shortened constant names to be clearer (e.g. kPubDevHttpHost -> kPubDev).
        - Added GitHub as a tested host since when you run `flutter` we hit that immediately.
        - Renamed the check "Network resources".
        - Updated the `slowWarning` of the check to say which hosts are pending.
        - Removed all timeout logic. Timeouts violate our style guide.
        - Removed `int.parse(... ?? '10')`; passing a constant to `int.parse` is inefficient.
        - Replaced the `_HostValidationResult` class with `String?` for simplicity.
        - Improved the error messages to be more detailed.
        - Removed all checks that dependened on the stringification of exceptions. That's very brittle.
        - Added a warning specifically for HandshakeException that talks about the implications (MITM attacks).
        - Replaced exception-message-parsing logic with just calling `Uri.tryParse` and validating the result.
        - Replaced a lot of list-filtering logic with just a single for loop to check the results.
        - Replaced code that added a constant to a known-empty list with just returning a constant list.
        - Revamped the logic for deciding which hosts to check to just use a single chain of if/else blocks instead of getters, lists literals with `if` expressions, `??`, functions, etc spread over multiple places in the code.
      d29668dd
  15. 04 Jan, 2023 1 commit
  16. 02 Dec, 2022 1 commit
    • Jackson Gardner's avatar
      Platform binaries reland (#115502) · db1c3e20
      Jackson Gardner authored
      You can now specify a --local-web-sdk flag to point to a wasm_release folder. This will make it so that only artifacts that pertain to the web sdk are overridden to point to the wasm_release folder. Other artifacts (such as impellerc) will pull from the cache, or from the --local-engine path if that is specified.
      
      This also uses precompiled platform kernel files for both ddc and dart2js
      db1c3e20
  17. 01 Dec, 2022 1 commit
  18. 13 Nov, 2022 1 commit
  19. 12 Nov, 2022 1 commit
  20. 02 Sep, 2022 1 commit
  21. 26 Jul, 2022 1 commit
  22. 20 Jun, 2022 1 commit
  23. 02 Mar, 2022 1 commit
  24. 02 Feb, 2022 1 commit
  25. 10 Jan, 2022 1 commit
  26. 06 Jan, 2022 1 commit
  27. 11 Nov, 2021 1 commit
  28. 25 Sep, 2021 1 commit
  29. 14 Aug, 2021 1 commit
  30. 26 May, 2021 1 commit
  31. 14 May, 2021 1 commit
  32. 13 Apr, 2021 1 commit
  33. 31 Mar, 2021 1 commit
  34. 23 Mar, 2021 1 commit
  35. 18 Mar, 2021 1 commit
  36. 12 Mar, 2021 1 commit
  37. 27 Jan, 2021 1 commit
  38. 13 Jan, 2021 1 commit
  39. 17 Dec, 2020 1 commit