- 10 Jul, 2018 1 commit
-
-
Ian Hickson authored
They should fail, because we don't have real support yet. Also, make the debug override work in release builds, so that people on those platforms have a workaround.
-
- 09 Jul, 2018 2 commits
-
-
Hans Muller authored
-
Jonah Williams authored
-
- 04 Jul, 2018 2 commits
-
-
xster authored
-
Mikkel Nygaard Ravn authored
-
- 03 Jul, 2018 3 commits
-
-
Jonah Williams authored
This reverts commit 989f5741.
-
Jonah Williams authored
-
Greg Price authored
This logic is described in the test as looking for a scroll ending very close to a new page, but in fact its behavior is more like "very close to a page to the right": if we're not very, very close to any page, it will pick the page to the left, not an old page. There's no reason this should be left-right asymmetrical. Instead, pick the nearest page. In practice, the case where this makes a difference never arises when the scroll runs undisturbed to completion; but when the user taps on the page to hold or drag, the scroll will be interrupted before it gets within tolerance of a particular page, and this case does arise. This fixes a glitch that is hard to trigger without time dilation, but is quite conspicuous with it: * Open a tab view with at least 4 tabs, e.g. the Buttons screen of the gallery (with "Animate Slowly" on.) * Starting at tab 0, tap tab 2. * When the animation is nearly complete, tap the page a couple of times, as if to drag it around to scroll. Then let the page view settle ballistically toward page 2. * Before it finishes, tap tab 3. * Suddenly page 1 fills the view, replacing page 2, before we scroll from there to page 3. With this fix, the animation in the last step moves smoothly from where we are when it starts onward to page 3.
-
- 02 Jul, 2018 2 commits
-
-
Michael Goderbauer authored
Also: * Export TextInputAction from `text_field.dart` to parallel `TextInputType`.
-
matthew-carroll authored
* Support all keyboard actions. (#11344)
-
- 27 Jun, 2018 1 commit
-
-
Jonah Williams authored
-
- 22 Jun, 2018 2 commits
-
-
Jonah Williams authored
-
Jonah Williams authored
-
- 21 Jun, 2018 1 commit
-
-
amirh authored
Move the notch computation from the FAB to the BAB. The notch in the BAB (bottom action bar) for the FAB (floating action button) was previously kept as part of the FAB's implementation. This was done to keep the shape of the FAB and the shape of the notch coupled. That approach resulted in a somewhat complex and 'non Fluttery' mechanism for propagating the notch computation from the FAB to the BAB. This CL uncouples the FAB and the notch computation. With the new API the BAB computes its overall shape including the notch using a NotchedShape delegate. This includes multiple breaking changes: * Scaffold.setFloatingActionButtonNotchFor is deleted. * The ComputeNotch type is deleted. * The hasNotch property of BottomAppBar is deleted. * The notchMargin property of FloatingActionButton is deleted. Quick migration guide from the previous API: | Previous API | New API | | ------------------|-------------| | BottomAppBar(hasNotch: false) | BottomAppBar() | | Using a FloatingActionButton with: BottomAppBar() / BottomAppBar(hasNotch: true) | BottomAppBar(shape: CircularNotchedRectangle()) | | Scaffold.setFloatingActionButtonNotchFor(..) | No longer supported |
-
- 20 Jun, 2018 2 commits
-
-
Jonah Williams authored
-
Jonah Williams authored
-
- 16 Jun, 2018 1 commit
-
-
Jonah Williams authored
-
- 15 Jun, 2018 2 commits
-
-
Hans Muller authored
-
Jonah Williams authored
-
- 13 Jun, 2018 1 commit
-
-
Chris Bracken authored
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly from source, flutter_platform.dart automatically runs a kernel compile when operating in Dart 2 mode, but this assumes a functional Dart SDK is available in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts directory with an empty temp dir. Remaining work is: 1. Get the frontend server building as a dependency on Fuchsia. 2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server. This also reverts migration to Dart 2 typedef syntax. This reverts commit 6c56bb24. (#18362) This reverts commit 3daebd05. (#18316)
-
- 12 Jun, 2018 1 commit
-
-
Hans Muller authored
-
- 11 Jun, 2018 1 commit
-
-
Greg Spencer authored
Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax. Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml. No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
-
- 08 Jun, 2018 1 commit
-
-
Jonah Williams authored
-
- 07 Jun, 2018 2 commits
-
-
Jonah Williams authored
-
Jonah Williams authored
-
- 06 Jun, 2018 2 commits
-
-
Michael Goderbauer authored
Fixes #18145.
-
amirh authored
A bug in _RenderCustomClip was compaeing the type of oldClipper to itself instead to the type of newClipper. This was the root cause for the crash #14937 worked around. This also reverts the workaround introduced in #14937.
-
- 05 Jun, 2018 2 commits
-
-
Hans Muller authored
-
Alexandre Ardhuin authored
-
- 04 Jun, 2018 1 commit
-
-
Tran Huy Phuc authored
* TextFormField/TextField - remove spaces in character counter(follow material design guidelines)
-
- 01 Jun, 2018 2 commits
-
-
Michael Goderbauer authored
-
Michael Goderbauer authored
-
- 31 May, 2018 1 commit
-
-
Ian Hickson authored
-
- 30 May, 2018 5 commits
-
-
Jonah Williams authored
-
Greg Spencer authored
Revert "Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)" (#18041) This reverts commit 32586020.
-
Greg Spencer authored
Fixes #18028 Just changes typedef declarations, no logic changes.
-
Mikkel Nygaard Ravn authored
-
Michael Goderbauer authored
-
- 26 May, 2018 1 commit
-
-
Jonah Williams authored
-
- 25 May, 2018 1 commit
-
-
Todd Volkert authored
It should be calling `tile.getDistanceToActualBaseline()` rather than `tile.getDistanceToBaseline()`. This is causing us to hit assertions `getDistanceToBaseline()`
-