1. 18 Oct, 2023 1 commit
    • Arash's avatar
      [Feat] Stroke color for Slider value indicator (#135986) · a9567313
      Arash authored
      Consider a scenario where the background color and indicator's background color are the same. 
      
      Adding a stroke color to the value indicator would be a valuable for the following reasons:
      - **Visual Clarity:** It would allow developers to make the value indicator stand out more against the background, making it easier for users to notice.
      - **Customization:** It would provide more flexibility in customizing the appearance of the sliding widget, allowing developers to match the design requirements of their apps.
      - **Accessibility:** Improved visual distinction can enhance the accessibility of the sliding widget for users with various needs.
      
      *List which issues are fixed by this PR. You must list at least one issue.*
      
      Fixes #135984
      a9567313
  2. 20 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must be non-null' and 'must not be null' comments from material. (#134991) · a1e49be2
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the material library.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134984
      - https://github.com/flutter/flutter/pull/134992
      - https://github.com/flutter/flutter/pull/134993
      - https://github.com/flutter/flutter/pull/134994
      
      ## Tests
       - Documentation only change.
      a1e49be2
  3. 16 May, 2023 1 commit
  4. 01 May, 2023 1 commit
  5. 28 Apr, 2023 1 commit
  6. 22 Mar, 2023 1 commit
  7. 16 Feb, 2023 1 commit
  8. 24 Jan, 2023 1 commit
  9. 17 Nov, 2022 1 commit
  10. 02 Sep, 2022 1 commit
  11. 28 Aug, 2022 1 commit
  12. 06 Jun, 2022 1 commit
  13. 25 May, 2022 1 commit
  14. 18 May, 2022 1 commit
  15. 17 May, 2022 1 commit
  16. 27 Apr, 2022 1 commit
  17. 14 Apr, 2022 1 commit
  18. 01 Mar, 2022 1 commit
  19. 22 Feb, 2022 1 commit
  20. 17 Feb, 2022 1 commit
  21. 14 Jan, 2022 1 commit
  22. 17 Nov, 2021 1 commit
  23. 02 Jul, 2021 1 commit
  24. 12 Jun, 2021 1 commit
  25. 21 May, 2021 1 commit
  26. 31 Mar, 2021 1 commit
  27. 12 Mar, 2021 2 commits
  28. 11 Feb, 2021 1 commit
  29. 29 Jan, 2021 1 commit
  30. 28 Jan, 2021 1 commit
  31. 15 Dec, 2020 1 commit
  32. 11 Dec, 2020 1 commit
  33. 18 Nov, 2020 1 commit
  34. 02 Nov, 2020 2 commits
  35. 27 Oct, 2020 1 commit
  36. 15 Oct, 2020 1 commit
  37. 10 Oct, 2020 1 commit
  38. 06 Oct, 2020 1 commit