1. 14 Jan, 2024 1 commit
  2. 10 Jan, 2024 1 commit
    • Igor Hnízdo's avatar
      `NestedScrollView`'s outer scrollable jumping with `BouncingScrollPhysics` due... · 7efed85b
      Igor Hnízdo authored
      `NestedScrollView`'s outer scrollable jumping with `BouncingScrollPhysics` due to `double` precision errors (#138319)
      
      This PR fixes scrolling issues with `NestedScrollView` using the `BouncingScrollPhysics`. In one of the steps of the calculation, we can reach a state where the position of the inner scrollable is set to a `double` value that falls within `precisionErrorTolerance` of `0` but we were using `==` with `0` rather than checking for a precision. My posts in the linked issue show the current behavior, and how I reached to conclusion (the code in this PR). This PR only addresses the "jumping" of the outer scrollable.  
      
      Fixes #136199
      
      I have not finished a test for this since I have never done so and therefore have 0 experience writing tests in Flutter, so any help there would be appreciated. I am also not sure how to test double precision errors in general. I did run all the nested_scroll_view_tests.dart locally and there are no failures.
      7efed85b
  3. 22 Oct, 2023 1 commit
    • Todd Volkert's avatar
      Add timeline events for post frame callbacks (#136435) · cb9a3f69
      Todd Volkert authored
      Before this change, long-running post-frame callbacks wouldn't show up in the timeline at all.  This adds a timeline event for post-frame callbacks, with a debug flag that will add timeline events for each individual callback.
      
      #testexempt -- we have no way to test calls to the timeline.
      cb9a3f69
  4. 22 Sep, 2023 1 commit
  5. 20 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must be non-null' and 'must not be null' comments in widgets library (#134992) · 6e5134b0
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the widgets library.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134984
      - https://github.com/flutter/flutter/pull/134991
      - https://github.com/flutter/flutter/pull/134993
      - https://github.com/flutter/flutter/pull/134994
      
      ## Tests
       - Documentation only change.
      6e5134b0
  6. 05 Jun, 2023 1 commit
  7. 01 Jun, 2023 1 commit
  8. 12 Apr, 2023 1 commit
  9. 31 Mar, 2023 1 commit
  10. 22 Mar, 2023 1 commit
  11. 24 Jan, 2023 1 commit
  12. 03 Jan, 2023 1 commit
  13. 27 Dec, 2022 1 commit
  14. 22 Dec, 2022 1 commit
  15. 13 Dec, 2022 1 commit
  16. 31 Oct, 2022 1 commit
  17. 08 Sep, 2022 1 commit
  18. 19 Aug, 2022 1 commit
  19. 17 Aug, 2022 1 commit
  20. 28 Jul, 2022 1 commit
  21. 09 Jun, 2022 1 commit
  22. 26 May, 2022 1 commit
  23. 18 May, 2022 1 commit
  24. 14 Apr, 2022 1 commit
  25. 03 Feb, 2022 1 commit
  26. 21 Jan, 2022 1 commit
  27. 13 Jan, 2022 1 commit
  28. 13 Dec, 2021 1 commit
  29. 12 Dec, 2021 1 commit
  30. 08 Oct, 2021 3 commits
  31. 04 Oct, 2021 1 commit
    • Greg Spencer's avatar
      Clean up examples, remove section markers and --template args (#91133) · fd9ce277
      Greg Spencer authored
      This does a cleanup of the examples, removing all of the "section" markers and extra comments that we don't need anymore now that the samples are no longer in the source code. It also removes the --template arguments from the {@tool dartpad} and {@tool sample} directives, since those are no longer used. It converts two examples that I discovered were still embedded into linked examples in the examples folder.
      
      I didn't delete the templates from the snippets config folder yet, because there are still embedded samples in the dart:ui package from the engine that use them. Once dart:ui no longer uses the templates, they can be removed.
      
      I bumped the version of the snippets package to pick up a change that allows removal of the --template argument.
      fd9ce277
  32. 25 Aug, 2021 1 commit
    • Greg Spencer's avatar
      Extract Sample code into examples/api (#87280) · 33403bd2
      Greg Spencer authored
      This extracts the sample code out from the API doc comments, and places them in separate files on disk, allowing running of the examples locally, testing them, and building of slightly larger examples.
      33403bd2
  33. 15 Jul, 2021 1 commit
  34. 14 Jul, 2021 3 commits
  35. 13 Jul, 2021 2 commits