Commits · 41abe998ee37fb70fb3c86c5c2bbc3dcf2f1302c · abdullh.alsoleman / Front-End

15 May, 2023 14 commits

[devicelab] add drawPoints benchmark (#126728) · 41abe998
Jonah Williams authored May 15, 2023
```
Add a benchmark that measures the improvements from https://github.com/flutter/engine/pull/41803
```
41abe998
Remove obsolete iOS benchmark (#126862) · 674b1ad0
Zachary Anderson authored May 15, 2023
```
Fixes https://github.com/flutter/flutter/issues/126861
```
674b1ad0

Roll Packages from 6328cfbd2a46 to 6608b604b0e7 (22 revisions) (#126865) · 96580f50

engine-flutter-autoroll authored May 15, 2023

https://github.com/flutter/packages/compare/6328cfbd2a46...6608b604b0e7

2023-05-15 stuartmorgan@google.com [ci] Remove unnecessary Linux libraries (flutter/packages#3975)
2023-05-15 stuartmorgan@google.com [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979)
2023-05-15 stuartmorgan@google.com [ci] Disable Windows repo tool tests (flutter/packages#3980)
2023-05-12 stuartmorgan@google.com [ci] Add LUCI repo tool tests (flutter/packages#3964)
2023-05-12 reidbaker@google.com [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973)
2023-05-12 reidbaker@google.com Update build.gradle with a comment explaining version (flutter/packages#3972)
2023-05-12 engine-flutter-autoroll@skia.org Roll Flutter from 8c5a1ea7 to a76dbe44 (12 revisions) (flutter/packages#3958)
2023-05-12 stuartmorgan@google.com [image_picker] Fix Android lints (flutter/packages#3887)
2023-05-12 stuartmorgan@google.com [various] Update minimum Flutter version to 3.3 (flutter/packages#3967)
2023-05-12 stuartmorgan@google.com [tool] Target specific Android unit tests (flutter/packages#3955)
2023-05-12 34871572+gmackall@users.noreply.github.com [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960)
2023-05-12 stuartmorgan@google.com [local_auth] Improve iOS test DI (flutter/packages#3959)
2023-05-12 stuartmorgan@google.com [ci] Ensure scripts fail if a command fails (flutter/packages#3963)
2023-05-11 stuartmorgan@google.com [ci] Pin the Flutter version for `release` (flutter/packages#3965)
2023-05-11 tarrinneal@gmail.com [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784)
2023-05-11 stuartmorgan@google.com [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969)
2023-05-11 stuartmorgan@google.com [tool] Ensure that publish credential path is available (flutter/packages#3970)
2023-05-11 63286031+ahmednfwela@users.noreply.github.com [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877)
2023-05-11 stuartmorgan@google.com [tool] Use new pub cache location for publish (flutter/packages#3962)
2023-05-10 engine-flutter-autoroll@skia.org Roll Flutter (stable) from f72efea43c30 to 84a1e904f44f (1920 revisions) (flutter/packages#3961)
2023-05-10 andrelvsousa@gmail.com [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423)
2023-05-10 43054281+camsim99@users.noreply.github.com [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

96580f50

Roll Flutter Engine from f074fd3b2d7f to dffc480a2bbf (2 revisions) (#126863) · 0526e940

engine-flutter-autoroll authored May 15, 2023

https://github.com/flutter/engine/compare/f074fd3b2d7f...dffc480a2bbf

2023-05-15 30870216+gaaclarke@users.noreply.github.com [Impeller] switches the wide gamut surface to f16 (flutter/engine#41994)
2023-05-15 kjlubick@users.noreply.github.com Migrate uses of SkSurface factories (flutter/engine#41978)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0526e940

Mark no longer flakey tests as bringup:false (#126281) · 159ebf73

Reid Baker authored May 15, 2023

This is a result of auditing the ci.yaml tests marked as bringup true and determining which ones were still flakey. 
Each commit markes one tests as non flakey along with a link of proof of the lack of flakes. 

- Mark new_gallery_impeller__transition_perf as not flakey, #124699 closed, not recent flakes
- No failures in 500 runs for Staging_build_linux analyze https://ci.chromium.org/p/flutter/builders/staging/Staging_build_linux%20analyze\?cursor\=id%3E8782771663962116337\&limit\=200
- No flakes in 600 builds https://ci.chromium.org/p/flutter/builders/staging/Linux%20flutter_packaging_test\?cursor\=id%3E8787892377160059793\&limit\=200
- No flakes in 600 builds https://ci.chromium.org/p/flutter/builders/staging/Mac%20flutter_packaging_test\?cursor\=id%3E8787870631931126673\&limit\=200
- No flakes in 600 builds https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64%20flutter_packaging_test\?cursor\=id%3E8787809799161254193\&limit\=200

#124699 is the only closed bug that was linked for a test that is no longer flakey. Closed status helps the case that flakes are no longer an issue.

159ebf73

Revert "i125138 abstract method smoke agp update (#125139)" (#126274) · c5b31e7f

Reid Baker authored May 15, 2023

This reverts commit 64591356.

#125331 
https://ci.chromium.org/p/flutter/builders/staging/Linux%20firebase_abstract_method_smoke_test?cursor=id%3E8783275059678311409&limit=200

- [ x I signed the [CLA].

c5b31e7f

Remove duplicate plugin tests (#126582) · d3c3dde1

stuartmorgan authored May 15, 2023

Removes two plugin tests that aren't actually doing anything useful.

When they were added they were testing v2-embedding plugins in a v1-embedding app, but support for creating v1-embedding apps--and the environment variable that these tests were using to, in theory, trigger them--was removed several years ago in #61203. That means that these tests are in practice exact duplicates of the copies just above without the ennvironment variables.

Fixes https://github.com/flutter/flutter/issues/122200

d3c3dde1

Add debugging for Dart VM timeout flake (#126437) · 5d113256

Victoria Ashworth authored May 15, 2023

Check what is available in the device's iOS DeviceSupport folder to check if symbols were properly fetched. Also, add some logging to track what status the debugger is in.

Debugging for https://github.com/flutter/flutter/issues/121231.

5d113256

Roll Flutter Engine from 7bd748207171 to f074fd3b2d7f (2 revisions) (#126852) · 0636f5e0

engine-flutter-autoroll authored May 15, 2023

https://github.com/flutter/engine/compare/7bd748207171...f074fd3b2d7f

2023-05-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from A3thcPNgxVcKzR-da... to JCoP2Fekj3MBIqskE... (flutter/engine#42041)
2023-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from c777d54743e1 to c302a0252785 (1 revision) (flutter/engine#42040)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from A3thcPNgxVcK to JCoP2Fekj3MB

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0636f5e0

Adds support for f16 surfaces to wide gamut unit tests. (#126712) · 658a1a25

gaaclarke authored May 15, 2023

issue: https://github.com/flutter/flutter/issues/126620

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

658a1a25

rename AssetManifest.bin (#126077) · d3e0e03e

Andrew Kolos authored May 15, 2023

Fixes #124883. Will require a g3fix.

Renames `AssetManifest.bin` to `AssetManifest.smcbin` (madeup extension for "Standard Message Codec binary").

d3e0e03e

Roll Flutter Engine from d6855205df29 to 7bd748207171 (8 revisions) (#126819) · fae99c5a

engine-flutter-autoroll authored May 15, 2023

https://github.com/flutter/engine/compare/d6855205df29...7bd748207171

2023-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 7d6324d5488b to c777d54743e1 (1 revision) (flutter/engine#42038)
2023-05-15 bdero@google.com [Impeller] Fix DrawPaint advanced blends on iOS. (flutter/engine#42032)
2023-05-15 49699333+dependabot[bot]@users.noreply.github.com Bump google/mirror-branch-action from 1.0 to 2.0 (flutter/engine#42037)
2023-05-15 skia-flutter-autoroll@skia.org Roll Skia from 0c2083a60b66 to 4becb53e3c21 (2 revisions) (flutter/engine#42036)
2023-05-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jXrn0SP_MnSmhkz_P... to EweLgJoiYUDok2vyU... (flutter/engine#42035)
2023-05-15 skia-flutter-autoroll@skia.org Roll Skia from 0410e5d9ec03 to 0c2083a60b66 (1 revision) (flutter/engine#42034)
2023-05-15 chillers@google.com [Impeller] Include AndroidSurfaceVulkanImpeller behind a flag (flutter/engine#42033)
2023-05-15 chillers@google.com Reland "Remove GN staging flag for save layer bounds" (flutter/engine#42029)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from jXrn0SP_MnSm to EweLgJoiYUDo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fae99c5a

Add spaces after flow control statements (#126320) · 99c7e9f0
Tomasz Gucio authored May 15, 2023

99c7e9f0

Roll Flutter Engine from 326de1d849dd to d6855205df29 (1 revision) (#126794) · 231e00d2

engine-flutter-autoroll authored May 15, 2023

https://github.com/flutter/engine/compare/326de1d849dd...d6855205df29

2023-05-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qnNU5eQaox06ejpSE... to A3thcPNgxVcKzR-da... (flutter/engine#42030)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from qnNU5eQaox06 to A3thcPNgxVcK

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

231e00d2

14 May, 2023 4 commits

Roll Flutter Engine from a1ccf90904b8 to 326de1d849dd (2 revisions) (#126783) · 7b8f7a2a

engine-flutter-autoroll authored May 14, 2023

https://github.com/flutter/engine/compare/a1ccf90904b8...326de1d849dd

2023-05-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 005648f027a3 to 7d6324d5488b (1 revision) (flutter/engine#42027)
2023-05-14 chillers@google.com Revert "Remove GN staging flag for save layer bounds" (flutter/engine#42026)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7b8f7a2a

Roll Flutter Engine from 2560e1af6fbd to a1ccf90904b8 (3 revisions) (#126777) · ab28585e

engine-flutter-autoroll authored May 14, 2023

https://github.com/flutter/engine/compare/2560e1af6fbd...a1ccf90904b8

2023-05-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hEJzgtSberqdXmLnk... to jXrn0SP_MnSmhkz_P... (flutter/engine#42025)
2023-05-14 skia-flutter-autoroll@skia.org Roll Skia from 35d8ac3ced75 to 0410e5d9ec03 (1 revision) (flutter/engine#42024)
2023-05-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from hXcPXU_V5nVeGkEbt... to qnNU5eQaox06ejpSE... (flutter/engine#42023)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from hEJzgtSberqd to jXrn0SP_MnSm
fuchsia/sdk/core/mac-amd64 from hXcPXU_V5nVe to qnNU5eQaox06

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ab28585e

Roll Flutter Engine from fb703b1965cd to 2560e1af6fbd (2 revisions) (#126769) · eafba8e7

engine-flutter-autoroll authored May 14, 2023

https://github.com/flutter/engine/compare/fb703b1965cd...2560e1af6fbd

2023-05-14 skia-flutter-autoroll@skia.org Roll Skia from 1c00432c2a85 to 35d8ac3ced75 (1 revision) (flutter/engine#42022)
2023-05-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from mAQy_vMru3cTWSoBl... to hEJzgtSberqdXmLnk... (flutter/engine#42021)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from mAQy_vMru3cT to hEJzgtSberqd

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

eafba8e7

Roll Flutter Engine from 96bd55349119 to fb703b1965cd (2 revisions) (#126758) · 27635b4c

engine-flutter-autoroll authored May 14, 2023

https://github.com/flutter/engine/compare/96bd55349119...fb703b1965cd

2023-05-14 flar@google.com add non-rendering operation culling to DisplayListBuilder (flutter/engine#41463)
2023-05-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from wxolyLvEWZ9IMOCU_... to hXcPXU_V5nVeGkEbt... (flutter/engine#42020)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from wxolyLvEWZ9I to hXcPXU_V5nVe

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

27635b4c

13 May, 2023 9 commits

Roll Flutter Engine from 802ff626f498 to 96bd55349119 (2 revisions) (#126747) · f6b23f1d

engine-flutter-autoroll authored May 13, 2023

https://github.com/flutter/engine/compare/802ff626f498...96bd55349119

2023-05-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 48d09a6216a8 to 005648f027a3 (1 revision) (flutter/engine#42017)
2023-05-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from bddx8p5907poNnZTq... to mAQy_vMru3cTWSoBl... (flutter/engine#42016)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from bddx8p5907po to mAQy_vMru3cT

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f6b23f1d

Roll Flutter Engine from d4f141f182d8 to 802ff626f498 (1 revision) (#126742) · d628f129

engine-flutter-autoroll authored May 13, 2023

https://github.com/flutter/engine/compare/d4f141f182d8...802ff626f498

2023-05-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from oc2gdx4PWYT-K7XQ9... to wxolyLvEWZ9IMOCU_... (flutter/engine#42015)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from oc2gdx4PWYT- to wxolyLvEWZ9I

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d628f129

Roll Flutter Engine from 1745d441405e to d4f141f182d8 (1 revision) (#126741) · c6fd6258

engine-flutter-autoroll authored May 13, 2023

https://github.com/flutter/engine/compare/1745d441405e...d4f141f182d8

2023-05-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 2a285d87f5d7 to 48d09a6216a8 (1 revision) (flutter/engine#42014)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c6fd6258

Roll Flutter Engine from 259daf6efd3e to 1745d441405e (1 revision) (#126737) · cba1dee3

engine-flutter-autoroll authored May 13, 2023

https://github.com/flutter/engine/compare/259daf6efd3e...1745d441405e

2023-05-13 skia-flutter-autoroll@skia.org Roll Skia from 872787e7595c to 1c00432c2a85 (1 revision) (flutter/engine#42013)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cba1dee3

Roll Flutter Engine from eb5748199016 to 259daf6efd3e (2 revisions) (#126735) · 99dd10af

engine-flutter-autoroll authored May 13, 2023

https://github.com/flutter/engine/compare/eb5748199016...259daf6efd3e

2023-05-13 leroux_bruno@yahoo.fr [macOS - TextInput] Insert new line only when TextInputAction.newline (flutter/engine#41977)
2023-05-13 skia-flutter-autoroll@skia.org Roll Skia from cfdfc039b848 to 872787e7595c (1 revision) (flutter/engine#42010)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

99dd10af

Roll Flutter Engine from 36ced12f75af to eb5748199016 (1 revision) (#126730) · 7559454d

engine-flutter-autoroll authored May 13, 2023

https://github.com/flutter/engine/compare/36ced12f75af...eb5748199016

2023-05-13 skia-flutter-autoroll@skia.org Roll Skia from 6a4e29cbd73b to cfdfc039b848 (2 revisions) (flutter/engine#42004)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7559454d

Fix crash from invalid ListWheelViewport assertion (#126539) · ae82f3cb
nt4f04uNd authored May 13, 2023
```
Fixes https://github.com/flutter/flutter/issues/126491
```
ae82f3cb

Roll Flutter Engine from 12e436d3aa7e to 36ced12f75af (1 revision) (#126726) · 3ef9bc5f

engine-flutter-autoroll authored May 13, 2023

https://github.com/flutter/engine/compare/12e436d3aa7e...36ced12f75af

2023-05-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from HMLNsG7w9sTDpW2Ge... to bddx8p5907poNnZTq... (flutter/engine#42003)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from HMLNsG7w9sTD to bddx8p5907po

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3ef9bc5f

Roll Flutter Engine from 502e1eb591d9 to 12e436d3aa7e (8 revisions) (#126725) · a1ddaa95

engine-flutter-autoroll authored May 13, 2023

https://github.com/flutter/engine/compare/502e1eb591d9...12e436d3aa7e

2023-05-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from rO5qs4MpN6WfJcu64... to oc2gdx4PWYT-K7XQ9... (flutter/engine#42000)
2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 64bdd87fadfe to 6a4e29cbd73b (2 revisions) (flutter/engine#41999)
2023-05-12 jason-simmons@users.noreply.github.com [Impeller] Remove a debug log from the Vulkan render pass (flutter/engine#41987)
2023-05-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 858f83d6d993 to 2a285d87f5d7 (2 revisions) (flutter/engine#41997)
2023-05-12 bdero@google.com [Impeller] Ignore the Z basis when scaling text (flutter/engine#41995)
2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 539fb10d7cfb to 64bdd87fadfe (18 revisions) (flutter/engine#41993)
2023-05-12 mdebbar@google.com [web] Cleaner output on LUCI (flutter/engine#41989)
2023-05-12 leroux_bruno@yahoo.fr [Web+Linux] Fix pressing Meta keys throws (flutter/engine#41694)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from rO5qs4MpN6Wf to oc2gdx4PWYT-

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a1ddaa95

12 May, 2023 13 commits

Roll Flutter Engine from c784d6d4137d to 502e1eb591d9 (14 revisions) (#126714) · d5bb1a83

engine-flutter-autoroll authored May 12, 2023

https://github.com/flutter/engine/compare/c784d6d4137d...502e1eb591d9

2023-05-12 30870216+gaaclarke@users.noreply.github.com [Impeller] starts
running vulkan golden image tests with swiftshader
(flutter/engine#41958)
2023-05-12 mdebbar@google.com [web] Fix crash on old versions of Chrome
(Intl.Segmenter missing) (flutter/engine#41986)
2023-05-12 godofredoc@google.com Move clang tidy v2 build to prod.
(flutter/engine#41985)
2023-05-12 godofredoc@google.com Reland "Move linux_license to engine
v2."" (flutter/engine#41983)
2023-05-12 skia-flutter-autoroll@skia.org Roll Dart SDK from
6cd6e54f280d to 858f83d6d993 (2 revisions) (flutter/engine#41980)
2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 0b929ada9cc6 to
539fb10d7cfb (2 revisions) (flutter/engine#41979)
2023-05-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
MjcKzcsqMDkuRKopu... to rO5qs4MpN6WfJcu64... (flutter/engine#41975)
2023-05-12 skia-flutter-autoroll@skia.org Roll Dart SDK from
4028c7d8b87c to 6cd6e54f280d (1 revision) (flutter/engine#41974)
2023-05-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
lf8VcONMWlne4oa3H... to HMLNsG7w9sTDpW2Ge... (flutter/engine#41973)
2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from 208a07f71701 to
0b929ada9cc6 (2 revisions) (flutter/engine#41971)
2023-05-12 dnfield@google.com [Impeller] [Android] Refactor the Android
context/surface implementation to work more like Skia.
(flutter/engine#41059)
2023-05-12 skia-flutter-autoroll@skia.org Roll Skia from ccec5093ca38 to
208a07f71701 (1 revision) (flutter/engine#41970)
2023-05-12 jonahwilliams@google.com [Impeller] Dont synthesize fake
index buffer if none was provided to VBB (flutter/engine#41969)
2023-05-12 dnfield@google.com [Impeller] Make index buffer optional
(flutter/engine#41962)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from lf8VcONMWlne to HMLNsG7w9sTD
  fuchsia/sdk/core/mac-amd64 from MjcKzcsqMDku to rO5qs4MpN6Wf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d5bb1a83

Add namespace to Android plugin templates (#126354) · aa230140

stuartmorgan authored May 12, 2023

Adds the `namespace` property necessary for AGP 8 compatibility to the plugin templates, with the conditional logic to ensure that it doesn't break AGP <4.2, so that new plugins will be maximally compatible.

Part of https://github.com/flutter/flutter/issues/125181

aa230140

Roll Packages from 0167d834e937 to 6328cfbd2a46 (2 revisions) (#126442) · 9c72f5a7

engine-flutter-autoroll authored May 12, 2023

https://github.com/flutter/packages/compare/0167d834e937...6328cfbd2a46

2023-05-10 43640732+dancamdev@users.noreply.github.com
[go_router_builder] Adds name parameter to TypedGoRoute and supports its
generation. (flutter/packages#3665)
2023-05-10 stuartmorgan@google.com [various] Remove iOS 9 references
(flutter/packages#3948)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9c72f5a7

Fix focus behavior and provided thumb and focus color aren't applied to... · 96dae5e1

Taha Tesser authored May 12, 2023

Fix focus behavior and provided thumb and focus color aren't applied to Cupertino variant of `Switch.adaptive` (#126688)

fixes https://github.com/flutter/flutter/issues/126637
fixes https://github.com/flutter/flutter/issues/126669

##  ~~To be merged after https://github.com/flutter/flutter/pull/126684~~

### Description

1.  Fix the Cupertino variant of `Switch.adaptive` requires two tab key presses to focus.
2.  Fix `thumbColor` & `focusColor` aren't applied.

### Before
Requires two tab presses to focus. and `thumbColor` & `focusColor` aren't applied.

https://github.com/flutter/flutter/assets/48603081/24635551-0794-443f-8320-32fdaa5de57a

### After
Single tab key to focus (no additional focus node) and `thumbColor` & `focusColor` are applied.

https://github.com/flutter/flutter/assets/48603081/9bf42fd8-c7e0-475a-b933-192a94650b0c

96dae5e1

[Docs] Fix Typo (#126660) · 482d5671
杨加康 authored May 12, 2023

482d5671

Manual roll Flutter Engine from ef5c349f04d8 to c784d6d4137d (#126680) · 6e9c0db2

Jason Simmons authored May 12, 2023

https://github.com/flutter/engine/compare/ef5c349f04d8...c784d6d4137d

2023-05-12
[skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org)
Roll Dart SDK from 7ad028c26344 to 4028c7d8b87c (8 revisions)
(https://github.com/flutter/engine/pull/41967)

Requires some update for changes to the Dart analyzer

fixes https://github.com/flutter/flutter/issues/126683

6e9c0db2

Add `FocusNode`, `onFocusChange`, and `autofocus` to `CupertinoSwitch` (#126684) · b9e3aef2

Taha Tesser authored May 12, 2023

fixes https://github.com/flutter/flutter/issues/126679 

### Description
Control cupertino widgets like `CupertinoCheckbox` and `CupertinoRadio` have `focusNode` and `autofocus`, while these are missing in `CupertinoSwitch`.

This is blocking https://github.com/flutter/flutter/issues/126637 
(`switch.dart` currently maintains its focus node for `CupertinoSwitch` when using `Switch.adaptive` which causes a bug)

b9e3aef2

Hide the context menu on tap down (#126295) · 6ffcc9e5
Justin McCandless authored May 12, 2023
```
Desktop text selection toolbar no longer flashes before closing.
```
6ffcc9e5

Fix `showDatePicker` in input mode throws an `ArgumentError` (#126525) · 15a7e073

Taha Tesser authored May 12, 2023

fixes https://github.com/flutter/flutter/issues/126397

The `parseCompactDate` method in `material_localizations.dart` with long text throws an argument error before the date picker could handle it to show a validation error while the date picker is on autovalidate.

This PR adds `try/catch` in the `parseCompactDate` to return null on the argument error.

15a7e073

Increase test timeout for analyzer_benchmark to 60 minutes (#126586) · 468512e0
Zachary Anderson authored May 12, 2023
```
Fixes https://github.com/flutter/flutter/issues/126451
```
468512e0

Fix TextSpan gc regression (#126382) · 4eefced8

LongCatIsLooong authored May 12, 2023

`for (final InlineSpan child in children ?? const <InlineSpan>[])` bad

Fixes https://github.com/flutter/flutter/issues/126337

4eefced8

Roll Flutter Engine from 748ef964b993 to ef5c349f04d8 (1 revision) (#126624) · 5e459380

engine-flutter-autoroll authored May 12, 2023

https://github.com/flutter/engine/compare/748ef964b993...ef5c349f04d8

2023-05-11 leroux_bruno@yahoo.fr [Linux - TextInput] Do not add new line for send action (flutter/engine#41895)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5e459380

Roll Flutter Engine from f38f46f66e9a to 748ef964b993 (13 revisions) (#126622) · 43b2b658

engine-flutter-autoroll authored May 12, 2023

https://github.com/flutter/engine/compare/f38f46f66e9a...748ef964b993

2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from aed81125e6bc to ccec5093ca38 (10 revisions) (flutter/engine#41963)
2023-05-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 2tQjI0g3aDmjHAtMw... to MjcKzcsqMDkuRKopu... (flutter/engine#41960)
2023-05-11 smartercallum@gmail.com iPhone floating cursor selection (flutter/engine#36643)
2023-05-11 vashworth@google.com Update README.md (flutter/engine#41953)
2023-05-11 skia-flutter-autoroll@skia.org Roll Clang from 5344d8e10bb7 to 6d667d4b261e (flutter/engine#41949)
2023-05-11 kjlubick@users.noreply.github.com Use moved SkImage procs (flutter/engine#41947)
2023-05-11 msgh@selfisekai.rocks allow supplying custom gn args in gn wrapper (flutter/engine#41794)
2023-05-11 68549184+Mayb3Nots@users.noreply.github.com fix: platform_dispatcher documentation typo (flutter/engine#41739)
2023-05-11 lhkbob@gmail.com Remove GN staging flag for save layer bounds (flutter/engine#41940)
2023-05-11 flar@google.com switch MockTexture off of MockCanvas calls (flutter/engine#41906)
2023-05-11 gspencergoog@users.noreply.github.com [Android] Lifecycle defaults to focused instead of unfocused (flutter/engine#41875)
2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from ccf73af6ca91 to aed81125e6bc (9 revisions) (flutter/engine#41946)
2023-05-11 godofredoc@google.com Clobber caches in licenses test. (flutter/engine#41942)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 2tQjI0g3aDmj to MjcKzcsqMDku

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

43b2b658