- 17 Oct, 2023 1 commit
-
-
Kostia Sokolovskyi authored
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries. Each of them only had a few, so I lumped them together. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 15 May, 2023 1 commit
-
-
Tomasz Gucio authored
-
- 08 Nov, 2022 2 commits
-
-
Zachary Anderson authored
This reverts commit 53e68762.
-
Kate Lovett authored
* allow marking a golden check as flaky * add matchesFlutterGolden to analyze.dart; no tags for flutter_goldens/lib * Pause * ++ * ++ * Analyzer therapy * Once more with feeling * Nits * Review feedback * Silly oops * Test progress * More tests * Finish * Nits * Analyzer * Review feedback Co-authored-by: Yegor Jbanov <yjbanov@google.com>
-
- 08 Jun, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_driver` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens_client` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_localizations` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_test` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_web_plugins` * fix comments * Use `curly_braces_in_flow_control_structures` for `packages/integration_test` * fix indentation
-
- 30 Mar, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 03 Mar, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 25 Feb, 2022 1 commit
-
-
Kate Lovett authored
-
- 24 Feb, 2022 2 commits
-
-
Harry Terkelsen authored
This reverts commit ee86e61f.
-
Kate Lovett authored
-
- 11 Dec, 2021 1 commit
-
-
Kate Lovett authored
-
- 07 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Mouad Debbar authored
This reverts commit cb378edc.
-
Ian Hickson authored
-
- 01 Jun, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 07 May, 2021 1 commit
-
-
Kate Lovett authored
-
- 22 Apr, 2021 1 commit
-
-
Phil Quitslund authored
-
- 04 Mar, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 20 Feb, 2021 1 commit
-
-
Sam Rawlins authored
-
- 13 Oct, 2020 1 commit
-
-
Kate Lovett authored
-
- 08 Oct, 2020 1 commit
-
-
Kate Lovett authored
-
- 06 Oct, 2020 1 commit
-
-
Jonah Williams authored
* [flutter_test] handle breaking change to test main . Fixes #67382
-
- 01 Oct, 2020 1 commit
-
-
Kate Lovett authored
-
- 19 Sep, 2020 1 commit
-
-
Kate Lovett authored
-
- 02 Sep, 2020 1 commit
-
-
Kate Lovett authored
-
- 24 Aug, 2020 1 commit
-
-
Jonah Williams authored
-
- 09 Apr, 2020 1 commit
-
-
Jacob MacDonald authored
-
- 18 Mar, 2020 1 commit
-
-
Kate Lovett authored
-
- 16 Mar, 2020 1 commit
-
-
Kate Lovett authored
This reverts commit 7edcc92b.
-
- 14 Mar, 2020 1 commit
-
-
Kate Lovett authored
-
- 13 Mar, 2020 1 commit
-
-
Kate Lovett authored
-
- 05 Feb, 2020 1 commit
-
-
Kate Lovett authored
-
- 10 Jan, 2020 1 commit
-
-
Kate Lovett authored
-
- 09 Jan, 2020 1 commit
-
-
Kate Lovett authored
-
- 07 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 11 Dec, 2019 1 commit
-
-
Kate Lovett authored
-
- 04 Dec, 2019 1 commit
-
-
Kate Lovett authored
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-