1. 18 Aug, 2016 1 commit
  2. 27 Jun, 2016 2 commits
    • Adam Barth's avatar
      Improve test coverage for gestures.dart (#4773) · bb0c41f2
      Adam Barth authored
      This patch adds tests for some code paths we weren't hitting before and removes
      some dead code that couldn't be tested because it was unreachable.
      bb0c41f2
    • Adam Barth's avatar
      Change how navigator prevents redundant operations (#4769) · 2af668f8
      Adam Barth authored
      * Change how navigator prevents redundant operations
      
      Instead of requiring transactions, we now cancel all active pointers that are
      interacting with the navigator and absorb future pointers until we get a chance
      to build. This approach isn't perfect (e.g., events that trigger off the
      cancelled pointers could still interact with the navigator), but it should be
      better than the current transaction-based approach.
      
      Fixes #4716
      
      * Remove openTransaction
      
      * test
      
      * fixup
      2af668f8
  3. 03 Jun, 2016 1 commit
    • Adam Barth's avatar
      Convert drag gestures to use details objects (#4343) · 2d4acb80
      Adam Barth authored
      Previously we supplied individual parameters to the various drag and pan
      callbacks. However, that approach isn't extensible because each new
      parameter is a breaking change to the API.
      
      This patch makes a one-time breaking change to the API to provide a
      "details" object that we can extend over time as we need to expose more
      information. The first planned extension is adding enough information to
      accurately produce an overscroll glow on Android.
      2d4acb80
  4. 27 May, 2016 1 commit
  5. 16 May, 2016 1 commit
    • Ian Hickson's avatar
      Make it possible to run tests live on a device (#3936) · 32527017
      Ian Hickson authored
      This makes it possible to substitute 'flutter run' for 'flutter test'
      and actually watch a test run on a device.
      
      For any test that depends on flutter_test:
      
      1. Remove any import of 'package:test/test.dart'.
      
      2. Replace `testWidgets('...', (WidgetTester tester) {`
            with `testWidgets('...', (WidgetTester tester) async {`
      
      3. Add an "await" in front of calls to any of the following:
          * tap()
          * tapAt()
          * fling()
          * flingFrom()
          * scroll()
          * scrollAt()
          * pump()
          * pumpWidget()
      
      4. Replace any calls to `tester.flushMicrotasks()` with calls to
         `await tester.idle()`.
      
      There's a guarding API that you can use, if you have particularly
      complicated tests, to get better error messages. Search for
      TestAsyncUtils.
      32527017
  6. 26 Apr, 2016 1 commit
    • Adam Barth's avatar
      Delay win-by-default in gesture arena (#3552) · 51b1550d
      Adam Barth authored
      Wait until the end of the microtask to tell gesture recognizers that
      they've won in the gesture arena. This lets recognizers dispose reject
      themselves at arbitrary times without triggering gestures in awkward
      call stacks.
      
      Fixes #3183
      51b1550d
  7. 22 Apr, 2016 1 commit
  8. 15 Apr, 2016 1 commit
  9. 12 Apr, 2016 1 commit
  10. 14 Mar, 2016 1 commit
  11. 12 Mar, 2016 1 commit
  12. 10 Mar, 2016 1 commit
  13. 25 Feb, 2016 1 commit
    • Adam Barth's avatar
      Remove PointerRouter and GestureArena arguments · 4b1a9ff1
      Adam Barth authored
      There's no reason to make clients supply a PointerRounter and a
      GestureArena when constructing gesture recognizers. These objects are
      statics and the gesture recognizers can just grab them directly.
      
      Also, remove the callback constructor arguments. Almost no code used
      them. Instead, people seem to prefer using the `..` operator to set
      callbacks on the recognizers. Removing the arguments removes a bunch of
      boilerplate.
      4b1a9ff1
  14. 14 Feb, 2016 1 commit
    • Adam Barth's avatar
      Add a Velocity class to be explicit about units · 4fb47600
      Adam Barth authored
      We were using an Offset, which represented pixels/second, but it wasn't
      clear to clients whether that was pixels/ms. Now we use a Velocity class
      that is explict about the units.
      
      Fixes #1510
      Fixes #785
      4fb47600
  15. 11 Jan, 2016 1 commit
    • Adam Barth's avatar
      DoubleTap gesture asserts when rejected · 07a9cc75
      Adam Barth authored
      The pointer router was using an iteration pattern that always delivers
      handleEvent calls even if you remove a route during the iteration.
      That's awkward to program against and causes trouble for the double-tap
      gesture.
      
      This patch switches PointerRouter to using a re-entrant iteration
      pattern that supports removing routes (but not adding routes) during the
      iteration.
      07a9cc75
  16. 16 Dec, 2015 1 commit