- 23 Oct, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 19 Oct, 2018 1 commit
-
-
Michael Goderbauer authored
This reverts commit 8e2ca93f. Fixes https://github.com/flutter/flutter/issues/23172
-
- 17 Oct, 2018 2 commits
-
-
Alexandre Ardhuin authored
* enable lint prefer_void_to_null * replace last Null by void
- 16 Oct, 2018 2 commits
-
-
Alexandre Ardhuin authored
* Future<void> main * Future<void>.delayed * prefer_void_to_Null * address review comments
-
Amir Hardon authored
Before this PR AndroidView's gestureRecognizers field was a list of gesture recognizers. This was problematic as when the widget was rebuilt with the same gesture recognizer instances we would try to re-join the recognizers to a gesture arena team and crash (as a OneSeqeunceGestureRecognizer team can only be set once). With this change, we instead take a set of factories. This allows AndroidView to create the gesture recognizers just before adding them to the team, and thus be sure that they are only added once to a team. The factories are identified by the type of the object they create, this allows AndroidView to know when it is given an equivalent set of gesture recognizer factories, and do nothing in that case.
-
- 13 Oct, 2018 1 commit
-
-
Michael Goderbauer authored
Service extensions can only be activated in debug or profile mode, their code should never be included in release mode. This PR adds guards around all service extension registration calls that enable Dart's tree shaker to remove the extension's code in release mode, which reduces our binary size: Android Snapshot (uncompressed): minus 127,384 Bytes (-124.40KB) APK (compressed): minus 38,136 Bytes (-37.24KB) iOS Snapshot (App.framework, uncompressed): 264,304 Bytes(-258.10KB) For details: https://docs.google.com/document/d/13JlgvliCn5sWwT2K2SfDwD1NhEfxpJH9DCf22gZZru8/edit **Benchmark Regressions:** This PR may cause benchmarks to regress because it may change the timing of GC. If you notice a benchmark regression **please note down the exact set of benchmarks that regressed on this PR** and then feel free to revert. I will follow-up with a PR that forces a GC before the effected benchmarks run to get a clean baseline before re-applying this PR.
-
- 05 Oct, 2018 2 commits
-
-
Yegor authored
* first pass * revert WidgetsBindingObserver * disable prefer_mixin * docs and more mixins * newer engine; binding fixes * upgrade dependencies * fix test binding * remove whitespace * remove the obsolete `enableSuperMixins: true` * upgrade dartdoc to 0.22.0 * temporarily use git version of dartdoc * fix pub global activate syntax * use dartdoc 0.23.0
- 04 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 01 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 24 Sep, 2018 1 commit
-
-
Michael Klimushyn authored
-
- 14 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 07 Sep, 2018 2 commits
-
-
Alexandre Ardhuin authored
* lint unnecessary_new on samples * fix tests
-
Alexandre Ardhuin authored
-
- 18 Aug, 2018 1 commit
-
-
Ian Hickson authored
* Fixes resulting from audit of issues links I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link. * Update run_test.dart skip this test again since it failed on linux and macos bots
-
- 10 Aug, 2018 1 commit
-
-
Mikkel Nygaard Ravn authored
-
- 03 Aug, 2018 1 commit
-
-
Ian Hickson authored
The following changes are made by this PR: * Translation bundles now implement MaterialLocalizations directly, and are public so that they can be directly extended. * The list of supported languages is now a generated constant. * The icuShortTimePattern/TimeOfDayFormat values are now pre-parsed. * Various other changes for consistency with the style guide and the rest of the codebase, e.g. the class names don't use `_`, the `path` library is imported as such, more dartdocs, fewer `// ignore`s, validation using exceptions. This reduces our technical debt benchmark.
-
- 02 Aug, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Jul, 2018 1 commit
-
-
Todd Volkert authored
It was causing problems rolling Flutter into Fuchsia
-
- 23 Jul, 2018 1 commit
-
-
Alexandre Ardhuin authored
* re-enable lint unnecessary_const * remove trailling whitespaces * remove unnecessary const (after merge)
-
- 20 Jul, 2018 1 commit
-
-
Greg Spencer authored
-
- 16 Jul, 2018 2 commits
-
-
Ian Hickson authored
This reverts commit cc1cf13e.
-
Alexandre Ardhuin authored
-
- 10 Jul, 2018 1 commit
-
-
Ian Hickson authored
They should fail, because we don't have real support yet. Also, make the debug override work in release builds, so that people on those platforms have a workaround.
-
- 09 Jul, 2018 1 commit
-
-
stuartmorgan authored
A significant amonut of code uses defaultTargetPlatform, so it's currently impossible to run most apps on Windows. This adds a mapping from Windows as a host to Android as a target, paralleling the macOS->iOS and Linux->Android mappings. This allows more use of Windows as a host platform (e.g., for testing, as in issue #17768).
-
- 27 Jun, 2018 1 commit
-
-
Ian Hickson authored
-
- 19 Jun, 2018 1 commit
-
-
Greg Spencer authored
-
- 14 Jun, 2018 1 commit
-
-
xster authored
-
- 13 Jun, 2018 1 commit
-
-
Chris Bracken authored
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly from source, flutter_platform.dart automatically runs a kernel compile when operating in Dart 2 mode, but this assumes a functional Dart SDK is available in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts directory with an empty temp dir. Remaining work is: 1. Get the frontend server building as a dependency on Fuchsia. 2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server. This also reverts migration to Dart 2 typedef syntax. This reverts commit 6c56bb24. (#18362) This reverts commit 3daebd05. (#18316)
-
- 11 Jun, 2018 1 commit
-
-
Greg Spencer authored
Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax. Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml. No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 30 May, 2018 3 commits
-
-
Greg Spencer authored
Revert "Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)" (#18041) This reverts commit 32586020.
-
Greg Spencer authored
Fixes #18028 Just changes typedef declarations, no logic changes.
-
Mikkel Nygaard Ravn authored
-
- 29 May, 2018 1 commit
-
-
Todd Volkert authored
-
- 28 May, 2018 1 commit
-
-
Todd Volkert authored
https://github.com/flutter/flutter/issues/17956 * Add a `debugInstrumentAction()` method that will wrap an action in a stopwatch and print the time it took to run the action. * Add a global `debugInstrumentationEnabled` that will control whether `debugInstrumentAction()` does anything (even in debug builds). * Add some basic instrumentation to `registerServiceExtension()` * Temporarily enable the `debugInstrumentationEnabled` flag in the Gallery to give us better visibility into what's happening in https://github.com/flutter/flutter/issues/17956
-
- 22 May, 2018 1 commit
-
-
Todd Volkert authored
Fixes https://github.com/flutter/flutter/issues/17597
-
- 18 May, 2018 1 commit
-
-
Greg Spencer authored
Our style guide says the k's are not necessary, and it seems like a good idea to make all the code be consistent on this. Only naming changes to private vars: no logic changes.
-