- 23 Feb, 2023 1 commit
-
-
Lioness100 authored
* Fix typos * lowercase animated & opacity * Undo typo fix --------- Co-authored-by:
Michael Goderbauer <goderbauer@google.com>
-
- 30 Jun, 2022 1 commit
-
-
Loïc Sharma authored
The `flutter doctor` command uses `vswhere.exe` to verify the Visual Studio installation. This `vswhere.exe` is known to encode its output incorrectly. This is problematic as the `description` property is localized, and in certain languages this results in invalid JSON due to the incorrect encoding. This change introduces a fallback to our `vswhere.exe` output parsing logic: if parsing JSON fails, remove the `description` property and retry parsing the JSON. This fix was also tested on the outputs provided here: https://github.com/flutter/flutter/issues/106601#issuecomment-1170138123 Addresses https://github.com/flutter/flutter/issues/106601
-
- 24 May, 2022 1 commit
-
-
Loïc Sharma authored
Flutter uses `vswhere.exe` to find Visual Studio installations and determine if they satisfy Flutter's requirements. However, `vswhere.exe`'s JSON output is known to contain bad UTF-8. This change ignores bad UTF-8 as long as they affect JSON properties that are either unused, or, used only for display purposes by Flutter. Fixes: https://github.com/flutter/flutter/issues/102451
-
- 20 May, 2022 1 commit
-
-
Loïc Sharma authored
`VisualStudio` calls `vswhere.exe` to find Visual Studio installations and determine if they satisfy Flutter's requirements. Previously, `VisualStudio` stored the JSON output from `vswhere.exe` as `Map`s, resulting in duplicated logic to read the JSON output (once to validate values, second to expose values). Also, `VisualStudio` stored two copies of the JSON output (the latest valid installation as well as the latest VS installation). This change simplifies `VisualStudio` by introducing a new `VswhereDetails`. This type contains the logic to read `vswhere.exe`'s JSON output, and, understand whether an installation is usable by Flutter. In the future, this `VswhereDetails` type will be used to make Flutter doctor resilient to bad UTF-8 output from `vswhere.exe`. Part of https://github.com/flutter/flutter/issues/102451.
-
- 27 Apr, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 11 Nov, 2021 1 commit
-
-
stuartmorgan authored
-
- 26 Aug, 2021 1 commit
-
-
Jenn Magder authored
-
- 14 Jun, 2021 1 commit
-
-
Greg Spencer authored
This adds avoid_dynamic_calls to the list of lints, and fixes all instances where it was violated. Importantly, this lint is NOT turned on for flutter/packages/test, because those changes are happening in another PR: #84478
-
- 09 Jun, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 09 Apr, 2021 1 commit
-
-
Jenn Magder authored
-
- 25 Mar, 2021 1 commit
-
-
Jenn Magder authored
-
- 08 Feb, 2021 1 commit
-
-
Jonah Williams authored
This reverts commit 8b6baae4.
-
- 04 Feb, 2021 1 commit
-
-
Jonah Williams authored
Our current top crasher is an unclear error when ProcessManager fails to resolve an executable path. To fix this, we'd like to being adjusting the process resolution logic and adding more instrumentation to track failures. In order to begin the process, the ProcessManager has been folded back into the flutter tool
-
- 27 Jan, 2021 1 commit
-
-
Jonah Williams authored
* opt out the flutter tool * oops EOF * fix import * Update tool_backend.dart * Update daemon_client.dart * fix more
-
- 12 Oct, 2020 5 commits
-
-
Jonah Williams authored
Revert "[flutter_tools] reland: fold process resolution logic into the flutter tool (#67957)" (#67968) This reverts commit bd813879.
-
Jonah Williams authored
Reland of #67669 The flutter tool has a number of crashes on stable where an ArgumentError is thrown due to the process manager not being able to resolve an executable. So that we can adjust/modify this logic, fold it into flutter and add some additional logging. caches the resolved executable per target directory, to avoid repeated look ups. Instead of throwing an argument error, attempts to run the executable as given if an exact path can't be found Accept files or symlinks for the executable path. user where/which to resolve path instead of package:process logic.
-
Jonah Williams authored
This reverts commit 10c78c26.
-
Jonah Williams authored
The flutter tool has a number of crashes on stable where an ArgumentError is thrown due to the process manager not being able to resolve an executable. Fold the resolution logic into the tool and use where/which instead of the package:process specific logic.
-
Jonah Williams authored
HACKTOBERFEST
-
- 31 Aug, 2020 1 commit
-
-
ekibun authored
add different workload & add -products * to vswhere calls to check both Visual Studio IDE and standalone Build Tools. (#64251)
-
- 06 Aug, 2020 1 commit
-
-
Nolan Scobie authored
* Add punctuation for unterminated sentences in doc comments * Addressing review nit
-
- 06 Jul, 2020 1 commit
-
-
stuartmorgan authored
* First pass at CMake files; untested * First pass of adding CMake generation logic on Windows * Misc fixes * Get bundling working, start incoprorating CMake build into tool * Fix debug, exe name. * Add resources * Move cmake.dart * Rip out all the vcxproj/solution plumbing * Fix plugin cmake generation * Build with cmake rather than calling VS directly * Adjust Windows plugin template to match standard header directory structure * Pass config selection when building * Partially fix multi-config handling * Rev template version * Share the CMake generation instead of splitting it out * VS build/run cycle works, with slightly awkward requirement to always build all * Update manifest * Plugin template fixes * Minor adjustments * Build install as part of build command, instead of separately * Test cleanup * Update Linux test for adjusted generated CMake approach * Plugin test typo fix * Add missing stub file for project test * Add a constant for VS generator
-
- 18 Jun, 2020 1 commit
-
-
stuartmorgan authored
On Windows, Process.run assumes the output uses the system codepage by default. This allows specifying it in our wrapper, and sets the encoding for vswhere to UTF-8 since we're passing a flag that forces it to use UTF-8 output. Fixes #53515
-
- 05 Jun, 2020 1 commit
-
-
stuartmorgan authored
Current versions of the Windows desktop build files don't require a specific Windows 10 SDK version, but doctor still checks for one since vswhere doesn't allow for flexible queries. This has been a common source of issues for people setting up on Windows for the first time, because the current VS installer by default only includes a newer version of the SDK than what doctor is looking for. This removes the vswhere SDK check, and instead uses a manual check for SDKs. Since this uses undocumented (although fairly widely used, so relatively unlikely to change) registry information, the check is non-fatal, so that builds can progress even if the SDK isn't found by doctor; in practice, it's very unlikely that someone would install the C++ Windows development workload but remove the selected-by-default SDK from the install. Now that all requirements are default, the instructions when missing VS have been simplified so that they no longer list individual components, and instead just say to include default items. Fixes #50487
-
- 06 May, 2020 1 commit
-
-
Zachary Anderson authored
-
- 10 Mar, 2020 1 commit
-
-
Jonah Williams authored
Updates VisualStudio and VisualStudioValidator to use constructors instead of global injection. Updates VisualStudio test cases to prefer FakeProcessManager Updates build_windows test to work without injected VisualStudio
-
- 15 Jan, 2020 1 commit
-
-
stuartmorgan authored
-
- 10 Jan, 2020 1 commit
-
-
Tim Sneath authored
-
- 06 Jan, 2020 1 commit
-
-
Jonah Williams authored
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 22 Nov, 2019 1 commit
-
-
Greg Spencer authored
No code changes, just comments: I spell-checked all the comments in the repo.
-
- 19 Nov, 2019 1 commit
-
-
Alexandre Ardhuin authored
* implicit-casts:false on flutter_tools/lib * address review comments * use castStringKeyedMap * introduce {bool,string,strings}Arg * fix ci
-
- 24 Oct, 2019 1 commit
-
-
Jonah Williams authored
-
- 24 Sep, 2019 1 commit
-
-
Francisco Magdaleno authored
-
- 12 Sep, 2019 3 commits
-
-
Francisco Magdaleno authored
-
Francisco Magdaleno authored
Fixes a crash introduced on #40011 due to an incorrect type in the vswhere search Fixes #40238
-
Zachary Anderson authored
-
- 11 Sep, 2019 1 commit
-
-
Francisco Magdaleno authored
-
- 06 Jun, 2019 1 commit
-
-
stuartmorgan authored
Moves the logic for finding vcvars64.bat to a new VisualStudio class that encapsulates finding, and providing information about, VisualStudio installations. Adds a validator for it, and runs it for Windows workflows in doctor.
-