1. 15 Feb, 2023 1 commit
    • Ian Hickson's avatar
      Improve network resources doctor check (#120417) · d29668dd
      Ian Hickson authored
      ...and various other minor cleanup:
      
      * Moved "FLUTTER_STORAGE_BASE_URL" into a constant throughout the code. There are other strings that we should do that to but this one was relevant to the code I was changing.
      
      * Fixed the logger's handling of slow warnings. Previously it deleted too much text. Fixed the test for that to actually verify it entirely, too.
      
      * Made the logger delete the slow warning when it's finished.
      
      * Fixed 'Please choose one (To quit, press "q/Q")' message to be the cleaner 'Please choose one (or "q" to quit)'.
      
      * Added a debug toString to ValidationResult for debugging purposes (not used).
      
      * In http_host_validator:
      
        - Shortened constant names to be clearer (e.g. kPubDevHttpHost -> kPubDev).
        - Added GitHub as a tested host since when you run `flutter` we hit that immediately.
        - Renamed the check "Network resources".
        - Updated the `slowWarning` of the check to say which hosts are pending.
        - Removed all timeout logic. Timeouts violate our style guide.
        - Removed `int.parse(... ?? '10')`; passing a constant to `int.parse` is inefficient.
        - Replaced the `_HostValidationResult` class with `String?` for simplicity.
        - Improved the error messages to be more detailed.
        - Removed all checks that dependened on the stringification of exceptions. That's very brittle.
        - Added a warning specifically for HandshakeException that talks about the implications (MITM attacks).
        - Replaced exception-message-parsing logic with just calling `Uri.tryParse` and validating the result.
        - Replaced a lot of list-filtering logic with just a single for loop to check the results.
        - Replaced code that added a constant to a known-empty list with just returning a constant list.
        - Revamped the logic for deciding which hosts to check to just use a single chain of if/else blocks instead of getters, lists literals with `if` expressions, `??`, functions, etc spread over multiple places in the code.
      d29668dd
  2. 23 Jan, 2023 1 commit
  3. 24 Mar, 2021 2 commits
  4. 09 Feb, 2021 1 commit
  5. 27 Jan, 2021 1 commit
  6. 06 May, 2020 1 commit
  7. 29 Jan, 2020 1 commit
  8. 28 Jan, 2020 1 commit
  9. 07 Jan, 2020 1 commit
  10. 06 Jan, 2020 1 commit
  11. 12 Dec, 2019 1 commit
    • Danny Tuppeny's avatar
      Support URL tunnelling (pass dwds UrlEncoder through to editors via daemon) (#44271) · 4944622b
      Danny Tuppeny authored
      * Prposal for supporting URL tunnelling
      
      * Update daemon.md
      
      * Add the ability for daemon to call clients to expose URLs
      
      * Fix dwds mock in web_fs tests
      
      * Fix type error
      
      * Remove build_runner import from run
      
      * Move appStartedTime back to after the app has started
      
      * Remove nested DI scope and pass urlTunneller down
      
      * Fix import
      
      * Tweak TODO
      
      * Fix existing tests
      
      * Fix spec to use result instead of params for response object
      
      * Fix exposeUrl to use a url field, as spec'd
      
      * Test that the daemon's exposeUrl sends a request and handles the response
      4944622b
  12. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  13. 07 Nov, 2019 1 commit
  14. 13 Sep, 2019 1 commit
  15. 20 Aug, 2019 1 commit
  16. 15 Aug, 2019 1 commit
  17. 17 Jun, 2019 1 commit
  18. 17 May, 2019 1 commit
  19. 25 Apr, 2019 1 commit
  20. 08 Mar, 2019 2 commits
  21. 21 Feb, 2019 1 commit
  22. 13 Feb, 2019 2 commits
  23. 08 Feb, 2019 2 commits
  24. 19 Jan, 2019 1 commit
    • Ian Hickson's avatar
      [O] Removing all timeouts (mark II) (#26736) · 31a9626c
      Ian Hickson authored
      These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
      31a9626c
  25. 21 Dec, 2018 2 commits
    • Ian Hickson's avatar
      Revert "[O] Remove many timeouts. (#23531)" (#25646) · 8426910a
      Ian Hickson authored
      This reverts commit 76f70810.
      8426910a
    • Ian Hickson's avatar
      [O] Remove many timeouts. (#23531) · 76f70810
      Ian Hickson authored
      * Remove many timeouts.
      
      These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
      
      * Get the attach tests to pass.
      
      * Apply review comments from Todd
      
      * More review comment fixes
      
      * Put back the extended timeouts here now that I know why we have them...
      76f70810
  26. 30 Oct, 2018 1 commit
    • Ben Konyi's avatar
      Added '--check-for-remote-artifacts' option for Flutter Doctor. (#23543) · b1a23299
      Ben Konyi authored
      * Added '--check-for-remote-artifacts' option for Flutter Doctor.
      
      This option takes a Flutter engine revision and issues HEAD requests to
      determine whether or not artifacts for the provided engine revision are
      available from cloud storage. This functionality is needed for the Dart
      SDK autoroller to avoid creating a PR to roll the engine into the
      framework while artifacts haven't finished building, which would cause
      Cirrus tests to fail.
      b1a23299
  27. 05 Oct, 2018 1 commit
  28. 14 Sep, 2018 1 commit
  29. 12 Sep, 2018 1 commit
  30. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  31. 11 Jun, 2018 1 commit
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  32. 30 May, 2018 2 commits
  33. 16 Apr, 2018 1 commit
  34. 26 Jan, 2018 1 commit