1. 04 May, 2018 1 commit
  2. 03 May, 2018 2 commits
  3. 20 Mar, 2018 1 commit
  4. 12 Mar, 2018 1 commit
  5. 09 Mar, 2018 1 commit
  6. 28 Feb, 2018 1 commit
  7. 06 Feb, 2018 2 commits
    • Greg Spencer's avatar
      Adds the semantic node traversal API. (#14060) · 14309b93
      Greg Spencer authored
      This adds an API for defining the semantic node traversal order.
      
      It adds a sortOrder argument to the Semantics widget, which is a class that can define a list of sort keys to sort on. The keys are sorted globally so that an order that doesn't have to do with the current widget hierarchy may be defined.
      
      It also adds a shortcut sortKey argument to the Semantics widget that simply sets the sortOrder to just contain that key.
      
      The platform side (flutter/engine#4540) gets an additional member in the SemanticsData object that is an integer describing where in the overall order each semantics node belongs. There is an associated engine-side change that takes this integer and uses it to order widgets for the platform's accessibility services.
      14309b93
    • Alexandre Ardhuin's avatar
      unnessary parenthesis (#14475) · 2e80bf1d
      Alexandre Ardhuin authored
      2e80bf1d
  8. 02 Feb, 2018 1 commit
  9. 18 Jan, 2018 1 commit
  10. 10 Jan, 2018 1 commit
  11. 09 Jan, 2018 2 commits
  12. 22 Dec, 2017 1 commit
    • Michael Goderbauer's avatar
      Fixes crash caused by invisible semantics children (#13740) · 4e13cd07
      Michael Goderbauer authored
      **tl;dr:** A `RenderObject` can only be an effective semantics boundary if it actually owned a `SemanticsNode` in the previous tree generation.
      
      When using the `BlockSemantics` widget it is possible to introduce `RenderObject`s that are configured to be a semantics boundary, but because their semantics are blocked by `BlockSemantics` they will not (immediately) end up owning a `SemanticsNode`. When now a descendant of such a node-less semantics boundary marks itself as needing a semantics update we walk up the tree until we find the closest semantics boundary (which is our node-less `RenderObject`). We now incorrectly assume that this semantics boundary has a valid `SemanticsNode` and only regenerate the semantics subtree below this node. However, because the identified semantics boundary doesn't actually own a valid `SemanticsNode` asserts are throwing (e.g. `Child with id xx is invisible and should not be added to tree.`).
      
      To fix this problem, we can just abort the walk if we reach a semantics boundary without a semantics node because (for now) we know that the semantics information of this branch will not make it into the final semantics tree.
      If the semantics block is ever removed, the current algorithm re-generates the semantics for the entire branch and the semantics will be up-to-date then despite the abort. I've added a test to verify this to make sure it continues to work even when we change the algorithm.
      
      Fixes https://github.com/flutter/flutter/issues/13326.
      /cc @gavindoughtie FYI
      4e13cd07
  13. 21 Dec, 2017 1 commit
  14. 13 Dec, 2017 1 commit
  15. 08 Dec, 2017 1 commit
    • Yegor's avatar
      Make time picker accessible (#13152) · b80751cd
      Yegor authored
      * make time picker accessible
      
      * use new CustomPaint a11y API
      
      * flutter_localizations tests; use bigger distance delta
      
      * fix am/pm control; selected values
      
      * fix translations; remove @mustCallSuper in describeSemanticsConfiguration
      
      * exclude AM/PM announcement from iOS as on iOS the label is read back automatically
      b80751cd
  16. 05 Dec, 2017 1 commit
  17. 30 Nov, 2017 1 commit
    • Michael Goderbauer's avatar
      Adapt markNeedsSemanticsUpdate algorithm to new semantics tree compiler (#13274) · 6493c8b4
      Michael Goderbauer authored
      * ensures that only semantics boundaries will be added to owner._nodesNeedingSemantics as expected by compiler.
      * no longer throws assert if markNeedsSemanticsUpdate is called on non-semantic-boundary render object with a non-semantic-boundary parent.
      * Fixes #13109.
      * removes onlyLocalUpdates from markNeedsSemanticsUpdate as its no longer needed.
      6493c8b4
  18. 29 Nov, 2017 1 commit
  19. 22 Nov, 2017 1 commit
    • Ian Hickson's avatar
      Popup menus RTL (#13110) · 34ba6be9
      Ian Hickson authored
      This fixes the popup menu code to do a better job of expanding
      smoothly regardless of which side of the screen it's on. It still
      results in a bidirection growth when positioned at the bottom of the
      screen, so maybe we'll need to animate menus differently, but that's
      a problem for another patch.
      
      Also, improve some docs and provide RelativeRect.toSize which I needed
      at one point while building this patch (though it didn't survive all
      the way to the end).
      34ba6be9
  20. 17 Nov, 2017 1 commit
    • Greg Spencer's avatar
      Fix spelling errors in all the dartdocs. (#13061) · 0259be90
      Greg Spencer authored
      I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once.
      
      This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
      0259be90
  21. 09 Nov, 2017 1 commit
    • Greg Spencer's avatar
      Add an UnconstrainedBox and factor out debug overflow indicator. (#12856) · 3541ad0a
      Greg Spencer authored
      UnconstrainedBox will allow its child to size itself as if it had no constraints, and then attempt to fit around that object, until its own constraints are exceeded, in which case it will clip and display an overflow warning.
      
      I also factored out DebugOverflowIndicator, which will draw overflow indicators on containers which overflow but aren't expected to.
      3541ad0a
  22. 03 Nov, 2017 1 commit
  23. 01 Nov, 2017 3 commits
  24. 25 Oct, 2017 1 commit
  25. 24 Oct, 2017 2 commits
  26. 23 Oct, 2017 1 commit
  27. 19 Oct, 2017 1 commit
    • Greg Spencer's avatar
      Fixes InputDecorator to work with textScaleFactor, fixes Material Design differences. (#12595) · 67cf7918
      Greg Spencer authored
      Fixes InputDecorator to work with textScaleFactor, fixes Material Design differences.
      
      There were a number of differences with the Material Design spec, including
      several different padding values and underline thickness.  This corrects
      that so that the decorator is in line with the Material Design spec now.
      
      Also, the decorator properly handles changes to the textScaleFactor, where
      before it would not re-layout when needed, painting the cursor and
      underline incorrectly.
      
      The decorator also now properly animates helper, error, and hint text when
      the textScaleFactor or input decoration properties change.
      
      Helper text is now properly displayed in dense mode, as the spec shows.
      Before this change, it was never displayed in dense mode.
      
      Fixes #12485
      67cf7918
  28. 18 Oct, 2017 1 commit
    • Michael Goderbauer's avatar
      Redesign Semantic Tree Compilation Algorithm (#12605) · f8a2bd20
      Michael Goderbauer authored
      * Oct 12 10:12am
      
      * implicit_semantics_test.dart passes
      
      * refactoring
      
      * works in nice
      
      * minor rename
      
      * more doc comments
      
      * to be explicit check better
      
      * fix test
      
      * ++
      
      * ++
      
      * semantics_9_test (BlockSemantics) and implicit_semantics_test are passing
      
      * doc updates
      
      * tiny refactor
      
      * fix static errors in tests
      
      * fix gesture detector
      
      * ++
      
      * ++
      
      * geometry
      
      * ++
      
      * remove noGeometry
      
      * revert test
      
      * +
      
      * all tests but scrolling/clipping pass
      
      * clipping works
      
      * scrolling halfway
      
      * sliver tests pass
      
      * ALL TESTS PASS
      
      * SemanticsNode changed
      
      * docs and tiny fixes
      
      * card test
      
      * more doc comments
      
      * remove missed print
      
      * more tests
      
      * make test pass on Linux
      
      * remove changes to intellij proj file
      
      * review comments
      f8a2bd20
  29. 13 Oct, 2017 1 commit
  30. 03 Oct, 2017 1 commit
    • Michael Goderbauer's avatar
      Drop invisible SemanticsNodes from tree (#12358) · 49499457
      Michael Goderbauer authored
      * Drop invisible SemanticsNodes from tree
      
      A node is invisible if it is outside of the bounds of the screen and if it is not merged into its (partially) visible parent.
      
      Also in this PR: only set `wasAffectedByClip` to true if the nodes has actually been clipped.
      
      * Fix other failing tests
      
      * renaming
      
      * review feedback
      
      * more doc
      49499457
  31. 02 Oct, 2017 1 commit
  32. 28 Sep, 2017 1 commit
  33. 27 Sep, 2017 1 commit
  34. 24 Sep, 2017 1 commit