- 04 May, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 03 May, 2018 2 commits
-
-
Chris Bracken authored
Revert longPress/Tap and Gallery changes
-
Jonah Williams authored
-
- 20 Mar, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Mar, 2018 1 commit
-
-
Jason Simmons authored
-
- 09 Mar, 2018 1 commit
-
-
Michael Goderbauer authored
-
- 28 Feb, 2018 1 commit
-
-
najeira authored
-
- 06 Feb, 2018 2 commits
-
-
Greg Spencer authored
This adds an API for defining the semantic node traversal order. It adds a sortOrder argument to the Semantics widget, which is a class that can define a list of sort keys to sort on. The keys are sorted globally so that an order that doesn't have to do with the current widget hierarchy may be defined. It also adds a shortcut sortKey argument to the Semantics widget that simply sets the sortOrder to just contain that key. The platform side (flutter/engine#4540) gets an additional member in the SemanticsData object that is an integer describing where in the overall order each semantics node belongs. There is an associated engine-side change that takes this integer and uses it to order widgets for the platform's accessibility services.
-
Alexandre Ardhuin authored
-
- 02 Feb, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 18 Jan, 2018 1 commit
-
-
Jason Simmons authored
The picture may need to draw outside the bounds (specifically for shadows) Fixes https://github.com/flutter/flutter/issues/12618
-
- 10 Jan, 2018 1 commit
-
-
Michael Goderbauer authored
* Do not crash when toggeling Semantics on, off, on * review comments
-
- 09 Jan, 2018 2 commits
-
-
Michael Goderbauer authored
`RenderSemanticsGestureHandler` is no longer a semantics boundary, which allows us to correctly mark disabled buttons as disabled without having their semantics size and semantics node id change unexpectedly. Fixes https://github.com/flutter/flutter/issues/12589. Fixes https://github.com/flutter/flutter/issues/11991. See also https://github.com/flutter/flutter/issues/11993. This change also required some refactoring to how we deal with `twoPaneSemantics` scrolling as it previously relied on `RenderSemanticsGestureHandler` being a semantics boundary. This should also make the underlying logic easier to understand. In addition, the following minor changes are included in this PR: * Removal of orphaned and unused `SemanticsConfiguration.isMergingDescendantsIntoOneNode`. * Logic optimizations for `markNeedsSemanticsUpdate` . * Fix for edge case where `MergeSemantics` failed to merge semantics. * Use of emojis to better indicate leaf merging in the printed semantics tree. * Better assert message for adding invisible child semantics nodes. * Make some semantics tests robuster by not relying on creation order of SemanticsNode ids across test boundaries. Fixes https://github.com/flutter/flutter/issues/13943.
-
Ian Hickson authored
Fixes the last bits of #5759.
-
- 22 Dec, 2017 1 commit
-
-
Michael Goderbauer authored
**tl;dr:** A `RenderObject` can only be an effective semantics boundary if it actually owned a `SemanticsNode` in the previous tree generation. When using the `BlockSemantics` widget it is possible to introduce `RenderObject`s that are configured to be a semantics boundary, but because their semantics are blocked by `BlockSemantics` they will not (immediately) end up owning a `SemanticsNode`. When now a descendant of such a node-less semantics boundary marks itself as needing a semantics update we walk up the tree until we find the closest semantics boundary (which is our node-less `RenderObject`). We now incorrectly assume that this semantics boundary has a valid `SemanticsNode` and only regenerate the semantics subtree below this node. However, because the identified semantics boundary doesn't actually own a valid `SemanticsNode` asserts are throwing (e.g. `Child with id xx is invisible and should not be added to tree.`). To fix this problem, we can just abort the walk if we reach a semantics boundary without a semantics node because (for now) we know that the semantics information of this branch will not make it into the final semantics tree. If the semantics block is ever removed, the current algorithm re-generates the semantics for the entire branch and the semantics will be up-to-date then despite the abort. I've added a test to verify this to make sure it continues to work even when we change the algorithm. Fixes https://github.com/flutter/flutter/issues/13326. /cc @gavindoughtie FYI
-
- 21 Dec, 2017 1 commit
-
-
Ian Hickson authored
This is a collection of fixes I've run into recently.
-
- 13 Dec, 2017 1 commit
-
-
Michael Goderbauer authored
**This PR contains a breaking API change:** `SemanticsConfiguration.addAction()` has been removed and replaces by action-specific setters (`onTap`, `onLongPress`, etc.) to take care of the fact that some action handlers (those, who take arguments) have different signatures.
-
- 08 Dec, 2017 1 commit
-
-
Yegor authored
* make time picker accessible * use new CustomPaint a11y API * flutter_localizations tests; use bigger distance delta * fix am/pm control; selected values * fix translations; remove @mustCallSuper in describeSemanticsConfiguration * exclude AM/PM announcement from iOS as on iOS the label is read back automatically
-
- 05 Dec, 2017 1 commit
-
-
Yegor authored
Summary: - Add `key` field to `SemanticsNode`, while moving key into `foundation` library so it can be used by the render layer. - Introduce `SemanticsProperties` and move many of the `Semantics` fields into it. - Introduce `CustomPaintSemantics` - a `SemanticsNode` prototype created by `CustomPainter`. - Introduce `semanticsBuilder` and `shouldRebuildSemantics` in `CustomerPainter` **Breaking change** The default `Semantics` constructor becomes non-const (due to https://github.com/dart-lang/sdk/issues/20962). However, a new `const Semantics.fromProperties` is added that still allowed creating constant `Semantics` widgets ([mailing list announcement](https://groups.google.com/forum/#!topic/flutter-dev/KQXBl2_1sws)). Fixes https://github.com/flutter/flutter/issues/11791 Fixes https://github.com/flutter/flutter/issues/1666
-
- 30 Nov, 2017 1 commit
-
-
Michael Goderbauer authored
* ensures that only semantics boundaries will be added to owner._nodesNeedingSemantics as expected by compiler. * no longer throws assert if markNeedsSemanticsUpdate is called on non-semantic-boundary render object with a non-semantic-boundary parent. * Fixes #13109. * removes onlyLocalUpdates from markNeedsSemanticsUpdate as its no longer needed.
-
- 29 Nov, 2017 1 commit
-
-
Greg Spencer authored
-
- 22 Nov, 2017 1 commit
-
-
Ian Hickson authored
This fixes the popup menu code to do a better job of expanding smoothly regardless of which side of the screen it's on. It still results in a bidirection growth when positioned at the bottom of the screen, so maybe we'll need to animate menus differently, but that's a problem for another patch. Also, improve some docs and provide RelativeRect.toSize which I needed at one point while building this patch (though it didn't survive all the way to the end).
-
- 17 Nov, 2017 1 commit
-
-
Greg Spencer authored
I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once. This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
-
- 09 Nov, 2017 1 commit
-
-
Greg Spencer authored
UnconstrainedBox will allow its child to size itself as if it had no constraints, and then attempt to fit around that object, until its own constraints are exceeded, in which case it will clip and display an overflow warning. I also factored out DebugOverflowIndicator, which will draw overflow indicators on containers which overflow but aren't expected to.
-
- 03 Nov, 2017 1 commit
-
-
amirh authored
-
- 01 Nov, 2017 3 commits
-
-
Michael Goderbauer authored
-
Ian Hickson authored
Various improvements (in particular a new painting fuzzer) to the text manual test. Some additional documentation. A fix to Stack to remove an LTR bias: make unpositioned children apply "alignment". Some more debugging information on RichText and Text. A fix to the flutter tool to not crash when an RPC call throws an exception.
-
amirh authored
(in preparation for moving the semantics stuff out of rendering)
-
- 25 Oct, 2017 1 commit
-
-
Alexandre Ardhuin authored
* enable lint prefer_foreach * fix tests
-
- 24 Oct, 2017 2 commits
-
-
Greg Spencer authored
Revert "Revert "Fixes InputDecorator to work with textScaleFactor, fixes Material Design differences. (#12595)" (#12678)" (#12689) This reverts commit 72dc7d91. Re-landing my InputDecorator changes so that I can land the character counter PR.
-
Michael Goderbauer authored
* Without checking compatibility * ++ * ++ * ++ * more docs
-
- 23 Oct, 2017 1 commit
-
-
Greg Spencer authored
Revert "Fixes InputDecorator to work with textScaleFactor, fixes Material Design differences. (#12595)" (#12678) This reverts commit 67cf7918. Reverting because this causes scuba regressions that I'd like to address in another PR that is pending, but we'd like to roll Flutter.
-
- 19 Oct, 2017 1 commit
-
-
Greg Spencer authored
Fixes InputDecorator to work with textScaleFactor, fixes Material Design differences. There were a number of differences with the Material Design spec, including several different padding values and underline thickness. This corrects that so that the decorator is in line with the Material Design spec now. Also, the decorator properly handles changes to the textScaleFactor, where before it would not re-layout when needed, painting the cursor and underline incorrectly. The decorator also now properly animates helper, error, and hint text when the textScaleFactor or input decoration properties change. Helper text is now properly displayed in dense mode, as the spec shows. Before this change, it was never displayed in dense mode. Fixes #12485
-
- 18 Oct, 2017 1 commit
-
-
Michael Goderbauer authored
* Oct 12 10:12am * implicit_semantics_test.dart passes * refactoring * works in nice * minor rename * more doc comments * to be explicit check better * fix test * ++ * ++ * semantics_9_test (BlockSemantics) and implicit_semantics_test are passing * doc updates * tiny refactor * fix static errors in tests * fix gesture detector * ++ * ++ * geometry * ++ * remove noGeometry * revert test * + * all tests but scrolling/clipping pass * clipping works * scrolling halfway * sliver tests pass * ALL TESTS PASS * SemanticsNode changed * docs and tiny fixes * card test * more doc comments * remove missed print * more tests * make test pass on Linux * remove changes to intellij proj file * review comments
-
- 13 Oct, 2017 1 commit
-
-
Michael Goderbauer authored
-
- 03 Oct, 2017 1 commit
-
-
Michael Goderbauer authored
* Drop invisible SemanticsNodes from tree A node is invisible if it is outside of the bounds of the screen and if it is not merged into its (partially) visible parent. Also in this PR: only set `wasAffectedByClip` to true if the nodes has actually been clipped. * Fix other failing tests * renaming * review feedback * more doc
-
- 02 Oct, 2017 1 commit
-
-
Michael Goderbauer authored
* ++ * Allow unmerging of SemanticsNodes * test passing * ++ * remove prints * doc comments * rectify comment * review comments
-
- 28 Sep, 2017 1 commit
-
-
Ian Hickson authored
-
- 27 Sep, 2017 1 commit
-
-
Ian Hickson authored
-
- 24 Sep, 2017 1 commit
-
-
Ian Hickson authored
-