1. 17 Oct, 2016 1 commit
    • Adam Barth's avatar
      Tap above LongPressDraggable should work (#6348) · 61240fe8
      Adam Barth authored
      Previously, we were nulling out the ArenaEntry in MultiDragPointerState
      too early, which was prevent MultiDragPointerState from rejecting the
      gesture in `dispose` if we hadn't accepted by the time the pointer went
      up. Now we properly reject the gesture, which causes the tap gesture to
      win during `sweep` in the arena.
      
      Also, add a bunch of docs and annotations based on information I learned
      while studying this issue. Finally, rename a private member of tap
      recognizer to a name that would have confused me less in my
      investigation.
      
      Fixes #1186
      61240fe8
  2. 26 Apr, 2016 1 commit
    • Adam Barth's avatar
      Delay win-by-default in gesture arena (#3552) · 51b1550d
      Adam Barth authored
      Wait until the end of the microtask to tell gesture recognizers that
      they've won in the gesture arena. This lets recognizers dispose reject
      themselves at arbitrary times without triggering gestures in awkward
      call stacks.
      
      Fixes #3183
      51b1550d
  3. 24 Mar, 2016 1 commit
  4. 12 Mar, 2016 1 commit
  5. 11 Mar, 2016 1 commit
    • Ian Hickson's avatar
      Enable ALL THE LINTS · 1b9cd520
      Ian Hickson authored
      Well, all the easy ones, anyway.
      
      For some reason `// ignore:` isn't working for me so I've disabled
      lints that need that. Also disabled those that require a ton of work
      (which I'm doing, but not in this PR, to keep it reviewable).
      
      This adds:
      - avoid_init_to_null
      - library_names
      - package_api_docs
      - package_names
      - package_prefixed_library_names
      - prefer_is_not_empty
      - sort_constructors_first
      - sort_unnamed_constructors_first
      - unnecessary_getters_setters
      1b9cd520
  6. 05 Feb, 2016 1 commit
  7. 14 Dec, 2015 1 commit
  8. 10 Dec, 2015 1 commit
  9. 13 Nov, 2015 1 commit
    • Ian Hickson's avatar
      Fix tapcancel on slop. · c40cb176
      Ian Hickson authored
      Make sure to send tapcancel when the primary pointer fails because of
      slop, even if the gesture won by default.
      
      Also, minor cleanup and clarification of an invariant.
      c40cb176
  10. 05 Nov, 2015 1 commit
    • Hixie's avatar
      Make Draggable use gestures · 255ed0b9
      Hixie authored
      Draggable is now itself a gesture arena member. This means it won't
      conflict with other gesture recognisers in the same path.
      
      This also allows variants of Draggable that are triggered by other
      gestures.
      
      Also, some cleanup of DoubleTapGestureRecognizer, GestureDetector, and
      PrimaryPointerGestureRecognizer.
      
      Also, make MultiTapGestureRecognizer support a timeout for longpress.
      
      Also, make Draggable data be typed.
      
      Also, hide warnings about constructor warnings for now. Analyzer doesn't
      support them yet. (Have to do this on a per-line basis)
      
      Directions for future research:
       - animating the avatar (enter/exit transitions)
       - interaction with the navigator (canceling a drag on page navigation, etc)
       - double-tap draggable
      255ed0b9
  11. 04 Nov, 2015 1 commit
    • Hixie's avatar
      Gesture class hierarchy tune-up · ba3f60f8
      Hixie authored
      Make all the *GestureRecognizer classes inherit from a class called
      GestureRecognizer. Give the old GestureRecognizer a name that is more
      precise about its purpose. Remove the members of GestureArenaMember that
      aren't used by GestureArenas.
      ba3f60f8
  12. 03 Nov, 2015 1 commit
  13. 15 Oct, 2015 1 commit
  14. 13 Oct, 2015 1 commit
  15. 17 Sep, 2015 1 commit
    • Adam Barth's avatar
      Create gestures.dart · 41b8ffd6
      Adam Barth authored
      This patch is part of a sequence of patches towards fewer top-level libraries.
      In this patch, the gesture libraries are combined into one gestures.dart
      library.
      41b8ffd6
  16. 30 Aug, 2015 1 commit
    • Adam Barth's avatar
      Scrolls should start immediately when possible · bef55951
      Adam Barth authored
      If there are no other gestures in the arena, we should kick off the scroll
      gesture right away. This change pulled a refactoring of how we dispatch events
      to Widgets. Now we dispatch events to Widgets interleaved with their associated
      RenderObjects. (Previously we dispatched to all of the RenderObjects first.)
      bef55951
  17. 28 Aug, 2015 2 commits