- 17 Oct, 2016 1 commit
-
-
Adam Barth authored
Previously, we were nulling out the ArenaEntry in MultiDragPointerState too early, which was prevent MultiDragPointerState from rejecting the gesture in `dispose` if we hadn't accepted by the time the pointer went up. Now we properly reject the gesture, which causes the tap gesture to win during `sweep` in the arena. Also, add a bunch of docs and annotations based on information I learned while studying this issue. Finally, rename a private member of tap recognizer to a name that would have confused me less in my investigation. Fixes #1186
-
- 26 Apr, 2016 1 commit
-
-
Adam Barth authored
Wait until the end of the microtask to tell gesture recognizers that they've won in the gesture arena. This lets recognizers dispose reject themselves at arbitrary times without triggering gestures in awkward call stacks. Fixes #3183
-
- 24 Mar, 2016 1 commit
-
-
Hans Muller authored
-
- 12 Mar, 2016 1 commit
-
-
Adam Barth authored
Also, change the keys to be explicitly pointer ids. Fixes #202
-
- 11 Mar, 2016 1 commit
-
-
Ian Hickson authored
Well, all the easy ones, anyway. For some reason `// ignore:` isn't working for me so I've disabled lints that need that. Also disabled those that require a ton of work (which I'm doing, but not in this PR, to keep it reviewable). This adds: - avoid_init_to_null - library_names - package_api_docs - package_names - package_prefixed_library_names - prefer_is_not_empty - sort_constructors_first - sort_unnamed_constructors_first - unnecessary_getters_setters
-
- 05 Feb, 2016 1 commit
-
-
Adam Barth authored
-
- 14 Dec, 2015 1 commit
-
-
Ian Hickson authored
-
- 10 Dec, 2015 1 commit
-
-
Florian Loitsch authored
-
- 13 Nov, 2015 1 commit
-
-
Ian Hickson authored
Make sure to send tapcancel when the primary pointer fails because of slop, even if the gesture won by default. Also, minor cleanup and clarification of an invariant.
-
- 05 Nov, 2015 1 commit
-
-
Hixie authored
Draggable is now itself a gesture arena member. This means it won't conflict with other gesture recognisers in the same path. This also allows variants of Draggable that are triggered by other gestures. Also, some cleanup of DoubleTapGestureRecognizer, GestureDetector, and PrimaryPointerGestureRecognizer. Also, make MultiTapGestureRecognizer support a timeout for longpress. Also, make Draggable data be typed. Also, hide warnings about constructor warnings for now. Analyzer doesn't support them yet. (Have to do this on a per-line basis) Directions for future research: - animating the avatar (enter/exit transitions) - interaction with the navigator (canceling a drag on page navigation, etc) - double-tap draggable
-
- 04 Nov, 2015 1 commit
-
-
Hixie authored
Make all the *GestureRecognizer classes inherit from a class called GestureRecognizer. Give the old GestureRecognizer a name that is more precise about its purpose. Remove the members of GestureArenaMember that aren't used by GestureArenas.
-
- 03 Nov, 2015 1 commit
-
-
Hixie authored
Turns out there were no uses of GestureArenaMember other than those that use DisposableArenaMember.
-
- 15 Oct, 2015 1 commit
-
-
Kris Giesing authored
-
- 13 Oct, 2015 1 commit
-
-
Kris Giesing authored
-
- 17 Sep, 2015 1 commit
-
-
Adam Barth authored
This patch is part of a sequence of patches towards fewer top-level libraries. In this patch, the gesture libraries are combined into one gestures.dart library.
-
- 30 Aug, 2015 1 commit
-
-
Adam Barth authored
If there are no other gestures in the arena, we should kick off the scroll gesture right away. This change pulled a refactoring of how we dispatch events to Widgets. Now we dispatch events to Widgets interleaved with their associated RenderObjects. (Previously we dispatched to all of the RenderObjects first.)
-
- 28 Aug, 2015 2 commits
-
-
Adam Barth authored
These gestures use the new gesture detection system.
-
Adam Barth authored
In the GestureArena, gestures will fight it out to see which is the real ultimate gesture.
-