In #42533, I disabled the up/down arrows for focus navigation in text fields, but we thought of a better way to do it, so this is that better way.

This change reverts the other change, and instead it tests the context of the node in the action to see if it's an EditableText node. If so, then it doesn't do the navigation action.

git@github.com:flutter/engine.git/compare/3a357afc0372...508146f0defb

git log 3a357afc0372..508146f0defb --no-merges --oneline
2019-10-17 stuartmorgan@google.com Add a task runner for the Win32 embedding (flutter/engine#13043)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

git@github.com:flutter/engine.git/compare/9660eddaa588...3a357afc0372

git log 9660eddaa588..3a357afc0372 --no-merges --oneline
2019-10-17 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1dfc77cc08ee..f29cb70281d5 (1 commits) (flutter/engine#13195)
2019-10-17 bkonyi@google.com Roll src/third_party/dart b28b9ae8fc..f020ce5d23 (14 commits)
2019-10-17 chinmaygarde@google.com Remove incomplete static thread safety annotations. (flutter/engine#13151)
2019-10-16 garyq@google.com Add utils to disable on mac/windows, disable invalid LibLxt tests on mac (flutter/engine#13189)
2019-10-16 liyuqian@google.com Update timeout_microseconds to timeout in docs (flutter/engine#13179)
2019-10-16 chinmaygarde@google.com Use the fixtures mechanism for txt unit-tests and benchmarks. (flutter/engine#13180)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

* Test the Android embedding v2

* Update integration tests

* Split into shards

git@github.com:flutter/engine.git/compare/d4be9c1637cf...9660eddaa588

git log d4be9c1637cf..9660eddaa588 --no-merges --oneline
2019-10-16 bkonyi@google.com Roll src/third_party/dart ed1e0e199e..b28b9ae8fc (3 commits)
2019-10-16 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from oTVah... to ek5iQ... (flutter/engine#13186)
2019-10-16 jason-simmons@users.noreply.github.com Remove redundant call to updateEditingState in sendKeyEvent (flutter/engine#13175)
2019-10-16 hterkelsen@users.noreply.github.com If we get a 'down' event, add that device to the active devices. (flutter/engine#13182)
2019-10-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4e11526e3d7e..1dfc77cc08ee (9 commits) (flutter/engine#13183)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

git@github.com:flutter/engine.git/compare/43b33d743aa8...d4be9c1637cf

git log 43b33d743aa8..d4be9c1637cf --no-merges --oneline
2019-10-16 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from KVDL4... to 6j3Gw... (flutter/engine#13184)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

git@github.com:flutter/engine.git/compare/bb78551a0a3d...43b33d743aa8

git log bb78551a0a3d..43b33d743aa8 --no-merges --oneline
2019-10-16 liyuqian@google.com Revert "Update compiler to Clang 10. (#13177)" (flutter/engine#13181)
2019-10-16 chinmaygarde@google.com Update compiler to Clang 10. (flutter/engine#13177)
2019-10-16 chinmaygarde@google.com Document //flutter/runtime/dart_isolate.h (flutter/engine#13162)
2019-10-16 jason-simmons@users.noreply.github.com Fix an output file path for the frontend server package_incremental script (flutter/engine#13154)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

git@github.com:flutter/engine.git/compare/5e6c005ef1f9...bb78551a0a3d

git log 5e6c005ef1f9..bb78551a0a3d --no-merges --oneline
2019-10-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia 59e72b71b5cf..4e11526e3d7e (10 commits) (flutter/engine#13174)
2019-10-16 hterkelsen@users.noreply.github.com Fix type error in SkVertices (flutter/engine#13157)
2019-10-16 bkonyi@google.com Roll src/third_party/dart 41b65b27c2..ed1e0e199e (18 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

git@github.com:flutter/engine.git/compare/540fc977bb6b...5e6c005ef1f9

git log 540fc977bb6b..5e6c005ef1f9 --no-merges --oneline
2019-10-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia 083a75d6762c..59e72b71b5cf (1 commits) (flutter/engine#13169)
2019-10-16 a-siva@users.noreply.github.com Roll src/third_party/dart 4131d3d7c4...41b65b27c2 (28 commits) (flutter/engine#13163)
2019-10-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7274850f96f2..083a75d6762c (1 commits) (flutter/engine#13168)
2019-10-16 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 5I4Iw... to oTVah... (flutter/engine#13167)
2019-10-16 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from qpzUe... to KVDL4... (flutter/engine#13166)
2019-10-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia 634d15032d37..7274850f96f2 (3 commits) (flutter/engine#13165)
2019-10-16 yjbanov@google.com Move surface-based SceneBuilder implementation under surface/ (flutter/engine#13159)
2019-10-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia ba8752f37dab..634d15032d37 (2 commits) (flutter/engine#13164)
2019-10-16 chinmaygarde@gmail.com Revert "Issue 13238: on iOS, force an orientation change when the current orientation is not allowed" (flutter/engine#13160)
2019-10-15 chinmaygarde@google.com Roll buildroot to pull in static thread safety analysis options. (flutter/engine#13155)
2019-10-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia fb6a1abe4567..ba8752f37dab (8 commits) (flutter/engine#13156)
2019-10-15 chinmaygarde@google.com Make the Dart isolate constructor private. (flutter/engine#13153)
2019-10-15 iska.kaushik@gmail.com Revert "Upgrades the ICU version to 64.2 (#13123)" (flutter/engine#13146)
2019-10-15 1541038+josh-ksr@users.noreply.github.com Issue 13238: on iOS, force an orientation change when the current orientation is not allowed (flutter/engine#12295)
2019-10-15 chinmaygarde@google.com Allow embedders to specify a render task runner description. (flutter/engine#13124)
2019-10-15 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from Jv4XM... to 5I4Iw... (flutter/engine#13150)
2019-10-15 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from i5xD1... to qpzUe... (flutter/engine#13149)
2019-10-15 bkonyi@google.com Roll src/third_party/dart fc933312f7..4131d3d7c4 (3 commits)
2019-10-15 chinmaygarde@google.com Document //flutter/runtime/dart_vm (flutter/engine#13144)
2019-10-15 iska.kaushik@gmail.com Revert "Enable/tweak web sdk source maps (#13141)" (flutter/engine#13148)
2019-10-15 jason-simmons@users.noreply.github.com Merge the Fuchsia frontend_server build script into the new flutter_frontend_server target (flutter/engine#13145)
2019-10-15 iska.kaushik@gmail.com Add `flutter_tester` binary to the CIPD package (flutter/engine#13143)
2019-10-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia f22c57ddcc8c..fb6a1abe4567 (2 commits) (flutter/engine#13142)
2019-10-15 vsm@google.com Enable/tweak web sdk source maps (flutter/engine#13141)
2019-10-15 filmil@gmail.com Upgrades the ICU version to 64.2 (flutter/engine#13123)
2019-10-15 rmacnak@google.com [frontend_server] Include bytecode generation in the training run. (flutter/engine#13126)
2019-10-15 wvvwwvw@gmail.com Support empty strings and vectors in standard codec (flutter/engine#12974)
2019-10-15 bkonyi@google.com Roll src/third_party/dart 50f7ae9c5d..fc933312f7 (2 commits)
2019-10-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia 55f9cba6e2e7..f22c57ddcc8c (1 commits) (flutter/engine#13136)
2019-10-15 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from xRgq0... to Jv4XM... (flutter/engine#13135)
2019-10-15 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Lk7iT... to i5xD1... (flutter/engine#13134)
2019-10-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia 858cf233ef71..55f9cba6e2e7 (3 commits) (flutter/engine#13133)
2019-10-15 bkonyi@google.com Roll src/third_party/dart 70a7ef3f58..50f7ae9c5d (18 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
...

* Fix tooltip not showing when PopupMenuButton.child was non-null

So we can test SkSL precompile using the command line tools.
See https://github.com/flutter/engine/pull/12412.

The _computeChildren[Width/Height]With[Min/Max]Intrinsics methods in
RenderParagraph overwrite the text painter's placeholder dimensions
in order to compute potential widths and heights for the paragraph.

The placeholder dimensions should be restored to the values computed by
_layoutChildren before painting the text.

540fc977b Roll src/third_party/skia 7d7aaf46aeb4..858cf233ef71 (1 commits) (flutter/engine#13131) (#42706)


git@github.com:flutter/engine.git/compare/49a8e451b8dd...540fc977bb6b

git log 49a8e451b8dd..540fc977bb6b --no-merges --oneline
2019-10-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7d7aaf46aeb4..858cf233ef71 (1 commits) (flutter/engine#13131)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

git@github.com:flutter/engine.git/compare/66bf00bca361...49a8e451b8dd

git log 66bf00bca361..49a8e451b8dd --no-merges --oneline
2019-10-15 CptBlackPixel Adding deviceId to KeyEventChannel enconding method (flutter/engine#12958)
2019-10-14 47866232+chunhtai@users.noreply.github.com Enable all engine test on windows (flutter/engine#12814)
2019-10-14 devoncarew@google.com add the dart:__interceptors library to the dart sdk (flutter/engine#13125)
2019-10-14 bkonyi@google.com Roll src/third_party/dart 892fcf2c45..70a7ef3f58 (9 commits)
2019-10-14 skia-flutter-autoroll@skia.org Roll src/third_party/skia a7e1b45d9c28..7d7aaf46aeb4 (19 commits) (flutter/engine#13127)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

This optimizes certain paths in the FocusManager, FocusNode, and FocusScopeNode classes in order to fix a regression in stock_animation_open_first_frame_average when I added more focus nodes to the tree to do focus traversal.

Mainly I removed some remaining sync* iterators, and also started caching the computation of descendants and ancestors, since those are iterated over fairly often.

This improves stock_animation_open_first_frame_average by about 2.8% overall (so about half of a 4.9% regression, both averaged over 10 runs).

Addresses #42564

This disables the arrow key focus navigation for text fields. This was non-standard behavior for text fields, although it remains useful for other kinds of controls.

Fixes #42259