- 19 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so must not be null" or "so-and-so must be non-null" from the cases where those values are defines as non-nullable values. This PR removes them from the library in the repo that don't have anything to do with the framework. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 ## Tests - Documentation only change.
-
- 18 Sep, 2023 1 commit
-
-
Vasiliy Ditsyak authored
This PR fixes the issue #108614 Particularly this behaviour https://github.com/flutter/flutter/issues/108614#issuecomment-1645231915
-
- 16 Aug, 2023 1 commit
-
-
Michael Goderbauer authored
Fixes TODO in the analyzer script :)
-
- 13 Jul, 2023 1 commit
-
-
Mouad Debbar authored
- `ui_web.warmupEngine` - `ui_web.setPluginHandler` - `ui_web.debugEmulateFlutterTesterEnvironment`
-
- 06 Jun, 2023 1 commit
-
-
Mouad Debbar authored
- Use `Uri.parse()` to extract pathname. - Remove unused code from `utils.dart`. - Add test for URL encoding. (need to wait for https://github.com/flutter/flutter/pull/126851 to make it into Google3)
-
- 01 Jun, 2023 1 commit
-
-
Mouad Debbar authored
To avoid confusion and unpredictable errors (e.g. https://github.com/flutter/flutter/issues/127462), I'm adding this assert to disallow this pattern. Fixes https://github.com/flutter/flutter/issues/127462
-
- 31 May, 2023 1 commit
-
-
Mouad Debbar authored
Remove the following APIs and export them directly from `dart:ui_web`: - `urlStrategy` getter and setter - `HashUrlStrategy` - `PlatformLocation` and `BrowserPlatformLocation` (keep the façades for non-web platforms) Depends on https://github.com/flutter/engine/pull/42043 Depends on https://github.com/flutter/engine/pull/42252 Part of https://github.com/flutter/flutter/issues/126831
-
- 09 May, 2023 1 commit
-
-
Severin authored
This PR fixes the dropping of both the `path` and `search` fields from the platform location in the URL when using Flutter Web and brings it in par with similar technologies (e.g. React Router). It allows developers to keep the original path and/or search parameters in the URL, which are perfectly valid even while fragment routing is present. **Example use case:** Call a Flutter Web app with initial config parameters in the URL: `http://my-flutter.app/?skipIntro=true` **Example:** Before initial routing: `http://localhost:45389/?foo=bar` After routing: `http://localhost:45389/#/menu` After routing (with fix): `http://localhost:45389/?foo=bar#menu` Fixes #116415
-
- 05 May, 2023 1 commit
-
-
Jackson Gardner authored
This is based off (and dependent on) these changes in the web engine that expose web-specific APIs: https://github.com/flutter/engine/pull/40608
-
- 23 Feb, 2023 1 commit
-
-
Lioness100 authored
* Fix typos * lowercase animated & opacity * Undo typo fix --------- Co-authored-by:
Michael Goderbauer <goderbauer@google.com>
-
- 23 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_driver` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens_client` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_localizations` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_test` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_web_plugins` * fix comments * Use `curly_braces_in_flow_control_structures` for `packages/integration_test` * fix indentation
-
- 30 Mar, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 21 Jan, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 02 Nov, 2021 1 commit
-
-
Mouad Debbar authored
-
- 15 Oct, 2021 1 commit
-
-
Ian Hickson authored
-
- 13 Oct, 2021 1 commit
-
-
- 01 Oct, 2021 1 commit
-
-
Ian Hickson authored
-
- 14 Jun, 2021 1 commit
-
-
Greg Spencer authored
This adds avoid_dynamic_calls to the list of lints, and fixes all instances where it was violated. Importantly, this lint is NOT turned on for flutter/packages/test, because those changes are happening in another PR: #84478
-
- 02 Jun, 2021 1 commit
-
-
Anis Alibegić authored
-
- 21 May, 2021 1 commit
-
-
Ian Hickson authored
-
- 14 May, 2021 1 commit
-
-
Ian Hickson authored
-
- 13 May, 2021 1 commit
-
-
Ian Hickson authored
-
- 10 May, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 04 May, 2021 2 commits
-
-
Ian Hickson authored
- 26 Apr, 2021 1 commit
-
- 23 Apr, 2021 1 commit
-
-
Ian Hickson authored
* Migrate to ChannelBuffers.push * Move TestDefaultBinaryMessenger to its own file * Apply deprecations and fix usages
-
- 07 Apr, 2021 1 commit
-
-
Mouad Debbar authored
-
- 19 Mar, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 17 Feb, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 03 Dec, 2020 1 commit
-
-
Ian Hickson authored
In principle this is backwards compatible; I just merged all the classes into one and deprecated everything that became redundant as a result.
-
- 20 Nov, 2020 1 commit
-
-
Jonah Williams authored
-
- 14 Nov, 2020 1 commit
-
-
Jonah Williams authored
This reverts commit 8749d955.
-
- 13 Nov, 2020 1 commit
-
-
Ian Hickson authored
In principle this is backwards compatible; I just merged all the classes into one and deprecated everything that became redundant as a result.
-
- 06 Nov, 2020 1 commit
-
-
David Iglesias authored
-
- 09 Oct, 2020 1 commit
-
-
Mouad Debbar authored
-
- 07 Oct, 2020 1 commit
-
-
Jonah Williams authored
-
- 06 Oct, 2020 1 commit
-
-
Ian Hickson authored
-
- 02 Oct, 2020 1 commit
-
-
Jonah Williams authored
Force opt-in flutter test platform to null safety for repo testing
-