- 18 Aug, 2018 1 commit
-
-
Ian Hickson authored
* Fixes resulting from audit of issues links I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link. * Update run_test.dart skip this test again since it failed on linux and macos bots
-
- 20 Jun, 2018 1 commit
-
-
- 19 Jun, 2018 1 commit
-
-
Greg Spencer authored
-
- 13 Jun, 2018 1 commit
-
-
Chris Bracken authored
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly from source, flutter_platform.dart automatically runs a kernel compile when operating in Dart 2 mode, but this assumes a functional Dart SDK is available in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts directory with an empty temp dir. Remaining work is: 1. Get the frontend server building as a dependency on Fuchsia. 2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server. This also reverts migration to Dart 2 typedef syntax. This reverts commit 6c56bb24. (#18362) This reverts commit 3daebd05. (#18316)
-
- 11 Jun, 2018 1 commit
-
-
Greg Spencer authored
Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax. Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml. No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
-
- 05 Jun, 2018 2 commits
-
-
Alexandre Ardhuin authored
-
matthew-carroll authored
* Documented nested navigators in the Navigator class file (#15040).
-
- 30 May, 2018 2 commits
-
-
Greg Spencer authored
Revert "Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)" (#18041) This reverts commit 32586020.
-
Greg Spencer authored
Fixes #18028 Just changes typedef declarations, no logic changes.
-
- 03 May, 2018 1 commit
-
-
Konstantin Scheglov authored
-
- 22 Mar, 2018 1 commit
-
-
Ian Hickson authored
This is not a grand refactor yet, it's just cleaning up what we have already, so that people who keep using this API (e.g. dialogs) have something coherent to deal with. The major changes are that Navigator and NavigatorState have the same API now, that most of the examples use `<void>` instead of `<Null>`, that the navigator observer can see replaces, and that the `settings` is moved from ModalRoute to Route. I also cleaned up some of the API documentation.
-
- 07 Mar, 2018 1 commit
-
-
Josh Soref authored
* spelling: accommodate * spelling: allotted * spelling: anonymous * spelling: artificial * spelling: associated * spelling: asset * spelling: button * spelling: canvas * spelling: compatibility * spelling: coverage * spelling: condition * spelling: decoration * spelling: deferring * spelling: diameter * spelling: direction * spelling: displacement * spelling: dropdown * spelling: needing * spelling: environment * spelling: exited * spelling: expansion * spelling: explore * spelling: families * spelling: horizontal * spelling: increment * spelling: indices * spelling: internationalization * spelling: labrador * spelling: localizations * spelling: midflight * spelling: milliseconds * spelling: minimum * spelling: multiple * spelling: multiplication * spelling: navigator * spelling: overridden * spelling: package * spelling: performance * spelling: platform * spelling: porsche * spelling: position * spelling: preceded * spelling: precede * spelling: precedence * spelling: print * spelling: property * spelling: readily * spelling: reproducibility * spelling: rounded * spelling: scroll * spelling: separate * spelling: separator * spelling: services * spelling: specific * spelling: specify * spelling: synchronously * spelling: through * spelling: timeout * spelling: triangle * spelling: trivial * spelling: unusual * spelling: then * spelling: vertically * spelling: visible * spelling: visited * spelling: voice
-
- 02 Feb, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 02 Jan, 2018 1 commit
-
-
Leaf Petersen authored
* Remaining code changes for Dart 2.0 SDK roll
-
- 17 Nov, 2017 1 commit
-
-
Greg Spencer authored
I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once. This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
-
- 14 Nov, 2017 1 commit
-
-
Matt Sullivan authored
-
- 25 Oct, 2017 2 commits
-
-
Alexandre Ardhuin authored
* enable lint prefer_foreach * fix tests
-
Alexandre Ardhuin authored
-
- 23 Oct, 2017 1 commit
-
- 20 Oct, 2017 1 commit
-
-
xster authored
* Revert "BoxDecoration.borderRadius and RoundedRectangleBorder.borderRadius RTL (#12603)" This reverts commit 07908916. * Revert "Copy snapshot file into assets (#12523)" This reverts commit f6135107. * Revert "Add a rootNavigator option to Navigator.of (#12580)" This reverts commit 822084b2.
-
- 18 Oct, 2017 1 commit
-
-
xster authored
-
- 21 Sep, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 07 Aug, 2017 1 commit
-
-
Ian Hickson authored
-
- 28 Jul, 2017 1 commit
-
-
Ian Hickson authored
...and break the navigator<->routes circular dependency. This is a step towards fixing https://github.com/flutter/flutter/issues/9577 but doesn't yet do so.
-
- 21 Jul, 2017 1 commit
-
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/11323
-
- 23 Jun, 2017 1 commit
-
-
Ian Hickson authored
The main purpose of this PR is to make it so that when you set the initial route and it's a hierarchical route (e.g. `/a/b/c`), it implies multiple pushes, one for each step of the route (so in that case, `/`, `/a`, `/a/b`, and `/a/b/c`, in that order). If any of those routes don't exist, it falls back to '/'. As part of doing that, I: * Changed the default for MaterialApp.initialRoute to honor the actual initial route. * Added a MaterialApp.onUnknownRoute for handling bad routes. * Added a feature to flutter_driver that allows the host test script and the device test app to communicate. * Added a test to make sure `flutter drive --route` works. (Hopefully that will also prove `flutter run --route` works, though this isn't testing the `flutter` tool's side of that. My main concern is over whether the engine side works.) * Fixed `flutter drive` to output the right target file name. * Changed how the stocks app represents its data, so that we can show a page for a stock before we know if it exists. * Made it possible to show a stock page that doesn't exist. It shows a progress indicator if we're loading the data, or else shows a message saying it doesn't exist. * Changed the pathing structure of routes in stocks to work more sanely. * Made search in the stocks app actually work (before it only worked if we happened to accidentally trigger a rebuild). Added a test. * Replaced some custom code in the stocks app with a BackButton. * Added a "color" feature to BackButton to support the stocks use case. * Spaced out the ErrorWidget text a bit more. * Added `RouteSettings.copyWith`, which I ended up not using. * Improved the error messages around routing. While I was in some files I made a few formatting fixes, fixed some code health issues, and also removed `flaky: true` from some devicelab tests that have been stable for a while. Also added some documentation here and there.
-
- 02 Jun, 2017 1 commit
-
-
Alexandre Ardhuin authored
* preview of prefer_asserts_in_initializer_list lint * fix issue
-
- 24 May, 2017 2 commits
-
-
Hans Muller authored
-
Hans Muller authored
-
- 13 May, 2017 1 commit
-
-
Adam Barth authored
Fixes #9989
-
- 12 May, 2017 1 commit
-
-
Adam Barth authored
Previously, we would strand the old route in the overlay even though it had been removed from the history.
-
- 06 May, 2017 2 commits
-
-
Ian Hickson authored
-
Seth Ladd authored
* link more explicitly from route to navigator * fix from review
-
- 05 May, 2017 1 commit
-
-
Ian Hickson authored
-
- 25 Apr, 2017 1 commit
-
-
Adam Barth authored
This patch reworks some of the guts of scrolling to make it easier to implement nested scrolling effects. The actually nested scrolling effect will be included in a later patch.
-
- 23 Apr, 2017 1 commit
-
-
Alexandre Ardhuin authored
* more widget const constructors * prefer const constructors * address review comments
-
- 19 Apr, 2017 1 commit
-
-
Adam Barth authored
Turns out we have many immutable classes. Fixes #6892
-
- 17 Apr, 2017 1 commit
-
-
Hans Muller authored
-
- 11 Apr, 2017 1 commit
-
-
xster authored
Rename State.config to State.widget Rename State.didUpdateConfig to State.didUpdateWidget Renamed all State subclasses' local variables named config to something else
-
- 04 Apr, 2017 1 commit
-
-
Jason Simmons authored
-