Commits · 38e568e0582ae3514a38d372b592245635cab3f6 · abdullh.alsoleman / Front-End

10 Jul, 2023 17 commits

Roll Flutter Engine from 71c5674a44a5 to b328b034f07b (1 revision) (#130282) · 38e568e0

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/71c5674a44a5...b328b034f07b

2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from 7e45a9fbca5f to 03e689a0fa32 (2 revisions) (flutter/engine#43517)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

38e568e0

Roll Flutter Engine from 3beba397ca4d to 71c5674a44a5 (1 revision) (#130278) · cb91ba11

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/3beba397ca4d...71c5674a44a5

2023-07-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 4998bf65f91c to 3778952664e0 (6 revisions) (flutter/engine#43516)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cb91ba11

re-enable "Linux packages_autoroller" (#130088) · b89bfd8e

Christopher Fujino authored Jul 10, 2023

Fixes https://github.com/flutter/flutter/issues/129744

This change:

1. re-enables the Linux packages_autoroller
2. ensures we redact the token from appearing in any logs (in local testing I realized some failure logs might still expose the token)

What actually fixed authentication however was creating and uploading a new GitHub personal access token, not this change.

It's currently failing post-submit because being marked `bringup` it is running in the try pool, which does not have permissions to access the cloud KMS. However, I ran a LED build in the prod pool that succeeded:

https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/fujino_google.com/3a8f128c352fca53a9a29f1e7eab6c3ed24f3bb2a5feb196ea1a69127540e8a6/+/build.proto?server=chromium-swarm.appspot.com

b89bfd8e

Roll Flutter Engine from 1de141c6a6e7 to 3beba397ca4d (1 revision) (#130276) · 613bc890

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/1de141c6a6e7...3beba397ca4d

2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from 320f01ac1de7 to 7e45a9fbca5f (3 revisions) (flutter/engine#43515)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

613bc890

Throw error on unexpected positional arguments (#130274) · dabd7b3b

Tae Hyung Kim authored Jul 10, 2023

This PR fixes ignoring when random positional arguments added to the
`flutter gen-l10n`.

So we are no longer able to call `flutter gen-l10n hello world` or
`flutter gen-l10n --format false`.

Fixes https://github.com/flutter/flutter/issues/118203

dabd7b3b

Roll Flutter Engine from 7b826a78e73c to 1de141c6a6e7 (2 revisions) (#130275) · f731af63

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/7b826a78e73c...1de141c6a6e7

2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from 1c9e2588b577 to 320f01ac1de7 (6 revisions) (flutter/engine#43514)
2023-07-10 2539699336@qq.com [iOS][Keyboard] Reland wait vsync on UI thread and update viewport inset to avoid jitter (flutter/engine#43463)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f731af63

Change resultBundlePath representation from File to Directory (#130156) · 6c202316

Victoria Ashworth authored Jul 10, 2023

`resultBundlePath` is meant to be a directory. In the `xcodebuild --help`, it describes it as a directory: 
```
-resultBundlePath PATH     specifies the directory where a result bundle describing what occurred will be placed
```

This PR changes our usage of it from a file to a directory so that it gets deleted correctly between reruns.

Fixes https://github.com/flutter/flutter/issues/129954.

6c202316

Roll Flutter Engine from 168b68c304a5 to 7b826a78e73c (1 revision) (#130273) · 99a47c84

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/168b68c304a5...7b826a78e73c

2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from 17686918fa1f to 1c9e2588b577 (3 revisions) (flutter/engine#43513)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

99a47c84

Roll Packages from b61eea12dbf9 to 4469c5e95dd8 (15 revisions) (#130266) · 2eaec8f5

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/packages/compare/b61eea12dbf9...4469c5e95dd8

2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter from d55a7d89 to 65ff3cb9 (21 revisions) (flutter/packages#4413)
2023-07-08 stuartmorgan@google.com [tool] Update Dart SDK version (flutter/packages#4402)
2023-07-08 stuartmorgan@google.com [url_lancher] Don't use `canLaunchUrl` in Link (flutter/packages#4400)
2023-07-08 32242716+ricardoamador@users.noreply.github.com Remove unused autosubmit configuration file (flutter/packages#4410)
2023-07-07 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.5.0 to 1.6.0 in /packages/file_selector/file_selector_android/android (flutter/packages#4312)
2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter from bc49cd1b to d55a7d89 (17 revisions) (flutter/packages#4403)
2023-07-07 tarrinneal@gmail.com [shared_preferences] Variable binding in a condition requires an initializer fix (flutter/packages#4407)
2023-07-07 jhy03261997@gmail.com [go_router] implemented helpers for StatefulShellRoute (flutter/packages#4228)
2023-07-07 34871572+gmackall@users.noreply.github.com [in_app_purchase_android] Bump com.android.billingclient:billing from 5.2.0 to 6.0.0. (flutter/packages#4390)
2023-07-07 stuartmorgan@google.com [tool] Use 'flutter pub get' for Flutter packages (flutter/packages#4397)
2023-07-07 stuartmorgan@google.com [ci] Enable LUCI stable custom Linux tests (flutter/packages#4404)
2023-07-07 stuartmorgan@google.com [tool] Fix --current-package for app-facing packages (flutter/packages#4399)
2023-07-07 stuartmorgan@google.com [ci] Switch some tests to LUCI (flutter/packages#4395)
2023-07-07 tarrinneal@gmail.com [flutter_markdown] Pass parent TextStyle down to MarkdownElementBuilder.visitElementAfter (flutter/packages#4393)
2023-07-07 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.3 to 2.20.3 (flutter/packages#4394)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2eaec8f5

Fix default icon color constants reversed brightness documentation (#130231) · b828846f

Rydmike authored Jul 10, 2023

Fixes the reversed default icon color constants brightness documentation for `kDefaultIconLightColor` and `kDefaultIconDarkColor`.

FIX: https://github.com/flutter/flutter/issues/130230

b828846f

Roll Flutter Engine from 27f121896356 to 168b68c304a5 (2 revisions) (#130265) · bde20211

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/27f121896356...168b68c304a5

2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from cf3f3d048122 to 17686918fa1f (1 revision) (flutter/engine#43511)
2023-07-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from eRSQn0XKuI7byK2i_... to 4fmJ_PQoaE2L9vdx0... (flutter/engine#43510)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from eRSQn0XKuI7b to 4fmJ_PQoaE2L

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bde20211

Roll Flutter Engine from 49c6dcdac5ad to 27f121896356 (2 revisions) (#130255) · 4ca4464b

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/49c6dcdac5ad...27f121896356

2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from 0a1e7aeb29b5 to cf3f3d048122 (1 revision) (flutter/engine#43509)
2023-07-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from aQqgcKf1EwSoRWDet... to raXixVs2pKxD9ZasB... (flutter/engine#43508)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from aQqgcKf1EwSo to raXixVs2pKxD

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4ca4464b

Roll Flutter Engine from 074135bbcc61 to 49c6dcdac5ad (1 revision) (#130252) · 2fd4f8bf

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/074135bbcc61...49c6dcdac5ad

2023-07-10 robert.ancell@canonical.com Fix leak when switching channels (flutter/engine#41827)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2fd4f8bf

Roll Flutter Engine from e193c7c61bdb to 074135bbcc61 (1 revision) (#130246) · 9e76d54e

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/e193c7c61bdb...074135bbcc61

2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from a72649f13420 to 0a1e7aeb29b5 (1 revision) (flutter/engine#43505)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9e76d54e

Roll Flutter Engine from ed3c5534ac6c to e193c7c61bdb (1 revision) (#130240) · 1f2998e2

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/ed3c5534ac6c...e193c7c61bdb

2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from ab7f95f52ea6 to a72649f13420 (3 revisions) (flutter/engine#43504)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1f2998e2

Roll Flutter Engine from 09c6ce42436b to ed3c5534ac6c (1 revision) (#130238) · c565cff9

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/09c6ce42436b...ed3c5534ac6c

2023-07-10 dan@mindstab.net [linux] Allow overriding aot_library_path (flutter/engine#42555)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c565cff9

Roll Flutter Engine from 382a0be57584 to 09c6ce42436b (1 revision) (#130233) · 53452217

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/382a0be57584...09c6ce42436b

2023-07-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from E9CEA-wZJ9VgSP80c... to eRSQn0XKuI7byK2i_... (flutter/engine#43498)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from E9CEA-wZJ9Vg to eRSQn0XKuI7b

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

53452217

09 Jul, 2023 5 commits

Roll Flutter Engine from 111051e4f517 to 382a0be57584 (1 revision) (#130232) · 899ebe35

engine-flutter-autoroll authored Jul 09, 2023

https://github.com/flutter/engine/compare/111051e4f517...382a0be57584

2023-07-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from UKVzvetd5M4SA_ufb... to aQqgcKf1EwSoRWDet... (flutter/engine#43497)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from UKVzvetd5M4S to aQqgcKf1EwSo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

899ebe35

Roll Flutter Engine from 9ae623328d28 to 111051e4f517 (1 revision) (#130225) · 3ec96a8a

engine-flutter-autoroll authored Jul 09, 2023

https://github.com/flutter/engine/compare/9ae623328d28...111051e4f517

2023-07-09 skia-flutter-autoroll@skia.org Roll Skia from 05ce4af04609 to ab7f95f52ea6 (1 revision) (flutter/engine#43496)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3ec96a8a

Roll Flutter Engine from 594701beda2c to 9ae623328d28 (1 revision) (#130223) · bc5ba6bf

engine-flutter-autoroll authored Jul 09, 2023

https://github.com/flutter/engine/compare/594701beda2c...9ae623328d28

2023-07-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8X61T1htYuHQtWtFv... to E9CEA-wZJ9VgSP80c... (flutter/engine#43495)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 8X61T1htYuHQ to E9CEA-wZJ9Vg

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bc5ba6bf

Roll Flutter Engine from 958591a1c0e8 to 594701beda2c (1 revision) (#130218) · a35e42a8

engine-flutter-autoroll authored Jul 09, 2023

https://github.com/flutter/engine/compare/958591a1c0e8...594701beda2c

2023-07-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from TSpkNWkgR0F7xl8q5... to UKVzvetd5M4SA_ufb... (flutter/engine#43494)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from TSpkNWkgR0F7 to UKVzvetd5M4S

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a35e42a8

Roll Flutter Engine from 0e06562c94c3 to 958591a1c0e8 (1 revision) (#130217) · b6f0bfac

engine-flutter-autoroll authored Jul 09, 2023

https://github.com/flutter/engine/compare/0e06562c94c3...958591a1c0e8

2023-07-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Q4Oq8NRW2yeBrgy4b... to 8X61T1htYuHQtWtFv... (flutter/engine#43492)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Q4Oq8NRW2yeB to 8X61T1htYuHQ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b6f0bfac

08 Jul, 2023 10 commits

Roll Flutter Engine from 189f823e7b41 to 0e06562c94c3 (1 revision) (#130208) · 378e6648

engine-flutter-autoroll authored Jul 08, 2023

https://github.com/flutter/engine/compare/189f823e7b41...0e06562c94c3

2023-07-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 8YPOimmJgaAd5SlAT... to TSpkNWkgR0F7xl8q5... (flutter/engine#43490)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 8YPOimmJgaAd to TSpkNWkgR0F7

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

378e6648

Roll Flutter Engine from 69eb8275ce47 to 189f823e7b41 (1 revision) (#130201) · 65ff3cb9

engine-flutter-autoroll authored Jul 08, 2023

https://github.com/flutter/engine/compare/69eb8275ce47...189f823e7b41

2023-07-08 jason-simmons@users.noreply.github.com [Impeller] Check for a null command buffer in InlinePassContext::EndPass (flutter/engine#43485)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

65ff3cb9

Roll Flutter Engine from d5a35b4650b1 to 69eb8275ce47 (1 revision) (#130199) · 24082b9f

engine-flutter-autoroll authored Jul 08, 2023

https://github.com/flutter/engine/compare/d5a35b4650b1...69eb8275ce47

2023-07-08 skia-flutter-autoroll@skia.org Roll Skia from 6d733caa0d3f to 05ce4af04609 (1 revision) (flutter/engine#43489)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

24082b9f

Roll Flutter Engine from 9006633571bb to d5a35b4650b1 (1 revision) (#130197) · 7556274b

engine-flutter-autoroll authored Jul 08, 2023

https://github.com/flutter/engine/compare/9006633571bb...d5a35b4650b1

2023-07-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vee6hAD_43mq_4FS7... to Q4Oq8NRW2yeBrgy4b... (flutter/engine#43486)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from vee6hAD_43mq to Q4Oq8NRW2yeB

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7556274b

Roll Flutter Engine from 4ca619166c4a to 9006633571bb (2 revisions) (#130195) · 50d26f7a

engine-flutter-autoroll authored Jul 08, 2023

https://github.com/flutter/engine/compare/4ca619166c4a...9006633571bb

2023-07-08 dkwingsmt@users.noreply.github.com Make updating window metrics multi-view (flutter/engine#43366)
2023-07-08 dkwingsmt@users.noreply.github.com Rename default views to implicit views (flutter/engine#43364)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

50d26f7a

Roll Flutter Engine from 13d9d84e8aba to 4ca619166c4a (2 revisions) (#130191) · 74954153

engine-flutter-autoroll authored Jul 08, 2023

https://github.com/flutter/engine/compare/13d9d84e8aba...4ca619166c4a

2023-07-08 32242716+ricardoamador@users.noreply.github.com Remove unused autosubmit configuration file (flutter/engine#43483)
2023-07-07 skia-flutter-autoroll@skia.org Roll Skia from 2885452c3fb1 to 6d733caa0d3f (1 revision) (flutter/engine#43482)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

74954153

Roll Flutter Engine from 40a8732a5de0 to 13d9d84e8aba (2 revisions) (#130189) · 6a619bb3

engine-flutter-autoroll authored Jul 08, 2023

https://github.com/flutter/engine/compare/40a8732a5de0...13d9d84e8aba

2023-07-07 dworsham@google.com [fuchsia] Fix tests; remove fuchsia dart SDK deps (flutter/engine#43461)
2023-07-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from MPy31yjgPV-d_YJq0... to 8YPOimmJgaAd5SlAT... (flutter/engine#43481)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from MPy31yjgPV-d to 8YPOimmJgaAd

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6a619bb3

fix: duplicated Intellij IDE message when running flutter doctor (#129030) · 0cb6a03d

Chuan-Yen Chiang authored Jul 08, 2023

This PR fixes the duplicated message from `flutter doctor` when install `Intellij IDE` from `JetBrains Toolbox`. 

The solution is based on the #98276. Add a function to skip the creation of the validator for `Mac` when the key word `JetBrainsToolboxApp` is in the `info.plist`.

Before: 
<img width="918" alt="Screenshot 2023-06-16 at 21 04 43" src="https://github.com/flutter/flutter/assets/3291319/2f5ef0c6-0d29-4d02-97ed-257f29965a1a">

After: 
<img width="924" alt="Screenshot 2023-06-16 at 21 13 15" src="https://github.com/flutter/flutter/assets/3291319/dcdca845-41a1-4896-a5ac-5bca724af676">

fix #98276

0cb6a03d

Remove unneeded configuration file (#130183) · e3b5ae56

Ricardo Amador authored Jul 08, 2023

Remove autosubmit config files that are no longer being used. This was from a previous design and not longer used.

*List which issues are fixed by this PR. You must list at least one issue.*
Part of https://github.com/flutter/flutter/issues/130182

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

e3b5ae56

Roll Flutter Engine from 893ab3bf7bb9 to 40a8732a5de0 (1 revision) (#130186) · 99841eb7

engine-flutter-autoroll authored Jul 08, 2023

https://github.com/flutter/engine/compare/893ab3bf7bb9...40a8732a5de0

2023-07-07 skia-flutter-autoroll@skia.org Roll Skia from 93c92f97f5ab to 2885452c3fb1 (2 revisions) (flutter/engine#43478)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

99841eb7

07 Jul, 2023 8 commits

Roll Flutter Engine from b39e6fe4b3bf to 893ab3bf7bb9 (1 revision) (#130180) · 6502f46b

engine-flutter-autoroll authored Jul 07, 2023

https://github.com/flutter/engine/compare/b39e6fe4b3bf...893ab3bf7bb9

2023-07-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 0b07debd5862 to 4998bf65f91c (2 revisions) (flutter/engine#43480)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6502f46b

Roll Flutter Engine from 7c83ea3e8542 to b39e6fe4b3bf (1 revision) (#130176) · 2b649242

engine-flutter-autoroll authored Jul 07, 2023

https://github.com/flutter/engine/compare/7c83ea3e8542...b39e6fe4b3bf

2023-07-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Cfxhimvf7nMO99ky_... to vee6hAD_43mq_4FS7... (flutter/engine#43475)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Cfxhimvf7nMO to vee6hAD_43mq

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2b649242

Add a threshold when comparing screen order for selectables. (#130043) · b80bbd55

hangyu authored Jul 07, 2023

Add a threshold when comparing screen order for selectables. So when the vertical position diff is within the threshold, will compare the horizontal position.

This fixes https://github.com/flutter/flutter/issues/111021 and https://github.com/flutter/flutter/issues/127942

b80bbd55

Upgrade framework pub dependencies, roll engine with rolled dart sdk (#130163) · 3b8f6c40

Alexander Aprelev authored Jul 07, 2023

Manual roll is needed because incoming dart sdk requires updated version
vm_snapshot_analysis (>=0.7.4).


https://github.com/flutter/engine/compare/5ae09b8b4fa381e8723ed5382a26eafd0d97236f...7c83ea3e854202aea22405a947ac1b8f18c5a72c

```
7c83ea3e85 Reland "Manual roll Dart SDK from 2d98d9e27dae to 0b07debd5862 (21 revisions) (#43457)" (#43472)
9ef3e8d533 Roll Skia from 5eba922297bb to 93c92f97f5ab (2 revisions) (#43471)
```

Remove implementation of SuitePlatform from the test as well. Remove use
of fake cwd from SuitePlatform as it can't be properly faked.

3b8f6c40

Revert "[a11y] CupertinoSwitch On/Off labels" (#130166) · acb08554
Jesús S Guerrero authored Jul 07, 2023
```
Reverts flutter/flutter#127776
Currently breaking google testing
```
acb08554
Test that inspector does not hold objects. (#130102) · ce508286
Polina Cherkasova authored Jul 07, 2023

ce508286

Fix XCode download link (#129795) · 3f2d798b

Caique Ribeiro de Oliveira authored Jul 07, 2023

<img width="919" alt="image" src="https://github.com/flutter/flutter/assets/42003129/4bc8c3b8-29af-4b98-9232-47a583523e3c">
I was installing Flutter and noticed that the download link for Xcode is incorrect. They might have changed it, but the current link doesn't exist.

3f2d798b

Roll Packages from 9bcf4bfa493f to b61eea12dbf9 (1 revision) (#130154) · f2e281fb

engine-flutter-autoroll authored Jul 07, 2023

https://github.com/flutter/packages/compare/9bcf4bfa493f...b61eea12dbf9

2023-07-07 aam@google.com Roll pigeon dependency to unblock flutter framework deps roll (flutter/packages#4383)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f2e281fb