- 23 Aug, 2023 16 commits
-
-
Michael Goderbauer authored
Blocking issue (https://github.com/dart-lang/linter/issues/453) for this lint has been resolved.
-
chunhtai authored
Since applink validation tool is going to be a static tool, It won't have access to vmservices. [flutter.dev/go/static-tooling-in-devtools](http://flutter.dev/go/static-tooling-in-devtools) I remove the vm services and also update the deeplink task to also include path pattern and custom scheme http://go/android-applink-apis (internal only)
-
Reid Baker authored
fixes #133119 Similar to https://github.com/flutter/flutter/issues/131006 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing.
-
Christopher Fujino authored
Fixes https://github.com/flutter/flutter/issues/133093 When I introduced the new, more robust version file `//flutter/bin/cache/version.json` in https://github.com/flutter/flutter/pull/124558, I changed `class FlutterVersion` into an abstract interface, implemented by `_FlutterVersionFromGit` (which is essentially the previous behavior) and `_FlutterVersionFromFile`, which merely reads the data it would have computed via git from `//flutter/bin/cache/version.json`. While doing this, I made `_FlutterVersionFromGit.ensureVersionFile()` to be a no-op, since I assumed this would not be necessary since we already had a version file in the cache. However, this method was what was previously responsible for ensuring `//flutter/version` existed on disk. This means that if, for whatever reason, the user had `//flutter/bin/cache/flutter.version.json` present but NOT `//flutter/version`, the tool would have never created that file, and they would hit the tool crash seen in https://github.com/flutter/flutter/issues/133093. This fixes the tool by ensuring `//flutter/version` exists regardless of if we're hydrating `FlutterVersion` from `//flutter/bin/cache/flutter.version.json` or not.
-
Michael Goderbauer authored
Part of https://github.com/flutter/flutter/issues/133171. Removes from `TestWindow`: * `localeTestValue` * `clearLocaleTestValue` * `localesTestValue` * `clearLocalesTestValue` * `initialLifecycleStateTestValue` * `alwaysUse24HourFormatTestValue` * `clearAlwaysUse24HourTestValue` * `brieflyShowPasswordTestValue` * `defaultRouteNameTestValue` * `clearDefaultRouteNameTestValue` * `semanticsEnabledTestValue` * `clearSemanticsEnabledTestValue` * `accessibilityFeaturesTestValue` * `clearAccessibilityFeaturesTestValue` These properties have reached the end of their deprecation period.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ac352ba95f43...58dc868c26cb 2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from 2111e8126c08 to 5428f147e632 (2 revisions) (flutter/engine#45008) 2023-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DoQ8KUxSk-5EU6VQ1... to vJ6oaubpqgRM2nb1e... (flutter/engine#45005) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from DoQ8KUxSk-5E to vJ6oaubpqgRM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Mouad Debbar authored
This became unnecessary since https://github.com/flutter/flutter/pull/132087
-
Jackson Gardner authored
This makes two changes to prepare for incoming changes to skwasm in the web engine: * We will (at least for now) be depending on the `WebAssembly.Function` constructor in `skwasm`, which is hidden behind the `--experimental-wasm-type-reflection` flag. We need to pass that when running skwasm benchmarks. * We are going to be upgrading the skwasm build to a newer version of emscripten, which exposes the wasm exports via the `wasmExports` property instead of the `asm` property. Make sure to support either, if passed.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/72a06427bd37...ac352ba95f43 2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from d0c369eaa637 to 2111e8126c08 (1 revision) (flutter/engine#45002) 2023-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VSvpNFoFjqXIQTcs6... to -HcyJtxGxUDcqX-jo... (flutter/engine#44999) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from VSvpNFoFjqXI to -HcyJtxGxUDc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/c730a90f2fcc...3060b1aec99c 2023-08-23 ian@hixie.ch [rfw] Support web (as JS) (flutter/packages#4650) 2023-08-22 84124091+opxdelwin@users.noreply.github.com [webview_flutter] Update sample code. (flutter/packages#4727) 2023-08-22 ctrysbita@outlook.com [flutter_adaptive_scaffold] Fix top padding for NavigationBar (flutter/packages#4661) 2023-08-22 31859944+LongCatIsLooong@users.noreply.github.com Remove deprecated `ImageProvider` methods (flutter/packages#4725) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7d56840865d2...72a06427bd37 2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from ee7404db8273 to d0c369eaa637 (1 revision) (flutter/engine#44997) 2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from d0d2b7042bb9 to ee7404db8273 (1 revision) (flutter/engine#44995) 2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from eac8f8ea2660 to d0d2b7042bb9 (1 revision) (flutter/engine#44994) 2023-08-23 zanderso@users.noreply.github.com Revert "FontVariation.lerp, custom FontVariation constructors, and more documentation" (flutter/engine#44993) 2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from aa208c8a2d60 to eac8f8ea2660 (1 revision) (flutter/engine#44992) 2023-08-23 dkwingsmt@users.noreply.github.com Move Rasterizer::Draw's discard_callback to Delegate (flutter/engine#44813) 2023-08-23 ian@hixie.ch FontVariation.lerp, custom FontVariation constructors, and more documentation (flutter/engine#43750) 2023-08-23 ian@hixie.ch Make web tests start with an empty title (flutter/engine#43846) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
Manual roll requested by zra@google.com https://github.com/flutter/engine/compare/b190f9015049...7d56840865d2 2023-08-23 zanderso@users.noreply.github.com Revert "Roll Dart SDK from ab417bc74bb1 to c162b4979562 (1 revision)" (flutter/engine#44989) 2023-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from G25oJMO5jbUi-UN4F... to DoQ8KUxSk-5EU6VQ1... (flutter/engine#44988) 2023-08-23 zanderso@users.noreply.github.com Revert "Make `FontWeight` an enum, Remove unused text classes" (flutter/engine#44987) 2023-08-23 skia-flutter-autoroll@skia.org Roll Dart SDK from ab417bc74bb1 to c162b4979562 (1 revision) (flutter/engine#44986) 2023-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kKI09su99b0AKs8b3... to VSvpNFoFjqXIQTcs6... (flutter/engine#44984) 2023-08-23 matanlurey@users.noreply.github.com Enable clang-tidy for pre-push (opt-out), exclude `performance-unnecessary-value-param` (flutter/engine#44936) 2023-08-22 john@johnmccutchan.com Restore old SurfaceTextureExternal drawing code (flutter/engine#44979) 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from d0918de21c1a to aa208c8a2d60 (2 revisions) (flutter/engine#44981) 2023-08-22 jason-simmons@users.noreply.github.com Initialize the texture destruction callback in the Metal embedder test harness (flutter/engine#44973) 2023-08-22 matanlurey@users.noreply.github.com Further filter/clear `<SkPaint>.setDither(true)`, this time in `DlSkPaintDispatchHelper` (flutter/engine#44912) 2023-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 3ebf0fedfceb to ab417bc74bb1 (1 revision) (flutter/engine#44977) 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from bf6019be75ef to d0918de21c1a (3 revisions) (flutter/engine#44975) 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from c675298ddeda to bf6019be75ef (3 revisions) (flutter/engine#44974) 2023-08-22 31859944+LongCatIsLooong@users.noreply.github.com Make `FontWeight` an enum, Remove unused text classes (flutter/engine#44960) 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from 9f4b81aac175 to c675298ddeda (2 revisions) (flutter/engine#44971) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from kKI09su99b0A to VSvpNFoFjqXI fuchsia/sdk/core/mac-amd64 from G25oJMO5jbUi to DoQ8KUxSk-5E If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Ian Hickson authored
-
Ian Hickson authored
-
Zachary Anderson authored
-
Polina Cherkasova authored
-
- 22 Aug, 2023 24 commits
-
-
Jonah Williams authored
Reverts flutter/flutter#133083 failing on cocoapods: ``` [2023-08-22 16:28:37.783355] [STDOUT] stdout: [ ] Error output from CocoaPods: [2023-08-22 16:28:37.783379] [STDOUT] stdout: â³ [2023-08-22 16:28:37.783402] [STDOUT] stdout: [ ] [!] The version of CocoaPods used to generate the lockfile (1.12.1) is higher than the version of the current executable (1.11.3). Incompatibility issues may arise. [2023-08-22 16:28:37.783423] [STDOUT] stdout: [2023-08-22 16:28:37.783445] [STDOUT] stdout: [!] Automatically assigning platform `iOS` with version `11.0` on target `Runner` because no platform was specified. Please specify a platform for this target in your Podfile. See `https://guides.cocoapods.org/syntax/podfile.html#platform`. [2023-08-22 16:28:37.783469] [STDOUT] stdout: [2023-08-22 16:28:37.784059] [STDOUT] stderr: [ ] Error: CocoaPods's specs repository is too out-of-date to satisfy dependencies. [2023-08-22 16:28:37.784102] [STDOUT] stderr: To update the CocoaPods specs, run: [2023-08-22 16:28:37.784126] [STDOUT] stderr: pod repo update [2023-08-22 16:28:37.784147] [STDOUT] stderr: ``` https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20new_gallery_ios__transition_perf/10590/overview
-
Jonah Williams authored
This shrinks the size of the reply image attachments which should make it easier to find the actionable issues in https://github.com/flutter/flutter/issues/132690
-
Taha Tesser authored
Related https://github.com/flutter/flutter/issues/131676 ## Description #### Fix default input text style for `DropdownMenu`  ### Fix default text style for `MenuAnchor`'s menu items (which `DropdownMenu` uses for menu items)  ### Default `DropdownMenu` Input text style  ### Default `DropdownMenu` menu item text style  ### Default `MenuAnchor` menu item text style  ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; /// Flutter code sample for [DropdownMenu]s. The first dropdown menu has an outlined border. void main() => runApp(const DropdownMenuExample()); class DropdownMenuExample extends StatefulWidget { const DropdownMenuExample({super.key}); @override State<DropdownMenuExample> createState() => _DropdownMenuExampleState(); } class _DropdownMenuExampleState extends State<DropdownMenuExample> { final TextEditingController colorController = TextEditingController(); final TextEditingController iconController = TextEditingController(); ColorLabel? selectedColor; IconLabel? selectedIcon; @override Widget build(BuildContext context) { final List<DropdownMenuEntry<ColorLabel>> colorEntries = <DropdownMenuEntry<ColorLabel>>[]; for (final ColorLabel color in ColorLabel.values) { colorEntries.add( DropdownMenuEntry<ColorLabel>( value: color, label: color.label, enabled: color.label != 'Grey'), ); } final List<DropdownMenuEntry<IconLabel>> iconEntries = <DropdownMenuEntry<IconLabel>>[]; for (final IconLabel icon in IconLabel.values) { iconEntries .add(DropdownMenuEntry<IconLabel>(value: icon, label: icon.label)); } return MaterialApp( theme: ThemeData( useMaterial3: true, colorSchemeSeed: Colors.green, // textTheme: const TextTheme( // bodyLarge: TextStyle( // fontWeight: FontWeight.bold, // fontStyle: FontStyle.italic, // decoration: TextDecoration.underline, // ), // ), ), home: Scaffold( body: SafeArea( child: Column( children: <Widget>[ const Text('DropdownMenus'), Padding( padding: const EdgeInsets.symmetric(vertical: 20), child: Row( mainAxisAlignment: MainAxisAlignment.center, children: <Widget>[ DropdownMenu<ColorLabel>( controller: colorController, label: const Text('Color'), dropdownMenuEntries: colorEntries, onSelected: (ColorLabel? color) { setState(() { selectedColor = color; }); }, ), const SizedBox(width: 20), DropdownMenu<IconLabel>( controller: iconController, enableFilter: true, leadingIcon: const Icon(Icons.search), label: const Text('Icon'), dropdownMenuEntries: iconEntries, inputDecorationTheme: const InputDecorationTheme( filled: true, contentPadding: EdgeInsets.symmetric(vertical: 5.0), ), onSelected: (IconLabel? icon) { setState(() { selectedIcon = icon; }); }, ), ], ), ), const Text('Plain TextFields'), Padding( padding: const EdgeInsets.symmetric(vertical: 20), child: Row( mainAxisAlignment: MainAxisAlignment.center, children: <Widget>[ SizedBox( width: 150, child: TextField( controller: TextEditingController(text: 'Blue'), decoration: const InputDecoration( suffixIcon: Icon(Icons.arrow_drop_down), labelText: 'Color', border: OutlineInputBorder(), )), ), const SizedBox(width: 20), SizedBox( width: 150, child: TextField( controller: TextEditingController(text: 'Smile'), decoration: const InputDecoration( prefixIcon: Icon(Icons.search), suffixIcon: Icon(Icons.arrow_drop_down), filled: true, labelText: 'Icon', )), ), ], ), ), if (selectedColor != null && selectedIcon != null) Row( mainAxisAlignment: MainAxisAlignment.center, children: <Widget>[ Text( 'You selected a ${selectedColor?.label} ${selectedIcon?.label}'), Padding( padding: const EdgeInsets.symmetric(horizontal: 5), child: Icon( selectedIcon?.icon, color: selectedColor?.color, ), ) ], ) else const Text('Please select a color and an icon.') ], ), ), ), ); } } enum ColorLabel { blue('Blue', Colors.blue), pink('Pink', Colors.pink), green('Green', Colors.green), yellow('Yellow', Colors.yellow), grey('Grey', Colors.grey); const ColorLabel(this.label, this.color); final String label; final Color color; } enum IconLabel { smile('Smile', Icons.sentiment_satisfied_outlined), cloud( 'Cloud', Icons.cloud_outlined, ), brush('Brush', Icons.brush_outlined), heart('Heart', Icons.favorite); const IconLabel(this.label, this.icon); final String label; final IconData icon; } ``` </details>
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/28b8bd5d5d91...b190f9015049 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from 50814d9ca5bb to 9f4b81aac175 (1 revision) (flutter/engine#44969) 2023-08-22 mdebbar@google.com [web] Move remaining web-only APIs to `dart:ui_web` (flutter/engine#44516) 2023-08-22 flar@google.com Revert "Split DisplayListBuilder into DlCanvas optimizer and DlOp recorder classes" (flutter/engine#44968) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Taha Tesser authored
fixes [Long `FlexibleSpaceBar.title` doesn't respect the leading widget ](https://github.com/flutter/flutter/issues/132030) ### Description - This adds `FlexibleSpaceBarSettings.hasLeading` for the `FlexibleSpaceBar`'s title to respect the leading widget. - Use the new `FlexibleSpaceBarSettings.hasLeading` property in the `SliverAppBar` for its `FlexibleSpaceBar`. ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, theme: ThemeData( useMaterial3: true, brightness: Brightness.dark, ), home: const Example(), ); } } class Example extends StatelessWidget { const Example({super.key}); @override Widget build(BuildContext context) { return Scaffold( body: Column( mainAxisAlignment: MainAxisAlignment.center, children: [ const Text('TargetPlatform.Android'), Theme( data: Theme.of(context).copyWith( platform: TargetPlatform.android, ), child: Container( height: 250, padding: const EdgeInsets.all(8), decoration: BoxDecoration( border: Border.all( color: Colors.amber, width: 4, ), ), child: const AppBarLeading( showLeading: true, showTitle: false, ), ), ), const Text('TargetPlatform.iOS'), Theme( data: Theme.of(context).copyWith( platform: TargetPlatform.iOS, ), child: Container( height: 250, padding: const EdgeInsets.all(8), decoration: BoxDecoration( border: Border.all( color: Colors.amber, width: 2, ), ), child: const AppBarLeading( showLeading: true, showTitle: false, ), ), ), ], ), ); } } class AppBarLeading extends StatelessWidget { const AppBarLeading({ super.key, required this.showLeading, required this.showTitle, }); final bool showLeading; final bool showTitle; @override Widget build(BuildContext context) { return Scaffold( drawer: const Drawer(), body: CustomScrollView( slivers: [ SliverAppBar( automaticallyImplyLeading: showLeading, iconTheme: const IconThemeData( color: Colors.amber, ), title: showTitle ? const Text('AppBar') : null, flexibleSpace: FlexibleSpaceBar( title: Text('Title ' * 15), // centerTitle: true, ), toolbarHeight: showTitle ? 170 : 100, ), ], ), ); } } ``` </details> ### Before  ### After 
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/21437d384b56...28b8bd5d5d91 2023-08-22 reidbaker@google.com i82973 scroll mouse wheel support (flutter/engine#44724) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/090754879679...21437d384b56 2023-08-22 30870216+gaaclarke@users.noreply.github.com [Impeller] Tiny optimizations for text rendering (avoiding extra ops and copies). (flutter/engine#44822) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Ivan Inozemtsev authored
Otherwise when tests use `expectLater(getBytesOrNull(), matchesGoldenFile(...))`, they may fail in sound null safety mode and pass in weak null safety mode. Fixes https://github.com/flutter/flutter/issues/132964
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/e26f3b9374d0...c730a90f2fcc 2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter from 5e6d88d7 to 54c98d74 (24 revisions) (flutter/packages#4754) 2023-08-22 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.5 to 1.13.7 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4736) 2023-08-21 engine-flutter-autoroll@skia.org Roll Flutter from 6f227c07 to 5e6d88d7 (8 revisions) (flutter/packages#4751) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ff375bf5d8eb...090754879679 2023-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from ecb1e3aecfbb to 3ebf0fedfceb (1 revision) (flutter/engine#44962) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Zachary Anderson authored
For the engine roll presubmit failure in https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20build_tests_3_3/10805/overview
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c5e0152b01f4...ff375bf5d8eb 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from eff8446c42f8 to 50814d9ca5bb (1 revision) (flutter/engine#44958) 2023-08-22 brianosman@google.com Add missing GrVkTypes include (flutter/engine#44957) 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from a548d28072ce to eff8446c42f8 (2 revisions) (flutter/engine#44955) 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from b3b8f3332cce to a548d28072ce (3 revisions) (flutter/engine#44953) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Justin McCandless authored
Diposes some restorable variables that weren't disposed before.
-
Victoria Ashworth authored
Re-enables Xcode Debug tests (still in bringup). It also has them use an older version of Xcode that is compatible with the host OS. Fixes https://github.com/flutter/flutter/issues/132309.
-
Zachary Anderson authored
Fixes https://github.com/flutter/flutter/issues/133051
-
Polina Cherkasova authored
This PR replaces some `testWidgets` with `testWidgestsWithLeakTracking`.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f5f099a4a5e3...c5e0152b01f4 2023-08-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DA_PryqcVU6Um3j2k... to G25oJMO5jbUi-UN4F... (flutter/engine#44951) 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from bf08da24a261 to b3b8f3332cce (1 revision) (flutter/engine#44952) 2023-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 00f6f69187df to ecb1e3aecfbb (1 revision) (flutter/engine#44950) 2023-08-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RVhmZNTYsaIiTyjwP... to kKI09su99b0AKs8b3... (flutter/engine#44949) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from RVhmZNTYsaIi to kKI09su99b0A fuchsia/sdk/core/mac-amd64 from DA_PryqcVU6U to G25oJMO5jbUi If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/447981acbf36...f5f099a4a5e3 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from f13ee6ee5433 to bf08da24a261 (1 revision) (flutter/engine#44946) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/5e84d733ef67...447981acbf36 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from 399e90397a07 to f13ee6ee5433 (1 revision) (flutter/engine#44944) 2023-08-22 leroux_bruno@yahoo.fr [Linux] Expose channel buffers 'resize' and 'overflow' control commands (flutter/engine#44636) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e183e8a94093...5e84d733ef67 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from 14e7b3b2d660 to 399e90397a07 (1 revision) (flutter/engine#44943) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/454e0e35f8e4...e183e8a94093 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from 9ecdc9265aaa to 14e7b3b2d660 (1 revision) (flutter/engine#44942) 2023-08-22 bdero@google.com [Impeller] Supply a text backend to the AiksContext at runtime. (flutter/engine#44884) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/857840db5574...454e0e35f8e4 2023-08-22 matanlurey@users.noreply.github.com Disallow using ./tools/gn --enable-unittests --android (or --ios) (flutter/engine#44930) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/1ab054967c1d...857840db5574 2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from 40442138ec94 to 9ecdc9265aaa (1 revision) (flutter/engine#44939) 2023-08-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from aXDvHIK6XMKTHieu_... to DA_PryqcVU6Um3j2k... (flutter/engine#44938) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from aXDvHIK6XMKT to DA_PryqcVU6U If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/5a292e42a593...1ab054967c1d 2023-08-22 chinmaygarde@google.com [Impeller] Document rendering backend selection on Android. (flutter/engine#44933) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
