1. 16 Jan, 2019 23 commits
  2. 15 Jan, 2019 14 commits
  3. 14 Jan, 2019 3 commits
    • Justin McCandless's avatar
      InputDecorator Count Widget (#25095) · de2470ff
      Justin McCandless authored
      * Allow a widget to be specified for the textfield count, and allow no count at all
      
      * Test all possible states for counter and counterText
      
      * Docs for counter
      
      * counter is a function that generates a widget
      
      * Tests use counter as function
      
      * Fix analyze error in docs
      
      * InputDecoration has counter widget, TextField has buildCounter function
      
      * InputDecorator tests expect counter to be widget again and include
      buildCounter
      
      * counter widget example that might actually fit
      
      * Clarify accessiblity concerns in docs
      
      * Include isFocused param for accessibility
      
      * Fix analyze error
      
      * Improve docs per code review
      
      * Rearrange getEffectiveDecoration a bit for clarity
      
      * Fix analyze error about hashValues params
      
      * Clean up docs and redundant code per code review
      
      * Code review doc improvement
      
      * Automatically wrap buildCounter widget in a Semantics widget for accessibility
      de2470ff
    • Greg Spencer's avatar
      Narrow regexp for import search in bot's analyze script. (#26539) · 35fcd907
      Greg Spencer authored
      This was causing analysis to fail when there was an import statement in a comment, such as when snippets add imports to their examples.
      
      I narrowed the RegExp to match only those lines which aren't commented out, but it really should probably be using the analysis server to catch all cases (e.g. if someone put the doc comment into /** */ comments, it could still match). Since this is a Flutter-specific script, it's probably not worth doing that.
      35fcd907
    • Ian Hickson's avatar