- 23 Feb, 2023 28 commits
-
-
David Neuy authored
Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props. (#114338) * Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props. * Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props - add tests. * Fix analysis errors * Review changes. * Add asserts for dataRowMinHeight and dataRowMaxHeight * Add asserts for dataRowMinHeight and dataRowMaxHeight * Make dataRowHeight a computed getter * Remove get only dataRowHeight from hashCode... * Update deprecated after * Add new line at end of AUTHORS * Apply suggestions from code review * Update packages/flutter/test/material/data_table_test.dart --------- Co-authored-by: Kate Lovett <katelovett@google.com>
-
Greg Price authored
Fixes #109675. This formula would produce an initial velocity quite different from the one specified as an argument. To update the test, I computed the expected results separately by using the physical formula. Happily, the framework by default never ends up actually exercising this code. Of the four SpringDescription call sites within the framework, two are explicitly overdamped; the other two are by design critically damped, but due to rounding they end up being treated as (very slightly) overdamped too. Details here: https://github.com/flutter/flutter/issues/109675#issuecomment-1423674855 So the only way an app could be affected by this bug is if it called a SpringDescription constructor itself, and managed to create a spring description where the distinguishing formula in _SpringSolution comes out exactly equal to zero. It's likely nobody has ever shipped such an app, because the behavior this produces would be so wildly wrong that it'd be hard to miss when exercised. Co-authored-by: Kate Lovett <katelovett@google.com>
-
Flutter GitHub Bot authored
-
Flutter GitHub Bot authored
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
-
engine-flutter-autoroll authored
* e7d34e1e8 Roll Skia from 69f83e81ef3f to a321a8750271 (2 revisions) (flutter/engine#39819) * b4b4c15d3 Roll Fuchsia Mac SDK from xFmgbl9L7nOoL8W-w... to OCFfGKefENe8lYAwM... (flutter/engine#39820)
-
chunhtai authored
* Fix text.rich to merge widget span * migrate to new API * update * addressing comment * addressing comments * update * addressing comment * Update
-
Taha Tesser authored
Fix `SliverAppBar.medium` & `SliverAppBar.large` title overlap with leading/actions widgets, leading width, and title spacing (#120780) * Fix `SliverAppBar.medium` & `SliverAppBar.large` title overlap with leading/actions widgets, leading width, and title spacing * Add `titleSpacing` theme tests and consolidate multiple tests for the same widgets
-
engine-flutter-autoroll authored
-
engine-flutter-autoroll authored
c87028288 Roll Fuchsia Linux SDK from 0RfFdaUCok_sFfUN1... to 69m3Jn73L34XwlsWH... (flutter/engine#39761) (#121332)
-
Eilidh Southren authored
* remove newline * update crswap * add const constructor * update const
-
engine-flutter-autoroll authored
* 952a89b4b [Impeller] Wire up a playground that can run Dart (flutter/engine#39805) * d4bae2887 [Impeller] Add PolygonMode to render layer (flutter/engine#39810)
-
Bruno Leroux authored
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
-
engine-flutter-autoroll authored
34794638c Roll Skia from 149bb820e0c3 to 69f83e81ef3f (2 revisions) (flutter/engine#39815) (#121316)
-
engine-flutter-autoroll authored
-
engine-flutter-autoroll authored
74eb9be55 Roll Skia from fa36bb160826 to 29fc6cac02f5 (3 revisions) (flutter/engine#39812) (#121308)
-
engine-flutter-autoroll authored
* 41d6f3bb7 Roll Skia from f163f6ed5db0 to fa36bb160826 (2 revisions) (flutter/engine#39811) * 26971ae36 Roll Fuchsia Mac SDK from cGa3bk2BmrHL_waB8... to xFmgbl9L7nOoL8W-w... (flutter/engine#39808)
-
engine-flutter-autoroll authored
* 00f2a3861 Deprecate WindowPadding (flutter/engine#39775) * 4c6c259ba Roll Skia from 335cabcf8b99 to 080897012390 (4 revisions) (flutter/engine#39802) * e1c327750 Roll Skia from 080897012390 to f163f6ed5db0 (1 revision) (flutter/engine#39806) * c4577135b [iOS][Text Input] Avoid crash when its UIViewController.view is nil. (flutter/engine#39768)
-
Todd Volkert authored
* Add ResizeImage.policy This adds a new `ResizeImage.policy` property that controls how `ResizeImage` will interpret its `width` and `height` properties. The existing behavior is preserved via `ResizeImagePolicy.exact` (default), but there is now the option to use `ResizeImagePolicy.fit`, which satisfies the use case outlined in flutter/flutter#118543. The API doc assets were added in flutter/assets-for-api-docs#209 Fixes flutter/flutter#118543 * Docuemnt public member * Remove protected annotation from overrides - was failing tests * Fixed analysis of code in Dartdoc * More dartdoc code analysis fixes * One more fix * Review comments
-
suragch authored
* Remove obsolete comment The method `_stopCursorTimer` no longer exists. * Add edited comment back in Addresses these comments: - https://github.com/flutter/flutter/pull/120265#discussion_r1101673834 - https://github.com/flutter/flutter/pull/120265#discussion_r1102120022 --------- Co-authored-by: Kate Lovett <katelovett@google.com>
-
codiss authored
* Fixed Material3 TabBarTheme.dividerColor not working * Add 'Material3 - TabBar inherits the dividerColor of TabBarTheme' test --------- Co-authored-by: Kate Lovett <katelovett@google.com>
-
Michael Goderbauer authored
-
Michael Goderbauer authored
-
Greg Spencer authored
* Add getInheritedWidgetOfExactType to BuildContext * Use the new API in all the places * Fix doc error * Review Changes
-
Christopher Fujino authored
Co-authored-by: Ricardo Amador <32242716+ricardoamador@users.noreply.github.com>
-
David Skelly authored
* add padding param to DropdownButton * improve padding comment * update test * Add more context to documentation * update padding documentation with more detail --------- Co-authored-by: Kate Lovett <katelovett@google.com>
-
Tomasz Gucio authored
-
engine-flutter-autoroll authored
* 0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine#39727) * f0e5c08f7 [platform_view] fix overlapping platform view not touchable (flutter/engine#39527) * 03b5998b4 Roll Fuchsia Mac SDK from 25mb67G0L_sZ_OQCC... to dj-2XkYHvZUsqlZTc... (flutter/engine#39782) * 2e5b1bf04 Updated the wide-gamut constant and added a unit test for it. (flutter/engine#39776) * 1ce93ca0a Roll Dart SDK from 0db7573c6b70 to c9a4fd7fd7fa (1 revision) (flutter/engine#39783) * 8368fb5b6 Roll Dart SDK from c9a4fd7fd7fa to 5003b952affb (1 revision) (flutter/engine#39787) * ee5ea205b Roll Dart SDK from 5003b952affb to 6f5df63655ad (1 revision) (flutter/engine#39790) * d9be356a8 Roll Fuchsia Mac SDK from dj-2XkYHvZUsqlZTc... to cGa3bk2BmrHL_waB8... (flutter/engine#39791) * 50af61302 [web] Add `dart:js_interop` to BUILD.gn. (flutter/engine#39792) * eb5e5624d [common] Use FML macro to prevent copy/assignment (flutter/engine#39786) * 6acfddc78 Add more log when receiving semantics node not part of update (flutter/engine#39777) * 336e7ce63 Roll Skia from 22b594afb4d3 to 78bad646fe78 (24 revisions) (flutter/engine#39793) * e65391f8b [Impeller] Add root dockspace to playgrounds (flutter/engine#39789) * 3848f6429 [Impeller] ensure glyph type contributes to FontGlyphPair hash/eq (flutter/engine#39794) * cb1ef6f08 Roll Skia from 78bad646fe78 to 335cabcf8b99 (2 revisions) (flutter/engine#39795) * ac6129db2 made opaque wide gamut images take up 32 bits per pixel (flutter/engine#39691) * c74a4bc67 save/restore around clipping the (potentially cached) frame canvas (flutter/engine#39797) * ed3f15d94 [Embedder API] Add CODEOWNERS (flutter/engine#39784) * 1a3bddcc1 Fix a race in ShellTest.PushBackdropFilterToVisitedPlatformViews (flutter/engine#39798) * 137caa761 Roll Dart SDK from 6f5df63655ad to 602941be8007 (2 revisions) (flutter/engine#39800)
-
Casey Hillers authored
Revert "Speed up first asset load by using the binary-formatted asset manifest for image resolution (#118782)" (#121220) This reverts commit e3db0488.
-
- 22 Feb, 2023 6 commits
-
-
Ricardo Amador authored
* Update jdk in cirrus dockerfile image. * Update to install jaxb for jdk11. Hopefully this works. * Add jaxb to classpath * Classpath was not set in run * Update to use newer tools * typo * Update path to commandline tools. * Trying different approach * Wrong path * Wrong path * Wrong path * Wrong path * Remove debug statements
-
Casey Hillers authored
This reverts commit 7ba44065.
-
Michael Goderbauer authored
* Rename WindowPadding to ViewPadding * dart fix * typos
-
Mushaheed Syed authored
* Add ActionButtonIconsData for overriding action icons * Fix formatting issues * Add missing exports in material library and add copyWith method in ActionButtonIconsData * Move all action buttons, and icons to action_buttons.dart * Rename actionButtonIcons to actionIconTheme * Refactor buttons in action_buttons.dart to extend a private class for common implementation * Refactor icons in action_buttons * Fix docs in action_buttons_theme * Fix #107646 always use 'Icons.arrow_back' as a back_button icon in web * Update documentation for action buttons and add style parameter to every action button * Fix analyzer warnings * Add missing style argument in IconButton of _ActionButton * Add tests for action buttons, action icon theme, drawer buttons, and back buttons * Add example (+test) for action icon button's action icon theme in examples/api * Fix analysis errors * Add missing license header in action_icon_theme.0.dart * Fix deprecation notice in theme_data.dart * Update theme data tests for actionIconTheme * Remove iconSize parameter from ActionButtons and update docs * Fix failing tests * Update button color during backbutton tests to red * Fix analytics issues * Fix format
-
Ricardo Amador authored
-
gaaclarke authored
* Added negative test and blur test to the wide gamut tests. * switched back to dstOver * fixed blur test * analysis warnings * analyzer
-
- 21 Feb, 2023 6 commits
-
-
suragch authored
* fix spelling typo * _index not nullable This address the comment here: https://github.com/flutter/flutter/pull/120062#issuecomment-1421424676
-
Jessica Pereira authored
* fix license page rtl * fix editor spacings, tests to lateral view * fix defaultSize and setSurfaceSize * add validation for packageList position * fix spacing * simplify align
-
Kate Lovett authored
-
engine-flutter-autoroll authored
-
David Iglesias authored
* Allow any JS file in flutter loader. * Nag only if service worker API is completely unavailable. * Add info about Secure Contexts if that may be the reason why serviceworker is not available. * Update sanity test. * If service worker settings are null, do not even check if the API is available.
-
engine-flutter-autoroll authored
* 068670a1f Roll Dart SDK from 12aec0627d0a to 0db7573c6b70 (2 revisions) (flutter/engine#39774) * 40f60b92b Roll Skia from a16472080754 to 22b594afb4d3 (2 revisions) (flutter/engine#39773)
-