Commits · 367203b3011fc1752cfa1f51adf9751d090c94e6 · abdullh.alsoleman / Front-End

15 Sep, 2023 11 commits

Makes scheme and target optional parameter when getting universal lin… (#134571) · 367203b3

chunhtai authored Sep 15, 2023

â¦k settings

the show build settings xcode command can only accept one of the target or scheme flag. Therefore I make them optional.

367203b3

Dispose layers in test. (#134802) · f629dc87
Polina Cherkasova authored Sep 15, 2023

f629dc87

[Windows_android channels_integration_test] Column -> ListView (#134836) · ec471480

LongCatIsLooong authored Sep 15, 2023

This should fix https://github.com/flutter/flutter/issues/134636. 

The column can get really tall, especially when there's line wrapping. This is the layout on a tablet, so on a motor g4 this column is likely going to overflow.

```
     RenderParagraph#66251 relayoutBoundary=up3
â creator: RichText â Text-[<'status'>] â Column â
â   FutureBuilder<TestStepResult> â Padding â
â   KeyedSubtree-[GlobalKey#0f29e] â _BodyBuilder â MediaQuery â
â   LayoutId-[<_ScaffoldSlot.body>] â CustomMultiChildLayout â
â   _ActionsScope â Actions â â¯
|  parentData: offset=Offset(0.0, 600.0); flex=null; fit=null
```

![flutter_01](https://github.com/flutter/flutter/assets/31859944/5e700d21-3c5e-4990-bfb5-153f44f1c517)

ec471480

moved hello_world_impeller to a 7pro (#134830) · 43260cce

gaaclarke authored Sep 15, 2023

arm64 is necessary for this test

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

43260cce

Speed up native assets target (#134523) · 8ebb8d4f

Daco Harkes authored Sep 15, 2023

Speeds up the native assets target in the backend by

1. changing other targets `gen_dart_plugin_registrant` and
`release_unpack_ios` to do async I/O,
2. not reparsing the package config, and
3. not calling `dart pub deps --json` for 0 or 1 packages (fixed
package:native_assets_builder).

* https://github.com/flutter/flutter/issues/134427

```
           [   +2 ms] native_assets: Starting due to {}
           [   +2 ms] Skipping target: gen_localizations
           [   +1 ms] gen_dart_plugin_registrant: Starting due to {InvalidatedReasonKind.inputChanged: The following inputs have updated contents: /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/package_config_subset}
           [  +33 ms] gen_dart_plugin_registrant: Complete
           [ +107 ms] release_unpack_ios: Complete
           [  +60 ms] Writing native_assets.yaml.
           [   +7 ms] Writing /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/flutter_build/be2692bbfbc0b9a27fcd2422d52354c6/native_assets.yaml done.
           [        ] native_assets: Complete
```

->

```
           [   +4 ms] native_assets: Starting due to {}
           [        ] Skipping target: gen_localizations
           [   +1 ms] gen_dart_plugin_registrant: Starting due to {InvalidatedReasonKind.inputChanged: The following inputs have updated contents: /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/package_config_subset}
           [  +31 ms] Writing native_assets.yaml.
           [   +8 ms] Writing /Users/dacoharkes/flt/engine/flutter/examples/hello_world/.dart_tool/flutter_build/f9451a65a465bfab70d004e21d6cc1d6/native_assets.yaml done.
           [   +1 ms] native_assets: Complete
```

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.


<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

8ebb8d4f

Date picker dialog state should dispose members. (#134804) · 72b69f94
Polina Cherkasova authored Sep 15, 2023

72b69f94

Roll Packages from 275b76ccffa5 to bc8c2f20910b (7 revisions) (#134823) · 0b9551e6

engine-flutter-autoroll authored Sep 15, 2023

https://github.com/flutter/packages/compare/275b76ccffa5...bc8c2f20910b

2023-09-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.6 to 2.21.7 (flutter/packages#4930)
2023-09-14 stuartmorgan@google.com [ios_platform_images] Add extension tests (flutter/packages#4925)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2524052335ec to 367f9ea16bfa (3 revisions) (flutter/packages#4929)
2023-09-14 stuartmorgan@google.com [ci] Enable ios_platform_images tests (flutter/packages#4920)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.5 to 2.21.6 (flutter/packages#4922)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter from 61b890bf to 58ba6c29 (16 revisions) (flutter/packages#4928)
2023-09-14 43054281+camsim99@users.noreply.github.com Manual Roll of Flutter from 4e7a07af to 61b890bf (flutter/packages#4919)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0b9551e6

Fix navigation rail hover misplaced when direction is RTL and extended is true (#134815) · 2a7ad01e

Bruno Leroux authored Sep 15, 2023

## Description

This PR fixes `NavigationRail` hover position when text direction is set to RTL and `NavigationRail.extended` is true.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/134361.

## Tests

Adds 1 test.

2a7ad01e

Applied the logo to the Discord badge. (#134339) · 0b540a87

K9i - Kota Hayashi authored Sep 15, 2023

Before
<img width="414" alt="image" src="https://github.com/flutter/flutter/assets/90010509/af386804-a8a2-43b9-a7fd-6e79df400734">

After

<img width="412" alt="image" src="https://github.com/flutter/flutter/assets/90010509/5e289946-7690-414a-8ff0-9abeb861842b">

0b540a87

Fix memory leak in ListWheelScrollView (#134732) · 09acfe63
Kostia Sokolovskyi authored Sep 15, 2023

09acfe63
Move two tests on Pixel 7 from staging to prod (#134784) · 1e4a1be6
Zachary Anderson authored Sep 15, 2023
```
Related https://github.com/flutter/flutter/issues/134698
```
1e4a1be6

14 Sep, 2023 19 commits

Roll Flutter Engine from 683bca53d4d7 to 45bc4307cda3 (2 revisions) (#134789) · 0f4ca515

engine-flutter-autoroll authored Sep 14, 2023

https://github.com/flutter/engine/compare/683bca53d4d7...45bc4307cda3

2023-09-14 goderbauer@google.com Enable private field promotion (flutter/engine#45722)
2023-09-14 bdero@google.com [Impeller] Add Entity::RenderingMode enum. (flutter/engine#45845)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0f4ca515

[web] provide serviceWorkerVersion to the getNewServiceWorker function (#131240) · 783f2f48

Pavel Mazhnik authored Sep 14, 2023

Fixes https://github.com/flutter/flutter/issues/130212

Fix `Unresolved variable or type 'serviceWorkerVersion'` in the `_getNewServiceWorker` function.

Supersedes https://github.com/flutter/flutter/pull/130206

783f2f48

Roll Flutter Engine from 3a3a2807c3b6 to 683bca53d4d7 (3 revisions) (#134778) · 98bee677

engine-flutter-autoroll authored Sep 14, 2023

https://github.com/flutter/engine/compare/3a3a2807c3b6...683bca53d4d7

2023-09-14 bdero@google.com [Impeller] Assert IMPELLER_ENABLE_3D when importing scene_contents.h. (flutter/engine#45848)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 0f003d5748bc to 6bc9f5886ddf (2 revisions) (flutter/engine#45847)
2023-09-14 bdero@google.com [Impeller] Add AbsorbOpacity enum. (flutter/engine#45838)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

98bee677

Roll Flutter Engine from 035932d64017 to 3a3a2807c3b6 (5 revisions) (#134769) · ab715b20

engine-flutter-autoroll authored Sep 14, 2023

https://github.com/flutter/engine/compare/035932d64017...3a3a2807c3b6

2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 9bdf01416042 to 0f003d5748bc (4 revisions) (flutter/engine#45841)
2023-09-14 jacksongardner@google.com Declare the js context as nullable in skwasm surface callback (flutter/engine#45810)
2023-09-14 matanlurey@users.noreply.github.com [Impeller] Release a texture during Playground teardown (flutter/engine#45832)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 87025d1e162c to 9bdf01416042 (1 revision) (flutter/engine#45835)
2023-09-14 matanlurey@users.noreply.github.com Make `fml::ScopedCleanupClosure` `std::move`-able and add unit tests. (flutter/engine#45772)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ab715b20

Allows page removal that contains Localhistoryentry (#134757) · 0e521942

chunhtai authored Sep 14, 2023

fixes https://github.com/flutter/flutter/issues/97836
fixes https://github.com/flutter/flutter/issues/134752
fixes https://github.com/flutter/flutter/issues/118645

0e521942

Roll Flutter Engine from e0b5b6c4eb76 to 035932d64017 (2 revisions) (#134763) · 6ec1ff23

engine-flutter-autoroll authored Sep 14, 2023

https://github.com/flutter/engine/compare/e0b5b6c4eb76...035932d64017

2023-09-14 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 1ee7ef8bbc65 to d25e8d682c8f (22 revisions) (flutter/engine#45836)
2023-09-14 godofredoc@google.com Update webdriver imports. (flutter/engine#45816)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6ec1ff23

Cover more test/widgets tests with leak tracking #3 (#134576) · ff10c52a
Kostia Sokolovskyi authored Sep 14, 2023

ff10c52a

Roll Flutter Engine from 2cd34d23c1a2 to e0b5b6c4eb76 (2 revisions) (#134755) · ba233b8a

engine-flutter-autoroll authored Sep 14, 2023

https://github.com/flutter/engine/compare/2cd34d23c1a2...e0b5b6c4eb76

2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 54253f58533d to 87025d1e162c (1 revision) (flutter/engine#45833)
2023-09-14 bdero@google.com [Impeller] Incorporate filters in subpass coverage. (flutter/engine#45778)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ba233b8a

Set xcode version to older compatible version for microbenchmarks_ios_xcode_debug test (#134693) · eb4b97d6

Victoria Ashworth authored Sep 14, 2023

Test added in https://github.com/flutter/flutter/pull/134493 requires an
older version of Xcode because default version of Xcode is not
compatible with macOS version in CI.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

eb4b97d6

Cover some Services tests with leak tracing (#134381) · 54673633
derdilla authored Sep 14, 2023

54673633

Roll Flutter Engine from 4160ebacdae2 to 2cd34d23c1a2 (18 revisions) (#134749) · d2ff2417

engine-flutter-autoroll authored Sep 14, 2023

https://github.com/flutter/engine/compare/4160ebacdae2...2cd34d23c1a2

2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 91d5a781ebaf to 54253f58533d (2 revisions) (flutter/engine#45829)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 08fb9768d1b8 to 91d5a781ebaf (3 revisions) (flutter/engine#45828)
2023-09-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from f4jtyOMeNSKGqqI4y... to FF4r9-tqhioBbRG9f... (flutter/engine#45827)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 45ba26fae9cd to 08fb9768d1b8 (2 revisions) (flutter/engine#45825)
2023-09-14 godofredoc@google.com Fix script (flutter/engine#45598)
2023-09-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5aKvHj_QcSHJkbWjr... to MzLcTzBiWJ7o3Q2_Z... (flutter/engine#45823)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 4bb29f80ed43 to 45ba26fae9cd (1 revision) (flutter/engine#45821)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump html from 0.15.0 to 0.15.4 in /lib/web_ui (flutter/engine#45819)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 5ff47ea11c13 to 4bb29f80ed43 (1 revision) (flutter/engine#45818)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from 5f18d2ead8c8 to 5ff47ea11c13 (1 revision) (flutter/engine#45815)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from b2a4969c7782 to 5f18d2ead8c8 (2 revisions) (flutter/engine#45814)
2023-09-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gHhOd3d6V3Zv6CzK2... to f4jtyOMeNSKGqqI4y... (flutter/engine#45813)
2023-09-14 skia-flutter-autoroll@skia.org Roll Skia from ad51509c8e3f to b2a4969c7782 (3 revisions) (flutter/engine#45812)
2023-09-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ftcEc93bjtc0q2a6s... to 5aKvHj_QcSHJkbWjr... (flutter/engine#45808)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump uuid from 3.0.6 to 4.0.0 in /lib/web_ui (flutter/engine#45794)
2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from 5c7d604c81b0 to ad51509c8e3f (1 revision) (flutter/engine#45802)
2023-09-13 jacksongardner@google.com Compile a platform dill for dart2wasm (flutter/engine#45797)
2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from a30fbf83f2e9 to 5c7d604c81b0 (2 revisions) (flutter/engine#45800)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ftcEc93bjtc0 to MzLcTzBiWJ7o
fuchsia/sdk/core/mac-amd64 from gHhOd3d6V3Zv to FF4r9-tqhioB

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d2ff2417

🐛 Setup color tween for `RefreshIndicator` in a better way (#134492) · 5c09ccad
Alex Li authored Sep 14, 2023
```
Fixes https://github.com/flutter/flutter/issues/134489.
```
5c09ccad

Fix NavigationRail hover misplaced when using large icons (#134719) · 9fa09ea4

Bruno Leroux authored Sep 14, 2023

## Description

This PR fixes `NavigationRail` hover position when using enlarged icons whose size is specified using `NavigationRailThemeData.selectedIconTheme` and `NavigationRailThemeData.unselectedIconTheme`.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/133799.

## Tests

Adds 1 test, updates 1 test (to replace some magic numbers).

9fa09ea4

Roll Flutter Engine from cd90cc8469fb to 4160ebacdae2 (5 revisions) (#134695) · 63f25b0d

engine-flutter-autoroll authored Sep 14, 2023

https://github.com/flutter/engine/compare/cd90cc8469fb...4160ebacdae2

2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from b38989859b81 to a30fbf83f2e9 (3 revisions) (flutter/engine#45796)
2023-09-13 49699333+dependabot[bot]@users.noreply.github.com Bump quiver from 3.0.0 to 3.2.1 in /lib/web_ui (flutter/engine#45792)
2023-09-13 49699333+dependabot[bot]@users.noreply.github.com Bump http from 0.13.5 to 1.1.0 in /lib/web_ui (flutter/engine#45791)
2023-09-13 49699333+dependabot[bot]@users.noreply.github.com Bump archive from 3.1.2 to 3.3.9 in /lib/web_ui (flutter/engine#45795)
2023-09-13 mdebbar@google.com [web] Use DOM to render paragraphs with letter spacing (flutter/engine#45651)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

63f25b0d

Added a devicelab test for vulkan validation layers (#134685) · 57ad4ff0

gaaclarke authored Sep 14, 2023

This makes sure validation layers are being used and that there are no
validation errors

fixes https://github.com/flutter/flutter/issues/134175

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

57ad4ff0

Roll Packages from 06cd9e967b9f to 275b76ccffa5 (1 revision) (#134734) · 58ba6c29

engine-flutter-autoroll authored Sep 14, 2023

https://github.com/flutter/packages/compare/06cd9e967b9f...275b76ccffa5

2023-09-13 kevmoo@users.noreply.github.com go_router_builder: support the latest pkg:analyzer (flutter/packages#4921)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

58ba6c29

Update plugin_ffi generated file to match FFIgen 9.0.0 (#134614) · 77a5a5d3

Daco Harkes authored Sep 14, 2023

Template plugin_ffi uses FFIgen and generates both the FFIgen inputs and the generated file.

We rolled FFIgen to 9.0.0 in https://github.com/flutter/flutter/pull/130494, which means a slight change to the generated file.

* https://github.com/dart-lang/ffigen/issues/619

Note, because of https://github.com/flutter/flutter/issues/105695, we run the test on the FFIgen repo rather than on the flutter CI.

77a5a5d3

LinkedText (Linkify) (#125927) · 4db47db1
Justin McCandless authored Sep 14, 2023
```
New LinkedText widget and TextLinker class for easily adding hyperlinks to text.
```
4db47db1
_DayPicker should build days using separate stetefull widget _Day. (#134607) · ee9aef01
Polina Cherkasova authored Sep 14, 2023
```
Fixes https://github.com/flutter/flutter/issues/134323
```
ee9aef01

13 Sep, 2023 10 commits

Remove `Path.combine` call from `CupertionoTextSelectionToolbar` (#134369) · b2f3404c

LongCatIsLooong authored Sep 13, 2023

Hopefully this fixes https://github.com/flutter/flutter/issues/110076 by removing the `Path.combine` call. Not sure how I can verify in a test that `Path.combine` is not called.

b2f3404c

Update KeepAlive.debugTypicalAncestorWidgetClass (#133498) · 2ea9edc1
Kate Lovett authored Sep 13, 2023

2ea9edc1

Fix null check crash by ReorderableList (#132153) · b4953c37

Delwin Mathew authored Sep 13, 2023

Fix issue where if you drag the last element of `ReorderableList` and put it in the same index, a `Null check` error arises. This happens as index in `_items` is out of bounds (when `reverse: true`). Fix is to check if last element, dragged element and drop index is same, and return as nothing has changed. Find this video attached.

https://github.com/flutter/flutter/assets/84124091/8043cac3-eb08-42e1-87e7-8095ecab09dc

Fixes issue #132077

b4953c37

Roll Flutter Engine from 154d6fd601a3 to cd90cc8469fb (3 revisions) (#134691) · a80af67a

engine-flutter-autoroll authored Sep 13, 2023

https://github.com/flutter/engine/compare/154d6fd601a3...cd90cc8469fb

2023-09-13 godofredoc@google.com Update dependabot.yml (flutter/engine#45788)
2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from e39cf360ea93 to b38989859b81 (4 revisions) (flutter/engine#45787)
2023-09-13 109111084+yaakovschectman@users.noreply.github.com Use `start` instead of `extent` for Windows IME cursor position (flutter/engine#45667)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a80af67a

Bump github/codeql-action from 2.21.5 to 2.21.6 (#134692) · 04ad1da1

dependabot[bot] authored Sep 13, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.5 to 2.21.6.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.21.6 - 13 Sep 2023</h2>
<ul>
<li>Better error message when there is a failure to determine the merge base of the code to analysis. <a href="https://redirect.github.com/github/codeql-action/pull/1860">#1860</a></li>
<li>Improve the calculation of default amount of RAM used for query execution on GitHub Enterprise Server. This now reduces in proportion to the runner's total memory to better account for system memory usage, helping to avoid out-of-memory failures on larger runners. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/1866">#1866</a></li>
<li>Enable improved file coverage information for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/1867">#1867</a></li>
<li>Update default CodeQL bundle version to 2.14.4. <a href="https://redirect.github.com/github/codeql-action/pull/1873">#1873</a></li>
</ul>
<h2>2.21.5 - 28 Aug 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.3. <a href="https://redirect.github.com/github/codeql-action/pull/1845">#1845</a></li>
<li>Fixed a bug in CodeQL Action 2.21.3 onwards that affected beta support for <a href="https://projectlombok.org/">Project Lombok</a> when analyzing Java. The environment variable <code>CODEQL_EXTRACTOR_JAVA_RUN_ANNOTATION_PROCESSORS</code> will now be respected if it was manually configured in the workflow. <a href="https://redirect.github.com/github/codeql-action/pull/1844">#1844</a></li>
<li>Enable support for Kotlin 1.9.20 when running with CodeQL CLI v2.13.4 through v2.14.3. <a href="https://redirect.github.com/github/codeql-action/pull/1853">#1853</a></li>
</ul>
<h2>2.21.4 - 14 Aug 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.2. <a href="https://redirect.github.com/github/codeql-action/pull/1831">#1831</a></li>
<li>Log a warning if the amount of available disk space runs low during a code scanning run. <a href="https://redirect.github.com/github/codeql-action/pull/1825">#1825</a></li>
<li>When downloading CodeQL bundle version 2.13.4 and later, cache these bundles in the Actions tool cache using a simpler version number. <a href="https://redirect.github.com/github/codeql-action/pull/1832">#1832</a></li>
<li>Fix an issue that first appeared in CodeQL Action v2.21.2 that prevented CodeQL invocations from being logged. <a href="https://redirect.github.com/github/codeql-action/pull/1833">#1833</a></li>
<li>We are rolling out a feature in August 2023 that will improve the quality of file coverage information. <a href="https://redirect.github.com/github/codeql-action/pull/1835">#1835</a></li>
</ul>
<h2>2.21.3 - 08 Aug 2023</h2>
<ul>
<li>We are rolling out a feature in August 2023 that will improve multi-threaded performance on larger runners. <a href="https://redirect.github.com/github/codeql-action/pull/1817">#1817</a></li>
<li>We are rolling out a feature in August 2023 that adds beta support for <a href="https://projectlombok.org/">Project Lombok</a> when analyzing Java. <a href="https://redirect.github.com/github/codeql-action/pull/1809">#1809</a></li>
<li>Reduce disk space usage when downloading the CodeQL bundle. <a href="https://redirect.github.com/github/codeql-action/pull/1820">#1820</a></li>
</ul>
<h2>2.21.2 - 28 Jul 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.1. <a href="https://redirect.github.com/github/codeql-action/pull/1797">#1797</a></li>
<li>Avoid duplicating the analysis summary within the logs. <a href="https://redirect.github.com/github/codeql-action/pull/1811">#1811</a></li>
</ul>
<h2>2.21.1 - 26 Jul 2023</h2>
<ul>
<li>Improve the handling of fatal errors from the CodeQL CLI. <a href="https://redirect.github.com/github/codeql-action/pull/1795">#1795</a></li>
<li>Add the <code>sarif-output</code> output to the analyze action that contains the path to the directory of the generated SARIF. <a href="https://redirect.github.com/github/codeql-action/pull/1799">#1799</a></li>
</ul>
<h2>2.21.0 - 19 Jul 2023</h2>
<ul>
<li>CodeQL Action now requires CodeQL CLI 2.9.4 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.20.4. <a href="https://redirect.github.com/github/codeql-action/pull/1724">#1724</a></li>
</ul>
<h2>2.20.4 - 14 Jul 2023</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/701f152f28d4350ad289a5e31435e9ab6169a7ca"><code>701f152</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1875">#1875</a> from github/update-v2.21.6-6a6a82470</li>
<li><a href="https://github.com/github/codeql-action/commit/1b6299040ad80bda41f4a39badd92c941bb4f691"><code>1b62990</code></a> Fix misplaced changelog entry</li>
<li><a href="https://github.com/github/codeql-action/commit/5462f691537a95d1496acdc934d234930f8300bb"><code>5462f69</code></a> Update changelog for v2.21.6</li>
<li><a href="https://github.com/github/codeql-action/commit/6a6a824702bd1d44a92996212781e3a602e71d70"><code>6a6a824</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1873">#1873</a> from github/update-bundle/codeql-bundle-v2.14.4</li>
<li><a href="https://github.com/github/codeql-action/commit/88c7a5c4ccbf66f35fe5cb09c52cbd1c28618a67"><code>88c7a5c</code></a> Add changelog note</li>
<li><a href="https://github.com/github/codeql-action/commit/da650354980b498016b5c3d94088fccf593a40ba"><code>da65035</code></a> Update default bundle to codeql-bundle-v2.14.4</li>
<li><a href="https://github.com/github/codeql-action/commit/43750fe4fc4f068f04f2215206e6f6a29c78c763"><code>43750fe</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1872">#1872</a> from github/henrymercer/user-errors-for-upload-sarif</li>
<li><a href="https://github.com/github/codeql-action/commit/a7c12a522555ecd630965e7f80e9e3dc35dc0268"><code>a7c12a5</code></a> Address PR comments</li>
<li><a href="https://github.com/github/codeql-action/commit/7218de5369ba3e5f3959e134631f2af1f41079f9"><code>7218de5</code></a> Merge branch 'main' into henrymercer/user-errors-for-upload-sarif</li>
<li><a href="https://github.com/github/codeql-action/commit/4764dce02f71916cc65cfef3af053e331cc6831c"><code>4764dce</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1866">#1866</a> from github/henrymercer/enable-scaling-reserved-ram-...</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/00e563ead9f72a8461b24876bee2d0c2e8bd2ee8...701f152f28d4350ad289a5e31435e9ab6169a7ca">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.21.5&new-version=2.21.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

04ad1da1

Roll Flutter Engine from b71b366e3de3 to 154d6fd601a3 (6 revisions) (#134683) · 5243d18e

engine-flutter-autoroll authored Sep 13, 2023

https://github.com/flutter/engine/compare/b71b366e3de3...154d6fd601a3

2023-09-13 godofredoc@google.com Auto update dependencies for web_ui. (flutter/engine#45754)
2023-09-13 30870216+gaaclarke@users.noreply.github.com Revert "[Impeller] Patch the compiler to account for subpass inputs and PSO metadata." (flutter/engine#45777)
2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from 471216072c74 to e39cf360ea93 (4 revisions) (flutter/engine#45776)
2023-09-13 chinmaygarde@google.com [Impeller] Remove dependency on //flutter/vulkan and use a single proc table. (flutter/engine#45741)
2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from 78d18d509475 to 471216072c74 (4 revisions) (flutter/engine#45774)
2023-09-13 47866232+chunhtai@users.noreply.github.com [Impeller] Fixes stroke path geometry that can draw outside of path if the path ends at sharp turn. (flutter/engine#45252)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5243d18e

[flutter_tools] Run ShutdownHooks when handling signals (#134590) · 3d7cd359

Christopher Fujino authored Sep 13, 2023

Fixes https://github.com/flutter/flutter/issues/134566.

Prior to this fix, `ShutdownHooks` were run in the private helper
function `_exit()` defined in the `package:flutter_tools/runner.dart`
library. Independent of this, the tool had signal handling logic that
traps SIGINT and SIGTERM. However, these handlers called `exit()` from
`dart:io`, and didn't run these hooks.

This PR moves the `_exit()` private helper to
`package:flutter_tools/src/base/process.dart` and renames it to
`exitWithHooks()`, so that it can be called by the signal handlers in
`package:flutter_tools/src/base/signals.dart`.

3d7cd359

Dispose routes in navigator when throwing exception (#134596) · ab1b865e

hangyu authored Sep 13, 2023

fixes: #133695
## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

ab1b865e

[framework] reduce ink sparkle uniform count. (#133897) · 2daf9177

Jonah Williams authored Sep 13, 2023

Fixes https://github.com/flutter/flutter/issues/133325

Due to the number of uniforms present, the ink_sparkle shader can't run without post processing (on all target platforms) that the impellerc offline compiler doesn't perform. However, we can't just move the uniforms into a uniform buffer object (UBO) because the Skia backend doesn't support it.

Rather than work around this in the compiler, we can reduce the uniform count by 1) packing four floats into a single vec4 2) removing a uniform for what is effectively a constant.

This should have no visible effects, and if any scubas fail it means I did this wrong ð

2daf9177

Roll Flutter Engine from 5e671d5c90f9 to b71b366e3de3 (4 revisions) (#134676) · 12261f98

engine-flutter-autoroll authored Sep 13, 2023

https://github.com/flutter/engine/compare/5e671d5c90f9...b71b366e3de3

2023-09-13 matanlurey@users.noreply.github.com Do not run real processes in `clang_tidy_test.dart` (flutter/engine#45748)
2023-09-13 30870216+gaaclarke@users.noreply.github.com [Impeller] Adds test to verify wide gamut indexed png decompression fix for Skia. (flutter/engine#45399)
2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from 284c333d7eb2 to 78d18d509475 (2 revisions) (flutter/engine#45769)
2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from 3ff43577d04b to 284c333d7eb2 (1 revision) (flutter/engine#45768)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

12261f98