1. 19 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must be non-null' and 'must not be null' comments from non-framework libraries (#134994) · 4ce7fdd9
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so must not be null" or "so-and-so must be non-null" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the library in the repo that don't have anything to do with the framework.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134984
      - https://github.com/flutter/flutter/pull/134991
      - https://github.com/flutter/flutter/pull/134992
      - https://github.com/flutter/flutter/pull/134993
      
      ## Tests
       - Documentation only change.
      4ce7fdd9
  2. 05 Sep, 2023 1 commit
  3. 10 Aug, 2023 1 commit
  4. 28 Jun, 2023 1 commit
  5. 08 May, 2023 1 commit
  6. 20 Jan, 2023 1 commit
  7. 02 Sep, 2022 1 commit
  8. 25 May, 2022 1 commit
    • Pierre-Louis's avatar
      Use `curly_braces_in_flow_control_structures` for non-`flutter` packages (#104629) · 74cfc3db
      Pierre-Louis authored
      * Use `curly_braces_in_flow_control_structures` for `packages/flutter_driver`
      
      * Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens`
      
      * Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens_client`
      
      * Use `curly_braces_in_flow_control_structures` for `packages/flutter_localizations`
      
      * Use `curly_braces_in_flow_control_structures` for `packages/flutter_test`
      
      * Use `curly_braces_in_flow_control_structures` for `packages/flutter_web_plugins`
      
      * fix comments
      
      * Use `curly_braces_in_flow_control_structures` for `packages/integration_test`
      
      * fix indentation
      74cfc3db
  9. 30 Mar, 2022 1 commit
  10. 03 Feb, 2022 1 commit
  11. 21 Jan, 2022 1 commit
  12. 29 Jul, 2021 1 commit
  13. 28 Jul, 2021 1 commit
  14. 27 Jul, 2021 1 commit
  15. 15 Jul, 2021 1 commit
  16. 14 Jul, 2021 3 commits
  17. 13 Jul, 2021 2 commits
  18. 02 Jun, 2021 1 commit
    • Tong Mu's avatar
      Test WidgetTester handling test pointers (#83337) · e3da1bd7
      Tong Mu authored
      Adds tests to the following behaviors, which have existed without tests:
      
      - When tapping during live testing, a message is printed with widgets that contain the tap location.
      - When tapping during live testing, a mark is displayed on screen on the tap location.
      e3da1bd7
  19. 13 May, 2021 1 commit
  20. 29 Jan, 2021 1 commit
  21. 05 Oct, 2020 1 commit
  22. 01 Oct, 2020 3 commits
    • Dan Field's avatar
      Revert dispose images when done (#67100) · 473358d9
      Dan Field authored
      * Revert "docs for image disposal (#67066)"
      
      This reverts commit bcb2ac5a.
      
      * Revert "Dispose of images after using them (#66688)"
      
      This reverts commit a7954691.
      473358d9
    • Dan Field's avatar
      Dispose of images after using them (#66688) · a7954691
      Dan Field authored
      * Dispose of images after using them
      Adds ImageInfo.clone, ImageInfo.dispose, and ImageInfo.isCloneOf.
      Makes all stateful holders of ui.Image objects properly clone and dispose of them.
      Behavior change for ImageStreamCompleter: Removing the last listener after registering at least one listener results in the object being disposed, and new listeners cannot be added, unless a keepAlive handle is created.
      Makes all non-stateful holders of ui.Image (i.e. paintImage and RawImage) assert that whoever gave the image to them has not disposed it on them.
      a7954691
    • Michael Goderbauer's avatar
      Migrate flutter_test (#66663) · 19e07d2b
      Michael Goderbauer authored
      19e07d2b
  23. 28 Jul, 2020 1 commit
  24. 14 May, 2020 1 commit