- 19 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so must not be null" or "so-and-so must be non-null" from the cases where those values are defines as non-nullable values. This PR removes them from the library in the repo that don't have anything to do with the framework. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 ## Tests - Documentation only change.
-
- 05 Sep, 2023 1 commit
-
-
Tong Mu authored
This PR adds `AnimationSheetRecorder.dispose`, which disposes all the images generated by the recorder, eliminating leaks. Fixes https://github.com/flutter/flutter/issues/133071.
-
- 10 Aug, 2023 1 commit
-
-
Michael Goderbauer authored
Fixes https://github.com/flutter/flutter/issues/132274.
-
- 28 Jun, 2023 1 commit
-
-
pdblasi-google authored
Removes deprecated APIs from AnimationBuilder. Resolves #129653
-
- 08 May, 2023 1 commit
-
-
Michael Goderbauer authored
Fixes https://github.com/flutter/flutter/issues/126096. Fixes https://github.com/flutter/flutter/issues/126097. Fixes https://github.com/flutter/flutter/issues/126102. Fixes https://github.com/flutter/flutter/issues/126098. Fixes https://github.com/flutter/flutter/issues/126147. Work towards https://github.com/flutter/flutter/issues/126100. Does not fix the OverlyEntry/ModalRoute leak (https://github.com/flutter/flutter/issues/126100).
-
- 20 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 02 Sep, 2022 1 commit
-
-
Pierre-Louis authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_driver` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens_client` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_localizations` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_test` * Use `curly_braces_in_flow_control_structures` for `packages/flutter_web_plugins` * fix comments * Use `curly_braces_in_flow_control_structures` for `packages/integration_test` * fix indentation
-
- 30 Mar, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 03 Feb, 2022 1 commit
-
-
Ian Hickson authored
-
- 21 Jan, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 29 Jul, 2021 1 commit
-
- 28 Jul, 2021 1 commit
-
- 27 Jul, 2021 1 commit
-
-
Tong Mu authored
-
- 15 Jul, 2021 1 commit
-
- 14 Jul, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 31de052e.
-
Ian Hickson authored
-
- 13 Jul, 2021 2 commits
-
-
Ian Hickson authored
This reverts commit e2490f29.
-
Ian Hickson authored
-
- 02 Jun, 2021 1 commit
-
-
Tong Mu authored
Adds tests to the following behaviors, which have existed without tests: - When tapping during live testing, a message is printed with widgets that contain the tap location. - When tapping during live testing, a mark is displayed on screen on the tap location.
-
- 13 May, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 29 Jan, 2021 1 commit
-
-
Yegor authored
-
- 05 Oct, 2020 1 commit
-
-
Dan Field authored
* Reland dispose images when done (#67100) Changes since last time: - Test for CanvasKit image rendering (https://github.com/flutter/flutter/pull/67176) - Fix CanvasKit dispose impl (https://github.com/flutter/engine/pull/21555) - Update internal google3 customer with a problematic ImageStream Listener impl (cl/335091311, cl/335459002) This reverts commit 473358d9.
-
- 01 Oct, 2020 3 commits
-
-
Dan Field authored
* Dispose of images after using them Adds ImageInfo.clone, ImageInfo.dispose, and ImageInfo.isCloneOf. Makes all stateful holders of ui.Image objects properly clone and dispose of them. Behavior change for ImageStreamCompleter: Removing the last listener after registering at least one listener results in the object being disposed, and new listeners cannot be added, unless a keepAlive handle is created. Makes all non-stateful holders of ui.Image (i.e. paintImage and RawImage) assert that whoever gave the image to them has not disposed it on them.
-
Michael Goderbauer authored
- 28 Jul, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 14 May, 2020 1 commit
-
-
Tong Mu authored
-