- 07 Jun, 2023 1 commit
-
-
fzyzcjy authored
Close https://github.com/flutter/flutter/issues/126303 When I encounter bugs in production environment saying null pointer error on `return _size!`, I wish I could know more information! However, currently the information is revealed by `assert(hasSize, 'RenderBox was not laid out: $this');`, thus *only* in debug mode can I know what is `this` (and/or more information that can be added), while in release mode I can only see a stack trace saying it is `RenderBox.size` that throws - nothing more :/ Therefore, it is intuitive to add this extra information in release mode. However, will it affect performance? We all know this is in critical path and should be quite careful. Thus I did some experiments: https://godbolt.org/z/zPPPf5969 From my naive understanding of assembly, the two versions of code (`size!` vs `size ?? throw`) has the same assembly, except that they throw different types of errors. In other words, when there is no error, both code should be equivalent; when there is an error, surely the new code will be slower since it calls `this.toString()`, but the error handling process is rare and already heavy, so this is not a problem. 
-
- 06 Jun, 2023 22 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ca499463ec2e...6f9df0f988c1 2023-06-06 mdebbar@google.com [web] Remove /#/ from home page URL (flutter/engine#42598) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Khanh Nguyen authored
The old Draggable video had a mistake in it, we've since uploaded a newer version that's been corrected. Thanks for catching that @gspencergoog! - [na] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [na] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [na] I listed at least one issue that this PR fixes in the description above. - [na] I added new tests to check the change I am making, or this PR is [test-exempt]. - [na] All existing and new tests are passing.
-
LongCatIsLooong authored
Add the conditional rounding that I forgot to add in https://github.com/flutter/flutter/pull/127099
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/4571695f9e76...ca499463ec2e 2023-06-06 chillers@google.com [labeler] Add engine workflow (flutter/engine#42566) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Camille Simon authored
[Android] Update plugin and module templates to use Flutter constant for `compileSdkVersion` (#128073) Updates plugin and module templates to use Flutter constant for `compileSdkVersion`.
-
Renzo Olivares authored
handleSelectWord in MultiSelectableSelectionContainerDelegate should handle rects inside of rects (#127478) Fixes #127076 Sometimes a `Selectable`s rect may contain another `Selectable`s rect within it. In the case of `handleSelectWord` when choosing which `Selectable` to dispatch the `SelectionEvent` to, the event would be dispatched to the wrong `Selectable` causing an assertion error to be thrown. <img width="577" alt="Screenshot 2023-05-24 at 2 46 13 AM" src="https://github.com/flutter/flutter/assets/948037/bb246966-acad-4d81-bd87-758c3ea6ea39"> In the picture above the red outline shows the rect of a two-line piece of text. And the blue rect shows the rect of a piece of text that is on the second line of the two-line piece of text, but has been separated into its own rect for some case, for example when `TextSpan`s are separated by a `WidgetSpan`. We should check if the text layout of the selectable that has been dispatched the SelectionEvent contains the word, if not then return `SelectionResult.next`, and continue to look through the list of selectables.
-
Christopher Fujino authored
Always pass the space code point (`0x20`) to the font subsetter when targetting web because the web engine relies on that character to calculate a font's height. Fixes #127270
-
LongCatIsLooong authored
I am trying to remove `textScaleFactor`-dependent logic from the framework since it's likely going to be deprecated, hopefully the original logic isn't from the material spec. I stole the sample code from https://github.com/flutter/flutter/pull/125038 and here are the screenshots (`textScaleFactor = 3.0`). Internal Tests: **no relevant test failures** | Medium | Large | | --------------- | --------------- | |  |  |
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b6d37f8f74ad...4571695f9e76 2023-06-06 jacksongardner@google.com Use proper sampling options in Skwasm's drawAtlas. (flutter/engine#42595) 2023-06-06 zanderso@users.noreply.github.com Revert "[Impeller] Reland: Add Impeller Metal support in the embedder API (#42411)" (flutter/engine#42593) 2023-06-06 zanderso@users.noreply.github.com Fix raster cache optional value check logic (flutter/engine#42592) 2023-06-06 zhangzhijian.123@bytedance.com [Impeller] Fix the rendering issue when the tile mode of gradient is set to 'decal' (flutter/engine#42591) 2023-06-06 skia-flutter-autoroll@skia.org Roll Skia from e8a71c76b88f to 4065e92bf577 (1 revision) (flutter/engine#42587) 2023-06-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vAwdggqMrL1yoH_Zn... to lpbkSRJBMkPs0FM7_... (flutter/engine#42590) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from vAwdggqMrL1y to lpbkSRJBMkPs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
fzyzcjy authored
Close #128113 Fun fact: This is caught by monkey testing I have written (will soon be open sourced as well) that runs on my app! Without the fix, the test fails as expected: <details> ``` (base) â flutter git:(feat/text-field-npe) /Volumes/MyExternal/ExternalRefCode/flutter/bin/flutter test test/material/text_field_test.dart --name 'changes from default' 00:06 +0: context menu contextMenuBuilder changes from default to null âââ¡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââ The following _TypeError was thrown building _OverlayEntryWidget-[LabeledGlobalKey<_OverlayEntryWidgetState>#e3717](state: _OverlayEntryWidgetState#7666a): Null check operator used on a null value When the exception was thrown, this was the stack: #0 EditableTextState._createSelectionOverlay.<anonymous closure> (package:flutter/src/widgets/editable_text.dart:3331:43) #1 SelectionOverlay.showToolbar.<anonymous closure> (package:flutter/src/widgets/text_selection.dart:1357:36) #2 ContextMenuController.show.<anonymous closure> (package:flutter/src/widgets/context_menu_controller.dart:65:54) #3 _OverlayEntryWidgetState.build (package:flutter/src/widgets/overlay.dart:351:36) #4 StatefulElement.build (package:flutter/src/widgets/framework.dart:5198:27) #5 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5086:15) #6 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #7 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #8 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #9 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #10 RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:6093:32) #11 MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6595:17) #12 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #13 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #14 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #15 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #16 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #17 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #18 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #19 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #20 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #21 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #22 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #23 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #24 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #25 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) #26 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #27 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #28 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #29 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #30 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #31 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #32 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #33 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #34 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #35 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) #36 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #37 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #38 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #39 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #40 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #41 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #42 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #43 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #44 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #45 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #46 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #47 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) #48 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #49 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) #50 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #51 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #52 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #53 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #54 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #55 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #56 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #57 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #58 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #59 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #60 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #61 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #62 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #63 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) #64 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #65 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) #66 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #67 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #68 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #69 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #70 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #71 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #72 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #73 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #74 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #75 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #76 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #77 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #78 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #79 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #80 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #81 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #82 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #83 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #84 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #85 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #86 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #87 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #88 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #89 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #90 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) #91 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #92 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #93 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #94 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #95 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #96 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #97 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #98 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) #99 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #100 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #101 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #102 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #103 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #104 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #105 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #106 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #107 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #108 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #109 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #110 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #111 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #112 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #113 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #114 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #115 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #116 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #117 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #118 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #119 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #120 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) #121 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #122 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #123 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #124 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #125 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #126 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) #127 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #128 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #129 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #130 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) #131 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #132 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #133 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #134 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) #135 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #136 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #137 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #138 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) #139 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #140 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #141 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #142 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #143 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #144 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #145 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #146 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #147 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #148 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) #149 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #150 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #151 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #152 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #153 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #154 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #155 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) #156 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #157 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #158 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #159 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #160 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) #161 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #162 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #163 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #164 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #165 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #166 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #167 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #168 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #169 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #170 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #171 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #172 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #173 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #174 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #175 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #176 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #177 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #178 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #179 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #180 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #181 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) #182 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #183 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #184 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #185 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #186 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) #187 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #188 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #189 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #190 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #191 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #192 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #193 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #194 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #195 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #196 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #197 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #198 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #199 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #200 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #201 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #202 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #203 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #204 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #205 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #206 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #207 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) #208 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #209 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #210 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #211 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #212 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) #213 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #214 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #215 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #216 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #217 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #218 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #219 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #220 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #221 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #222 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #223 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #224 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #225 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #226 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) #227 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #228 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) #229 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #230 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #231 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #232 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #233 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) #234 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #235 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #236 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #237 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #238 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #239 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #240 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #241 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #242 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #243 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #244 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #245 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #246 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #247 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #248 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #249 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #250 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #251 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #252 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #253 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #254 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #255 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #256 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #257 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #258 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #259 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #260 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #261 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #262 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #263 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #264 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #265 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #266 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #267 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #268 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #269 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #270 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #271 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #272 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #273 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #274 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #275 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #276 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #277 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) #278 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #279 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #280 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #281 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #282 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) #283 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #284 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #285 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #286 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #287 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #288 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #289 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #290 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #291 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #292 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #293 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #294 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #295 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #296 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #297 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #298 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #299 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #300 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #301 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #302 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #303 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #304 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #305 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #306 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #307 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #308 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #309 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #310 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #311 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #312 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #313 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #314 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #315 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #316 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #317 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) #318 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #319 RenderObjectToWidgetElement._rebuild (package:flutter/src/widgets/binding.dart:1253:16) #320 RenderObjectToWidgetElement.update (package:flutter/src/widgets/binding.dart:1230:5) #321 RenderObjectToWidgetElement.performRebuild (package:flutter/src/widgets/binding.dart:1244:7) #322 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #323 BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2780:19) #324 AutomatedTestWidgetsFlutterBinding.drawFrame (package:flutter_test/src/binding.dart:1396:19) #325 RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:358:5) #326 SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1297:15) #327 SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1227:9) #328 AutomatedTestWidgetsFlutterBinding.pump.<anonymous closure> (package:flutter_test/src/binding.dart:1246:9) #331 TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:68:41) #332 AutomatedTestWidgetsFlutterBinding.pump (package:flutter_test/src/binding.dart:1232:27) #333 WidgetTester._pumpWidget (package:flutter_test/src/widget_tester.dart:587:20) #334 WidgetTester.pumpWidget.<anonymous closure> (package:flutter_test/src/widget_tester.dart:572:14) #337 TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:68:41) #338 WidgetTester.pumpWidget (package:flutter_test/src/widget_tester.dart:571:27) #339 main.<anonymous closure>.<anonymous closure> (file:///Volumes/MyExternal/ExternalRefCode/flutter/packages/flutter/test/material/text_field_test.dart:15687:20) <asynchronous suspension> <asynchronous suspension> (elided 5 frames from dart:async and package:stack_trace) ââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââ 00:06 +0 -1: context menu contextMenuBuilder changes from default to null [E] Test failed. See exception logs above. The test description was: contextMenuBuilder changes from default to null To run this test again: /Volumes/MyExternal/ExternalRefCode/flutter/bin/cache/dart-sdk/bin/dart test /Volumes/MyExternal/ExternalRefCode/flutter/packages/flutter/test/material/text_field_test.dart -p vm --plain-name 'context menu contextMenuBuilder changes from default to null' 00:06 +0 -1: Some tests failed. (base) â flutter git:(feat/text-field-npe) ``` </details>
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/db4e5c26ed3f...da72219048fc 2023-06-06 42692766+dimabran@users.noreply.github.com remove unnecessary typed_data imports (flutter/packages#4136) 2023-06-06 43054281+camsim99@users.noreply.github.com [local_auth_android] Bump androidx.fragment to 1.5.7 and androidx.core to 1.10.1 (flutter/packages#4142) 2023-06-05 ditman@gmail.com [google_maps] Endorses package:google_maps_flutter_web. (flutter/packages#4124) 2023-06-05 ditman@gmail.com [ci] Removes bespoke web scripts. (flutter/packages#4129) 2023-06-05 arteevraina@gmail.com [webview_flutter]: fix typo (flutter/packages#4070) 2023-06-05 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.google.guava:guava from 31.1-android to 32.0.0-android in /packages/camera/camera_android_camerax/android (flutter/packages#4116) 2023-06-05 stuartmorgan@google.com [tools] Fix OOB test error (flutter/packages#4144) 2023-06-05 46547604+dsambuk@users.noreply.github.com [path_provider] Allow win32 up to version 5.x (flutter/packages#4125) 2023-06-05 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.guava:guava from 31.1-android to 32.0.0-android in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4112) 2023-06-05 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 2.18.6 to 2.18.7 in /packages/video_player/video_player_android/android (flutter/packages#4053) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
-
Leigha Jarett authored
Fixes https://github.com/flutter/flutter/issues/127214
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/722aad83e5fe...b6d37f8f74ad 2023-06-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from tCxDcZ3yi0rnKGVHt... to atrYtfHWi2cmV9B_C... (flutter/engine#42589) 2023-06-06 zhangzhijian.123@bytedance.com [Impeller] Make conical gradient work as expected (flutter/engine#42567) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from tCxDcZ3yi0rn to atrYtfHWi2cm If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Michael Goderbauer authored
Follow-up to https://github.com/flutter/engine/pull/42493.
-
Kevin Chisholm authored
There are some snake case labels (issue_link) and some sentence case labels (Commit Hash). This creates inconsistencies in the visual output of the template and when creating automations.
-
Hans Muller authored
Set `useMaterial3: true' for the MaterialApp used in the 2D tests to enable making `useMaterial3: true' the default for ThemeData in a future PR.
-
Nate Bosch authored
The members which are currently hidden may get removed from `package:test_api` because they have no uses. https://github.com/dart-lang/test/pull/2030 Switch to a `show` and list all the exported APIs. This is currently a no-op change, and is forward compatible with the breaking change when it lands. A `show` is also safer than a `hide` when exporting across package boundaries. Adding a new member to a library _can be_ breaking, but is often treated as non-breaking. If a new member is added to `package:test_api/scaffolding.dart` it will need to be manually added to the list to be usable from `package:flutter_test`, but we anyways want to add a CHANGELOG entry for user facing changes.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/aaa7574375a6...722aad83e5fe 2023-06-06 matej.knopp@gmail.com [macOS] Force clipping to path when platform view clip rect is rotated (flutter/engine#42539) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Leigha Jarett authored
Fixes https://github.com/flutter/flutter/issues/127213
-
Mouad Debbar authored
- Use `Uri.parse()` to extract pathname. - Remove unused code from `utils.dart`. - Add test for URL encoding. (need to wait for https://github.com/flutter/flutter/pull/126851 to make it into Google3)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/2b353ae90731...aaa7574375a6 2023-06-06 skia-flutter-autoroll@skia.org Roll Skia from 7db361be474b to e8a71c76b88f (4 revisions) (flutter/engine#42582) 2023-06-05 goderbauer@google.com Remove onSemanticsAction (flutter/engine#42579) 2023-06-05 godofredoc@google.com Use the arm64 dsymutil on Mac M1 machines (flutter/engine#42533) 2023-06-05 skia-flutter-autoroll@skia.org Roll Skia from a226cfbd6cc7 to 7db361be474b (14 revisions) (flutter/engine#42578) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 05 Jun, 2023 12 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/220ece4d9faa...2b353ae90731 2023-06-05 bdero@google.com [Impeller] Reland: Add Impeller Metal support in the embedder API (#42411) (flutter/engine#42545) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
dependabot[bot] authored
Bumps [actions/labeler](https://github.com/actions/labeler) from 4.0.4 to 4.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/labeler/releases">actions/labeler's releases</a>.</em></p> <blockquote> <h2>v4.1.0</h2> <h2>What's Changed</h2> <p>In scope of this release, the <code>dot</code> input was added by <a href="https://github.com/kachkaev"><code>@âkachkaev</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/316">actions/labeler#316</a>. It allows patterns to match paths starting with a period. This input is set to <code>false</code> by default.</p> <h3>Usage</h3> <pre lang="yml"><code>name: "Pull Request Labeler" on: - pull_request_target <p>jobs: triage: permissions: contents: read pull-requests: write runs-on: ubuntu-latest steps: - uses: actions/labeler@v4 with: dot: true </code></pre></p> <p>This release also includes the following changes:</p> <ul> <li>Simplify globbing examples in README by <a href="https://github.com/Youssef1313"><code>@âYoussef1313</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/451">actions/labeler#451</a></li> <li>Bump <code>@âtypescript-eslint/parser</code> from 5.59.7 to 5.59.8 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/577">actions/labeler#577</a></li> <li>Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.59.7 to 5.59.8 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/578">actions/labeler#578</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/Youssef1313"><code>@âYoussef1313</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/451">actions/labeler#451</a></li> <li><a href="https://github.com/kachkaev"><code>@âkachkaev</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/316">actions/labeler#316</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/labeler/compare/v4...v4.1.0">https://github.com/actions/labeler/compare/v4...v4.1.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/labeler/commit/9fcb2c2f5584144ca754f8bfe8c6f81e77753375"><code>9fcb2c2</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/578">#578</a> from actions/dependabot/npm_and_yarn/typescript-eslin...</li> <li><a href="https://github.com/actions/labeler/commit/0d06c504350cdc97e82c323547d28b981e2698ec"><code>0d06c50</code></a> Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.59.7 to 5.59.8</li> <li><a href="https://github.com/actions/labeler/commit/1d399c3ab6911b4a72b5219cb0f283080456c866"><code>1d399c3</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/577">#577</a> from actions/dependabot/npm_and_yarn/typescript-eslin...</li> <li><a href="https://github.com/actions/labeler/commit/82a4f6fc258f3df5a7b4e3ea7c4076397f45b7f2"><code>82a4f6f</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/316">#316</a> from kachkaev/dot-option</li> <li><a href="https://github.com/actions/labeler/commit/d40596e5db2302f8bd180870610f0059a6e3ace2"><code>d40596e</code></a> micromatch â minimatch</li> <li><a href="https://github.com/actions/labeler/commit/3cbc54c641133d82f4d5f2bc850c8feff279337c"><code>3cbc54c</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/451">#451</a> from Youssef1313/patch-1</li> <li><a href="https://github.com/actions/labeler/commit/639ba81ab1bba531e30a7d24861c54eb53982160"><code>639ba81</code></a> Rebuild</li> <li><a href="https://github.com/actions/labeler/commit/71d2484daaf26523ee79447d458c78a3a1b122ee"><code>71d2484</code></a> Address review comment</li> <li><a href="https://github.com/actions/labeler/commit/59d3310a72970937ed9bbdc21c5d457d287fb50e"><code>59d3310</code></a> Rebuild</li> <li><a href="https://github.com/actions/labeler/commit/a78a6c7eb7714f46ddda8e1f2c243abd28ce713d"><code>a78a6c7</code></a> Update README.md</li> <li>Additional commits viewable in <a href="https://github.com/actions/labeler/compare/0776a679364a9a16110aac8d0f40f5e11009e327...9fcb2c2f5584144ca754f8bfe8c6f81e77753375">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7f12e3497428...220ece4d9faa 2023-06-05 zanderso@users.noreply.github.com Ensure Dart roll script picks up udpates to dart-sdk/tools (flutter/engine#42576) 2023-06-05 chillers@google.com Run dependabot in off peak hours (flutter/engine#42572) 2023-06-05 flar@google.com fix bounds of inverted rendered rectangles (flutter/engine#42556) 2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fgfgAhpxFpse7Xi4i... to tCxDcZ3yi0rnKGVHt... (flutter/engine#42574) 2023-06-05 kjlubick@users.noreply.github.com Add missing #include of SkCFObject.h (flutter/engine#42573) 2023-06-05 matej.knopp@gmail.com Improve getting non-overlapping rectangles from RTree (flutter/engine#42399) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from fgfgAhpxFpse to tCxDcZ3yi0rn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jonah Williams authored
Adds a special opacity widget that does not act like a repaint boundary. Better solution for https://github.com/flutter/flutter/pull/128138
-
-
Kate Lovett authored
The deprecated `[RawScrollbar/Scrollbar/CupertinoScrollbar/ScrollbarThemeData].isAlwaysShown` has expired and is removed in thi PR. Also, `Scrollbar.hoverThickness` is also removed after having expired. The replacement for `isAlwaysShown` is `thumbVisibility`. This deprecation was introduced in #96957. The name change came from new behaviors like a track that is conditionally visible. Since the original API only referred to the thumb, the name was changed to reflect this intention. This change is supported by dart fix. â The replacement for `hoverThickness` is `ScrollbarThemeData.thickness`, which is a MaterialStateProperty that allows for the thickness to respond to multiple states including hover. This deprecation was introduced in #97173. This change is not supported by dart fix. ð Part of https://github.com/flutter/flutter/issues/127042
-
Kate Lovett authored
#### (plus some more docs) Fixes https://github.com/flutter/flutter/issues/76760 Fixes https://github.com/flutter/flutter/issues/82391 Fixes https://github.com/flutter/flutter/issues/45619 Fixes #117316 Fixes #110956 Fixes #127282 Fixes #32563 Fixes #46089 Fixes #79077 Part of fixing #62833 This fixes (a bunch of) issues that have been reported differently over the years, but all have the same root cause. Sometimes the NestedScrollView would incorrectly calculate whether or not there is enough content to allow scrolling. This would only apply to drag scrolling (not mouse wheel scrolling for example). This did not relate to how the extent of the NestedScrollView is computed, but just the logic that enabled the actual drag gestures. This fixes that. :)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f9f72388a4da...7f12e3497428 2023-06-05 matej.knopp@gmail.com Fix clang tidy error and crash (flutter/engine#42564) 2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gp1k1agqxQIz0oTXV... to vAwdggqMrL1yoH_Zn... (flutter/engine#42570) 2023-06-05 zanderso@users.noreply.github.com Revert Dart SDK to 3.1.0-163.0.dev for branch alignment (flutter/engine#42569) 2023-06-05 zanderso@users.noreply.github.com Check more optional accesses (flutter/engine#42528) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from gp1k1agqxQIz to vAwdggqMrL1y If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Michael Goderbauer authored
Follow-up to https://github.com/flutter/engine/pull/42493.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c838a1b05924...f9f72388a4da 2023-06-05 zanderso@users.noreply.github.com Revert Dart SDK to 3.1.0-166.0.dev (flutter/engine#42568) 2023-06-05 skia-flutter-autoroll@skia.org Roll Skia from a10e944601cf to a226cfbd6cc7 (1 revision) (flutter/engine#42562) 2023-06-05 kjlubick@users.noreply.github.com Add missing includes of GrBackendSurface.h (flutter/engine#42563) 2023-06-05 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.5 to 2.3.6 (flutter/engine#42561) 2023-06-05 skia-flutter-autoroll@skia.org Roll Skia from 210ad9cde42b to a10e944601cf (3 revisions) (flutter/engine#42560) 2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from sk-SFXAARqkT7wGmf... to fgfgAhpxFpse7Xi4i... (flutter/engine#42558) 2023-06-05 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d00a370c1fd3 to 5144119b99c8 (2 revisions) (flutter/engine#42557) 2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 839LDf0p1Q4wyszA5... to gp1k1agqxQIz0oTXV... (flutter/engine#42553) 2023-06-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 5pFMQIRHNENhekRDO... to sk-SFXAARqkT7wGmf... (flutter/engine#42551) 2023-06-04 skia-flutter-autoroll@skia.org Roll Skia from 8ca7bad9158f to 210ad9cde42b (1 revision) (flutter/engine#42549) 2023-06-04 skia-flutter-autoroll@skia.org Roll Skia from 611132d6ab8c to 8ca7bad9158f (1 revision) (flutter/engine#42548) 2023-06-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Bb9z8SjSCzRN6SVee... to 839LDf0p1Q4wyszA5... (flutter/engine#42544) 2023-06-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from vVgQ12wNh2DIT_hV7... to 5pFMQIRHNENhekRDO... (flutter/engine#42543) 2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from 0e80a97ccee3 to 611132d6ab8c (2 revisions) (flutter/engine#42542) 2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from 98da8d7a299d to 0e80a97ccee3 (1 revision) (flutter/engine#42541) 2023-06-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VtLnfLmVda1_h1AtM... to Bb9z8SjSCzRN6SVee... (flutter/engine#42538) 2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from 656de7fc6994 to 98da8d7a299d (1 revision) (flutter/engine#42537) 2023-06-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gcm-vsCu6IPUZZnN0... to vVgQ12wNh2DIT_hV7... (flutter/engine#42536) 2023-06-03 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d198f84f5e4e to d00a370c1fd3 (3 revisions) (flutter/engine#42535) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from VtLnfLmVda1_ to gp1k1agqxQIz fuchsia/sdk/core/mac-amd64 from gcm-vsCu6IPU to fgfgAhpxFpse If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jonah Williams authored
Fixes https://github.com/flutter/flutter/issues/127836 The flexible scroll bar needs to rebuild even if the child/opacity hasn't changed. Force this with a value key.
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/75085edb54fe...db4e5c26ed3f 2023-06-05 engine-flutter-autoroll@skia.org Roll Flutter from 3db9504d to 0b741535 (108 revisions) (flutter/packages#4135) 2023-06-05 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 9cd3d0d9ff05 to f92f44110e87 (4 revisions) (flutter/packages#4133) 2023-06-02 engine-flutter-autoroll@skia.org Roll Flutter from ee162e4b to 3db9504d (31 revisions) (flutter/packages#4098) 2023-06-02 43054281+camsim99@users.noreply.github.com [many] Bump most robolectric dependencies to version 4.10.3 (flutter/packages#4128) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 03 Jun, 2023 3 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/54293721816a...c838a1b05924 2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from daf2219fec54 to 656de7fc6994 (23 revisions) (flutter/engine#42534) 2023-06-03 bdero@google.com Revert "[Impeller] Add Impeller Metal support in the embedder API (#42411)" (flutter/engine#42532) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/8769e9ce3a90...54293721816a 2023-06-03 jonahwilliams@google.com [Impeller] Fix 1-d grid computation for compute (flutter/engine#42516) 2023-06-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from PuYA-6NVHeHPlkCdk... to VtLnfLmVda1_h1AtM... (flutter/engine#42529) 2023-06-02 chris@bracken.jp [macOS] Top-left origin for PlatformView container (flutter/engine#42523) 2023-06-02 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 9d8df2a5210b to d198f84f5e4e (1 revision) (flutter/engine#42527) 2023-06-02 flar@google.com Revert "Reland "add non-rendering operation culling to DisplayListBuilder" (#41463)" (flutter/engine#42525) 2023-06-02 godofredoc@google.com Move benchmarks no upload to staging. (flutter/engine#42524) 2023-06-02 mdebbar@google.com [web] Support platform view creation params (flutter/engine#42255) 2023-06-02 goderbauer@google.com MultiView changes for dart:ui (flutter/engine#42493) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from PuYA-6NVHeHP to VtLnfLmVda1_ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
-
- 02 Jun, 2023 2 commits
-
-
Alexander Aprelev authored
The fix is coming as part of https://dart-review.git.corp.google.com/c/sdk/+/306908 dart sdk roll as well as https://github.com/flutter/flutter/pull/128084. BUG=https://github.com/dart-lang/sdk/issues/52522
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f3f6a020595d...8769e9ce3a90 2023-06-02 godofredoc@google.com Use json for json blocks in docs. (flutter/engine#42521) 2023-06-02 mdebbar@google.com [web] New platform view API to get view by ID (flutter/engine#41784) 2023-06-02 jason-simmons@users.noreply.github.com Generate a unique temporary directory name in the iOS scenario test script (flutter/engine#42520) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
![dependabot[bot]'s avatar](https://secure.gravatar.com/avatar/48ea49be76d0c68403a7f3df87e3487d?s=80&d=identicon "dependabot[bot]")
