1. 22 Nov, 2023 1 commit
  2. 14 Nov, 2023 1 commit
  3. 30 Oct, 2023 1 commit
  4. 27 Oct, 2023 1 commit
  5. 20 Oct, 2023 1 commit
  6. 18 Oct, 2023 1 commit
  7. 11 Oct, 2023 1 commit
  8. 29 Sep, 2023 1 commit
  9. 27 Sep, 2023 2 commits
  10. 26 Sep, 2023 1 commit
  11. 22 Sep, 2023 1 commit
    • Daco Harkes's avatar
      Reland "Native assets support for Linux" (#135097) · 2def9519
      Daco Harkes authored
      Reland of #134031. (Reverted in #135069.) Contains the fix for b/301051367 together with cl/567233346.
      
      Support for FFI calls with `@Native external` functions through Native assets on Linux. This enables bundling native code without any build-system boilerplate code.
      
      For more info see:
      
      * https://github.com/flutter/flutter/issues/129757
      
      ### Implementation details for Linux.
      
      Mainly follows the design of https://github.com/flutter/flutter/pull/130494.
      
      Some differences are:
      
      * Linux does not support cross compiling or compiling for multiple architectures, so this has not been implemented.
      * Linux has no add2app.
      
      The assets copying is done in the install-phase of the CMake build of a flutter app.
      CMake requires the native assets folder to exist, so we create it also when the feature is disabled or there are no assets.
      
      ### Tests
      
      This PR adds new tests to cover the various use cases.
      
      * packages/flutter_tools/test/general.shard/linux/native_assets_test.dart
        * Unit tests the Linux-specific part of building native assets.
      
      It also extends various existing tests:
      
      * packages/flutter_tools/test/integration.shard/native_assets_test.dart
        * Runs (incl hot reload/hot restart), builds, builds frameworks for Linux and flutter-tester.
      2def9519
  12. 21 Sep, 2023 1 commit
  13. 20 Sep, 2023 1 commit
  14. 19 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must be non-null' and 'must not be null' comments from non-framework libraries (#134994) · 4ce7fdd9
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so must not be null" or "so-and-so must be non-null" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the library in the repo that don't have anything to do with the framework.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134984
      - https://github.com/flutter/flutter/pull/134991
      - https://github.com/flutter/flutter/pull/134992
      - https://github.com/flutter/flutter/pull/134993
      
      ## Tests
       - Documentation only change.
      4ce7fdd9
  15. 18 Sep, 2023 1 commit
    • Daco Harkes's avatar
      Native assets support for Linux (#134031) · 2337c64d
      Daco Harkes authored
      Support for FFI calls with `@Native external` functions through Native assets on Linux. This enables bundling native code without any build-system boilerplate code.
      
      For more info see:
      
      * https://github.com/flutter/flutter/issues/129757
      
      ### Implementation details for Linux.
      
      Mainly follows the design of https://github.com/flutter/flutter/pull/130494.
      
      Some differences are:
      
      * Linux does not support cross compiling or compiling for multiple architectures, so this has not been implemented.
      * Linux has no add2app.
      
      The assets copying is done in the install-phase of the CMake build of a flutter app.
      CMake requires the native assets folder to exist, so we create it also when the feature is disabled or there are no assets.
      
      ### Tests
      
      This PR adds new tests to cover the various use cases.
      
      * packages/flutter_tools/test/general.shard/linux/native_assets_test.dart
        * Unit tests the Linux-specific part of building native assets.
      
      It also extends various existing tests:
      
      * packages/flutter_tools/test/integration.shard/native_assets_test.dart
        * Runs (incl hot reload/hot restart), builds, builds frameworks for Linux and flutter-tester.
      2337c64d
  16. 15 Sep, 2023 1 commit
  17. 10 Sep, 2023 1 commit
    • Daco Harkes's avatar
      Native assets support for MacOS and iOS (#130494) · aa36db1d
      Daco Harkes authored
      Support for FFI calls with `@Native external` functions through Native assets on MacOS and iOS. This enables bundling native code without any build-system boilerplate code.
      
      For more info see:
      
      * https://github.com/flutter/flutter/issues/129757
      
      ### Implementation details for MacOS and iOS.
      
      Dylibs are bundled by (1) making them fat binaries if multiple architectures are targeted, (2) code signing these, and (3) copying them to the frameworks folder. These steps are done manual rather than via CocoaPods. CocoaPods would have done the same steps, but (a) needs the dylibs to be there before the `xcodebuild` invocation (we could trick it, by having a minimal dylib in the place and replace it during the build process, that works), and (b) can't deal with having no dylibs to be bundled (we'd have to bundle a dummy dylib or include some dummy C code in the build file).
      
      The dylibs are build as a new target inside flutter assemble, as that is the moment we know what build-mode and architecture to target.
      
      The mapping from asset id to dylib-path is passed in to every kernel compilation path. The interesting case is hot-restart where the initial kernel file is compiled by the "inner" flutter assemble, while after hot restart the "outer" flutter run compiled kernel file is pushed to the device. Both kernel files need to contain the mapping. The "inner" flutter assemble gets its mapping from the NativeAssets target which builds the native assets. The "outer" flutter run get its mapping from a dry-run invocation. Since this hot restart can be used for multiple target devices (`flutter run -d all`) it contains the mapping for all known targets.
      
      ### Example vs template
      
      The PR includes a new template that uses the new native assets in a package and has an app importing that. Separate discussion in: https://github.com/flutter/flutter/issues/131209.
      
      ### Tests
      
      This PR adds new tests to cover the various use cases.
      
      * dev/devicelab/bin/tasks/native_assets_ios.dart
        * Runs an example app with native assets in all build modes, doing hot reload and hot restart in debug mode.
      * dev/devicelab/bin/tasks/native_assets_ios_simulator.dart
        * Runs an example app with native assets, doing hot reload and hot restart.
      * packages/flutter_tools/test/integration.shard/native_assets_test.dart
        * Runs (incl hot reload/hot restart), builds, builds frameworks for iOS, MacOS and flutter-tester.
      * packages/flutter_tools/test/general.shard/build_system/targets/native_assets_test.dart
        * Unit tests the new Target in the backend.
      * packages/flutter_tools/test/general.shard/ios/native_assets_test.dart
      * packages/flutter_tools/test/general.shard/macos/native_assets_test.dart
        * Unit tests the native assets being packaged on a iOS/MacOS build.
      
      It also extends various existing tests:
      
      * dev/devicelab/bin/tasks/module_test_ios.dart
         * Exercises the add2app scenario.
      * packages/flutter_tools/test/general.shard/features_test.dart
         * Unit test the new feature flag.
      aa36db1d
  18. 19 Aug, 2023 1 commit
  19. 08 Jun, 2023 1 commit
    • Tess Strickland's avatar
      Use `--target-os` for appropriate precompiled targets. (#127567) · 840d7dd6
      Tess Strickland authored
      This PR adds uses of the `--target-os` command line argument when
      building kernel sources for precompiled applications for supported
      target operating systems. The Dart CFE then:
      
      * treats `Platform.operatingSystem` as if it were defined as the
      constant string provided as an argument to the flag,
      * treats `Platform.pathSeparator` as the appropriate separator for that
      operating system,
      * attempts to constant evaluate the initializer for any field annotated
      with the `vm:platform-const` pragma, and
      * attempts to constant evaluate all calls to a method annotated with the
      `vm:platform-const` pragma.
      
      The `vm:platform-const` pragma can appear in either library or user
      code. If the attempt to constant evaluate the field initializer or
      method call fails, then an error is thrown at kernel compilation time.
      
      Addresses #14233.
      
      The tests in
      `packages/flutter_tools/test/general.shard/build_system/targets/common_test.dart`
      have been adjusted properly to account for the new passed command line
      arguments.
      840d7dd6
  20. 06 Jun, 2023 1 commit
  21. 31 May, 2023 1 commit
  22. 26 May, 2023 1 commit
  23. 23 May, 2023 1 commit
  24. 05 May, 2023 3 commits
  25. 04 May, 2023 2 commits
  26. 03 May, 2023 2 commits
  27. 26 Apr, 2023 1 commit
    • Tae Hyung Kim's avatar
      Refactor "gen-l10n" command to use same code path when "l10n.yaml" is present... · 5c44b1df
      Tae Hyung Kim authored
      Refactor "gen-l10n" command to use same code path when "l10n.yaml" is present or not present (#125429)
      
      I think this is a long needed change to the `gen-l10n` command.
      Essentially, the arguments to `flutter gen-l10n` can be provided by two
      different methods: via command line arguments or via the `l10n.yaml`
      file. The existence of a `l10n.yaml` file causes the latter approach to
      take precedence.
      
      However, currently, there's several differences in how the two
      approaches are handled, and most of the default arguments are all over
      the place, causing unexpected issues such as #120457 or #120023.
      
      This PR refactors the command so that
      * `LocalizationOptions` are more consistent with the actual argument
      names/yaml options.
      * All default values are determined in `LocalizationOptions`'s
      constructor (or in `argParser.addOption(...)` in the case a boolean
      value needs to be explicitly true).
      * New `parseLocalizationsOptionsFromCommand` function to parse
      arguments.
      * Parse `LocalizationOptions` at the beginning of `runCommand()` and
      pass it to `generateLocalizations`.
      
      Fixes #120023.
      5c44b1df
  28. 14 Apr, 2023 3 commits
  29. 11 Apr, 2023 1 commit
  30. 10 Apr, 2023 1 commit
  31. 06 Apr, 2023 1 commit
  32. 04 Apr, 2023 1 commit
  33. 30 Mar, 2023 1 commit