Commits · 22c2ce72a4117ead9e4a16581b77557c9b828f63 · abdullh.alsoleman / Front-End

16 Oct, 2023 10 commits

Roll Packages from fd84e6545a45 to 872d6d26c48b (5 revisions) (#136644) · 22c2ce72

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/packages/compare/fd84e6545a45...872d6d26c48b

2023-10-16 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.2 to 2.22.3 (flutter/packages#5151)
2023-10-15 engine-flutter-autoroll@skia.org Roll Flutter from 3865e49a to b00216b3 (34 revisions) (flutter/packages#5147)
2023-10-13 737941+loic-sharma@users.noreply.github.com [ci] Add x64 specific Windows platform (flutter/packages#5133)
2023-10-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.1 to 2.22.2 (flutter/packages#5138)
2023-10-13 engine-flutter-autoroll@skia.org Roll Flutter from 83134ac7 to 3865e49a (80 revisions) (flutter/packages#5140)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

22c2ce72

Roll Flutter Engine from cfff75967b06 to 505c720fd10f (1 revision) (#136636) · afc39160

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/cfff75967b06...505c720fd10f

2023-10-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from CQhXLIfBTsZWBA4XM... to bMDZdOFfPiVkjIdiv... (flutter/engine#46943)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from CQhXLIfBTsZW to bMDZdOFfPiVk

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

afc39160

Roll Flutter Engine from bd038d688ed3 to cfff75967b06 (1 revision) (#136635) · bc526d1b

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/bd038d688ed3...cfff75967b06

2023-10-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from D-ejMxpgAyRoO6DUr... to 6E-cSq679DjzBMcqY... (flutter/engine#46942)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from D-ejMxpgAyRo to 6E-cSq679Djz

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bc526d1b

Roll Flutter Engine from 15dee700867b to bd038d688ed3 (1 revision) (#136626) · 0b035e02

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/15dee700867b...bd038d688ed3

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 36503efe4154 to 238ab1631282 (1 revision) (flutter/engine#46940)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0b035e02

Roll Flutter Engine from 41b3b4f90cd9 to 15dee700867b (1 revision) (#136625) · 88f30291

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/41b3b4f90cd9...15dee700867b

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from a83914bb86c9 to 36503efe4154 (1 revision) (flutter/engine#46939)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

88f30291

Fix `NavigationRail`'s indicator inkwell doesn't support transparent color. (#136359) · 17c664fb

Taha Tesser authored Oct 16, 2023

fixes [NavigationRail can't have a transparent Hover color because there is always opacity set](https://github.com/flutter/flutter/issues/135866)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.green).copyWith(
          primary: Colors.transparent,
        ),
      ),
      home: const Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({Key? key}) : super(key: key);

  @override
  State<StatefulWidget> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {
  int _selectedIndex = 0;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('NavigationRail Example'),
      ),
      body: Row(
        children: <Widget>[
          NavigationRail(
            selectedIndex: _selectedIndex,
            onDestinationSelected: (int index) {
              setState(() {
                _selectedIndex = index;
              });
            },
            labelType: NavigationRailLabelType.all,
            destinations: const <NavigationRailDestination>[
              NavigationRailDestination(
                icon: Icon(Icons.favorite_border),
                selectedIcon: Icon(Icons.favorite),
                label: Text('First'),
              ),
              NavigationRailDestination(
                icon: Icon(Icons.bookmark_border),
                selectedIcon: Icon(Icons.book),
                label: Text('Second'),
              ),
              NavigationRailDestination(
                icon: Icon(Icons.star_border),
                selectedIcon: Icon(Icons.star),
                label: Text('Third'),
              ),
            ],
          ),
          const VerticalDivider(thickness: 1, width: 1),
          Expanded(
            child: Center(
              child: Text('Selected Index: $_selectedIndex'),
            ),
          )
        ],
      ),
    );
  }
}
```

</details>

17c664fb

Roll Flutter Engine from 12122eac2820 to 41b3b4f90cd9 (1 revision) (#136623) · 7124b69e

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/12122eac2820...41b3b4f90cd9

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 798ef5becc8d to a83914bb86c9 (1 revision) (flutter/engine#46938)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7124b69e

Roll Flutter Engine from 539ad5b232a6 to 12122eac2820 (2 revisions) (#136619) · 6d5691b4

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/539ad5b232a6...12122eac2820

2023-10-16 leroux_bruno@yahoo.fr Reland - [Android] Add support for text processing actions (flutter/engine#46817)
2023-10-16 dkwingsmt@users.noreply.github.com Revert "Reland: Enforce the rule of calling FlutterView.Render (#45300)" (flutter/engine#46919)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6d5691b4

Roll Flutter Engine from 452e75f2a6b6 to 539ad5b232a6 (1 revision) (#136617) · b66ab70c

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/452e75f2a6b6...539ad5b232a6

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from cd9561107494 to 798ef5becc8d (1 revision) (flutter/engine#46937)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b66ab70c

Roll Flutter Engine from 72598229bec9 to 452e75f2a6b6 (1 revision) (#136614) · 9f985ad7

engine-flutter-autoroll authored Oct 16, 2023

https://github.com/flutter/engine/compare/72598229bec9...452e75f2a6b6

2023-10-16 skia-flutter-autoroll@skia.org Roll Skia from 9b773f7cebee to cd9561107494 (1 revision) (flutter/engine#46936)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9f985ad7

15 Oct, 2023 9 commits

Roll Flutter Engine from f8eb68b115f1 to 72598229bec9 (2 revisions) (#136611) · 4ea0d7d4

engine-flutter-autoroll authored Oct 15, 2023

https://github.com/flutter/engine/compare/f8eb68b115f1...72598229bec9

2023-10-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SatOcMmpSCwa51hi6... to CQhXLIfBTsZWBA4XM... (flutter/engine#46935)
2023-10-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kElPcDiGfsGBI7qr9... to D-ejMxpgAyRoO6DUr... (flutter/engine#46934)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from kElPcDiGfsGB to D-ejMxpgAyRo
fuchsia/sdk/core/mac-amd64 from SatOcMmpSCwa to CQhXLIfBTsZW

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4ea0d7d4

Test cover cupertino for memory leaks and fix Opacity Layer not disposed. (#136576) · 77c19f50
Binni Goel authored Oct 15, 2023

77c19f50
Test cover cupertino for memory leaks tracking -2 (#136577) · 0f555046
Binni Goel authored Oct 15, 2023

0f555046

Roll Flutter Engine from e2319935d8c8 to f8eb68b115f1 (1 revision) (#136605) · b00216b3

engine-flutter-autoroll authored Oct 15, 2023

https://github.com/flutter/engine/compare/e2319935d8c8...f8eb68b115f1

2023-10-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 02e6d943f1a7 to 64a485bb79bd (1 revision) (flutter/engine#46933)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b00216b3

Roll Flutter Engine from edf688d30ae3 to e2319935d8c8 (1 revision) (#136604) · 375a4a04

engine-flutter-autoroll authored Oct 15, 2023

https://github.com/flutter/engine/compare/edf688d30ae3...e2319935d8c8

2023-10-15 skia-flutter-autoroll@skia.org Roll Skia from f98a3b1303dc to 9b773f7cebee (1 revision) (flutter/engine#46932)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

375a4a04

Roll Flutter Engine from 1b3bf985490c to edf688d30ae3 (1 revision) (#136603) · f530b339

engine-flutter-autoroll authored Oct 15, 2023

https://github.com/flutter/engine/compare/1b3bf985490c...edf688d30ae3

2023-10-15 skia-flutter-autoroll@skia.org Roll Skia from fc4713797ec1 to f98a3b1303dc (1 revision) (flutter/engine#46931)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f530b339

Roll Flutter Engine from e4f8b2267906 to 1b3bf985490c (1 revision) (#136601) · 8fd8fdce

engine-flutter-autoroll authored Oct 15, 2023

https://github.com/flutter/engine/compare/e4f8b2267906...1b3bf985490c

2023-10-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from hdQ3YOjS1Ytp8W8Aq... to SatOcMmpSCwa51hi6... (flutter/engine#46930)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from hdQ3YOjS1Ytp to SatOcMmpSCwa

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8fd8fdce

Roll Flutter Engine from b64ebc0be62d to e4f8b2267906 (1 revision) (#136599) · b57636be

engine-flutter-autoroll authored Oct 15, 2023

https://github.com/flutter/engine/compare/b64ebc0be62d...e4f8b2267906

2023-10-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from GycFOb9QsDvp8qfDD... to kElPcDiGfsGBI7qr9... (flutter/engine#46929)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from GycFOb9QsDvp to kElPcDiGfsGB

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b57636be

Roll Flutter Engine from 529eb423604c to b64ebc0be62d (1 revision) (#136592) · 36f97fc0

engine-flutter-autoroll authored Oct 15, 2023

https://github.com/flutter/engine/compare/529eb423604c...b64ebc0be62d

2023-10-14 skia-flutter-autoroll@skia.org Roll Skia from 5bc5b4fdbe54 to fc4713797ec1 (1 revision) (flutter/engine#46928)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

36f97fc0

14 Oct, 2023 13 commits

Roll Flutter Engine from 82596277bd2b to 529eb423604c (1 revision) (#136591) · 1c56558a

engine-flutter-autoroll authored Oct 14, 2023

https://github.com/flutter/engine/compare/82596277bd2b...529eb423604c

2023-10-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 6fWBgb3bC9xULwq_k... to hdQ3YOjS1Ytp8W8Aq... (flutter/engine#46927)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 6fWBgb3bC9xU to hdQ3YOjS1Ytp

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1c56558a

Roll Flutter Engine from 015e352a174e to 82596277bd2b (1 revision) (#136590) · a0ad2da7

engine-flutter-autoroll authored Oct 14, 2023

https://github.com/flutter/engine/compare/015e352a174e...82596277bd2b

2023-10-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ATLkmtMOIbHDqp6a_... to GycFOb9QsDvp8qfDD... (flutter/engine#46926)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ATLkmtMOIbHD to GycFOb9QsDvp

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a0ad2da7

Roll Flutter Engine from 73acf62a2fe1 to 015e352a174e (1 revision) (#136589) · 5401ac59

engine-flutter-autoroll authored Oct 14, 2023

https://github.com/flutter/engine/compare/73acf62a2fe1...015e352a174e

2023-10-14 jonahwilliams@google.com [Impeller] Vulkan GPU tracer cleanups (flutter/engine#46915)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5401ac59

Upload GPU frame times for Impeller on Android/iOS. (#136565) · 19564744

Jonah Williams authored Oct 14, 2023

These values will be 0 until https://github.com/flutter/engine/pull/46846 and https://github.com/flutter/engine/pull/46796 roll into the framework.

19564744

Roll Flutter Engine from c777aae5ca15 to 73acf62a2fe1 (1 revision) (#136581) · 2963b746

engine-flutter-autoroll authored Oct 14, 2023

https://github.com/flutter/engine/compare/c777aae5ca15...73acf62a2fe1

2023-10-14 skia-flutter-autoroll@skia.org Roll Skia from 1c6e0141be7b to 5bc5b4fdbe54 (1 revision) (flutter/engine#46923)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2963b746

Roll Flutter Engine from d4e765fbefb8 to c777aae5ca15 (1 revision) (#136580) · 14be4302

engine-flutter-autoroll authored Oct 14, 2023

https://github.com/flutter/engine/compare/d4e765fbefb8...c777aae5ca15

2023-10-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 4DwpR2CMJECZJ8EKz... to 6fWBgb3bC9xULwq_k... (flutter/engine#46922)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 4DwpR2CMJECZ to 6fWBgb3bC9xU

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

14be4302

Roll Flutter Engine from 472be42e90e0 to d4e765fbefb8 (1 revision) (#136578) · b59b42c2

engine-flutter-autoroll authored Oct 14, 2023

https://github.com/flutter/engine/compare/472be42e90e0...d4e765fbefb8

2023-10-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from wBb32R567S1alWbfn... to ATLkmtMOIbHDqp6a_... (flutter/engine#46921)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from wBb32R567S1a to ATLkmtMOIbHD

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b59b42c2

Roll Flutter Engine from 9149a427ef98 to 472be42e90e0 (1 revision) (#136574) · 4b72a6e8

engine-flutter-autoroll authored Oct 14, 2023

https://github.com/flutter/engine/compare/9149a427ef98...472be42e90e0

2023-10-14 skia-flutter-autoroll@skia.org Roll Skia from 9affbebb459a to 1c6e0141be7b (2 revisions) (flutter/engine#46918)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4b72a6e8

_RouterState should dispose created _RestorableRouteInformation. (#136556) · 2c3db435

Kostia Sokolovskyi authored Oct 14, 2023

### Description
- Fixes https://github.com/flutter/flutter/issues/134205.

### Tests
- Removes ignoring the `_RestorableRouteInformation` leak from `cupertino/app_test.dart`;
- Removes ignoring the `_RestorableRouteInformation` leak from `material/app_test.dart`;
- Removes ignoring the `_RestorableRouteInformation` leak from `widgets/app_test.dart`;
- Removes ignoring the `_RestorableRouteInformation` leak from `widgets/route_notification_messages_test.dart`;
- Removes ignoring the `_RestorableRouteInformation` leak from `widgets/router_restoration_test.dart`;
- Updates `widgets/router_test.dart` to use `testWidgetsWithLeakTracking`.

2c3db435

Roll Flutter Engine from cd1a5ed6f961 to 9149a427ef98 (1 revision) (#136571) · 5b7e9d60

engine-flutter-autoroll authored Oct 14, 2023

https://github.com/flutter/engine/compare/cd1a5ed6f961...9149a427ef98

2023-10-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 5844b34768ce to 02e6d943f1a7 (1 revision) (flutter/engine#46917)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5b7e9d60

increase windows build test sharding, revert timeout 30 mins (#136474) · bcc795a0

Christopher Fujino authored Oct 14, 2023

In https://github.com/flutter/flutter/pull/136300 I increased the timeout. This is a revert of that, which also adds an additional shard.

bcc795a0

Roll Flutter Engine from a4e62581525c to cd1a5ed6f961 (2 revisions) (#136566) · f2ea7754

engine-flutter-autoroll authored Oct 14, 2023

https://github.com/flutter/engine/compare/a4e62581525c...cd1a5ed6f961

2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 4bc4b4d22866 to 9affbebb459a (2 revisions) (flutter/engine#46913)
2023-10-13 jonahwilliams@google.com [Impeller] Add GPU frame time to Vulkan backend using timestamp queries. (flutter/engine#46796)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f2ea7754

Change some usage of RawKeyEvent to KeyEvent in preparation for deprecation (#136420) · 3ef32f04

Greg Spencer authored Oct 14, 2023

## Description

This converts some usages of `RawKeyEvent` to `KeyEvent` to prepare the repo for deprecation of `RawKeyEvent`, and swaps out the `raw_keyboard.dart` manual test for `hardware_keyboard.dart`.

## Related Issues
 - https://github.com/flutter/flutter/issues/136419

## Tests
 - Just refactoring code, no semantic changes.

3ef32f04

13 Oct, 2023 8 commits

Manual roll Flutter Engine from 6605151b4d0a to a4e62581525c (9 revisions) (#136564) · 33db5d7a

engine-flutter-autoroll authored Oct 13, 2023

Manual roll requested by jacksongardner@google.com

Cannot build log URL because revision "a4e62581525c" is invalid: Luci builds of "Mac mac_ios_engine" for a4e62581525c1864a3cd23a67539a3615717eb98 was STARTED

2023-10-13 skia-flutter-autoroll@skia.org Manual roll Dart SDK from c8143a7c026f to 5844b34768ce (1 revision) (flutter/engine#46909)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from c9601553b0f3 to 4bc4b4d22866 (1 revision) (flutter/engine#46908)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 8dc8e21a4dec to c9601553b0f3 (3 revisions) (flutter/engine#46907)
2023-10-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SDPa6SfaKvRRSUCij... to 4DwpR2CMJECZJ8EKz... (flutter/engine#46903)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from b50d7f9aa743 to 8dc8e21a4dec (4 revisions) (flutter/engine#46902)
2023-10-13 jonahwilliams@google.com [Impeller] fix clear color optimization for large subpasses. (flutter/engine#46887)
2023-10-13 matanlurey@users.noreply.github.com Oops, allow files in opted-in third_party directories. (flutter/engine#46897)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from e10e6765480a to b50d7f9aa743 (1 revision) (flutter/engine#46899)
2023-10-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pI1BVH08V0eG0M7sw... to wBb32R567S1alWbfn... (flutter/engine#46898)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from pI1BVH08V0eG to wBb32R567S1a
fuchsia/sdk/core/mac-amd64 from SDPa6SfaKvRR to 4DwpR2CMJECZ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

33db5d7a

Bump github/codeql-action from 2.22.0 to 2.22.3 (#136563) · 5f9965cf

dependabot[bot] authored Oct 13, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.0 to 2.22.3.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.22.3 - 13 Oct 2023</h2>
<ul>
<li>Provide an authentication token when downloading the CodeQL Bundle from the API of a GitHub Enterprise Server instance. <a href="https://redirect.github.com/github/codeql-action/pull/1945">#1945</a></li>
</ul>
<h2>2.22.2 - 12 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.0. <a href="https://redirect.github.com/github/codeql-action/pull/1938">#1938</a></li>
<li>Improve the log output when an error occurs in an invocation of the CodeQL CLI. <a href="https://redirect.github.com/github/codeql-action/pull/1927">#1927</a></li>
</ul>
<h2>2.22.1 - 09 Oct 2023</h2>
<ul>
<li>Add a workaround for Python 3.12, which is not supported in CodeQL CLI version 2.14.6 or earlier. If you are running an analysis on Windows and using Python 3.12 or later, the CodeQL Action will switch to running Python 3.11. In this case, if Python 3.11 is not found, then the workflow will fail. <a href="https://redirect.github.com/github/codeql-action/pull/1928">#1928</a></li>
</ul>
<h2>2.22.0 - 06 Oct 2023</h2>
<ul>
<li>The CodeQL Action now requires CodeQL version 2.10.5 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.21.8. <a href="https://redirect.github.com/github/codeql-action/pull/1907">#1907</a></li>
<li>The CodeQL Action no longer runs ML-powered queries. For more information, including details on our investment in AI-powered security technology, see <a href="https://github.blog/changelog/2023-09-29-codeql-code-scanning-deprecates-ml-powered-alerts/">&quot;CodeQL code scanning deprecates ML-powered alerts.&quot;</a> <a href="https://redirect.github.com/github/codeql-action/pull/1910">#1910</a></li>
<li>Fix a bug which prevented tracing of projects using Go 1.21 and above on Linux. <a href="https://redirect.github.com/github/codeql-action/pull/1909">#1909</a></li>
</ul>
<h2>2.21.9 - 27 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.6. <a href="https://redirect.github.com/github/codeql-action/pull/1897">#1897</a></li>
<li>We are rolling out a feature in October 2023 that will improve the success rate of C/C++ autobuild. <a href="https://redirect.github.com/github/codeql-action/pull/1889">#1889</a></li>
<li>We are rolling out a feature in October 2023 that will provide specific file coverage information for C and C++, Java and Kotlin, and JavaScript and TypeScript. Currently file coverage information for each of these pairs of languages is grouped together. <a href="https://redirect.github.com/github/codeql-action/pull/1903">#1903</a></li>
<li>Add a warning to help customers avoid inadvertently analyzing the same CodeQL language in multiple matrix jobs. <a href="https://redirect.github.com/github/codeql-action/pull/1901">#1901</a></li>
</ul>
<h2>2.21.8 - 19 Sep 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.10.4 and earlier. These versions of CodeQL were discontinued on 12 September 2023 alongside GitHub Enterprise Server 3.6, and will be unsupported by the next minor release of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/1884">#1884</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.10.5 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.9.5 and 2.10.4, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.21.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>Enable the following language aliases when using CodeQL 2.14.4 and later: <code>c-cpp</code> for C/C++ analysis, <code>java-kotlin</code> for Java/Kotlin analysis, and <code>javascript-typescript</code> for JavaScript/TypeScript analysis. <a href="https://redirect.github.com/github/codeql-action/pull/1883">#1883</a></li>
</ul>
<h2>2.21.7 - 14 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.5. <a href="https://redirect.github.com/github/codeql-action/pull/1882">#1882</a></li>
</ul>
<h2>2.21.6 - 13 Sep 2023</h2>
<ul>
<li>Better error message when there is a failure to determine the merge base of the code to analysis. <a href="https://redirect.github.com/github/codeql-action/pull/1860">#1860</a></li>
<li>Improve the calculation of default amount of RAM used for query execution on GitHub Enterprise Server. This now reduces in proportion to the runner's total memory to better account for system memory usage, helping to avoid out-of-memory failures on larger runners. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/1866">#1866</a></li>
<li>Enable improved file coverage information for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/1867">#1867</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/0116bc2df50751f9724a2e35ef1f24d22f90e4e1"><code>0116bc2</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1947">#1947</a> from github/update-v2.22.3-82ba90b1d</li>
<li><a href="https://github.com/github/codeql-action/commit/f5a984b113c807e0268ddec39920f7e3253e29c8"><code>f5a984b</code></a> Update changelog for v2.22.3</li>
<li><a href="https://github.com/github/codeql-action/commit/82ba90b1d9944fe69c9c84e08d0cbd03406bf856"><code>82ba90b</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1945">#1945</a> from github/henrymercer/authenticate-api-url</li>
<li><a href="https://github.com/github/codeql-action/commit/34f97d7a16e031c81946105d8e6a417ebc334b22"><code>34f97d7</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1944">#1944</a> from github/henrymercer/sublanguage-file-coverage-fixes</li>
<li><a href="https://github.com/github/codeql-action/commit/74442e0a95c10585aa3b69d6f8f1901eabd8b499"><code>74442e0</code></a> Add changelog note</li>
<li><a href="https://github.com/github/codeql-action/commit/bd32fab74f8e9b5477f2256d657f4287be42d2c7"><code>bd32fab</code></a> Provide token when downloading from GHES API</li>
<li><a href="https://github.com/github/codeql-action/commit/b584cf832147a691d8f264a6c0ac67d5db0d54cd"><code>b584cf8</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1922">#1922</a> from github/nora/add-commit-sha-to-database-upload</li>
<li><a href="https://github.com/github/codeql-action/commit/761255a4a36028ea92a1378192d2aad042274e63"><code>761255a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1943">#1943</a> from github/mergeback/v2.22.2-to-main-d90b8d79</li>
<li><a href="https://github.com/github/codeql-action/commit/346d5c4b07cc4c12623714ee29f8e285903be4e5"><code>346d5c4</code></a> Test sub-language file coverage in file baseline information check</li>
<li><a href="https://github.com/github/codeql-action/commit/5950d135647787ae14e7332d9f0d0d07cefa117a"><code>5950d13</code></a> Enable sub-language file coverage in <code>interpret-results</code> too</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/2cb752a87e96af96708ab57187ab6372ee1973ab...0116bc2df50751f9724a2e35ef1f24d22f90e4e1">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.22.0&new-version=2.22.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

5f9965cf

[Impeller] GPU frame timings summarization. (#136408) · ec12ba28

Jonah Williams authored Oct 13, 2023

Allow processing GPU start and end events to get processed by flutter driver. To figure out whether or not this works we'll ship in on CI :)

ec12ba28

Changes WidgetInspector to use valuenotifier instead of a force rebuild for (#131634) · ac095ed3

Daniel Chevalier authored Oct 13, 2023

![](https://media.giphy.com/media/qriH9W51oLsL6/giphy.gif)
Fixes https://github.com/flutter/devtools/issues/6014

Change the forceRebuild behaviour of the WidgetInspector to use
ValueListenableBuilders instead. This should help resolve heavy rebuilds
when the widgetInspectorOverride value changes.

ac095ed3

Roll Flutter Engine from 799e8de11c12 to 6605151b4d0a (3 revisions) (#136558) · be45c4ca

engine-flutter-autoroll authored Oct 13, 2023

https://github.com/flutter/engine/compare/799e8de11c12...6605151b4d0a

2023-10-13 dnfield@google.com [Impeller] Only allow Impeller in flutter_tester if vulkan is enabled. (flutter/engine#46895)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 4783e1146146 to e10e6765480a (1 revision) (flutter/engine#46893)
2023-10-13 233583+mossmana@users.noreply.github.com Replace deprecated [UIScreen mainScreen] in FlutterView.mm (flutter/engine#46802)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

be45c4ca

Roll Flutter Engine from 93f02f7237db to 799e8de11c12 (6 revisions) (#136553) · cff36c99

engine-flutter-autoroll authored Oct 13, 2023

https://github.com/flutter/engine/compare/93f02f7237db...799e8de11c12

2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 643d74cf4e0b to 4783e1146146 (2 revisions) (flutter/engine#46890)
2023-10-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 95e2ecee106a to c8143a7c026f (1 revision) (flutter/engine#46889)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 77e73bb2744b to 643d74cf4e0b (2 revisions) (flutter/engine#46888)
2023-10-13 derekx@google.com Use --timeline_recorder=systrace instead of --systrace_timeline (flutter/engine#46884)
2023-10-13 erikgerman917@gmail.com fixed AutofillHints.middleName tanslation for web. (flutter/engine#46429)
2023-10-13 skia-flutter-autoroll@skia.org Roll Skia from 3acf82dcc479 to 77e73bb2744b (2 revisions) (flutter/engine#46886)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cff36c99

Mark leak in NativeCodec.getNextFrame. (#136514) · 9f512d70
Polina Cherkasova authored Oct 13, 2023

9f512d70
Stop skipping leaks in the test. (#136512) · 2ea541ac
Polina Cherkasova authored Oct 13, 2023

2ea541ac